delayed_job_with_named_queues 2.0.7.5 → 2.0.7.6

data/lib/delayed/worker.rb

@@ -144,7 +144,11 @@ module Delayed
 
         if job.payload_object.respond_to? :on_permanent_failure
           say "Running on_permanent_failure hook"
-          job.payload_object.on_permanent_failure
+          begin
+            job.payload_object.on_permanent_failure
+          rescue Exception => error
+            say "#{job.name} on permanent failure callback failed with #{error.class.name}: #{error.message}", Logger::ERROR
+          end
         end
 
         self.class.destroy_failed_jobs ? job.destroy : job.update_attributes(:failed_at => Delayed::Job.db_time_now)

data/spec/worker_spec.rb

@@ -169,6 +169,17 @@ describe Delayed::Worker do
             end
           end
 
+          context "when the job's payload has an #on_permanent_failure hook and that hook raises an exception" do
+            before do
+              @job = Delayed::Job.create :payload_object => OnPermanentFailureJob.new
+            end
+
+            it "should handle the exception" do
+              @job.payload_object.should_receive(:on_permanent_failure).and_raise("badness")
+              expect { @worker.reschedule(@job) }.to_not raise_error
+            end
+          end
+
           context "when the job's payload has no #on_permanent_failure hook" do
             # It's a little tricky to test this in a straightforward way, 
             # because putting a should_not_receive expectation on 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: delayed_job_with_named_queues
 version: !ruby/object:Gem::Version 
-  hash: 121
-  prerelease: false
+  hash: 127
+  prerelease: 
   segments: 
   - 2
   - 0
   - 7
-  - 5
-  version: 2.0.7.5
+  - 6
+  version: 2.0.7.6
 platform: ruby
 authors: 
 - Ray Walters
@@ -17,13 +17,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-01-19 00:00:00 -08:00
-default_executable: 
+date: 2012-02-15 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: ghazel-daemons
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -35,12 +32,12 @@ dependencies:
         - 13
         - 1
         version: 1.0.13.1
+  requirement: *id001
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: activesupport
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  name: ghazel-daemons
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -50,12 +47,12 @@ dependencies:
         - 2
         - 0
         version: "2.0"
+  requirement: *id002
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  name: activesupport
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -65,12 +62,12 @@ dependencies:
         - 1
         - 0
         version: "1.0"
+  requirement: *id003
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: rake
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  name: rspec
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -79,12 +76,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id004
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: rails
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  name: rake
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -94,12 +91,12 @@ dependencies:
         - 2
         - 3
         version: "2.3"
+  requirement: *id005
   type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: sqlite3
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  name: rails
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -108,12 +105,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id006
   type: :development
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: mysql
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  name: sqlite3
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -122,12 +119,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id007
   type: :development
-  version_requirements: *id007
-- !ruby/object:Gem::Dependency 
-  name: mongo_mapper
   prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  name: mysql
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -138,12 +135,12 @@ dependencies:
         - 8
         - 0
         version: 0.8.0
+  requirement: *id008
   type: :development
-  version_requirements: *id008
-- !ruby/object:Gem::Dependency 
-  name: dm-core
   prerelease: false
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  name: mongo_mapper
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -152,12 +149,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id009
   type: :development
-  version_requirements: *id009
-- !ruby/object:Gem::Dependency 
-  name: dm-observer
   prerelease: false
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  name: dm-core
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -166,12 +163,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id010
   type: :development
-  version_requirements: *id010
-- !ruby/object:Gem::Dependency 
-  name: dm-aggregates
   prerelease: false
-  requirement: &id011 !ruby/object:Gem::Requirement 
+  name: dm-observer
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -180,12 +177,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id011
   type: :development
-  version_requirements: *id011
-- !ruby/object:Gem::Dependency 
-  name: dm-validations
   prerelease: false
-  requirement: &id012 !ruby/object:Gem::Requirement 
+  name: dm-aggregates
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id012 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -194,12 +191,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id012
   type: :development
-  version_requirements: *id012
-- !ruby/object:Gem::Dependency 
-  name: do_sqlite3
   prerelease: false
-  requirement: &id013 !ruby/object:Gem::Requirement 
+  name: dm-validations
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id013 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -208,12 +205,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id013
   type: :development
-  version_requirements: *id013
-- !ruby/object:Gem::Dependency 
-  name: database_cleaner
   prerelease: false
-  requirement: &id014 !ruby/object:Gem::Requirement 
+  name: do_sqlite3
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id014 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -222,8 +219,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id014
   type: :development
-  version_requirements: *id014
+  prerelease: false
+  name: database_cleaner
 description: |-
   Delayed_job (or DJ) encapsulates the common pattern of asynchronously executing longer tasks in the background. It is a direct extraction from Shopify where the job table is responsible for a multitude of core tasks.
   
@@ -274,7 +273,6 @@ files:
 - tasks/jobs.rake
 - MIT-LICENSE
 - README.textile
-has_rdoc: true
 homepage: http://github.com/ezpub/delayed_job
 licenses: []
 
@@ -307,7 +305,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Database-backed asynchronous priority queue system -- Extracted from Shopify