delayed_job_shallow_mongoid 1.1.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 241496eebc696681823dccc7e8c86b31a821a470
-  data.tar.gz: 6a3694a48a1c5f94e00e904678ad2290001b9917
+SHA256:
+  metadata.gz: 06467d32c7321057a0695f4ecf5236a255990d48c785474b71804c03c9813cbd
+  data.tar.gz: 5e758ecd706d42f29ecc4e0b92ad1c42acbd2390c8bef99c681825c11f03f0af
 SHA512:
-  metadata.gz: 0e3d4c20ede088bcdfb6737d74b016da324aece575250254c7d3a6a6a36d6deacc5a2ed4f6b48bc3710fb67fb58a942acf4cf52f2af782da3212ec313315bbcb
-  data.tar.gz: 8ca08d593b35d303a86049f7c2cd2024f692ba5931df58e511a11380747d34f035e67571ef3b0720f0784ab232923087b91ab3e38077e7ed722fb87e5b18a9e5
+  metadata.gz: cb0c512e21499ccdcaccf4c6d79a5fd3d61498bd0b7a98a205f53c20165b4e4085262bfb544ebe9b11e60b9f075b31c8564ecf5a3582bb16594f9d6777c956dc
+  data.tar.gz: 3f0aac65fd3abb9cb404dd5857b45120a8f59e2ead205eff8461c9eb11df0e9e121e213ccbb28a80511e39a5120dbf425102fccaf75ed2defcdd89609bcf64e1

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+1.3.0 (2026-10-28)
+------------------
+
+* [#19](https://github.com/mongoid/delayed_job_shallow_mongoid/pull/19): Add Danger changelog review and fork-safe pull request comments through GitHub Actions - [@dblock](https://github.com/dblock).
+* [#18](https://github.com/mongoid/delayed_job_shallow_mongoid/pull/18): Add GitHub Actions compatibility testing for Mongoid 6-9, Ruby 2.7/3.3/3.4/4.0, and compatible Rails versions, replacing Travis CI - [@dblock](https://github.com/dblock).
+* [#18](https://github.com/mongoid/delayed_job_shallow_mongoid/pull/18): Add line/branch coverage, HTML/LCOV reports, and Coveralls reporting - [@dblock](https://github.com/dblock).
+* [#18](https://github.com/mongoid/delayed_job_shallow_mongoid/pull/18): Support current Mongoid embedded-association metadata and skip jobs whose embedded documents were removed before execution - [@dblock](https://github.com/dblock).
+* [#18](https://github.com/mongoid/delayed_job_shallow_mongoid/pull/18): Refresh development dependencies, RuboCop, gem metadata, and contributor documentation. Require Ruby 2.7 or newer - [@dblock](https://github.com/dblock).
+
+1.2.0 (2017-04-07)
+------------
+
+* [#12](https://github.com/joeyAghion/delayed_job_shallow_mongoid/pull/12): Support Mongoid 6 - [@yuki24](https://github.com/yuki24).
+
 1.1.0 (2015-09-25)
 ------------------
 

data/Gemfile

@@ -1,14 +1,24 @@
-source 'http://rubygems.org'
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
 
 gemspec
 
-case version = ENV['MONGOID_VERSION'] || '5.0'
-when /^5/
-  gem 'mongoid', '~> 4.0'
-when /^4/
-  gem 'mongoid', '~> 4.0'
-when /^3/
-  gem 'mongoid', '~> 3.1'
-else
-  gem 'mongoid', version
+gem 'mongoid', ENV.fetch('MONGOID_VERSION', '~> 9.0')
+
+rails_version = ENV.fetch('RAILS_VERSION', '~> 8.1')
+gem 'actionmailer', rails_version
+gem 'activemodel', rails_version
+gem 'activesupport', rails_version
+
+if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1')
+  gem 'danger', '~> 9.0'
+  gem 'danger-changelog', '~> 0.10'
+  gem 'danger-pr-comment', '~> 0.1.1'
 end
+
+gem 'rake', '~> 13.0'
+gem 'rspec', '~> 3.13'
+gem 'rubocop', '~> 1.75'
+gem 'simplecov', '~> 0.22'
+gem 'simplecov-lcov', '~> 0.8'

data/README.md

@@ -1,17 +1,44 @@
 delayed_job_shallow_mongoid
 ===========================
 
-[![Build Status](https://secure.travis-ci.org/joeyAghion/delayed_job_shallow_mongoid.png?branch=master)](http://travis-ci.org/joeyAghion/delayed_job_shallow_mongoid)
+[![Tests](https://github.com/mongoid/delayed_job_shallow_mongoid/actions/workflows/test.yml/badge.svg)](https://github.com/mongoid/delayed_job_shallow_mongoid/actions/workflows/test.yml)
+[![Rubocop](https://github.com/mongoid/delayed_job_shallow_mongoid/actions/workflows/rubocop.yml/badge.svg)](https://github.com/mongoid/delayed_job_shallow_mongoid/actions/workflows/rubocop.yml)
+[![Coverage Status](https://coveralls.io/repos/github/mongoid/delayed_job_shallow_mongoid/badge.svg?branch=master)](https://coveralls.io/github/mongoid/delayed_job_shallow_mongoid?branch=master)
+[![Gem Version](https://badge.fury.io/rb/delayed_job_shallow_mongoid.svg)](https://rubygems.org/gems/delayed_job_shallow_mongoid)
 
-This library short-circuits serialization of [Mongoid](http://mongoid.org) model instances when a delayed job is called on them, or when they're passed as arguments to a delayed job. Rather than generate and store the fully-serialized YAML, a simple stub is stored. When the job is run, the stub is recognized and a `find` is done to look up the underlying document. If a referenced model isn't found at this point, the job simply does nothing.
+This library short-circuits serialization of [Mongoid](https://www.mongodb.com/docs/mongoid/current/) model instances when a delayed job is called on them, or when they're passed as arguments to a delayed job. Rather than generate and store the fully-serialized YAML, a simple stub is stored. When the job is run, the stub is recognized and a `find` is done to look up the underlying document. If a referenced model isn't found at this point, the job simply does nothing.
 
-This gem supports Mongoid 3.x, 4.x and 5.x.
+Requires Ruby 2.7 or newer. CI exercises Mongoid 6-9, Rails 5.2/6.1/7.2/8.0/8.1, and Ruby 2.7/3.3/3.4/4.0 in compatible combinations. Mongoid 6 and 7 are tested with MongoDB 4.4; Mongoid 8 and 9 use MongoDB 8.0. Legacy combinations are compatibility checks, not recommendations for new applications.
+
+Development
+-----------
+
+The default bundle uses Mongoid 9 and Rails 8.1. Use Ruby 3.3 or newer and start MongoDB before running the suite:
+
+```sh
+bundle install
+bundle exec rake
+```
+
+Tests use `mongodb://127.0.0.1:27017/delayed_job_shallow_mongoid_test` by default. Override `MONGODB_URI` to use an isolated test database. **The suite purges and drops this database; never point it at development or production data.**
+
+To select another compatible dependency combination:
+
+```sh
+MONGOID_VERSION='~> 8.1' RAILS_VERSION='~> 7.2' bundle update
+MONGOID_VERSION='~> 8.1' RAILS_VERSION='~> 7.2' bundle exec rake
+```
+
+Every test run writes HTML coverage to `coverage/index.html` and LCOV coverage to `coverage/lcov.info`, enforcing at least 90% line and 80% branch coverage. GitHub Actions uploads coverage artifacts and reports the compatibility jobs to Coveralls.
 
 Contributions
 -------------
 
 * Contributions encouraged. Feature branches appreciated.
-* Development generously supported by [Artsy](http://artsy.net).
+* Add user-facing changes to the next release in `CHANGELOG.md`, linking the issue or pull request and crediting the contributor. Danger checks new and edited entries without reformatting historical releases, and reminds contributors to update the changelog; README-only changes are exempt. Changelog review runs separately on Ruby 3.4 and publishes a report on pull requests, including forks, using GitHub's built-in token; no personal access token or shared Mongoid Danger gem is required.
+* Development generously supported by [Artsy](https://www.artsy.net).
+
+Maintainers: see [RELEASING.md](RELEASING.md) for release preparation, publishing, and verification.
 
 Copyright
 ---------

data/Rakefile

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 require 'rubygems'
 require 'bundler'
@@ -6,8 +6,8 @@ require 'bundler/gem_tasks'
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts 'Run `bundle install` to install missing gems'
+  warn e.message
+  warn 'Run `bundle install` to install missing gems'
   exit e.status_code
 end
 require 'rake'
@@ -21,4 +21,4 @@ end
 require 'rubocop/rake_task'
 RuboCop::RakeTask.new(:rubocop)
 
-task default: [:rubocop, :spec]
+task default: %i[rubocop spec]

data/delayed_job_shallow_mongoid.gemspec

@@ -1,12 +1,13 @@
-# -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'delayed/shallow_mongoid/version'
 
 Gem::Specification.new do |s|
   s.name = 'delayed_job_shallow_mongoid'
   s.version = Delayed::ShallowMongoid::VERSION
+  s.required_ruby_version = '>= 2.7'
 
   s.authors = ['Joey Aghion', 'Daniel Doubrovkine']
   s.description = 'When the object or arg to a delayed_job is a Mongoid document, store only a small stub of the object instead of the full serialization.'
@@ -17,7 +18,6 @@ Gem::Specification.new do |s|
   ]
   s.files = Dir[
     '.document',
-    '.travis.yml',
     'CHANGELOG.md',
     'Gemfile',
     'LICENSE.txt',
@@ -26,19 +26,19 @@ Gem::Specification.new do |s|
     'delayed_job_shallow_mongoid.gemspec',
     'lib/**/*'
   ]
-  s.homepage = 'http://github.com/joeyAghion/delayed_job_shallow_mongoid'
+  s.homepage = 'https://github.com/mongoid/delayed_job_shallow_mongoid'
+  s.metadata = {
+    'source_code_uri' => s.homepage,
+    'bug_tracker_uri' => "#{s.homepage}/issues",
+    'changelog_uri' => "#{s.homepage}/blob/master/CHANGELOG.md",
+    'rubygems_mfa_required' => 'true'
+  }
   s.licenses = ['MIT']
   s.require_paths = ['lib']
   s.summary = 'More efficient Mongoid document serialization for delayed_job.'
 
-  s.specification_version = 3
-  s.add_runtime_dependency('delayed_job', ['>= 3.0'])
-  s.add_runtime_dependency('delayed_job_mongoid', ['>= 2.0'])
-  s.add_runtime_dependency('mongoid', ['>= 3.0'])
-  s.add_runtime_dependency('activesupport', ['>= 3.2'])
-  s.add_development_dependency('actionmailer', ['>= 0'])
-  s.add_development_dependency('shoulda', ['>= 0'])
-  s.add_development_dependency('rake', ['~> 10.0'])
-  s.add_development_dependency('rspec', ['>= 3.0'])
-  s.add_development_dependency('rubocop', ['0.34.2'])
+  s.add_dependency('activesupport', ['>= 3.2'])
+  s.add_dependency('delayed_job', ['>= 3.0'])
+  s.add_dependency('delayed_job_mongoid', ['>= 2.0'])
+  s.add_dependency('mongoid', ['>= 3.0'])
 end

data/lib/delayed/shallow_mongoid/document_stub.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 module Delayed
   module ShallowMongoid
     DocumentStub = Struct.new(:klass, :id, :selector) do
       def description
-        "#{klass}[#{id}]".tap do |desc|
-          desc << '.' + selector.map do |s|
-            s.is_a?(Array) ? "#{s.first}(#{s[1..-1].map(&:inspect).join(', ')})" : s
-          end.join('.') if selector && selector.any?
+        path = (selector || []).map do |step|
+          step.is_a?(Array) ? "#{step.first}(#{step[1..].map(&:inspect).join(', ')})" : step
         end
+        ["#{klass}[#{id}]", *path].join('.')
       end
     end
   end

data/lib/delayed/shallow_mongoid/mongoid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Delayed
   module ShallowMongoid
     def self.mongoid3?
@@ -7,6 +9,8 @@ module Delayed
     def self.metadata(instance)
       if Delayed::ShallowMongoid.mongoid3?
         instance.metadata
+      elsif instance.respond_to?(:_association)
+        instance._association
       else
         instance.relation_metadata
       end

data/lib/delayed/shallow_mongoid/performable_mailer.rb

@@ -1,11 +1,14 @@
+# frozen_string_literal: true
+
 module Delayed
   class PerformableMailer < PerformableMethod
     def perform
       klass = ShallowMongoid.load(object)
       delayed_arguments = *args.map { |a| ShallowMongoid.load(a) }
-      klass.send(method_name, *delayed_arguments).deliver
+      message = klass.send(method_name, *delayed_arguments)
+      message.respond_to?(:deliver_now) ? message.deliver_now : message.deliver
     rescue Delayed::ShallowMongoid::Errors::DocumentNotFound
-      return true # do nothing if document has been removed
+      true # do nothing if document has been removed
     end
   end
 end

data/lib/delayed/shallow_mongoid/performable_method.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Delayed
   class PerformableMethod
     attr_accessor :object, :method_name, :args
 
     def initialize(object, method_name, args)
-      fail NoMethodError, "undefined method `#{method_name}' for #{object.inspect}" unless object.respond_to?(method_name, true)
+      raise NoMethodError, "undefined method `#{method_name}' for #{object.inspect}" unless object.respond_to?(method_name, true)
 
       self.object       = ShallowMongoid.dump(object)
       self.args         = args.map { |a| ShallowMongoid.dump(a) }
@@ -15,7 +17,7 @@ module Delayed
       delayed_arguments = *args.map { |a| ShallowMongoid.load(a) }
       klass.send(method_name, *delayed_arguments)
     rescue Delayed::ShallowMongoid::Errors::DocumentNotFound
-      return true # do nothing if document has been removed
+      true # do nothing if document has been removed
     end
 
     def display_name

data/lib/delayed/shallow_mongoid/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Delayed
   module ShallowMongoid
-    VERSION = '1.1.0'
+    VERSION = '1.3.0'
   end
 end

data/lib/delayed/shallow_mongoid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Delayed
   module ShallowMongoid
     module Errors
@@ -8,6 +10,7 @@ module Delayed
     def self.dump(arg)
       return arg unless arg.is_a?(::Mongoid::Document) && arg.persisted?
       return arg if arg._updates.any? && !Delayed::Worker.delay_jobs
+
       if arg.embedded?
         Delayed::ShallowMongoid::DocumentStub.new(arg._root.class, arg._root._id.to_s, selector_from(arg))
       else
@@ -17,16 +20,19 @@ module Delayed
 
     def self.load(arg)
       return arg unless arg.is_a?(Delayed::ShallowMongoid::DocumentStub)
+
       begin
         result = arg.klass.find(arg.id)
-        fail Delayed::ShallowMongoid::Errors::DocumentNotFound unless result
+        raise Delayed::ShallowMongoid::Errors::DocumentNotFound unless result
+
+        (arg.selector || []).each do |message|
+          result = result.send(*message)
+          raise Delayed::ShallowMongoid::Errors::DocumentNotFound unless result
+        end
       rescue Mongoid::Errors::DocumentNotFound
         raise Delayed::ShallowMongoid::Errors::DocumentNotFound
       end
-      (arg.selector || []).each do |message|
-        result = result.send(*message)
-      end
-      fail Delayed::ShallowMongoid::Errors::DocumentNotFound unless result
+
       result
     end
 
@@ -35,8 +41,14 @@ module Delayed
     def self.selector_from(doc)
       [].tap do |selector|
         while doc._parent
-          selector.unshift ['find', doc._id.to_s] if Delayed::ShallowMongoid.metadata(doc).macro == :embeds_many
-          selector.unshift Delayed::ShallowMongoid.metadata(doc).key
+          association = Delayed::ShallowMongoid.metadata(doc)
+          many = if association.respond_to?(:macro)
+                   association.macro == :embeds_many
+                 else
+                   association.is_a?(::Mongoid::Association::Embedded::EmbedsMany)
+                 end
+          selector.unshift ['find', doc._id.to_s] if many
+          selector.unshift association.key
           doc = doc._parent
         end
       end

data/lib/delayed_job_shallow_mongoid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delayed_job'
 require 'delayed/shallow_mongoid'
 require 'delayed/shallow_mongoid/version'

metadata

@@ -1,46 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: delayed_job_shallow_mongoid
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Joey Aghion
 - Daniel Doubrovkine
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-09-25 00:00:00.000000000 Z
+date: 2026-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: delayed_job
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: delayed_job_mongoid
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
-  name: mongoid
+  name: delayed_job
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -54,89 +40,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: delayed_job_mongoid
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
-- !ruby/object:Gem::Dependency
-  name: actionmailer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: shoulda
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: mongoid
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.34.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.34.2
 description: When the object or arg to a delayed_job is a Mongoid document, store
   only a small stub of the object instead of the full serialization.
 email: joey@aghion.com
@@ -147,7 +77,6 @@ extra_rdoc_files:
 - README.md
 files:
 - ".document"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -161,11 +90,15 @@ files:
 - lib/delayed/shallow_mongoid/performable_method.rb
 - lib/delayed/shallow_mongoid/version.rb
 - lib/delayed_job_shallow_mongoid.rb
-homepage: http://github.com/joeyAghion/delayed_job_shallow_mongoid
+homepage: https://github.com/mongoid/delayed_job_shallow_mongoid
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  source_code_uri: https://github.com/mongoid/delayed_job_shallow_mongoid
+  bug_tracker_uri: https://github.com/mongoid/delayed_job_shallow_mongoid/issues
+  changelog_uri: https://github.com/mongoid/delayed_job_shallow_mongoid/blob/master/CHANGELOG.md
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -173,16 +106,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
-specification_version: 3
+rubygems_version: 3.5.22
+signing_key:
+specification_version: 4
 summary: More efficient Mongoid document serialization for delayed_job.
 test_files: []

data/.travis.yml

@@ -1,18 +0,0 @@
-services: mongodb
-
-language: ruby
-
-cache: bundler
-
-rvm:
-  - 2.2
-  - 2.1.2
-  - 2.0.0
-  - 1.9.3
-  - rbx-2
-  - jruby-19mode
-
-env:
-  - MONGOID_VERSION=3
-  - MONGOID_VERSION=4
-  - MONGOID_VERSION=5