delayed_job_loner 0.0.1 → 0.0.2

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--format progress

data/README.md

@@ -1,6 +1,6 @@
 # DelayedJobLoner
 
-TODO: Write a gem description
+Adds an option on handle_asynchronously or delay that specifies which attributes to check for uniqueness on. A new job will not be created if one already exists for that method and object.
 
 ## Installation
 
@@ -18,7 +18,38 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+Pass the option `:unique_on` to any method that you would provide `:priority` or `:run_at`. `:unique_on` should be an array of attributes that you want to check the uniqueness of the job against.
+Here is an example:
+```ruby
+class Foo < ActiveRecord::Base
+  
+  def do_all_the_things
+    # All the things!
+  end
+  handle_asynchronously :do_all_the_things, :unique_on => [:id]
+
+  def do_some_of_the_things
+    # Some of the things!
+  end
+
+end
+```
+
+This allows you to do things like this:
+```ruby
+foo = Foo.first
+foo.do_all_the_things
+  # Creates a new job
+foo.do_all_the_things
+  # Doesn't create a new job because we already created one
+
+foo.delay(:priority => 10).do_some_of_the_things
+  # Creates a new job
+foo.delay(:priority => 10, :unique_on => [:id]).do_some_of_the_things
+  # Doesn't create a new job
+foo.delay(:priority => 10).do_some_of_the_things
+  # Creates a new job because we didn't specify :unique_on
+```
 
 ## Contributing
 

data/delayed_job_loner.gemspec

@@ -14,4 +14,12 @@ Gem::Specification.new do |gem|
   gem.name          = "delayed_job_loner"
   gem.require_paths = ["lib"]
   gem.version       = DelayedJobLoner::VERSION
+
+  gem.add_dependency 'delayed_job'
+
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'activerecord'
+  gem.add_development_dependency 'sqlite3-ruby'
+  gem.add_development_dependency 'sqlite3_ar_regexp'
+  gem.add_development_dependency 'delayed_job_active_record'
 end

data/lib/delayed_job_loner/init.rb

@@ -3,16 +3,17 @@ module Delayed
     module ActiveRecord
       class Job < ::ActiveRecord::Base
         attr_accessor :unique_on
+        attr_accessible :unique_on
 
-        before_create :check_uniqueness
+        validate :check_uniqueness
 
         def check_uniqueness
           if unique_on
-            scope = self.class.where("handler like '%method_name: :#{payload_object.method_name}%'").where(:locked_by => nil)
+            scope = self.class.where("handler REGEXP '\\nmethod_name: :#{payload_object.method_name}\\n'").where(:locked_by => nil)
             unique_on.each do |attribute_name|
-              scope = scope.where("handler like '%#{attribute_name}: #{payload_object.send(attribute_name)}%'")
+              scope = scope.where("handler REGEXP ' +#{attribute_name}: #{payload_object.send(attribute_name)}\\n'")
             end
-            scope.first.nil?
+            self.errors.add(:base, "Job already exists") unless scope.first.nil?
           else
             true
           end

data/lib/delayed_job_loner/version.rb

@@ -1,3 +1,3 @@
 module DelayedJobLoner
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/delayed_job_loner_spec.rb

@@ -0,0 +1,33 @@
+require "story"
+require "spec_helper"
+
+describe DelayedJobLoner do
+
+  it "should create a job if :unique_on is not specified" do
+    story = Story.create(:text => "foo")
+    story.reload
+    story.delay.tell.persisted?.should eql true
+  end
+
+  it "should create a job if :unique_on is specified and a similar job does not exist" do
+    story = Story.create(:text => "foo")
+    story2 = Story.create(:text => "foo")
+    story.reload
+    story2.reload
+
+    story.delay.tell.persisted?.should eql true
+    story2.delay(:unique_on => [:id]).tell.persisted?.should eql true
+  end
+
+  it "should not create a job if :unique_on is specified and a similar job exists" do
+    story = Story.create(:text => "foo")
+    story.reload
+
+    story.whatever.persisted?.should eql true
+    story.whatever.persisted?.should eql false
+
+    story.delay(:unique_on => [:id]).tell.persisted?.should eql true
+    story.delay(:unique_on => [:id]).tell.persisted?.should eql false
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,11 @@
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# Require this file using `require "spec_helper"` to ensure that it is only
+# loaded once.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+end

data/spec/story.rb

@@ -0,0 +1,45 @@
+require 'active_record'
+require 'delayed_job'
+require 'delayed_job_active_record'
+require 'delayed_job_loner'
+require 'sqlite3_ar_regexp'
+
+ActiveRecord::Base.logger = Logger.new('/tmp/dj.log')
+ActiveRecord::Base.establish_connection(:adapter => 'sqlite3', :database => '/tmp/jobs.sqlite')
+ActiveRecord::Migration.verbose = false
+ActiveRecord::Base.default_timezone = :utc if Time.zone.nil?
+
+ActiveRecord::Schema.define do
+
+  create_table :delayed_jobs, :force => true do |table|
+    table.integer  :priority, :default => 0
+    table.integer  :attempts, :default => 0
+    table.text     :handler
+    table.string   :last_error
+    table.datetime :run_at
+    table.datetime :locked_at
+    table.string   :locked_by
+    table.datetime :failed_at
+    table.timestamps
+  end
+
+  create_table :stories, :force => true do |table|
+    table.string :id, :text
+  end
+
+end
+
+# Purely useful for test cases...
+class Story < ActiveRecord::Base
+  attr_accessor :id
+
+  def tell
+    text
+  end
+
+  def whatever
+    tell
+  end
+  handle_asynchronously :whatever, :unique_on => [:id], :priority => 10
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed_job_loner
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,104 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-07 00:00:00.000000000 Z
-dependencies: []
+date: 2012-08-08 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: delayed_job
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3-ruby
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3_ar_regexp
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: delayed_job_active_record
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Gem that adds the ability to prevent duplicate delayed jobs from being
   created.
 email:
@@ -20,6 +116,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - Gemfile
 - LICENSE
 - README.md
@@ -28,6 +125,9 @@ files:
 - lib/delayed_job_loner.rb
 - lib/delayed_job_loner/init.rb
 - lib/delayed_job_loner/version.rb
+- spec/delayed_job_loner_spec.rb
+- spec/spec_helper.rb
+- spec/story.rb
 homepage: https://github.com/tstmedia/delayed_job_loner
 licenses: []
 post_install_message: 
@@ -54,4 +154,7 @@ specification_version: 3
 summary: Adds an option on handle_asynchronously or delay that specifies which attributes
   to check for uniqueness on. A new job will not be created if one already exists
   for that method and object.
-test_files: []
+test_files:
+- spec/delayed_job_loner_spec.rb
+- spec/spec_helper.rb
+- spec/story.rb