delayed_job_honeybadger 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 85950afa4d916ad57b890095c9772367bbf7b4e7
-  data.tar.gz: 7945f4814bb60cc55843a2a473a78c47d2b1d8f4
+  metadata.gz: 965afa1735cae2da416d846214a076921234a8a0
+  data.tar.gz: f27762eb4bc9a0b4f0047afe882aa877de55c23a
 SHA512:
-  metadata.gz: f3f799c3b7eba4ddfda1cb58cb988895cb9c15dc93f51a5edf84b1d6e0f11ed12de69ece3518c3633dbe680654763900b76437852ef05980923fc8136dd63816
-  data.tar.gz: d47c59534b1b2eebbc618026f236094048c7a8b81a743462685ed22800c5873dfe48717df97449b66768b04caf3c8455aa15c3a1d310d13e45c6d9a454b2e47b
+  metadata.gz: 6205291fa407d383f7c0835cc1273783396fe7f47593c3fa57e8f05599293c60e74591832ef0474f713de0967acdf76a8c3b46881f69f9cdf7d1ba244d01f74a
+  data.tar.gz: a8e5aabeae56fe4014d7559cadc5c141c1930cdfb5895cb8f6d3430e8614449127869f067b2c26362c906afcefe6e411813206f39d30f01fd59f891e81f2ec01

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+gemspec
+gem 'rake'

data/Gemfile.lock

@@ -0,0 +1,84 @@
+PATH
+  remote: .
+  specs:
+    delayed_job_honeybadger (0.0.2)
+      delayed_job
+      honeybadger
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (4.0.0)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    atomic (1.1.14)
+    coderay (1.0.9)
+    delayed_job (4.0.0)
+      activesupport (>= 3.0, < 4.1)
+    diff-lcs (1.2.4)
+    ffi (1.9.0)
+    formatador (0.2.4)
+    fuubar (1.2.1)
+      rspec (~> 2.0)
+      rspec-instafail (~> 0.2.0)
+      ruby-progressbar (~> 1.0)
+    guard (1.8.2)
+      formatador (>= 0.2.4)
+      listen (>= 1.0.0)
+      lumberjack (>= 1.0.2)
+      pry (>= 0.9.10)
+      thor (>= 0.14.6)
+    guard-rspec (3.0.3)
+      guard (>= 1.8)
+      rspec (~> 2.13)
+    honeybadger (1.8.0)
+      json
+    i18n (0.6.5)
+    json (1.8.0)
+    listen (1.3.1)
+      rb-fsevent (>= 0.9.3)
+      rb-inotify (>= 0.9)
+      rb-kqueue (>= 0.2)
+    lumberjack (1.0.4)
+    method_source (0.8.2)
+    minitest (4.7.5)
+    multi_json (1.8.0)
+    pry (0.9.12.2)
+      coderay (~> 1.0.5)
+      method_source (~> 0.8)
+      slop (~> 3.4)
+    rake (10.1.0)
+    rb-fsevent (0.9.3)
+    rb-inotify (0.9.2)
+      ffi (>= 0.5.0)
+    rb-kqueue (0.2.0)
+      ffi (>= 0.5.0)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.5)
+    rspec-expectations (2.14.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-instafail (0.2.4)
+    rspec-mocks (2.14.3)
+    ruby-progressbar (1.2.0)
+    slop (3.4.6)
+    thor (0.18.1)
+    thread_safe (0.1.3)
+      atomic
+    tzinfo (0.3.37)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  delayed_job_honeybadger!
+  fuubar
+  guard
+  guard-rspec
+  rake
+  rspec

data/Guardfile

@@ -0,0 +1,6 @@
+guard :rspec, cli: '--format Fuubar --fail-fast', all_after_pass: false, all_on_start: false do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/delayed_job_honeybadger_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+end

data/README.md

@@ -1,6 +1,9 @@
-Delayed Job Honeyabdger
+Delayed Job Honeybadger
 -----------------------
 
+[![Build Status](https://secure.travis-ci.org/honeybadger-io/delayed_job_honeybadger.png?branch=master)](http://travis-ci.org/honeybadger-io/delayed_job_honeybadger)
+[![Gem Version](https://badge.fury.io/rb/delayed_job_honeybadger.png)](http://badge.fury.io/rb/delayed_job_honeybadger)
+
 Notify Honeybadger of errors in Delayed Job workers.
 
 Adapted from [this](http://stackoverflow.com/a/14172132/1332687) and

data/Rakefile

@@ -0,0 +1,112 @@
+require 'rubygems'
+require 'bundler/setup'
+require 'rake'
+require 'date'
+
+#############################################################################
+#
+# Helper functions
+#
+#############################################################################
+
+def name
+  @name ||= Dir['*.gemspec'].first.split('.').first
+end
+
+def version
+  line = File.read("lib/#{name}.rb")[/^\s*VERSION\s*=\s*.*/]
+  line.match(/.*VERSION\s*=\s*['"](.*)['"]/)[1]
+end
+
+def date
+  Date.today.to_s
+end
+
+def gemspec_file
+  "#{name}.gemspec"
+end
+
+def gem_file
+  "#{name}-#{version}.gem"
+end
+
+def replace_header(head, header_name)
+  head.sub!(/(\.#{header_name}\s*= ').*'/) { "#{$1}#{send(header_name)}'"}
+end
+
+#############################################################################
+#
+# Standard tasks
+#
+#############################################################################
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+task :default => :spec
+task :test => :spec
+
+#############################################################################
+#
+# Packaging tasks
+#
+#############################################################################
+
+desc "Create tag v#{version} and build and push #{gem_file} to Rubygems"
+task :release => :build do
+  unless `git branch` =~ /^\* master$/
+    puts "You must be on the master branch to release!"
+    exit!
+  end
+  sh "git commit --allow-empty -a -m 'Release #{version}'"
+  sh "git tag v#{version}"
+  sh "git push origin master"
+  sh "git push origin v#{version}"
+  sh "gem push pkg/#{name}-#{version}.gem"
+end
+
+desc "Build #{gem_file} into the pkg directory"
+task :build => :gemspec do
+  sh "mkdir -p pkg"
+  sh "gem build #{gemspec_file}"
+  sh "mv #{gem_file} pkg"
+end
+
+desc "Generate #{gemspec_file}"
+task :gemspec => :validate do
+  # read spec file and split out manifest section
+  spec = File.read(gemspec_file)
+  head, manifest, tail = spec.split("  # = MANIFEST =\n")
+
+  # replace name version and date
+  replace_header(head, :name)
+  replace_header(head, :version)
+  replace_header(head, :date)
+
+  # determine file list from git ls-files
+  files = `git ls-files`.
+    split("\n").
+    sort.
+    reject { |file| file =~ /^\./ }.
+    reject { |file| file =~ /^(rdoc|pkg)/ }.
+    map { |file| "    #{file}" }.
+    join("\n")
+
+  # piece file back together and write
+  manifest = "  s.files = %w[\n#{files}\n  ]\n"
+  spec = [head, manifest, tail].join("  # = MANIFEST =\n")
+  File.open(gemspec_file, 'w') { |io| io.write(spec) }
+  puts "Updated #{gemspec_file}"
+end
+
+desc "Validate #{gemspec_file}"
+task :validate do
+  libfiles = Dir['lib/*'] - ["lib/#{name}.rb", "lib/#{name}", "lib/delayed"]
+  unless libfiles.empty?
+    puts "Directory `lib` should only contain a `#{name}.rb` file and `#{name}` dir."
+    exit!
+  end
+  unless Dir['VERSION*'].empty?
+    puts "A `VERSION` file at root level violates Gem best practices."
+    exit!
+  end
+end

data/delayed_job_honeybadger.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name          = 'delayed_job_honeybadger'
-  s.version       = '0.0.1'
-  s.date          = '2013-07-22'
+  s.version       = '0.0.2'
+  s.date          = '2013-10-01'
 
   s.summary       = "Honeybadger plugin for Delayed Job"
   s.description   = "Notifies Honeybadger of errors in Delayed Job workers."
@@ -15,11 +15,30 @@ Gem::Specification.new do |s|
   s.add_dependency('honeybadger')
   s.add_dependency('delayed_job')
 
+  s.add_development_dependency('rspec')
+  s.add_development_dependency('guard')
+  s.add_development_dependency('guard-rspec')
+  s.add_development_dependency('fuubar')
+
+  ## Leave this section as-is. It will be automatically generated from the
+  ## contents of your Git repository via the gemspec task. DO NOT REMOVE
+  ## THE MANIFEST COMMENTS, they are used as delimiters by the task.
+  # = MANIFEST =
   s.files = %w[
-    delayed_job_honeybadger.gemspec
+    Gemfile
+    Gemfile.lock
+    Guardfile
     LICENSE
     README.md
-    lib/delayed_job_honeybadger.rb
+    Rakefile
+    delayed_job_honeybadger.gemspec
     lib/delayed/plugins/honeybadger.rb
+    lib/delayed_job_honeybadger.rb
+    spec/delayed/backend/test.rb
+    spec/delayed/serialization/test.rb
+    spec/lib/delayed_job_honeybadger_spec.rb
+    spec/spec_helper.rb
+    spec/support/cobra_job.rb
   ]
+  # = MANIFEST =
 end

data/lib/delayed/plugins/honeybadger.rb

@@ -1,8 +1,3 @@
-# Notify Honeybadger of errors in DelayedJob workers
-# in /config/initializers/
-# 
-# modified
-
 module Delayed
   module Plugins
     class Honeybadger < Plugin
@@ -11,8 +6,13 @@ module Delayed
           ::Honeybadger.notify_or_ignore(
             :error_class   => error.class.name,
             :error_message => "#{ error.class.name }: #{ error.message }",
+            :backtrace => error.backtrace,
             :context       => {
-              :failed_job => job.inspect,
+              :job_id => job.id,
+              :handler => job.handler,
+              :last_error => job.last_error,
+              :attempts => job.attempts,
+              :queue => job.queue
             }
           )
           super if defined?(super)

data/lib/delayed_job_honeybadger.rb

@@ -4,3 +4,6 @@ require 'honeybadger'
 require 'delayed/plugins/honeybadger'
 
 Delayed::Worker.plugins << Delayed::Plugins::Honeybadger
+module DelayedJobHoneybadger
+  VERSION = '0.0.2'
+end

data/spec/delayed/backend/test.rb

@@ -0,0 +1,112 @@
+require 'ostruct'
+
+# An in-memory backend suitable only for testing. Tries to behave as if it were an ORM.
+module Delayed
+  module Backend
+    module Test
+      class Job
+        attr_accessor :id
+        attr_accessor :priority
+        attr_accessor :attempts
+        attr_accessor :handler
+        attr_accessor :last_error
+        attr_accessor :run_at
+        attr_accessor :locked_at
+        attr_accessor :locked_by
+        attr_accessor :failed_at
+        attr_accessor :queue
+
+        include Delayed::Backend::Base
+
+        cattr_accessor :id
+        self.id = 0
+
+        def initialize(hash = {})
+          self.attempts = 0
+          self.priority = 0
+          self.id = (self.class.id += 1)
+          hash.each{|k,v| send(:"#{k}=", v)}
+        end
+
+        @jobs = []
+        def self.all
+          @jobs
+        end
+
+        def self.count
+          all.size
+        end
+
+        def self.delete_all
+          all.clear
+        end
+
+        def self.create(attrs = {})
+          new(attrs).tap do |o|
+            o.save
+          end
+        end
+
+        def self.create!(*args); create(*args); end
+
+        def self.clear_locks!(worker_name)
+          all.select{|j| j.locked_by == worker_name}.each {|j| j.locked_by = nil; j.locked_at = nil}
+        end
+
+        # Find a few candidate jobs to run (in case some immediately get locked by others).
+        def self.find_available(worker_name, limit = 5, max_run_time = Worker.max_run_time)
+          jobs = all.select do |j|
+            j.run_at <= db_time_now &&
+            (j.locked_at.nil? || j.locked_at < db_time_now - max_run_time || j.locked_by == worker_name) &&
+            !j.failed?
+          end
+
+          jobs = jobs.select{|j| Worker.queues.include?(j.queue)}   if Worker.queues.any?
+          jobs = jobs.select{|j| j.priority >= Worker.min_priority} if Worker.min_priority
+          jobs = jobs.select{|j| j.priority <= Worker.max_priority} if Worker.max_priority
+          jobs.sort_by{|j| [j.priority, j.run_at]}[0..limit-1]
+        end
+
+        # Lock this job for this worker.
+        # Returns true if we have the lock, false otherwise.
+        def lock_exclusively!(max_run_time, worker)
+          now = self.class.db_time_now
+          if locked_by != worker
+            # We don't own this job so we will update the locked_by name and the locked_at
+            self.locked_at = now
+            self.locked_by = worker
+          end
+
+          return true
+        end
+
+        def self.db_time_now
+          Time.current
+        end
+
+        def update_attributes(attrs = {})
+          attrs.each{|k,v| send(:"#{k}=", v)}
+          save
+        end
+
+        def destroy
+          self.class.all.delete(self)
+        end
+
+        def save
+          self.run_at ||= Time.current
+
+          self.class.all << self unless self.class.all.include?(self)
+          true
+        end
+
+        def save!; save; end
+
+        def reload
+          reset
+          self
+        end
+      end
+    end
+  end
+end

data/spec/lib/delayed_job_honeybadger_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe 'Delayed job integration' do
+  it 'sends notice to honeybadger' do
+    Delayed::Job.enqueue CobraJob.new
+    Honeybadger.should_receive(:notify_or_ignore).with(hash_including({
+      error_class: 'RuntimeError',
+      error_message: 'RuntimeError: cobras!',
+      backtrace: kind_of(Array),
+      context: kind_of(Hash)
+    }))
+    expect { Delayed::Worker.new.work_off(1) }.not_to raise_error
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,19 @@
+require 'rspec'
+require 'delayed_job'
+require 'delayed_job_honeybadger'
+
+# Require files in spec/support/ and its subdirectories.
+Dir[File.expand_path('../../spec/support/**/*.rb', __FILE__)].each {|f| require f}
+
+# Use test backend
+Delayed::Worker.backend = :test
+
+RSpec.configure do |c|
+  c.mock_with :rspec
+  c.color_enabled = true
+  c.tty = true
+
+  c.treat_symbols_as_metadata_keys_with_true_values = true
+  c.filter_run :focus => true
+  c.run_all_when_everything_filtered = true
+end

data/spec/support/cobra_job.rb

@@ -0,0 +1,9 @@
+class CobraJob
+  def perform
+    raise 'cobras!'
+  end
+
+  def max_attempts
+    1
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: delayed_job_honeybadger
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Joshua Wood
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-22 00:00:00.000000000 Z
+date: 2013-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: honeybadger
@@ -38,17 +38,82 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: fuubar
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Notifies Honeybadger of errors in Delayed Job workers.
 email: josh@honeybadger.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- delayed_job_honeybadger.gemspec
+- Gemfile
+- Gemfile.lock
+- Guardfile
 - LICENSE
 - README.md
-- lib/delayed_job_honeybadger.rb
+- Rakefile
+- delayed_job_honeybadger.gemspec
 - lib/delayed/plugins/honeybadger.rb
+- lib/delayed_job_honeybadger.rb
+- spec/delayed/backend/test.rb
+- spec/delayed/serialization/test.rb
+- spec/lib/delayed_job_honeybadger_spec.rb
+- spec/spec_helper.rb
+- spec/support/cobra_job.rb
 homepage: https://github.com/honeybadger-io/delayed_job_honeybadger
 licenses: []
 metadata: {}
@@ -68,7 +133,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Honeybadger plugin for Delayed Job