delayed_job_groups_plugin 0.3.0 → 0.6.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (31) hide show
  1. checksums.yaml +5 -5
  2. data/.circleci/config.yml +72 -0
  3. data/.gitignore +1 -0
  4. data/.rspec +1 -0
  5. data/.rubocop.yml +11 -0
  6. data/Appraisals +17 -0
  7. data/CHANGELOG.md +25 -2
  8. data/Gemfile +2 -0
  9. data/README.md +4 -3
  10. data/Rakefile +2 -0
  11. data/delayed_job_groups.gemspec +19 -21
  12. data/gemfiles/rails_5.2.gemfile +9 -0
  13. data/gemfiles/rails_6.0.gemfile +8 -0
  14. data/gemfiles/rails_6.1.gemfile +8 -0
  15. data/lib/delayed/job_groups/compatibility.rb +2 -2
  16. data/lib/delayed/job_groups/job_extensions.rb +1 -1
  17. data/lib/delayed/job_groups/job_group.rb +9 -17
  18. data/lib/delayed/job_groups/plugin.rb +13 -9
  19. data/lib/delayed/job_groups/version.rb +2 -2
  20. data/lib/delayed/job_groups/yaml_loader.rb +17 -0
  21. data/lib/delayed_job_groups_plugin.rb +2 -1
  22. data/lib/generators/delayed_job_groups_plugin/install_generator.rb +3 -3
  23. data/lib/generators/delayed_job_groups_plugin/templates/{migration.rb → migration.erb} +2 -2
  24. data/spec/db/schema.rb +2 -2
  25. data/spec/delayed/job_groups/job_group_spec.rb +24 -25
  26. data/spec/delayed/job_groups/plugin_spec.rb +134 -85
  27. data/spec/delayed/job_groups/yaml_loader_spec.rb +43 -0
  28. data/spec/spec_helper.rb +12 -12
  29. data/spec/support/destroyed_model.rb +3 -3
  30. metadata +103 -46
  31. data/.travis.yml +0 -34
data/spec/delayed/job_groups/yaml_loader_spec.rb ADDED
@@ -0,0 +1,43 @@
1
+ # frozen_string_literal: true
2
+
3
+ describe Delayed::JobGroups::YamlLoader do
4
+ class Foo; end
5
+
6
+ describe "#load" do
7
+ context "with a correct yaml object representation" do
8
+ let(:yaml) { '--- !ruby/object:Foo {}' }
9
+
10
+ it "deserializes from YAML properly" do
11
+ expect(Delayed::JobGroups::YamlLoader.load(yaml)).to be_a(Foo)
12
+ end
13
+ end
14
+
15
+ context "with incorrect yaml object representations" do
16
+ let(:not_yaml1) { 'foo' }
17
+ let(:not_yaml2) { 1 }
18
+
19
+ it "deserializes from YAML properly" do
20
+ expect(Delayed::JobGroups::YamlLoader.load(not_yaml1)).to eq('foo')
21
+ expect(Delayed::JobGroups::YamlLoader.load(not_yaml2)).to eq(1)
22
+ end
23
+ end
24
+ end
25
+
26
+ describe "#dump" do
27
+ context "with an object" do
28
+ let(:object) { Foo.new }
29
+
30
+ it "serializes into YAML properly" do
31
+ expect(Delayed::JobGroups::YamlLoader.dump(object)).to eq("--- !ruby/object:Foo {}\n")
32
+ end
33
+ end
34
+
35
+ context "with a nil object" do
36
+ let(:object) { nil }
37
+
38
+ it "serializes into YAML properly" do
39
+ expect(Delayed::JobGroups::YamlLoader.dump(object)).to eq(nil)
40
+ end
41
+ end
42
+ end
43
+ end
data/spec/spec_helper.rb CHANGED
@@ -1,16 +1,17 @@
1
- # encoding: UTF-8
1
+ # frozen_string_literal: true
2
2
 
3
3
  require 'simplecov'
4
4
  require 'coveralls'
5
5
 
6
- SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
7
- SimpleCov::Formatter::HTMLFormatter,
8
- Coveralls::SimpleCov::Formatter
9
- ]
6
+ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
7
+ [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
8
+ )
9
+
10
10
  SimpleCov.start do
11
- add_filter 'spec'
11
+ add_filter 'spec'
12
12
  end
13
13
 
14
+ require 'rspec/its'
14
15
  require 'database_cleaner'
15
16
  require 'delayed_job_groups_plugin'
16
17
  require 'yaml'
@@ -30,27 +31,26 @@ ActiveRecord::Base.logger = Delayed::Worker.logger
30
31
  ActiveRecord::Migration.verbose = false
31
32
 
32
33
  db_adapter = ENV.fetch('ADAPTER', 'sqlite3')
33
- config = YAML.load(File.read('spec/db/database.yml'))
34
- ActiveRecord::Base.establish_connection(config[db_adapter])
34
+ db_config = YAML.safe_load(File.read('spec/db/database.yml'))
35
+ ActiveRecord::Base.establish_connection(db_config[db_adapter])
35
36
  require 'db/schema'
36
37
 
37
38
  RSpec.configure do |config|
38
- config.treat_symbols_as_metadata_keys_with_true_values = true
39
39
  config.order = 'random'
40
40
 
41
41
  config.before(:suite) do
42
42
  DatabaseCleaner.clean_with(:truncation)
43
43
  end
44
44
 
45
- config.before(:each) do
45
+ config.before do
46
46
  DatabaseCleaner.strategy = :transaction
47
47
  end
48
48
 
49
- config.before(:each) do
49
+ config.before do
50
50
  DatabaseCleaner.start
51
51
  end
52
52
 
53
- config.after(:each) do
53
+ config.after do
54
54
  DatabaseCleaner.clean
55
55
  end
56
56
  end
data/spec/support/destroyed_model.rb CHANGED
@@ -1,4 +1,4 @@
1
- # encoding: UTF-8
1
+ # frozen_string_literal: true
2
2
 
3
3
  RSpec::Matchers.define :have_been_destroyed do
4
4
  match do |actual|
@@ -6,10 +6,10 @@ RSpec::Matchers.define :have_been_destroyed do
6
6
  end
7
7
 
8
8
  description do
9
- "model should have been destroyed"
9
+ 'model should have been destroyed'
10
10
  end
11
11
 
12
- failure_message_for_should do |actual|
12
+ failure_message do |actual|
13
13
  "expected #{actual.class}(id: #{actual.id}) to have been destroyed"
14
14
  end
15
15
  end
metadata CHANGED
@@ -1,15 +1,15 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: delayed_job_groups_plugin
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.3.0
4
+ version: 0.6.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Joel Turkel
8
8
  - Randy Burkes
9
- autorequire:
9
+ autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2017-10-03 00:00:00.000000000 Z
12
+ date: 2020-12-17 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: delayed_job
@@ -31,48 +31,62 @@ dependencies:
31
31
  requirements:
32
32
  - - ">="
33
33
  - !ruby/object:Gem::Version
34
- version: '0.4'
34
+ version: '4.1'
35
35
  type: :runtime
36
36
  prerelease: false
37
37
  version_requirements: !ruby/object:Gem::Requirement
38
38
  requirements:
39
39
  - - ">="
40
40
  - !ruby/object:Gem::Version
41
- version: '0.4'
41
+ version: '4.1'
42
+ - !ruby/object:Gem::Dependency
43
+ name: appraisal
44
+ requirement: !ruby/object:Gem::Requirement
45
+ requirements:
46
+ - - ">="
47
+ - !ruby/object:Gem::Version
48
+ version: '0'
49
+ type: :development
50
+ prerelease: false
51
+ version_requirements: !ruby/object:Gem::Requirement
52
+ requirements:
53
+ - - ">="
54
+ - !ruby/object:Gem::Version
55
+ version: '0'
42
56
  - !ruby/object:Gem::Dependency
43
57
  name: activerecord
44
58
  requirement: !ruby/object:Gem::Requirement
45
59
  requirements:
46
60
  - - ">="
47
61
  - !ruby/object:Gem::Version
48
- version: '3.2'
62
+ version: '5.2'
49
63
  - - "<"
50
64
  - !ruby/object:Gem::Version
51
- version: '5.2'
52
- type: :development
65
+ version: '7'
66
+ type: :runtime
53
67
  prerelease: false
54
68
  version_requirements: !ruby/object:Gem::Requirement
55
69
  requirements:
56
70
  - - ">="
57
71
  - !ruby/object:Gem::Version
58
- version: '3.2'
72
+ version: '5.2'
59
73
  - - "<"
60
74
  - !ruby/object:Gem::Version
61
- version: '5.2'
75
+ version: '7'
62
76
  - !ruby/object:Gem::Dependency
63
- name: coveralls
77
+ name: coveralls_reborn
64
78
  requirement: !ruby/object:Gem::Requirement
65
79
  requirements:
66
80
  - - ">="
67
81
  - !ruby/object:Gem::Version
68
- version: '0'
82
+ version: 0.18.0
69
83
  type: :development
70
84
  prerelease: false
71
85
  version_requirements: !ruby/object:Gem::Requirement
72
86
  requirements:
73
87
  - - ">="
74
88
  - !ruby/object:Gem::Version
75
- version: '0'
89
+ version: 0.18.0
76
90
  - !ruby/object:Gem::Dependency
77
91
  name: database_cleaner
78
92
  requirement: !ruby/object:Gem::Requirement
@@ -88,55 +102,49 @@ dependencies:
88
102
  - !ruby/object:Gem::Version
89
103
  version: '1.2'
90
104
  - !ruby/object:Gem::Dependency
91
- name: rake
105
+ name: mime-types
92
106
  requirement: !ruby/object:Gem::Requirement
93
107
  requirements:
94
- - - "<"
108
+ - - ">="
95
109
  - !ruby/object:Gem::Version
96
- version: '11.0'
110
+ version: '0'
97
111
  type: :development
98
112
  prerelease: false
99
113
  version_requirements: !ruby/object:Gem::Requirement
100
114
  requirements:
101
- - - "<"
115
+ - - ">="
102
116
  - !ruby/object:Gem::Version
103
- version: '11.0'
117
+ version: '0'
104
118
  - !ruby/object:Gem::Dependency
105
- name: rspec
119
+ name: rake
106
120
  requirement: !ruby/object:Gem::Requirement
107
121
  requirements:
108
122
  - - ">="
109
123
  - !ruby/object:Gem::Version
110
- version: '2.14'
111
- - - "<"
112
- - !ruby/object:Gem::Version
113
- version: '2.99'
124
+ version: '0'
114
125
  type: :development
115
126
  prerelease: false
116
127
  version_requirements: !ruby/object:Gem::Requirement
117
128
  requirements:
118
129
  - - ">="
119
130
  - !ruby/object:Gem::Version
120
- version: '2.14'
121
- - - "<"
122
- - !ruby/object:Gem::Version
123
- version: '2.99'
131
+ version: '0'
124
132
  - !ruby/object:Gem::Dependency
125
- name: simplecov
133
+ name: rspec
126
134
  requirement: !ruby/object:Gem::Requirement
127
135
  requirements:
128
136
  - - "~>"
129
137
  - !ruby/object:Gem::Version
130
- version: 0.7.1
138
+ version: '3'
131
139
  type: :development
132
140
  prerelease: false
133
141
  version_requirements: !ruby/object:Gem::Requirement
134
142
  requirements:
135
143
  - - "~>"
136
144
  - !ruby/object:Gem::Version
137
- version: 0.7.1
145
+ version: '3'
138
146
  - !ruby/object:Gem::Dependency
139
- name: timecop
147
+ name: rspec-its
140
148
  requirement: !ruby/object:Gem::Requirement
141
149
  requirements:
142
150
  - - ">="
@@ -150,19 +158,47 @@ dependencies:
150
158
  - !ruby/object:Gem::Version
151
159
  version: '0'
152
160
  - !ruby/object:Gem::Dependency
153
- name: mime-types
161
+ name: rspec_junit_formatter
154
162
  requirement: !ruby/object:Gem::Requirement
155
163
  requirements:
156
- - - "~>"
164
+ - - ">="
157
165
  - !ruby/object:Gem::Version
158
- version: '2'
166
+ version: '0'
159
167
  type: :development
160
168
  prerelease: false
161
169
  version_requirements: !ruby/object:Gem::Requirement
162
170
  requirements:
163
- - - "~>"
171
+ - - ">="
172
+ - !ruby/object:Gem::Version
173
+ version: '0'
174
+ - !ruby/object:Gem::Dependency
175
+ name: salsify_rubocop
176
+ requirement: !ruby/object:Gem::Requirement
177
+ requirements:
178
+ - - '='
164
179
  - !ruby/object:Gem::Version
165
- version: '2'
180
+ version: 0.52.1.1
181
+ type: :development
182
+ prerelease: false
183
+ version_requirements: !ruby/object:Gem::Requirement
184
+ requirements:
185
+ - - '='
186
+ - !ruby/object:Gem::Version
187
+ version: 0.52.1.1
188
+ - !ruby/object:Gem::Dependency
189
+ name: simplecov
190
+ requirement: !ruby/object:Gem::Requirement
191
+ requirements:
192
+ - - ">="
193
+ - !ruby/object:Gem::Version
194
+ version: '0'
195
+ type: :development
196
+ prerelease: false
197
+ version_requirements: !ruby/object:Gem::Requirement
198
+ requirements:
199
+ - - ">="
200
+ - !ruby/object:Gem::Version
201
+ version: '0'
166
202
  - !ruby/object:Gem::Dependency
167
203
  name: sqlite3
168
204
  requirement: !ruby/object:Gem::Requirement
@@ -177,6 +213,20 @@ dependencies:
177
213
  - - ">="
178
214
  - !ruby/object:Gem::Version
179
215
  version: '0'
216
+ - !ruby/object:Gem::Dependency
217
+ name: timecop
218
+ requirement: !ruby/object:Gem::Requirement
219
+ requirements:
220
+ - - ">="
221
+ - !ruby/object:Gem::Version
222
+ version: '0'
223
+ type: :development
224
+ prerelease: false
225
+ version_requirements: !ruby/object:Gem::Requirement
226
+ requirements:
227
+ - - ">="
228
+ - !ruby/object:Gem::Version
229
+ version: '0'
180
230
  description: Aggregates Delayed::Job jobs into groups with group level management
181
231
  and lifecycle callbacks
182
232
  email:
@@ -186,27 +236,34 @@ executables: []
186
236
  extensions: []
187
237
  extra_rdoc_files: []
188
238
  files:
239
+ - ".circleci/config.yml"
189
240
  - ".gitignore"
190
241
  - ".rspec"
191
- - ".travis.yml"
242
+ - ".rubocop.yml"
243
+ - Appraisals
192
244
  - CHANGELOG.md
193
245
  - Gemfile
194
246
  - LICENSE.txt
195
247
  - README.md
196
248
  - Rakefile
197
249
  - delayed_job_groups.gemspec
250
+ - gemfiles/rails_5.2.gemfile
251
+ - gemfiles/rails_6.0.gemfile
252
+ - gemfiles/rails_6.1.gemfile
198
253
  - lib/delayed/job_groups/compatibility.rb
199
254
  - lib/delayed/job_groups/job_extensions.rb
200
255
  - lib/delayed/job_groups/job_group.rb
201
256
  - lib/delayed/job_groups/plugin.rb
202
257
  - lib/delayed/job_groups/version.rb
258
+ - lib/delayed/job_groups/yaml_loader.rb
203
259
  - lib/delayed_job_groups_plugin.rb
204
260
  - lib/generators/delayed_job_groups_plugin/install_generator.rb
205
- - lib/generators/delayed_job_groups_plugin/templates/migration.rb
261
+ - lib/generators/delayed_job_groups_plugin/templates/migration.erb
206
262
  - spec/db/database.yml
207
263
  - spec/db/schema.rb
208
264
  - spec/delayed/job_groups/job_group_spec.rb
209
265
  - spec/delayed/job_groups/plugin_spec.rb
266
+ - spec/delayed/job_groups/yaml_loader_spec.rb
210
267
  - spec/spec_helper.rb
211
268
  - spec/support/destroyed_model.rb
212
269
  homepage: https://github.com/salsify/delayed_job_groups_plugin
@@ -222,22 +279,22 @@ required_ruby_version: !ruby/object:Gem::Requirement
222
279
  requirements:
223
280
  - - ">="
224
281
  - !ruby/object:Gem::Version
225
- version: '2.1'
282
+ version: '2.5'
226
283
  required_rubygems_version: !ruby/object:Gem::Requirement
227
284
  requirements:
228
285
  - - ">="
229
286
  - !ruby/object:Gem::Version
230
287
  version: '0'
231
288
  requirements: []
232
- rubyforge_project:
233
- rubygems_version: 2.6.12
234
- signing_key:
289
+ rubygems_version: 3.0.8
290
+ signing_key:
235
291
  specification_version: 4
236
292
  summary: Delayed::Job job groups plugin
237
293
  test_files:
238
- - spec/db/database.yml
239
- - spec/db/schema.rb
240
- - spec/delayed/job_groups/job_group_spec.rb
241
- - spec/delayed/job_groups/plugin_spec.rb
242
294
  - spec/spec_helper.rb
243
295
  - spec/support/destroyed_model.rb
296
+ - spec/delayed/job_groups/plugin_spec.rb
297
+ - spec/delayed/job_groups/job_group_spec.rb
298
+ - spec/delayed/job_groups/yaml_loader_spec.rb
299
+ - spec/db/schema.rb
300
+ - spec/db/database.yml
data/.travis.yml DELETED
@@ -1,34 +0,0 @@
1
- language: ruby
2
- sudo: false
3
- env:
4
- global:
5
- - JRUBY_OPTS="$JRUBY_OPTS --debug"
6
- matrix:
7
- - RAILS_VERSION="~> 3.2.22.5"
8
- - RAILS_VERSION="~> 4.0.13"
9
- - RAILS_VERSION="~> 4.1.16"
10
- - RAILS_VERSION="~> 4.2.9"
11
- - RAILS_VERSION="~> 5.0.6"
12
- - RAILS_VERSION="~> 5.1.3"
13
- rvm:
14
- - 2.1.10
15
- - 2.2.8
16
- - 2.3.5
17
- - 2.4.2
18
- - jruby-9.1.13.0
19
- matrix:
20
- exclude:
21
- - rvm: 2.1.10
22
- env: RAILS_VERSION="~> 5.0.6"
23
- - rvm: 2.4.2
24
- env: RAILS_VERSION="~> 3.2.22.5"
25
- - rvm: 2.4.2
26
- env: RAILS_VERSION="~> 4.0.13"
27
- - rvm: 2.4.2
28
- env: RAILS_VERSION="~> 4.1.16"
29
- - rvm: jruby-9.1.13.0
30
- env: RAILS_VERSION="~> 5.0.6"
31
- - rvm: 2.1.10
32
- env: RAILS_VERSION="~> 5.1.3"
33
- - rvm: jruby-9.1.13.0
34
- env: RAILS_VERSION="~> 5.1.3"