delayed_job_groups_plugin 0.13.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9773f978178a522b2f7d150230d2aec54bdd5a3bd11b13a980e93ebd71a0bf8c
-  data.tar.gz: 9d7ae98668fc83a5d7aa516138470585dc5f711a52796c297f8c408969cb2903
+  metadata.gz: 9d88649deb9812581de80f6a57a265ccfd265f7f9122d837eff527647f77f01b
+  data.tar.gz: 4979b4dd43fb9294fb622e478ac5bb36a7f688f83236183eac2fc80a668af828
 SHA512:
-  metadata.gz: 964f5ea0c140c4d9122ed4602e2e059263f8e2ba71242aa741f079a195a8f7a39c42938380b8794f40b7ebb0b464c640ae1945c7a4174150d5299df9af381bd0
-  data.tar.gz: 98ff4ae8816c181e05aea9ad267d105e0d0397f3d02a50ef7fa3c61bfc9c53100d8e0a3a10aee298b512ae80a55f753f08e7407dafaabfaf6f5f40080428f600
+  metadata.gz: '083c6e1461374569d30d7538fb5a7e4d4f980cae04858bbac94793597f62d588a6078b6e55e605ee7e10ff413e0c6ef5460088cd50667663ceefdfc29543ae6a'
+  data.tar.gz: d4ede12f4275b606f0e0704ac3cfc255727f3796979ecff7aa87781629172d0e15ad6e1d0b96254bd845f243a7f8d7bc96f4c4bb670bf4d48be4e4a2590776a4

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 1.0.0
+### Breaking Changes
+- This library will fail to load if `Delayed::Worker.destroy_failed_jobs` is set to true.
+  Delayed::Job sets this option to true by default, you will need to configure it to false
+  in order to include this library.
+### Changes
+- Moves `on_cancellation` logic from the before delayed job lifecycle hook to the after hook.
+- Wrapped the job group cancel hook in a lock to prevent concurrently failing jobs from enqueueing
+  multiple on cancellation jobs.
+
+## 0.14.0
+- Reverts changes made in version 0.13.
+
 ## 0.13.0
 - Moves `on_cancellation` logic from the before delayed job lifecycle hook to the after hook.
 - Gem will now fail to load if `Delayed::Worker.destroy_failed_jobs` is set to true.

data/README.md

@@ -35,6 +35,15 @@ Run the required database migrations:
     $ rails generate delayed_job_groups_plugin:install
     $ rake db:migrate
 
+## Upgrading from 0.14.0
+
+This library is now incompatible with Delayed::Job's default setting for `destroy_failed_jobs`.
+In order to use Delayed Job Groups, you must set it to false while configuring Delayed::Job:
+
+```ruby
+Delayed::Worker.destroy_failed_jobs = false
+```
+
 ## Upgrading from 0.1.2
 run the following generator to create a migration for the new configuration column.
 
@@ -42,6 +51,7 @@ run the following generator to create a migration for the new configuration colu
     # add `default: true, null: false` to the generated migration for the failure_cancels_group column
     $ rake db:migrate
 
+
 ## Usage
 
 Creating a job group and queueing some jobs:

data/lib/delayed/job_groups/railtie.rb

@@ -11,7 +11,9 @@ module Delayed
         # complete the group instead of the group being cancelled. Therefore, we must ensure that
         # the Delayed::Worker.destroy_failed_jobs is set to false, guaranteeing that the group is
         # never empty if failure occurs.
-        raise Delayed::JobGroups::IncompatibleWithDelayedJobError if Delayed::Worker.destroy_failed_jobs
+        if Delayed::Worker.destroy_failed_jobs && ActiveRecord::Base.connection.table_exists?(:delayed_job_groups)
+          raise Delayed::JobGroups::IncompatibleWithDelayedJobError
+        end
 
         Delayed::Backend::ActiveRecord::Job.include(Delayed::JobGroups::JobExtensions)
       end

data/lib/delayed/job_groups/version.rb

@@ -2,6 +2,6 @@
 
 module Delayed
   module JobGroups
-    VERSION = '0.13.0'
+    VERSION = '1.0.0'
   end
 end

data/lib/generators/delayed_job_groups_plugin/install_generator.rb

@@ -18,5 +18,37 @@ module DelayedJobGroupsPlugin
       ActiveRecord::Generators::Base.next_migration_number(dirname)
     end
 
+    def create_initializer
+      initializer_file = File.join('config/initializers', 'delayed_job_config.rb')
+      configuration_on_matcher = /Delayed::Worker\.destroy_failed_jobs\s*=\s*true/
+      configuration_off_matcher = /Delayed::Worker\.destroy_failed_jobs\s*=\s*false/
+
+      say 'Attempting to initialize delayed_job_config initializer...', :green
+
+      if File.exist?(initializer_file)
+        say 'delayed_job_config initializer already exists... checking destroy_failed_jobs options', :green
+        contents = File.read(initializer_file)
+        if contents.match(configuration_on_matcher)
+          say 'Delayed::Worker.destroy_failed_jobs is set to true', :red
+          say 'This library requires the option to be set to false, updating config now!', :yellow
+
+          gsub_file initializer_file, configuration_on_matcher, 'Delayed::Worker.destroy_failed_jobs = false'
+        elsif contents.match(configuration_off_matcher)
+          say 'Delayed::Worker.destroy_failed_jobs is set to false; nothing to do!', :green
+        else
+          say 'Delayed::Worker.destroy_failed_jobs is not set'
+          say 'This library requires the option to be set to false, updating config now!', :yellow
+          inject_into_file initializer_file, "Delayed::Worker.destroy_failed_jobs = false\n"
+        end
+      else
+        create_file initializer_file do
+          <<~RUBY
+            # frozen_string_literal: true
+
+            Delayed::Worker.destroy_failed_jobs = false
+          RUBY
+        end
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed_job_groups_plugin
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Joel Turkel
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-09-24 00:00:00.000000000 Z
+date: 2025-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord