delayed_job 4.0.2 → 4.0.3

data/spec/psych_ext_spec.rb

@@ -0,0 +1,12 @@
+require 'helper'
+
+describe 'Psych::Visitors::ToRuby', :if => defined?(Psych::Visitors::ToRuby) do
+  context BigDecimal do
+    it 'deserializes correctly' do
+      deserialized = YAML.load("--- !ruby/object:BigDecimal 18:0.1337E2\n...\n")
+
+      expect(deserialized).to be_an_instance_of(BigDecimal)
+      expect(deserialized).to eq(BigDecimal('13.37'))
+    end
+  end
+end

data/spec/sample_jobs.rb

@@ -5,45 +5,73 @@ class NamedJob < Struct.new(:perform)
 end
 
 class SimpleJob
-  cattr_accessor :runs; self.runs = 0
-  def perform; @@runs += 1; end
+  cattr_accessor :runs
+  @runs = 0
+  def perform
+    self.class.runs += 1
+  end
 end
 
 class ErrorJob
-  cattr_accessor :runs; self.runs = 0
-  def perform; raise 'did not work'; end
+  cattr_accessor :runs
+  @runs = 0
+  def perform
+    raise 'did not work'
+  end
 end
 
 class CustomRescheduleJob < Struct.new(:offset)
-  cattr_accessor :runs; self.runs = 0
-  def perform; raise 'did not work'; end
-  def reschedule_at(time, attempts); time + offset; end
+  cattr_accessor :runs
+  @runs = 0
+  def perform
+    raise 'did not work'
+  end
+
+  def reschedule_at(time, _attempts)
+    time + offset
+  end
 end
 
 class LongRunningJob
-  def perform; sleep 250; end
+  def perform
+    sleep 250
+  end
 end
 
 class OnPermanentFailureJob < SimpleJob
-  def failure; end
-  def max_attempts; 1; end
+  attr_writer :raise_error
+
+  def initialize
+    @raise_error = false
+  end
+
+  def failure
+    raise 'did not work' if @raise_error
+  end
+
+  def max_attempts
+    1
+  end
 end
 
 module M
   class ModuleJob
-    cattr_accessor :runs; self.runs = 0
-    def perform; @@runs += 1; end
+    cattr_accessor :runs
+    @runs = 0
+    def perform
+      self.class.runs += 1
+    end
   end
 end
 
 class CallbackJob
   cattr_accessor :messages
 
-  def enqueue(job)
+  def enqueue(_job)
     self.class.messages << 'enqueue'
   end
 
-  def before(job)
+  def before(_job)
     self.class.messages << 'before'
   end
 
@@ -51,19 +79,19 @@ class CallbackJob
     self.class.messages << 'perform'
   end
 
-  def after(job)
+  def after(_job)
     self.class.messages << 'after'
   end
 
-  def success(job)
+  def success(_job)
     self.class.messages << 'success'
   end
 
-  def error(job, error)
+  def error(_job, error)
     self.class.messages << "error: #{error.class}"
   end
 
-  def failure(job)
+  def failure(_job)
     self.class.messages << 'failure'
   end
 end

data/spec/test_backend_spec.rb

@@ -3,9 +3,9 @@ require 'helper'
 describe Delayed::Backend::Test::Job do
   it_should_behave_like 'a delayed_job backend'
 
-  describe "#reload" do
-    it "causes the payload object to be reloaded" do
-      job = "foo".delay.length
+  describe '#reload' do
+    it 'causes the payload object to be reloaded' do
+      job = 'foo'.delay.length
       o = job.payload_object
       expect(o.object_id).not_to eq(job.reload.payload_object.object_id)
     end

data/spec/worker_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Delayed::Worker do
-  describe "backend=" do
+  describe 'backend=' do
     before do
       @clazz = Class.new
       Delayed::Worker.backend = @clazz
@@ -11,30 +11,30 @@ describe Delayed::Worker do
       Delayed::Worker.backend = :test
     end
 
-    it "sets the Delayed::Job constant to the backend" do
+    it 'sets the Delayed::Job constant to the backend' do
       expect(Delayed::Job).to eq(@clazz)
     end
 
-    it "sets backend with a symbol" do
+    it 'sets backend with a symbol' do
       Delayed::Worker.backend = :test
       expect(Delayed::Worker.backend).to eq(Delayed::Backend::Test::Job)
     end
   end
 
-  describe "job_say" do
+  describe 'job_say' do
     before do
       @worker = Delayed::Worker.new
       @job = double('job', :id => 123, :name => 'ExampleJob')
     end
 
-    it "logs with job name and id" do
+    it 'logs with job name and id' do
       expect(@worker).to receive(:say).
         with('Job ExampleJob (id=123) message', Delayed::Worker::DEFAULT_LOG_LEVEL)
       @worker.job_say(@job, 'message')
     end
   end
 
-  context "worker read-ahead" do
+  context 'worker read-ahead' do
     before do
       @read_ahead = Delayed::Worker.read_ahead
     end
@@ -43,19 +43,19 @@ describe Delayed::Worker do
       Delayed::Worker.read_ahead = @read_ahead
     end
 
-    it "reads five jobs" do
+    it 'reads five jobs' do
       expect(Delayed::Job).to receive(:find_available).with(anything, 5, anything).and_return([])
       Delayed::Job.reserve(Delayed::Worker.new)
     end
 
-    it "reads a configurable number of jobs" do
+    it 'reads a configurable number of jobs' do
       Delayed::Worker.read_ahead = 15
       expect(Delayed::Job).to receive(:find_available).with(anything, Delayed::Worker.read_ahead, anything).and_return([])
       Delayed::Job.reserve(Delayed::Worker.new)
     end
   end
 
-  context "worker exit on complete" do
+  context 'worker exit on complete' do
     before do
       Delayed::Worker.exit_on_complete = true
     end
@@ -64,15 +64,15 @@ describe Delayed::Worker do
       Delayed::Worker.exit_on_complete = false
     end
 
-    it "exits the loop when no jobs are available" do
+    it 'exits the loop when no jobs are available' do
       worker = Delayed::Worker.new
-      Timeout::timeout(2) do
+      Timeout.timeout(2) do
         worker.start
       end
     end
   end
 
-  context "worker job reservation" do
+  context 'worker job reservation' do
     before do
       Delayed::Worker.exit_on_complete = true
     end
@@ -81,34 +81,34 @@ describe Delayed::Worker do
       Delayed::Worker.exit_on_complete = false
     end
 
-    it "handles error during job reservation" do
+    it 'handles error during job reservation' do
       expect(Delayed::Job).to receive(:reserve).and_raise(Exception)
       Delayed::Worker.new.work_off
     end
 
-    it "gives up after 10 backend failures" do
+    it 'gives up after 10 backend failures' do
       expect(Delayed::Job).to receive(:reserve).exactly(10).times.and_raise(Exception)
       worker = Delayed::Worker.new
       9.times { worker.work_off }
       expect(lambda { worker.work_off }).to raise_exception Delayed::FatalBackendError
     end
 
-    it "allows the backend to attempt recovery from reservation errors" do
+    it 'allows the backend to attempt recovery from reservation errors' do
       expect(Delayed::Job).to receive(:reserve).and_raise(Exception)
       expect(Delayed::Job).to receive(:recover_from).with(instance_of(Exception))
       Delayed::Worker.new.work_off
     end
   end
 
-  context "#say" do
+  context '#say' do
     before(:each) do
       @worker = Delayed::Worker.new
       @worker.name = 'ExampleJob'
       @worker.logger = double('job')
       time = Time.now
       allow(Time).to receive(:now).and_return(time)
-      @text = "Job executed"
-      @worker_name = "[Worker(ExampleJob)]"
+      @text = 'Job executed'
+      @worker_name = '[Worker(ExampleJob)]'
       @expected_time = time.strftime('%FT%T%z')
     end
 
@@ -116,7 +116,7 @@ describe Delayed::Worker do
       @worker.logger = nil
     end
 
-    shared_examples_for "a worker which logs on the correct severity" do |severity|
+    shared_examples_for 'a worker which logs on the correct severity' do |severity|
       it "logs a message on the #{severity[:level].upcase} level given a string" do
         expect(@worker.logger).to receive(:send).
           with(severity[:level], "#{@expected_time}: #{@worker_name} #{@text}")
@@ -130,19 +130,19 @@ describe Delayed::Worker do
       end
     end
 
-    severities = [ { index: 0, level: "debug" },
-                   { index: 1, level: "info" },
-                   { index: 2, level: "warn" },
-                   { index: 3, level: "error" },
-                   { index: 4, level: "fatal" },
-                   { index: 5, level: "unknown" } ]
+    severities = [{:index => 0, :level => 'debug'},
+                  {:index => 1, :level => 'info'},
+                  {:index => 2, :level => 'warn'},
+                  {:index => 3, :level => 'error'},
+                  {:index => 4, :level => 'fatal'},
+                  {:index => 5, :level => 'unknown'}]
     severities.each do |severity|
-      it_behaves_like "a worker which logs on the correct severity", severity
+      it_behaves_like 'a worker which logs on the correct severity', severity
     end
 
     it "logs a message on the default log's level" do
       expect(@worker.logger).to receive(:send).
-        with("info", "#{@expected_time}: #{@worker_name} #{@text}")
+        with('info', "#{@expected_time}: #{@worker_name} #{@text}")
       @worker.say(@text, Delayed::Worker::DEFAULT_LOG_LEVEL)
     end
   end

data/spec/yaml_ext_spec.rb

@@ -1,35 +1,35 @@
 require 'helper'
 
-describe "YAML" do
-  it "autoloads classes" do
-    expect {
+describe 'YAML' do
+  it 'autoloads classes' do
+    expect do
       yaml = "--- !ruby/class Autoloaded::Clazz\n"
       expect(YAML.load(yaml)).to eq(Autoloaded::Clazz)
-    }.not_to raise_error
+    end.not_to raise_error
   end
 
-  it "autoloads the class of a struct" do
-    expect {
+  it 'autoloads the class of a struct' do
+    expect do
       yaml = "--- !ruby/class Autoloaded::Struct\n"
       expect(YAML.load(yaml)).to eq(Autoloaded::Struct)
-    }.not_to raise_error
+    end.not_to raise_error
   end
 
-  it "autoloads the class for the instance of a struct" do
-    expect {
-      yaml = "--- !ruby/struct:Autoloaded::InstanceStruct {}"
+  it 'autoloads the class for the instance of a struct' do
+    expect do
+      yaml = '--- !ruby/struct:Autoloaded::InstanceStruct {}'
       expect(YAML.load(yaml).class).to eq(Autoloaded::InstanceStruct)
-    }.not_to raise_error
+    end.not_to raise_error
   end
 
-  it "autoloads the class for the instance" do
-    expect {
+  it 'autoloads the class for the instance' do
+    expect do
       yaml = "--- !ruby/object:Autoloaded::InstanceClazz {}\n"
       expect(YAML.load(yaml).class).to eq(Autoloaded::InstanceClazz)
-    }.not_to raise_error
+    end.not_to raise_error
   end
 
-  it "does not throw an uninitialized constant Syck::Syck when using YAML.load with poorly formed yaml" do
-    expect{ YAML.load(YAML.dump("foo: *bar"))}.not_to raise_error
+  it 'does not throw an uninitialized constant Syck::Syck when using YAML.load with poorly formed yaml' do
+    expect { YAML.load(YAML.dump('foo: *bar')) }.not_to raise_error
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed_job
 version: !ruby/object:Gem::Version
-  version: 4.0.2
+  version: 4.0.3
 platform: ruby
 authors:
 - Brandon Keepers
@@ -15,26 +15,26 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-24 00:00:00.000000000 Z
+date: 2014-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '4.2'
 description: Delayed_job (or DJ) encapsulates the common pattern of asynchronously
@@ -85,12 +85,14 @@ files:
 - spec/autoloaded/instance_struct.rb
 - spec/autoloaded/struct.rb
 - spec/delayed/backend/test.rb
+- spec/delayed/command_spec.rb
 - spec/delayed/serialization/test.rb
 - spec/helper.rb
 - spec/lifecycle_spec.rb
 - spec/message_sending_spec.rb
 - spec/performable_mailer_spec.rb
 - spec/performable_method_spec.rb
+- spec/psych_ext_spec.rb
 - spec/sample_jobs.rb
 - spec/test_backend_spec.rb
 - spec/worker_spec.rb
@@ -105,12 +107,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -125,12 +127,14 @@ test_files:
 - spec/autoloaded/instance_struct.rb
 - spec/autoloaded/struct.rb
 - spec/delayed/backend/test.rb
+- spec/delayed/command_spec.rb
 - spec/delayed/serialization/test.rb
 - spec/helper.rb
 - spec/lifecycle_spec.rb
 - spec/message_sending_spec.rb
 - spec/performable_mailer_spec.rb
 - spec/performable_method_spec.rb
+- spec/psych_ext_spec.rb
 - spec/sample_jobs.rb
 - spec/test_backend_spec.rb
 - spec/worker_spec.rb