deimos-ruby 2.2.0.pre.beta5 → 2.2.1

data/spec/active_record_batch_consumer_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Lint/ConstantDefinitionInBlock
 # Wrapped in a module to prevent class leakage
 module ActiveRecordBatchConsumerTest
   describe Deimos::ActiveRecordConsumer, 'Batch Consumer' do
@@ -36,8 +37,8 @@ module ActiveRecordBatchConsumerTest
       stub_const('ConsumerTest::MyBatchConsumer', consumer_class)
       register_consumer(MyBatchConsumer,
                         'MySchema',
-                        key_config: {plain: true},
-                        configs: {bulk_import_id_column: :bulk_import_id})
+                        key_config: { plain: true },
+                        configs: { bulk_import_id_column: :bulk_import_id })
       Widget.delete_all
     end
 
@@ -94,11 +95,11 @@ module ActiveRecordBatchConsumerTest
             )
 
             expect(all_widgets).
-              to match_array(
-                [
-                  have_attributes(id: 1, test_id: 'abc', some_int: 3, updated_at: start, created_at: start),
-                  have_attributes(id: 2, test_id: 'def', some_int: 4, updated_at: start, created_at: start)
-                ]
+              to contain_exactly(
+                have_attributes(id: 1, test_id: 'abc', some_int: 3, updated_at: start,
+                                created_at: start),
+                have_attributes(id: 2, test_id: 'def', some_int: 4, updated_at: start,
+                                created_at: start)
               )
           end
 
@@ -143,11 +144,9 @@ module ActiveRecordBatchConsumerTest
             )
 
             expect(all_widgets).
-              to match_array(
-                [
-                  have_attributes(id: 1, test_id: 'abc', some_int: 3, updated_at: Time.zone.now, created_at: Time.zone.now)
-                ]
-              )
+              to contain_exactly(have_attributes(id: 1, test_id: 'abc', some_int: 3,
+                                                 updated_at: Time.zone.now,
+                                                 created_at: Time.zone.now))
           end
 
           it 'should handle a double update' do
@@ -165,11 +164,9 @@ module ActiveRecordBatchConsumerTest
             )
 
             expect(all_widgets).
-              to match_array(
-                [
-                  have_attributes(id: 1, test_id: 'ghi', some_int: 4, updated_at: Time.zone.now, created_at: start)
-                ]
-              )
+              to contain_exactly(have_attributes(id: 1, test_id: 'ghi', some_int: 4,
+                                                 updated_at: Time.zone.now,
+                                                 created_at: start))
           end
 
           it 'should handle a double deletion' do
@@ -201,11 +198,7 @@ module ActiveRecordBatchConsumerTest
             )
 
             expect(all_widgets).
-              to match_array(
-                [
-                  have_attributes(id: 2, test_id: 'def', some_int: 5)
-                ]
-              )
+              to contain_exactly(have_attributes(id: 2, test_id: 'def', some_int: 5))
           end
 
           it 'should handle deletes with deadlock retries' do
@@ -257,7 +250,7 @@ module ActiveRecordBatchConsumerTest
       before(:each) do
       register_consumer(consumer_class,
                         'MySchema',
-                        key_config: {plain: true})
+                        key_config: { plain: true })
 
       end
 
@@ -292,13 +285,9 @@ module ActiveRecordBatchConsumerTest
         )
 
         expect(all_widgets).
-          to match_array(
-            [
-              have_attributes(id: 1, test_id: 'abc', some_int: 3),
-              have_attributes(id: 2, test_id: 'def', some_int: 4),
-              have_attributes(id: 3, test_id: 'hij', some_int: 9)
-            ]
-          )
+          to contain_exactly(have_attributes(id: 1, test_id: 'abc', some_int: 3),
+                             have_attributes(id: 2, test_id: 'def', some_int: 4),
+                             have_attributes(id: 3, test_id: 'hij', some_int: 9))
       end
     end
 
@@ -306,7 +295,7 @@ module ActiveRecordBatchConsumerTest
       before(:each) do
         register_consumer(consumer_class,
                           'MySchema',
-                          key_config: {schema: 'MySchemaCompound_key'})
+                          key_config: { schema: 'MySchemaCompound_key' })
       end
 
       let(:consumer_class) do
@@ -347,12 +336,10 @@ module ActiveRecordBatchConsumerTest
         )
 
         expect(all_widgets).
-          to match_array(
-            [
-              have_attributes(test_id: 'aaa', some_int: 3, part_one: 'abc', part_two: 'def'),
-              have_attributes(test_id: 'bbb', some_int: 4, part_one: 'ghi', part_two: 'jkl')
-            ]
-          )
+          to contain_exactly(have_attributes(test_id: 'aaa', some_int: 3, part_one: 'abc',
+                                             part_two: 'def'),
+                             have_attributes(test_id: 'bbb', some_int: 4, part_one: 'ghi',
+                                             part_two: 'jkl'))
       end
     end
 
@@ -360,7 +347,7 @@ module ActiveRecordBatchConsumerTest
       before(:each) do
         register_consumer(consumer_class,
                           'MySchema',
-                          key_config: {none: true})
+                          key_config: { none: true })
       end
 
       it 'should handle unkeyed topics' do
@@ -375,13 +362,9 @@ module ActiveRecordBatchConsumerTest
         )
 
         expect(all_widgets).
-          to match_array(
-            [
-              have_attributes(test_id: 'xxx', some_int: 2),
-              have_attributes(test_id: 'aaa', some_int: 3),
-              have_attributes(test_id: 'bbb', some_int: 4)
-            ]
-          )
+          to contain_exactly(have_attributes(test_id: 'xxx', some_int: 2),
+                             have_attributes(test_id: 'aaa', some_int: 3),
+                             have_attributes(test_id: 'bbb', some_int: 4))
       end
     end
 
@@ -389,8 +372,9 @@ module ActiveRecordBatchConsumerTest
       before(:each) do
         register_consumer(consumer_class,
                           'MySchema',
-                          key_config: {plain: true})
+                          key_config: { plain: true })
       end
+
       let(:consumer_class) do
         Class.new(described_class) do
           record_class Widget
@@ -438,18 +422,14 @@ module ActiveRecordBatchConsumerTest
         )
 
         expect(all_widgets).
-          to match_array(
-            [
-              have_attributes(id: 1, test_id: 'abc', some_int: 2, deleted: true,
-                              created_at: start, updated_at: Time.zone.now),
-              have_attributes(id: 2, test_id: 'def', some_int: 3, deleted: true,
-                              created_at: Time.zone.now, updated_at: Time.zone.now),
-              have_attributes(id: 3, test_id: 'ghi', some_int: 4, deleted: false,
-                              created_at: start, updated_at: Time.zone.now),
-              have_attributes(id: 4, test_id: 'uvw', some_int: 5, deleted: false,
-                              created_at: start, updated_at: Time.zone.now)
-            ]
-          )
+          to contain_exactly(have_attributes(id: 1, test_id: 'abc', some_int: 2, deleted: true,
+                                             created_at: start, updated_at: Time.zone.now),
+                             have_attributes(id: 2, test_id: 'def', some_int: 3, deleted: true,
+                                             created_at: Time.zone.now, updated_at: Time.zone.now),
+                             have_attributes(id: 3, test_id: 'ghi', some_int: 4, deleted: false,
+                                             created_at: start, updated_at: Time.zone.now),
+                             have_attributes(id: 4, test_id: 'uvw', some_int: 5, deleted: false,
+                                             created_at: start, updated_at: Time.zone.now))
       end
     end
 
@@ -457,8 +437,9 @@ module ActiveRecordBatchConsumerTest
       before(:each) do
         register_consumer(consumer_class,
                           'MySchema',
-                          key_config: {plain: true})
+                          key_config: { plain: true })
       end
+
       let(:consumer_class) do
         Class.new(described_class) do
           record_class Widget
@@ -483,7 +464,7 @@ module ActiveRecordBatchConsumerTest
         )
 
         expect(all_widgets).
-          to match_array([have_attributes(id: 2, test_id: 'abc123')])
+          to contain_exactly(have_attributes(id: 2, test_id: 'abc123'))
       end
     end
 
@@ -492,8 +473,9 @@ module ActiveRecordBatchConsumerTest
         before(:each) do
           register_consumer(consumer_class,
                             'MySchema',
-                            key_config: {plain: true})
+                            key_config: { plain: true })
         end
+
         let(:consumer_class) do
           Class.new(described_class) do
             record_class Widget
@@ -536,9 +518,8 @@ module ActiveRecordBatchConsumerTest
         before(:each) do
           register_consumer(consumer_class,
                             'MySchema',
-                            key_config: {plain: true},
-                            configs: {bulk_import_id_generator: proc { 'global' }}
-                            )
+                            key_config: { plain: true },
+                            configs: { bulk_import_id_generator: proc { 'global' } })
         end
 
         it 'should call the default bulk_import_id_generator proc' do
@@ -550,16 +531,12 @@ module ActiveRecordBatchConsumerTest
           )
 
           expect(all_widgets).
-            to match_array(
-              [
-                have_attributes(id: 1,
-                                test_id: 'abc',
-                                some_int: 3,
-                                updated_at: start,
-                                created_at: start,
-                                bulk_import_id: 'global')
-              ]
-            )
+            to contain_exactly(have_attributes(id: 1,
+                                               test_id: 'abc',
+                                               some_int: 3,
+                                               updated_at: start,
+                                               created_at: start,
+                                               bulk_import_id: 'global'))
 
         end
 
@@ -571,14 +548,13 @@ module ActiveRecordBatchConsumerTest
           Karafka::App.routes.clear
           Karafka::App.routes.draw do
             defaults do
-              bulk_import_id_generator(proc { 'global'})
+              bulk_import_id_generator(proc { 'global' })
             end
           end
           register_consumer(consumer_class,
                             'MySchema',
-                            key_config: {plain: true},
-                            configs: {bulk_import_id_generator: proc { 'custom' }}
-                            )
+                            key_config: { plain: true },
+                            configs: { bulk_import_id_generator: proc { 'custom' } })
         end
 
         it 'should call the default bulk_import_id_generator proc' do
@@ -591,16 +567,12 @@ module ActiveRecordBatchConsumerTest
           )
 
           expect(all_widgets).
-            to match_array(
-              [
-                have_attributes(id: 1,
-                                test_id: 'abc',
-                                some_int: 3,
-                                updated_at: start,
-                                created_at: start,
-                                bulk_import_id: 'custom')
-              ]
-            )
+            to contain_exactly(have_attributes(id: 1,
+                                               test_id: 'abc',
+                                               some_int: 3,
+                                               updated_at: start,
+                                               created_at: start,
+                                               bulk_import_id: 'custom'))
 
         end
       end
@@ -612,8 +584,9 @@ module ActiveRecordBatchConsumerTest
       before(:each) do
         register_consumer(consumer_class,
                           'MySchema',
-                          key_config: {plain: true})
+                          key_config: { plain: true })
       end
+
       let(:consumer_class) do
         Class.new(described_class) do
           record_class Widget
@@ -647,18 +620,16 @@ module ActiveRecordBatchConsumerTest
         )
 
         expect(Widget.count).to eq(2)
-        expect(Widget.all.to_a).to match_array([
-                                                 have_attributes(id: 1,
-                                                                 test_id: 'abc',
-                                                                 some_int: 11,
-                                                                 updated_at: start,
-                                                                 created_at: start),
-                                                 have_attributes(id: 2,
-                                                                 test_id: 'def',
-                                                                 some_int: 2,
-                                                                 updated_at: start,
-                                                                 created_at: start)
-                                               ])
+        expect(Widget.all.to_a).to contain_exactly(have_attributes(id: 1,
+                                                                   test_id: 'abc',
+                                                                   some_int: 11,
+                                                                   updated_at: start,
+                                                                   created_at: start),
+                                                   have_attributes(id: 2,
+                                                                   test_id: 'def',
+                                                                   some_int: 2,
+                                                                   updated_at: start,
+                                                                   created_at: start))
       end
 
     end
@@ -669,8 +640,9 @@ module ActiveRecordBatchConsumerTest
         before(:each) do
           register_consumer(consumer_class,
                             'MySchema',
-                            key_config: {plain: true})
+                            key_config: { plain: true })
         end
+
         let(:consumer_class) do
           Class.new(described_class) do
             record_class Widget
@@ -689,7 +661,8 @@ module ActiveRecordBatchConsumerTest
             def self.process_invalid_records(invalid)
               # Invalid
               attrs = invalid.first.record.attributes
-              Widget.find_by(id: attrs['id'], test_id: attrs['test_id']).update!(some_int: attrs['some_int'])
+              Widget.find_by(id: attrs['id'], test_id: attrs['test_id']).
+                update!(some_int: attrs['some_int'])
             end
 
             Karafka.monitor.subscribe('deimos.batch_consumption.invalid_records') do |payload|
@@ -727,8 +700,9 @@ module ActiveRecordBatchConsumerTest
         before(:each) do
           register_consumer(consumer_class,
                             'MySchema',
-                            key_config: {plain: true})
+                            key_config: { plain: true })
         end
+
         let(:consumer_class) do
           Class.new(described_class) do
             record_class Widget
@@ -747,7 +721,8 @@ module ActiveRecordBatchConsumerTest
             def self.process_invalid_records(invalid)
               # Invalid
               attrs = invalid.first.record.attributes
-              Widget.find_by(id: attrs['id'], test_id: attrs['test_id']).update!(some_int: attrs['some_int'])
+              Widget.find_by(id: attrs['id'], test_id: attrs['test_id']).
+                update!(some_int: attrs['some_int'])
             end
 
             Karafka.monitor.subscribe('deimos.batch_consumption.invalid_records') do |payload|
@@ -785,8 +760,9 @@ module ActiveRecordBatchConsumerTest
         before(:each) do
           register_consumer(consumer_class,
                             'MySchema',
-                            key_config: {plain: true})
+                            key_config: { plain: true })
         end
+
         let(:consumer_class) do
           Class.new(described_class) do
             record_class Widget
@@ -831,3 +807,4 @@ module ActiveRecordBatchConsumerTest
 
   end
 end
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/active_record_consume/batch_consumption_spec.rb

@@ -103,47 +103,46 @@ RSpec.describe Deimos::ActiveRecordConsume::BatchConsumption do
 
   describe '#compact_messages' do
     it 'for scalars' do
-      message_1 = Deimos::Message.new({ v: "first" }, key: 1234)
-      message_2 = Deimos::Message.new({ v: "last" }, key: 1234)
-      result = batch_consumer.send(:compact_messages, [message_1, message_2])
+      message1 = Deimos::Message.new({ v: 'first' }, key: 1234)
+      message2 = Deimos::Message.new({ v: 'last' }, key: 1234)
+      result = batch_consumer.send(:compact_messages, [message1, message2])
       expect(result.size).to eq(1)
-      expect(result.first.equal?(message_2)).to eq(true)
+      expect(result.first.equal?(message2)).to be(true)
     end
 
     it 'for hashes' do
-      message_1 = Deimos::Message.new({ v: "first" }, key: { a: 1, b:2.0, c: "c"})
-      message_2 = Deimos::Message.new({ v: "last" }, key: { a: 1, b:2.0, c: "c"})
-      result = batch_consumer.send(:compact_messages, [message_1, message_2])
+      message1 = Deimos::Message.new({ v: 'first' }, key: { a: 1, b: 2.0, c: 'c' })
+      message2 = Deimos::Message.new({ v: 'last' }, key: { a: 1, b: 2.0, c: 'c' })
+      result = batch_consumer.send(:compact_messages, [message1, message2])
       expect(result.size).to eq(1)
-      expect(result.first.equal?(message_2)).to eq(true)
+      expect(result.first.equal?(message2)).to be(true)
     end
 
     it 'for schema classes' do
-      module Schemas
-        class Key < Deimos::SchemaClass::Record
-          attr_accessor :some_name
-
-          # @override
-          def initialize(some_name: "")
-            super
-            self.some_name = some_name
-          end
-
-          # @override
-          def as_json(_opts={})
-            {
-              'some_name' => @some_name
-            }
-          end
+      klass = Class.new(Deimos::SchemaClass::Record) do
+        attr_accessor :some_name
+
+        # @override
+        def initialize(some_name: '')
+          super
+          self.some_name = some_name
+        end
+
+        # @override
+        def as_json(_opts={})
+          {
+            'some_name' => @some_name
+          }
         end
       end
+      stub_const('Schemas::Key', klass)
 
-      message_1 = Deimos::Message.new({ v: "first" }, key: Schemas::Key.new(some_name: "2"))
-      message_2 = Deimos::Message.new({ v: "last" }, key: Schemas::Key.new(some_name: "2"))
+      message1 = Deimos::Message.new({ v: 'first' }, key: Schemas::Key.new(some_name: '2'))
+      message2 = Deimos::Message.new({ v: 'last' }, key: Schemas::Key.new(some_name: '2'))
 
-      result = batch_consumer.send(:compact_messages, [message_1, message_2])
+      result = batch_consumer.send(:compact_messages, [message1, message2])
       expect(result.size).to eq(1)
-      expect(result.first.equal?(message_2)).to eq(true) # The object is same as the latest one in the batch
+      expect(result.first.equal?(message2)).to be(true) # The object is same as the latest one in the batch
     end
   end
 end

data/spec/active_record_consume/batch_slicer_spec.rb

@@ -18,18 +18,10 @@ RSpec.describe Deimos::ActiveRecordConsume::BatchSlicer do
 
       expect(slices).
         to match([
-                   match_array([
-                                 Deimos::Message.new({ v: 1 }, key: 'C'),
-                                 Deimos::Message.new({ v: 123 }, key: 'A'),
-                                 Deimos::Message.new({ v: 999 }, key: 'B')
-                               ]),
-                   match_array([
-                                 Deimos::Message.new({ v: 456 }, key: 'A'),
-                                 Deimos::Message.new({ v: 2 }, key: 'C')
-                               ]),
-                   match_array([
-                                 Deimos::Message.new({ v: 3 }, key: 'C')
-                               ])
+                   contain_exactly(Deimos::Message.new({ v: 1 }, key: 'C'), Deimos::Message.new({ v: 123 }, key: 'A'),
+                                   Deimos::Message.new({ v: 999 }, key: 'B')),
+                   contain_exactly(Deimos::Message.new({ v: 456 }, key: 'A'), Deimos::Message.new({ v: 2 }, key: 'C')),
+                   contain_exactly(Deimos::Message.new({ v: 3 }, key: 'C'))
                  ])
     end
 

data/spec/active_record_consume/mass_updater_spec.rb

@@ -195,7 +195,7 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
           WidgetFidget.reset_column_information
         end
 
-        # rubocop:disable RSpec/MultipleExpectations, RSpec/ExampleLength
+        # rubocop:disable RSpec/ExampleLength
         it 'should backfill the associations when upserting primary records' do
           batch = Deimos::ActiveRecordConsume::BatchRecordList.new(
             [
@@ -247,14 +247,14 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
             expect(widget_fidget.note).to eq("Stuff #{ind + 1}")
           end
         end
-        # rubocop:enable RSpec/MultipleExpectations, RSpec/ExampleLength
+        # rubocop:enable RSpec/ExampleLength
 
       end
 
       context 'with recorded primary_keys' do
         before(:all) do
           ActiveRecord::Base.connection.create_table(:fidgets, force: true, id: false) do |t|
-            t.string :test_id, primary_key: true
+            t.string(:test_id, primary_key: true)
             t.integer(:some_int)
             t.string(:bulk_import_id)
             t.timestamps
@@ -281,6 +281,24 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
             belongs_to :fidget
           end
         end
+        let(:batch) do
+          Deimos::ActiveRecordConsume::BatchRecordList.new(
+            [
+              Deimos::ActiveRecordConsume::BatchRecord.new(
+                klass: Fidget,
+                attributes: { test_id: 'id1', some_int: 5, fidget_detail: { title: 'Title 1' } },
+                bulk_import_column: 'bulk_import_id',
+                bulk_import_id_generator: bulk_id_generator
+              ),
+              Deimos::ActiveRecordConsume::BatchRecord.new(
+                klass: Fidget,
+                attributes: { test_id: 'id2', some_int: 10, fidget_detail: { title: 'Title 2' } },
+                bulk_import_column: 'bulk_import_id',
+                bulk_import_id_generator: bulk_id_generator
+              )
+            ]
+          )
+        end
 
         let(:fidget_class) do
           Class.new(ActiveRecord::Base) do
@@ -311,26 +329,6 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
           Fidget.reset_column_information
         end
 
-
-        let(:batch) do
-          Deimos::ActiveRecordConsume::BatchRecordList.new(
-          [
-            Deimos::ActiveRecordConsume::BatchRecord.new(
-              klass: Fidget,
-              attributes: { test_id: 'id1', some_int: 5, fidget_detail: { title: 'Title 1' } },
-              bulk_import_column: 'bulk_import_id',
-              bulk_import_id_generator: bulk_id_generator
-            ),
-            Deimos::ActiveRecordConsume::BatchRecord.new(
-              klass: Fidget,
-              attributes: { test_id: 'id2', some_int: 10, fidget_detail: { title: 'Title 2' } },
-              bulk_import_column: 'bulk_import_id',
-              bulk_import_id_generator: bulk_id_generator
-            )
-          ]
-        )
-        end
-
         it 'should not backfill the primary key when the primary_key exists' do
           allow(Fidget).to receive(:where).and_call_original
           results = described_class.new(Widget,
@@ -339,7 +337,7 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
                                         key_col_proc: key_proc).mass_update(batch)
           expect(results.count).to eq(2)
           expect(Fidget.count).to eq(2)
-          expect(Fidget).not_to have_received(:where).with(:bulk_import_id => [instance_of(String), instance_of(String)])
+          expect(Fidget).not_to have_received(:where).with(bulk_import_id: [instance_of(String), instance_of(String)])
         end
 
       end
@@ -374,6 +372,24 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
             belongs_to :fidget
           end
         end
+        let(:batch) do
+          Deimos::ActiveRecordConsume::BatchRecordList.new(
+            [
+              Deimos::ActiveRecordConsume::BatchRecord.new(
+                klass: Fidget,
+                attributes: { test_id: 'id1', some_int: 5, fidget_detail: { title: 'Title 1' } },
+                bulk_import_column: 'bulk_import_id',
+                bulk_import_id_generator: bulk_id_generator
+              ),
+              Deimos::ActiveRecordConsume::BatchRecord.new(
+                klass: Fidget,
+                attributes: { test_id: 'id2', some_int: 10, fidget_detail: { title: 'Title 2' } },
+                bulk_import_column: 'bulk_import_id',
+                bulk_import_id_generator: bulk_id_generator
+              )
+            ]
+          )
+        end
 
         let(:fidget_class) do
           Class.new(ActiveRecord::Base) do
@@ -404,26 +420,6 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
           Fidget.reset_column_information
         end
 
-
-        let(:batch) do
-          Deimos::ActiveRecordConsume::BatchRecordList.new(
-            [
-              Deimos::ActiveRecordConsume::BatchRecord.new(
-                klass: Fidget,
-                attributes: { test_id: 'id1', some_int: 5, fidget_detail: { title: 'Title 1' } },
-                bulk_import_column: 'bulk_import_id',
-                bulk_import_id_generator: bulk_id_generator
-              ),
-              Deimos::ActiveRecordConsume::BatchRecord.new(
-                klass: Fidget,
-                attributes: { test_id: 'id2', some_int: 10, fidget_detail: { title: 'Title 2' } },
-                bulk_import_column: 'bulk_import_id',
-                bulk_import_id_generator: bulk_id_generator
-              )
-            ]
-          )
-        end
-
         it 'should not backfill the primary key when the primary_key exists' do
           allow(Fidget).to receive(:where).and_call_original
           results = described_class.new(Widget,
@@ -432,8 +428,8 @@ RSpec.describe Deimos::ActiveRecordConsume::MassUpdater do
                                         key_col_proc: key_proc).mass_update(batch)
           expect(results.count).to eq(2)
           expect(Fidget.count).to eq(2)
-          expect(Fidget).to have_received(:where).with(:bulk_import_id => [instance_of(String), instance_of(String)])
-          expect(batch.records.map(&:id)).to eq([1,2])
+          expect(Fidget).to have_received(:where).with(bulk_import_id: [instance_of(String), instance_of(String)])
+          expect(batch.records.map(&:id)).to eq([1, 2])
         end
 
       end

data/spec/active_record_consume/schema_model_converter_spec.rb

@@ -19,7 +19,7 @@ module SchemaModelConverterTest
       end
 
       # :nodoc:
-      class Wibble < ActiveRecord::Base
+      class Wibble < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinitionInBlock
       end
       Wibble.reset_column_information
     end