deimos-ruby 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e02d7457d1a37f2f8a7be9a18cf56b119358b0dbbc7300d817837c7f7dddf91e
-  data.tar.gz: 4e3f8c96ecb33354ae089c354fbf76e4fed6155917d95a178a71100c2cfa2d5e
+  metadata.gz: '0226368aa5a493ec167e0cd4b0d03eeb8ac9e3efe8c2518fbe869275f6b7b10b'
+  data.tar.gz: 94afab34fb599d3cc0a5336a0af1ab8458621c8655c22de6882d1b87a645d8bf
 SHA512:
-  metadata.gz: 55180f29d246af58f027939ef8d3cd07ee61bd93e59dbb581a9495a37cbad36c125029de227d6086bec7d00c71c525d64fdce172244582162231f314633374bc
-  data.tar.gz: 982c996eafe934db2fcac4c32d9b3cb1080a421ad72f0b23fceca6feaf13c02806ae6c91732ad69009d4fdc3090251a557b2e3ac5f6922dbf8437efab0596717
+  metadata.gz: ee0516157c9fedd3e0ad9ff5dab95afbd9d3eee0975c899ede0f8104c1c9b5e992117221a8e42772f397abc3b8e70c755a90423a8d3daf93fd949751b3095f38
+  data.tar.gz: e42ad9fca0314bfa6cf5f764f7369a22a28d60c4d395b219df2d0c1ad1bb0c2d45a37d9e5eeb76984dbd7d122f211f4f8bbf8a5d0198108346bc8c16df795266

data/CHANGELOG.md

@@ -7,55 +7,74 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## UNRELEASED
 
+## [1.6.1] - 2020-04-20
+### Fixes :wrench:
+- Re-consuming a message after crashing would try to re-decode message keys.
+
 # [1.6.0] - 2020-03-05
+### Roadmap :car:
 - Removed `was_message_sent?` method from `TestHelpers`.
-- Bumped version to 1.6.0.
 
 # [1.6.0-beta1] - 2020-02-05
+### Roadmap :car:
 - Updated dependency for Phobos to 1.9.0-beta3. This ensures compatibility with
   Phobos 2.0.
+### Fixes :wrench:
 - Fixed RSpec warning when using `test_consume_invalid_message`.
 
 # [1.5.0-beta2] - 2020-01-17
+### Roadmap :car:
 - Added schema backends, which should simplify Avro encoding and make it
   more flexible for unit tests and local development.
+### Features :star:
 - Add `:test` producer backend which replaces the existing TestHelpers
   functionality of writing messages to an in-memory hash.
 
 # [1.4.0-beta7] - 2019-12-16
+### Fixes :wrench:
 - Clone loggers when assigning to multiple levels.
 
 # [1.4.0-beta6] - 2019-12-16
+### Features :star:
 - Added default for max_bytes_per_partition.
 
 # [1.4.0-beta4] - 2019-11-26
+### Features :star:
 - Added `define_settings` to define settings without invoking callbacks.
 
 # [1.4.0-beta2] - 2019-11-22
-- FIX: settings with default_proc were being called immediately
+### Fixes :wrench:
+- Settings with default_proc were being called immediately
   instead of being lazy-evaluated.
 
 # [1.4.0-beta1] - 2019-11-22
+### Roadmap :car:
 - Complete revamp of configuration method.
 
 # [1.3.0-beta5] - 2020-01-14
+### Features :star:
 - Added `db_producer.insert` and `db_producer.process` metrics.
 
 # [1.3.0-beta4] - 2019-12-02
+### Fixes :wrench:
 - Fixed bug where by running `rake deimos:start` without
   specifying a producer backend would crash.
 
 # [1.3.0-beta3] - 2019-11-26
+### Fixes :wrench:
 - Fixed bug in TestHelpers where key_decoder was not stubbed out.
 
 # [1.3.0-beta2] - 2019-11-22
+### Fixes :wrench:
 - Fixed bug where consumers would require a key config in all cases
   even though it's optional if they don't use keys.
 
 # [1.3.0-beta1] - 2019-11-21
+### Features :star:
 - Added `fetch_record` and `assign_key` methods to ActiveRecordConsumer.
 
 # [1.2.0-beta1] - 2019-09-12
+### Features :star:
 - Added `fatal_error` to both global config and consumer classes.
 - Changed `pending_db_messages_max_wait` metric to send per topic.
 - Added config to compact messages in the DB producer.
@@ -63,13 +82,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added config to provide a separate logger to the DB producer.
 
 # [1.1.0-beta2] - 2019-09-11
+### Fixes :wrench:
 - Fixed bug where ActiveRecordConsumer was not using `unscoped` to update
   via primary key and causing duplicate record errors.
 
 # [1.1.0-beta1] - 2019-09-10
+### Features :star:
 - Added BatchConsumer.
 
 ## [1.0.0] - 2019-09-03
+### Roadmap :car:
 - Official release of Deimos 1.0!
 
 ## [1.0.0-beta26] - 2019-08-29

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    deimos-ruby (1.6.0)
+    deimos-ruby (1.6.1)
       avro_turf (~> 0.11)
       phobos (~> 1.9)
       ruby-kafka (~> 0.7)
@@ -71,7 +71,7 @@ GEM
     digest-crc (0.5.1)
     dogstatsd-ruby (4.5.0)
     erubi (1.9.0)
-    excon (0.72.0)
+    excon (0.73.0)
     exponential-backoff (0.0.4)
     ffi (1.11.3)
     formatador (0.2.5)

data/lib/deimos/consumer.rb

@@ -18,9 +18,10 @@ module Deimos
       _received_message(payload, metadata)
       benchmark = Benchmark.measure do
         _with_error_span(payload, metadata) do
-          metadata[:key] = decode_key(metadata[:key]) if self.class.config[:key_configured]
+          new_metadata = metadata.dup
+          new_metadata[:key] = decode_key(metadata[:key]) if self.class.config[:key_configured]
           decoded_payload = payload ? self.class.decoder.decode(payload) : nil
-          yield decoded_payload, metadata
+          yield decoded_payload, new_metadata
         end
       end
       _handle_success(benchmark.real, payload, metadata)

data/lib/deimos/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Deimos
-  VERSION = '1.6.0'
+  VERSION = '1.6.1'
 end

data/spec/consumer_spec.rb

@@ -32,6 +32,23 @@ module ConsumerTest
                            end
     end
 
+    it 'should consume a message idempotently' do
+      # testing for a crash and re-consuming the same message/metadata
+      key = { 'test_id' => 'foo' }
+      test_metadata = { key: key }
+      allow_any_instance_of(MyConsumer).to(receive(:decode_key)) do |_instance, k|
+        k['test_id']
+      end
+      MyConsumer.new.around_consume({ 'test_id' => 'foo',
+                                      'some_int' => 123 }, test_metadata) do |_payload, metadata|
+                                        expect(metadata[:key]).to eq('foo')
+                                      end
+      MyConsumer.new.around_consume({ 'test_id' => 'foo',
+                                      'some_int' => 123 }, test_metadata) do |_payload, metadata|
+                                        expect(metadata[:key]).to eq('foo')
+                                      end
+    end
+
     it 'should consume a message on a topic' do
       test_consume_message('my_consume_topic',
                            'test_id' => 'foo',

data/spec/producer_spec.rb

@@ -89,15 +89,9 @@ module ProducerTest
         [{ 'test_id' => 'foo', 'some_int' => 123 },
          { 'test_id' => 'bar', 'some_int' => 124 }]
       )
-      expect(
-        was_message_sent?({ 'test_id' => 'foo', 'some_int' => 123 }, 'my-topic')
-      ).to be(true)
-      expect(
-        was_message_sent?({ 'test_id' => 'foo', 'some_int' => 123 }, 'your-topic')
-      ).to be(false)
-      expect(
-        was_message_sent?({ 'test_id' => 'foo2', 'some_int' => 123 }, 'my-topic')
-      ).to be(false)
+      expect('my-topic').to have_sent('test_id' => 'foo', 'some_int' => 123)
+      expect('your-topic').not_to have_sent('test_id' => 'foo', 'some_int' => 123)
+      expect('my-topic').not_to have_sent('test_id' => 'foo2', 'some_int' => 123)
     end
 
     it 'should add a message ID' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deimos-ruby
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Daniel Orner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-05 00:00:00.000000000 Z
+date: 2020-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: avro_turf