deimos-ruby 1.1.0.pre.beta1 → 1.1.0.pre.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9cb2755df1f6588b130a9171d427a54301e7e5258d6f414d8e9950393b0a361
-  data.tar.gz: dc475fcb4e450a693501b6c3a148c93dec90e0c40212e40de991e2aa7b8afb4f
+  metadata.gz: 66e879a3dd314b2291d62b45044cc909173a4a91f72b3f749114c525f53a8eaf
+  data.tar.gz: e5b4c2c22d3392f97991675825ed4aa0ede4f78164aaf1385c5850f5c77403d0
 SHA512:
-  metadata.gz: 8b7594655e6051986ddc55efc7a5df32fafd3e445324b8d2592eeb406cbf607cf401b6c6ab9c4d7c76d6d8cfa3c8890d47400231dec15f330dbffb0341644a59
-  data.tar.gz: bc909ec5cb051ee58e6f7840a1d191e9881f72e3442d9eba35be14e28fada2ff070f318fd5d73d46eca3bdc05f7ed05e0b0ac4d8a98f8ff4f29377854dd129ca
+  metadata.gz: 5cb509aacf5c75c7b9be9ffd9fc6e9d2e52f5a7351dfeefd8bf7e6a5a76b795985ab08bbfe5330f2a1917859bd6f82d3a5df750c972e30b39db3df7cd47289fd
+  data.tar.gz: c8c7f1380c021ca4e991b507cc859e848dc3eb07d6af5fb2fad76bfb8c4560cd08e9aa9337450a1f597dcbbb620db3546125127ee11c137ef164ce3621de50b2

data/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## UNRELEASED
 
+# [1.1.0-beta2] - 2019-09-11
+- Fixed bug where ActiveRecordConsumer was not using `unscoped` to update
+  via primary key and causing duplicate record errors.
+
 # [1.1.0-beta1] - 2019-09-10
 - Added BatchConsumer.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    deimos-ruby (1.1.0.pre.beta1)
+    deimos-ruby (1.1.0.pre.beta2)
       avro-patches (~> 0.3)
       avro_turf (~> 0.8)
       phobos (~> 1.8.2.pre.beta2)

data/lib/deimos/active_record_consumer.rb

@@ -17,7 +17,7 @@ module Deimos
     def consume(payload, metadata)
       key = metadata.with_indifferent_access[:key]
       klass = self.class.config[:record_class]
-      record = klass.where(klass.primary_key => key).first
+      record = klass.unscoped.where(klass.primary_key => key).first
       if payload.nil?
         destroy_record(record)
         return

data/lib/deimos/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Deimos
-  VERSION = '1.1.0-beta1'
+  VERSION = '1.1.0-beta2'
 end

data/spec/active_record_consumer_spec.rb

@@ -17,6 +17,7 @@ module ActiveRecordProducerTest
 
       # :nodoc:
       class Widget < ActiveRecord::Base
+        default_scope -> { where(some_bool: false) }
       end
       Widget.reset_column_information
     end
@@ -55,8 +56,12 @@ module ActiveRecordProducerTest
         expect(widget.test_id).to eq('abc')
         expect(widget.some_int).to eq(3)
         expect(widget.some_datetime_int).to eq(Time.zone.now)
+        expect(widget.some_bool).to eq(false)
         expect(widget.updated_at).to eq(Time.zone.now)
 
+        # test unscoped
+        widget.update_attribute(:some_bool, true)
+
         # test update
         test_consume_message(MyConsumer, {
                                test_id: 'abcd',
@@ -64,7 +69,8 @@ module ActiveRecordProducerTest
                                some_datetime_int: Time.zone.now.to_i,
                                timestamp: 2.minutes.ago.to_s
                              }, { call_original: true, key: 5 })
-        widget = Widget.last
+        expect(Widget.unscoped.count).to eq(1)
+        widget = Widget.unscoped.last
         expect(widget.id).to eq(5)
         expect(widget.test_id).to eq('abcd')
         expect(widget.some_int).to eq(3)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deimos-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.0.pre.beta1
+  version: 1.1.0.pre.beta2
 platform: ruby
 authors:
 - Daniel Orner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-10 00:00:00.000000000 Z
+date: 2019-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: avro-patches