defra_ruby_validators 2.1.1 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 335cd07927a66b2234c6d46e3679c36cce4ea8d9
-  data.tar.gz: bbf40277daa6034e9a6fa475f6eb87720c639aa1
+  metadata.gz: 21bdd325a2591dc6b3240957791d511239cadf35
+  data.tar.gz: dbf3657df6f3c814a3f2081a4c576f3319c5c713
 SHA512:
-  metadata.gz: 4bcf3e27a98c5cf07824a7d2b65b882163fb793aa7db0f9b065c5e30a32688ca5c9342dda9a2ad2ce3bea9871953c9434ba32353c22dd12958ed280ccc4bf45a
-  data.tar.gz: e8aff732a95ac9952b6f4360e1f0014d1203ff1dd0581b87c0d18427fd0910df986d48718ef4f311bdbf83cbf32347c7a69485aef6dea413b678b281ab54077e
+  metadata.gz: 22c834aeb4feacd105d153c38a0db5ba1ea3951e8f4e78fb8bb8f48fb1a797ba64973b98565ea4c51904ca623a40934f1e9d6f57b7bb7319197762480cf17938
+  data.tar.gz: 3553f860583d638a6fcd86038240c507dd3fc4f89ad16e1fd87ec68bbf5386a27d36f46ecb7536717f2f060804ae5f8d9fdaa1ef784cbc05194df1beedf63b44

data/README.md

@@ -1,9 +1,9 @@
-<img src="/defra-ruby-validators.png" alt="Defra ruby validators logo" />
+# Defra Ruby Validators
 
-[![Build Status](https://travis-ci.com/DEFRA/defra-ruby-validators.svg?branch=master)](https://travis-ci.com/DEFRA/defra-ruby-validators)
-[![Maintainability](https://api.codeclimate.com/v1/badges/a0f8611f1a879786f642/maintainability)](https://codeclimate.com/github/DEFRA/defra-ruby-validators/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/a0f8611f1a879786f642/test_coverage)](https://codeclimate.com/github/DEFRA/defra-ruby-validators/test_coverage)
-[![security](https://hakiri.io/github/DEFRA/defra-ruby-validators/master.svg)](https://hakiri.io/github/DEFRA/defra-ruby-validators/master)
+[![Build Status](https://travis-ci.com/DEFRA/defra-ruby-validators.svg?branch=main)](https://travis-ci.com/DEFRA/defra-ruby-validators)
+[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=DEFRA_defra-ruby-validators&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=DEFRA_defra-ruby-validators)
+[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=DEFRA_defra-ruby-validators&metric=coverage)](https://sonarcloud.io/dashboard?id=DEFRA_defra-ruby-validators)
+[![security](https://hakiri.io/github/DEFRA/defra-ruby-validators/main.svg)](https://hakiri.io/github/DEFRA/defra-ruby-validators/main)
 [![Gem Version](https://badge.fury.io/rb/defra_ruby_validators.svg)](https://badge.fury.io/rb/defra_ruby_validators)
 [![Licence](https://img.shields.io/badge/Licence-OGLv3-blue.svg)](http://www.nationalarchives.gov.uk/doc/open-government-licence/version/3)
 
@@ -117,6 +117,16 @@ If you want to include `overseas` in the accepted locations, you can enable this
 validates :location, "defra_ruby/validators/location": { allow_overseas: true }
 ```
 
+### Past date
+
+This validator checks the value provided is present and not a date in the future (`<= Date.today`).
+
+Add it to your model or form object using
+
+```ruby
+validates :date_received, "defra_ruby/validators/past_date_validator": true
+```
+
 ### Phone number
 
 This validator checks the value is present, is not too long (15 is th maximum length for any phone number), and is in the correct format as per [E.164](https://en.wikipedia.org/wiki/E.164) (we use [phonelib](https://github.com/daddyz/phonelib) to check the format).

data/Rakefile

@@ -11,7 +11,6 @@ Bundler::GemHelper.install_tasks
 # This is wrapped to prevent an error when rake is called in environments where
 # rspec may not be available, e.g. production. As such we don't need to handle
 # the error.
-# rubocop:disable Lint/HandleExceptions
 begin
   require "rspec/core/rake_task"
 
@@ -26,8 +25,9 @@ begin
   require "github_changelog_generator/task"
 
   GitHubChangelogGenerator::RakeTask.new :changelog do |config|
+    config.user = "defra"
+    config.project = "defra-ruby-validators"
   end
 rescue LoadError
   # no changelog available
 end
-# rubocop:enable Lint/HandleExceptions

data/bin/console

@@ -1,14 +1,10 @@
 #!/usr/bin/env ruby
 
 require "bundler/setup"
-require "defra/ruby/validators"
+require "defra_ruby/validators"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start(__FILE__)
+require "pry"
+Pry.start

data/config/locales/defra_ruby/validators/business_type_validator/en.yml

@@ -2,5 +2,4 @@ en:
   defra_ruby:
     validators:
       BusinessTypeValidator:
-        business_type:
-          inclusion: "You must answer this question"
+        inclusion: "You must answer this question"

data/config/locales/defra_ruby/validators/companies_house_number_validator/en.yml

@@ -2,9 +2,8 @@ en:
   defra_ruby:
     validators:
       CompaniesHouseNumberValidator:
-        company_no:
-          blank: Enter a company registration number
-          invalid_format: "Enter a valid number - it should have 8 digits, or 2 letters followed by 6 digits, or 2 letters followed by 5 digits and another letter. If your number has only 7 digits, enter it with a zero at the start."
-          not_found: Companies House couldn't find a company with this number
-          inactive: Your company must be registered as an active company
-          error: There was an error connecting with Companies House. Hopefully this is a one off and will work if you try again.
+        blank: Enter a company registration number
+        invalid_format: "Enter a valid number - it should have 8 digits, or 2 letters followed by 6 digits, or 2 letters followed by 5 digits and another letter. If your number has only 7 digits, enter it with a zero at the start."
+        not_found: Companies House couldn't find a company with this number
+        inactive: Your company must be registered as an active company
+        error: There was an error connecting with Companies House. Hopefully this is a one off and will work if you try again.

data/config/locales/defra_ruby/validators/email_validator/en.yml

@@ -2,6 +2,5 @@ en:
   defra_ruby:
     validators:
       EmailValidator:
-        email:
-          blank: "Enter an email address"
-          invalid_format: "Enter a valid email address - there’s a mistake in that one"
+        blank: "Enter an email address"
+        invalid_format: "Enter a valid email address - there’s a mistake in that one"

data/config/locales/defra_ruby/validators/grid_reference_validator/en.yml

@@ -2,7 +2,6 @@ en:
   defra_ruby:
     validators:
       GridReferenceValidator:
-        grid_reference:
-          blank: Enter a grid reference
-          invalid_format: The grid reference should have 2 letters and 10 digits
-          invalid: The grid reference is not a valid coordinate
+        blank: Enter a grid reference
+        invalid_format: The grid reference should have 2 letters and 10 digits
+        invalid: The grid reference is not a valid coordinate

data/config/locales/defra_ruby/validators/location_validator/en.yml

@@ -2,5 +2,4 @@ en:
   defra_ruby:
     validators:
       LocationValidator:
-        location:
-          inclusion: "You must answer this question"
+        inclusion: "You must answer this question"

data/config/locales/defra_ruby/validators/past_date_validator/en.yml

@@ -0,0 +1,6 @@
+en:
+  defra_ruby:
+    validators:
+      PastDateValidator:
+        past_date: "Date cannot be in the future"
+        invalid_date: "You must enter a valid date"

data/config/locales/defra_ruby/validators/phone_number_validator/en.yml

@@ -2,7 +2,6 @@ en:
   defra_ruby:
     validators:
       PhoneNumberValidator:
-        phone_number:
-          blank: "Enter a telephone number"
-          invalid_format: "Enter a valid telephone number"
-          too_long: "Check the number you entered - it should have no more than than 15 characters"
+        blank: "Enter a telephone number"
+        invalid_format: "Enter a valid telephone number"
+        too_long: "Check the number you entered - it should have no more than than 15 characters"

data/config/locales/defra_ruby/validators/position_validator/en.yml

@@ -2,6 +2,5 @@ en:
   defra_ruby:
     validators:
       PositionValidator:
-        position:
-          invalid_format: "The position must contain only letters, spaces, commas, full stops, hyphens and apostrophes"
-          too_long: "The position must have no more than 70 characters"
+        invalid_format: "The position must contain only letters, spaces, commas, full stops, hyphens and apostrophes"
+        too_long: "The position must have no more than 70 characters"

data/config/locales/defra_ruby/validators/token_validator/en.yml

@@ -2,6 +2,5 @@ en:
   defra_ruby:
     validators:
       TokenValidator:
-        token:
-          invalid_format: "The token is not valid"
-          blank: "The token is missing"
+        invalid_format: "The token is not valid"
+        blank: "The token is missing"

data/config/locales/defra_ruby/validators/true_false_validator/en.yml

@@ -2,5 +2,4 @@ en:
   defra_ruby:
     validators:
       TrueFalseValidator:
-        attribute:
-          inclusion: "You must answer this question"
+        inclusion: "You must answer this question"

data/lib/defra_ruby/validators.rb

@@ -21,6 +21,7 @@ require_relative "validators/phone_number_validator"
 require_relative "validators/position_validator"
 require_relative "validators/token_validator"
 require_relative "validators/true_false_validator"
+require_relative "validators/past_date_validator"
 
 module DefraRuby
   module Validators

data/lib/defra_ruby/validators/base_validator.rb

@@ -6,11 +6,17 @@ module DefraRuby
 
       protected
 
-      def error_message(attribute, error)
+      def add_validation_error(record, attribute, error)
+        record.errors.add(attribute,
+                          error,
+                          message: error_message(error))
+      end
+
+      def error_message(error)
         if options[:messages] && options[:messages][error]
           options[:messages][error]
         else
-          I18n.t("defra_ruby.validators.#{class_name}.#{attribute}.#{error}")
+          I18n.t("defra_ruby.validators.#{class_name}.#{error}")
         end
       end
 

data/lib/defra_ruby/validators/companies_house_number_validator.rb

@@ -25,14 +25,14 @@ module DefraRuby
       def value_is_present?(record, attribute, value)
         return true if value.present?
 
-        record.errors[attribute] << error_message(:company_no, :blank)
+        add_validation_error(record, attribute, :blank)
         false
       end
 
       def format_is_valid?(record, attribute, value)
         return true if value.match?(VALID_COMPANIES_HOUSE_REGISTRATION_NUMBER_REGEX)
 
-        record.errors[attribute] << error_message(:company_no, :invalid_format)
+        add_validation_error(record, attribute, :invalid_format)
         false
       end
 
@@ -41,12 +41,12 @@ module DefraRuby
         when :active
           true
         when :inactive
-          record.errors[attribute] << error_message(:company_no, :inactive)
+          add_validation_error(record, attribute, :inactive)
         when :not_found
-          record.errors[attribute] << error_message(:company_no, :not_found)
+          add_validation_error(record, attribute, :not_found)
         end
       rescue StandardError
-        record.errors[attribute] << error_message(:company_no, :error)
+        add_validation_error(record, attribute, :error)
       end
 
     end

data/lib/defra_ruby/validators/concerns/can_validate_characters.rb

@@ -10,7 +10,7 @@ module DefraRuby
         # Name fields must contain only letters, spaces, commas, full stops, hyphens and apostrophes
         return true if value.match?(/\A[-a-z\s,.']+\z/i)
 
-        record.errors[attribute] << error_message(attribute, :invalid_format)
+        add_validation_error(record, attribute, :invalid_format)
         false
       end
 

data/lib/defra_ruby/validators/concerns/can_validate_length.rb

@@ -9,7 +9,7 @@ module DefraRuby
       def value_is_not_too_long?(record, attribute, value, max_length)
         return true if value.length <= max_length
 
-        record.errors[attribute] << error_message(attribute, :too_long)
+        add_validation_error(record, attribute, :too_long)
         false
       end
 

data/lib/defra_ruby/validators/concerns/can_validate_presence.rb

@@ -9,7 +9,7 @@ module DefraRuby
       def value_is_present?(record, attribute, value)
         return true if value.present?
 
-        record.errors[attribute] << error_message(attribute, :blank)
+        add_validation_error(record, attribute, :blank)
         false
       end
 

data/lib/defra_ruby/validators/concerns/can_validate_selection.rb

@@ -7,9 +7,10 @@ module DefraRuby
       private
 
       def value_is_included?(record, attribute, value, valid_options)
-        return true if value.present? && valid_options.include?(value)
+        # In this case, we do want `false.present?` to return `true` https://github.com/rails/rails/issues/10804
+        return true if (value == false || value.present?) && valid_options.include?(value)
 
-        record.errors[attribute] << error_message(attribute, :inclusion)
+        add_validation_error(record, attribute, :inclusion)
         false
       end
 

data/lib/defra_ruby/validators/email_validator.rb

@@ -19,7 +19,7 @@ module DefraRuby
         # validate_email_format returns nil if the validation passes
         return true unless ValidatesEmailFormatOf.validate_email_format(value)
 
-        record.errors[attribute] << error_message(:email, :invalid_format)
+        add_validation_error(record, attribute, :invalid_format)
         false
       end
 

data/lib/defra_ruby/validators/grid_reference_validator.rb

@@ -22,7 +22,7 @@ module DefraRuby
       def valid_format?(record, attribute, value)
         return true if value.match?(/\A#{grid_reference_pattern}\z/)
 
-        record.errors[attribute] << error_message(:grid_reference, :invalid_format)
+        add_validation_error(record, attribute, :invalid_format)
         false
       end
 
@@ -30,7 +30,7 @@ module DefraRuby
         OsMapRef::Location.for(value).easting
         true
       rescue OsMapRef::Error
-        record.errors[attribute] << error_message(:grid_reference, :invalid)
+        add_validation_error(record, attribute, :invalid)
         false
       end
 

data/lib/defra_ruby/validators/past_date_validator.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module DefraRuby
+  module Validators
+    class PastDateValidator < BaseValidator
+      def validate_each(record, attribute, value)
+        return false if value.blank?
+
+        date = value.to_date
+
+        if date > Date.today
+          add_validation_error(record, attribute, :past_date)
+
+          return false
+        end
+
+        if date.year < 1900
+          add_validation_error(record, attribute, :invalid_date)
+
+          return false
+        end
+
+        true
+      end
+    end
+  end
+end

data/lib/defra_ruby/validators/phone_number_validator.rb

@@ -23,7 +23,7 @@ module DefraRuby
         Phonelib.default_country = "GB"
         return true if Phonelib.valid?(value)
 
-        record.errors[attribute] << error_message(:phone_number, :invalid_format)
+        add_validation_error(record, attribute, :invalid_format)
         false
       end
 

data/lib/defra_ruby/validators/token_validator.rb

@@ -19,7 +19,7 @@ module DefraRuby
         # 24-character unique tokens
         return true if value.length == 24
 
-        record.errors[attribute] << error_message(:token, :invalid_format)
+        add_validation_error(record, attribute, :invalid_format)
         false
       end
     end

data/lib/defra_ruby/validators/true_false_validator.rb

@@ -6,7 +6,7 @@ module DefraRuby
       include CanValidateSelection
 
       def validate_each(record, attribute, value)
-        valid_options = %w[true false]
+        valid_options = [true, false]
 
         value_is_included?(record, attribute, value, valid_options)
       end

data/lib/defra_ruby/validators/version.rb

@@ -2,6 +2,6 @@
 
 module DefraRuby
   module Validators
-    VERSION = "2.1.1"
+    VERSION = "2.4.1"
   end
 end

data/spec/defra_ruby/validators/business_type_validator_spec.rb

@@ -42,7 +42,7 @@ module DefraRuby
             allow_any_instance_of(DefraRuby::Validators::BaseValidator).to receive(:options).and_return({})
           end
 
-          error_message = Helpers::Translator.error_message(BusinessTypeValidator, :business_type, :inclusion)
+          error_message = Helpers::Translator.error_message(BusinessTypeValidator, :inclusion)
 
           it_behaves_like "an invalid record",
                           validatable: validatable,

data/spec/defra_ruby/validators/companies_house_number_validator_spec.rb

@@ -37,11 +37,7 @@ module DefraRuby
         context "when given an invalid company number" do
           context "because it is blank" do
             validatable = Test::CompaniesHouseNumberValidatable.new
-            error_message = Helpers::Translator.error_message(
-              CompaniesHouseNumberValidator,
-              :company_no,
-              :blank
-            )
+            error_message = Helpers::Translator.error_message(CompaniesHouseNumberValidator, :blank)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,
@@ -52,11 +48,7 @@ module DefraRuby
 
           context "because the format is wrong" do
             validatable = Test::CompaniesHouseNumberValidatable.new(invalid_format_number)
-            error_message = Helpers::Translator.error_message(
-              CompaniesHouseNumberValidator,
-              :company_no,
-              :invalid_format
-            )
+            error_message = Helpers::Translator.error_message(CompaniesHouseNumberValidator, :invalid_format)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,
@@ -71,11 +63,7 @@ module DefraRuby
             end
 
             validatable = Test::CompaniesHouseNumberValidatable.new(unknown_number)
-            error_message = Helpers::Translator.error_message(
-              CompaniesHouseNumberValidator,
-              :company_no,
-              :not_found
-            )
+            error_message = Helpers::Translator.error_message(CompaniesHouseNumberValidator, :not_found)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,
@@ -90,11 +78,7 @@ module DefraRuby
             end
 
             validatable = Test::CompaniesHouseNumberValidatable.new(inactive_number)
-            error_message = Helpers::Translator.error_message(
-              CompaniesHouseNumberValidator,
-              :company_no,
-              :inactive
-            )
+            error_message = Helpers::Translator.error_message(CompaniesHouseNumberValidator, :inactive)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,
@@ -110,11 +94,7 @@ module DefraRuby
           end
 
           validatable = Test::CompaniesHouseNumberValidatable.new(valid_numbers.sample)
-          error_message = Helpers::Translator.error_message(
-            CompaniesHouseNumberValidator,
-            :company_no,
-            :error
-          )
+          error_message = Helpers::Translator.error_message(CompaniesHouseNumberValidator, :error)
 
           it_behaves_like "an invalid record",
                           validatable: validatable,

data/spec/defra_ruby/validators/companies_house_service_spec.rb

@@ -1,13 +1,21 @@
 # frozen_string_literal: true
 
+require "webmock/rspec"
+
 RSpec.describe DefraRuby::Validators::CompaniesHouseService do
   let(:subject) { described_class.new("09360070") }
   let(:host) { "https://api.companieshouse.gov.uk/" }
 
   describe "#status" do
     context "when the company_no is for an active company" do
-      before(:each) { VCR.insert_cassette("company_no_valid") }
-      after(:each) { VCR.eject_cassette }
+      before do
+        expected_body = { "company_status": "active" }
+
+        stub_request(:any, /.*#{host}.*/).to_return(
+          status: 200,
+          body: expected_body.to_json
+        )
+      end
 
       it "returns :active" do
         expect(subject.status).to eq(:active)
@@ -15,9 +23,11 @@ RSpec.describe DefraRuby::Validators::CompaniesHouseService do
     end
 
     context "when the company_no is not found" do
-      let(:subject) { described_class.new("99999999") }
-      before(:each) { VCR.insert_cassette("company_no_not_found") }
-      after(:each) { VCR.eject_cassette }
+      before do
+        stub_request(:any, /.*#{host}.*/).to_return(
+          status: 404
+        )
+      end
 
       it "returns :not_found" do
         expect(subject.status).to eq(:not_found)
@@ -25,9 +35,14 @@ RSpec.describe DefraRuby::Validators::CompaniesHouseService do
     end
 
     context "when the company_no is inactive" do
-      let(:subject) { described_class.new("07281919") }
-      before(:each) { VCR.insert_cassette("company_no_inactive") }
-      after(:each) { VCR.eject_cassette }
+      before do
+        expected_body = { "company_status": "dissolved" }
+
+        stub_request(:any, /.*#{host}.*/).to_return(
+          status: 200,
+          body: expected_body.to_json
+        )
+      end
 
       it "returns :inactive" do
         expect(subject.status).to eq(:inactive)
@@ -35,11 +50,8 @@ RSpec.describe DefraRuby::Validators::CompaniesHouseService do
     end
 
     context "when there is a problem with the Companies House API" do
-      before(:each) { VCR.turn_off! }
-      after(:each) { VCR.turn_on! }
-
       context "and the request times out" do
-        before(:each) { stub_request(:any, /.*#{host}.*/).to_timeout }
+        before { stub_request(:any, /.*#{host}.*/).to_timeout }
 
         it "raises an exception" do
           expect { subject.status }.to raise_error(StandardError)
@@ -47,7 +59,7 @@ RSpec.describe DefraRuby::Validators::CompaniesHouseService do
       end
 
       context "and request returns an error" do
-        before(:each) { stub_request(:any, /.*#{host}.*/).to_raise(SocketError) }
+        before { stub_request(:any, /.*#{host}.*/).to_raise(SocketError) }
 
         it "raises an exception" do
           expect { subject.status }.to raise_error(StandardError)

data/spec/defra_ruby/validators/email_validator_spec.rb

@@ -31,7 +31,7 @@ module DefraRuby
           context "because the email is not correctly formatted" do
             validatable = Test::EmailValidatable.new(invalid_email)
 
-            error_message = Helpers::Translator.error_message(EmailValidator, :email, :invalid_format)
+            error_message = Helpers::Translator.error_message(EmailValidator, :invalid_format)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,

data/spec/defra_ruby/validators/grid_reference_validator_spec.rb

@@ -31,7 +31,7 @@ module DefraRuby
         context "when the grid reference is not valid" do
           context "because the grid reference is not correctly formatted" do
             validatable = Test::GridReferenceValidatable.new(invalid_grid_reference)
-            error_message = Helpers::Translator.error_message(GridReferenceValidator, :grid_reference, :invalid_format)
+            error_message = Helpers::Translator.error_message(GridReferenceValidator, :invalid_format)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,
@@ -42,7 +42,7 @@ module DefraRuby
 
           context "because the grid reference is not a coordinate" do
             validatable = Test::GridReferenceValidatable.new(non_coordinate_grid_reference)
-            error_message = Helpers::Translator.error_message(GridReferenceValidator, :grid_reference, :invalid)
+            error_message = Helpers::Translator.error_message(GridReferenceValidator, :invalid)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,

data/spec/defra_ruby/validators/location_validator_spec.rb

@@ -42,7 +42,7 @@ module DefraRuby
             allow_any_instance_of(DefraRuby::Validators::BaseValidator).to receive(:options).and_return({})
           end
 
-          error_message = Helpers::Translator.error_message(LocationValidator, :location, :inclusion)
+          error_message = Helpers::Translator.error_message(LocationValidator, :inclusion)
 
           it_behaves_like "an invalid record",
                           validatable: validatable,

data/spec/defra_ruby/validators/past_date_validator_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Test
+  PastDateValidatable = Struct.new(:date) do
+    include ActiveModel::Validations
+
+    validates :date, "defra_ruby/validators/past_date": true
+  end
+end
+
+module DefraRuby
+  module Validators
+    RSpec.describe PastDateValidator, type: :model do
+
+      valid_date = Date.today
+      future_date = Date.today + 1
+      invalid_date = Date.new(20, 2, 2)
+
+      it_behaves_like "a valid record", Test::PastDateValidatable.new(valid_date)
+      it_behaves_like "an invalid record",
+                      validatable: Test::PastDateValidatable.new(future_date),
+                      attribute: :date,
+                      error: :past_date,
+                      error_message: Helpers::Translator.error_message(PastDateValidator, :past_date)
+
+      it_behaves_like "an invalid record",
+                      validatable: Test::PastDateValidatable.new(invalid_date),
+                      attribute: :date,
+                      error: :invalid_date,
+                      error_message: Helpers::Translator.error_message(PastDateValidator, :invalid_date)
+    end
+  end
+end

data/spec/defra_ruby/validators/phone_number_validator_spec.rb

@@ -44,7 +44,7 @@ module DefraRuby
         context "when the phone number is not valid" do
           context "because the phone number is not correctly formatted" do
             validatable = Test::PhoneNumberValidatable.new(invalid_number)
-            error_message = Helpers::Translator.error_message(PhoneNumberValidator, :phone_number, :invalid_format)
+            error_message = Helpers::Translator.error_message(PhoneNumberValidator, :invalid_format)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,

data/spec/defra_ruby/validators/token_validator_spec.rb

@@ -30,7 +30,7 @@ module DefraRuby
         context "when the token is not valid" do
           context "because the token is not correctly formatted" do
             validatable = Test::TokenValidatable.new(invalid_token)
-            error_message = Helpers::Translator.error_message(TokenValidator, :token, :invalid_format)
+            error_message = Helpers::Translator.error_message(TokenValidator, :invalid_format)
 
             it_behaves_like "an invalid record",
                             validatable: validatable,

data/spec/defra_ruby/validators/true_false_validator_spec.rb

@@ -13,17 +13,24 @@ end
 module DefraRuby
   module Validators
     RSpec.describe TrueFalseValidator do
-
-      valid_value = %w[true false].sample
       invalid_value = "unsure"
 
       it_behaves_like("a validator")
+
+      it_behaves_like(
+        "a selection validator",
+        TrueFalseValidator,
+        Test::TrueFalseValidatable,
+        :attribute,
+        valid: true, invalid: invalid_value
+      )
+
       it_behaves_like(
         "a selection validator",
         TrueFalseValidator,
         Test::TrueFalseValidatable,
         :attribute,
-        valid: valid_value, invalid: invalid_value
+        valid: false, invalid: invalid_value
       )
     end
   end

data/spec/support/helpers/translator.rb

@@ -2,10 +2,10 @@
 
 module Helpers
   module Translator
-    def self.error_message(klass, attribute, error)
+    def self.error_message(klass, error)
       class_name = klass_name(klass)
 
-      I18n.t("defra_ruby.validators.#{class_name}.#{attribute}.#{error}")
+      I18n.t("defra_ruby.validators.#{class_name}.#{error}")
     end
 
     def self.klass_name(klass)

data/spec/support/shared_examples/validators/characters_validator.rb

@@ -16,7 +16,7 @@ RSpec.shared_examples "a characters validator" do |validator, validatable_class,
     context "when the #{attribute} is not valid" do
       context "because the #{attribute} is not correctly formatted" do
         validatable = validatable_class.new(values[:invalid])
-        error_message = Helpers::Translator.error_message(validator, attribute, :invalid_format)
+        error_message = Helpers::Translator.error_message(validator, :invalid_format)
 
         it_behaves_like "an invalid record",
                         validatable: validatable,

data/spec/support/shared_examples/validators/length_validator.rb

@@ -16,7 +16,7 @@ RSpec.shared_examples "a length validator" do |validator, validatable_class, att
     context "when the #{attribute} is not valid" do
       context "because the #{attribute} is too long" do
         validatable = validatable_class.new(values[:invalid])
-        error_message = Helpers::Translator.error_message(validator, attribute, :too_long)
+        error_message = Helpers::Translator.error_message(validator, :too_long)
 
         it_behaves_like "an invalid record",
                         validatable: validatable,

data/spec/support/shared_examples/validators/presence_validator.rb

@@ -16,7 +16,7 @@ RSpec.shared_examples "a presence validator" do |validator, validatable_class, a
     context "when the #{attribute} is not valid" do
       context "because the #{attribute} is not present" do
         validatable = validatable_class.new
-        error_message = Helpers::Translator.error_message(validator, attribute, :blank)
+        error_message = Helpers::Translator.error_message(validator, :blank)
 
         it_behaves_like "an invalid record",
                         validatable: validatable,

data/spec/support/shared_examples/validators/selection_validator.rb

@@ -16,7 +16,7 @@ RSpec.shared_examples "a selection validator" do |validator, validatable_class,
     context "when the #{attribute} is not valid" do
       context "because the #{attribute} is not present" do
         validatable = validatable_class.new
-        error_message = Helpers::Translator.error_message(validator, attribute, :inclusion)
+        error_message = Helpers::Translator.error_message(validator, :inclusion)
 
         it_behaves_like "an invalid record",
                         validatable: validatable,
@@ -27,7 +27,7 @@ RSpec.shared_examples "a selection validator" do |validator, validatable_class,
 
       context "because the #{attribute} is not from an approved list" do
         validatable = validatable_class.new(values[:invalid])
-        error_message = Helpers::Translator.error_message(validator, attribute, :inclusion)
+        error_message = Helpers::Translator.error_message(validator, :inclusion)
 
         it_behaves_like "an invalid record",
                         validatable: validatable,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: defra_ruby_validators
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.4.1
 platform: ruby
 authors:
 - Defra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-28 00:00:00.000000000 Z
+date: 2020-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -180,32 +180,18 @@ dependencies:
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 0.17.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 0.17.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -237,6 +223,7 @@ files:
 - config/locales/defra_ruby/validators/email_validator/en.yml
 - config/locales/defra_ruby/validators/grid_reference_validator/en.yml
 - config/locales/defra_ruby/validators/location_validator/en.yml
+- config/locales/defra_ruby/validators/past_date_validator/en.yml
 - config/locales/defra_ruby/validators/phone_number_validator/en.yml
 - config/locales/defra_ruby/validators/position_validator/en.yml
 - config/locales/defra_ruby/validators/token_validator/en.yml
@@ -255,15 +242,13 @@ files:
 - lib/defra_ruby/validators/engine.rb
 - lib/defra_ruby/validators/grid_reference_validator.rb
 - lib/defra_ruby/validators/location_validator.rb
+- lib/defra_ruby/validators/past_date_validator.rb
 - lib/defra_ruby/validators/phone_number_validator.rb
 - lib/defra_ruby/validators/position_validator.rb
 - lib/defra_ruby/validators/token_validator.rb
 - lib/defra_ruby/validators/true_false_validator.rb
 - lib/defra_ruby/validators/version.rb
 - lib/defra_ruby_validators.rb
-- spec/cassettes/company_no_inactive.yml
-- spec/cassettes/company_no_not_found.yml
-- spec/cassettes/company_no_valid.yml
 - spec/defra_ruby/validators/business_type_validator_spec.rb
 - spec/defra_ruby/validators/companies_house_number_validator_spec.rb
 - spec/defra_ruby/validators/companies_house_service_spec.rb
@@ -271,12 +256,12 @@ files:
 - spec/defra_ruby/validators/email_validator_spec.rb
 - spec/defra_ruby/validators/grid_reference_validator_spec.rb
 - spec/defra_ruby/validators/location_validator_spec.rb
+- spec/defra_ruby/validators/past_date_validator_spec.rb
 - spec/defra_ruby/validators/phone_number_validator_spec.rb
 - spec/defra_ruby/validators/position_validator_spec.rb
 - spec/defra_ruby/validators/token_validator_spec.rb
 - spec/defra_ruby/validators/true_false_validator_spec.rb
 - spec/defra_ruby/validators_spec.rb
-- spec/examples.txt
 - spec/spec_helper.rb
 - spec/support/defra_ruby_validators.rb
 - spec/support/helpers/text_generator.rb
@@ -291,7 +276,6 @@ files:
 - spec/support/shared_examples/validators/valid_record.rb
 - spec/support/shared_examples/validators/validator.rb
 - spec/support/simplecov.rb
-- spec/support/vcr.rb
 homepage: https://github.com/DEFRA/defra-ruby-validators
 licenses:
 - The Open Government Licence (OGL) Version 3
@@ -320,6 +304,7 @@ summary: Defra ruby on rails validations
 test_files:
 - spec/spec_helper.rb
 - spec/defra_ruby/validators_spec.rb
+- spec/defra_ruby/validators/past_date_validator_spec.rb
 - spec/defra_ruby/validators/companies_house_service_spec.rb
 - spec/defra_ruby/validators/configuration_spec.rb
 - spec/defra_ruby/validators/phone_number_validator_spec.rb
@@ -331,13 +316,8 @@ test_files:
 - spec/defra_ruby/validators/true_false_validator_spec.rb
 - spec/defra_ruby/validators/location_validator_spec.rb
 - spec/defra_ruby/validators/email_validator_spec.rb
-- spec/examples.txt
-- spec/cassettes/company_no_not_found.yml
-- spec/cassettes/company_no_valid.yml
-- spec/cassettes/company_no_inactive.yml
 - spec/support/simplecov.rb
 - spec/support/i18n.rb
-- spec/support/vcr.rb
 - spec/support/pry.rb
 - spec/support/defra_ruby_validators.rb
 - spec/support/helpers/translator.rb

data/spec/cassettes/company_no_inactive.yml

@@ -1,67 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://api.companieshouse.gov.uk/company/07281919
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin16.7.0 x86_64) ruby/2.4.2p198
-      Host:
-      - api.companieshouse.gov.uk
-      Authorization:
-      - Basic MnZodWowb1dhYk13N2h6TnpBVWlTT2ctNktpVVRCcFhCRF83Zktibzo=
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Tue, 20 Aug 2019 14:28:41 GMT
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '979'
-      Connection:
-      - keep-alive
-      Access-Control-Allow-Credentials:
-      - 'true'
-      Access-Control-Allow-Headers:
-      - X-RateLimit-Query, origin, content-type, content-length, user-agent, host,
-        accept, authorization
-      Access-Control-Expose-Headers:
-      - Location,www-authenticate,cache-control,pragma,content-type,expires,last-modified
-      - X-RateLimit-Window, X-RateLimit-Limit, X-RateLimit-Remain, X-RateLimit-Reset,
-        Location, www-authenticate, cache-control, pragma, content-type, expires,
-        last-modified
-      Access-Control-Max-Age:
-      - '3600'
-      Cache-Control:
-      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
-      Pragma:
-      - no-cache
-      X-Ratelimit-Limit:
-      - '600'
-      X-Ratelimit-Remain:
-      - '590'
-      X-Ratelimit-Reset:
-      - '1566311455'
-      X-Ratelimit-Window:
-      - 5m
-      Server:
-      - CompaniesHouse
-    body:
-      encoding: UTF-8
-      string: '{"sic_codes":["82990"],"company_number":"07281919","has_been_liquidated":false,"accounts":{"last_accounts":{"made_up_to":"2013-06-30","type":"total-exemption-small"},"accounting_reference_date":{"day":"30","month":"06"}},"last_full_members_list_date":"2014-06-11","status":"active","type":"ltd","date_of_creation":"2010-06-11","registered_office_address":{"postal_code":"HA8
-        7EJ","locality":"Edgware","region":"Middlesex","address_line_1":"8th Floor
-        Elizabeth House","address_line_2":"54-58 High Street"},"undeliverable_registered_office_address":false,"company_name":"DIRECT
-        SKIPS UK LTD","annual_return":{"last_made_up_to":"2014-06-11"},"jurisdiction":"england-wales","etag":"1cdef5bc2a020b3e9003b086033b64b78bcb28f6","company_status":"dissolved","has_insolvency_history":false,"has_charges":false,"links":{"self":"/company/07281919","filing_history":"/company/07281919/filing-history","officers":"/company/07281919/officers"},"date_of_cessation":"2016-01-05","can_file":false}'
-    http_version: 
-  recorded_at: Tue, 20 Aug 2019 14:28:41 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/company_no_not_found.yml

@@ -1,64 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://api.companieshouse.gov.uk/company/99999999
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin16.7.0 x86_64) ruby/2.4.2p198
-      Host:
-      - api.companieshouse.gov.uk
-      Authorization:
-      - Basic MnZodWowb1dhYk13N2h6TnpBVWlTT2ctNktpVVRCcFhCRF83Zktibzo=
-  response:
-    status:
-      code: 404
-      message: Not Found
-    headers:
-      Date:
-      - Tue, 20 Aug 2019 14:28:41 GMT
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '70'
-      Connection:
-      - keep-alive
-      Access-Control-Allow-Credentials:
-      - 'true'
-      Access-Control-Allow-Headers:
-      - X-RateLimit-Query, origin, content-type, content-length, user-agent, host,
-        accept, authorization
-      Access-Control-Expose-Headers:
-      - Location,www-authenticate,cache-control,pragma,content-type,expires,last-modified
-      - X-RateLimit-Window, X-RateLimit-Limit, X-RateLimit-Remain, X-RateLimit-Reset,
-        Location, www-authenticate, cache-control, pragma, content-type, expires,
-        last-modified
-      Access-Control-Max-Age:
-      - '3600'
-      Cache-Control:
-      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
-      Pragma:
-      - no-cache
-      X-Ratelimit-Limit:
-      - '600'
-      X-Ratelimit-Remain:
-      - '591'
-      X-Ratelimit-Reset:
-      - '1566311455'
-      X-Ratelimit-Window:
-      - 5m
-      Server:
-      - CompaniesHouse
-    body:
-      encoding: UTF-8
-      string: '{"errors":[{"type":"ch:service","error":"company-profile-not-found"}]}'
-    http_version: 
-  recorded_at: Tue, 20 Aug 2019 14:28:41 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/company_no_valid.yml

@@ -1,65 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://api.companieshouse.gov.uk/company/09360070
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin16.7.0 x86_64) ruby/2.4.2p198
-      Host:
-      - api.companieshouse.gov.uk
-      Authorization:
-      - Basic MnZodWowb1dhYk13N2h6TnpBVWlTT2ctNktpVVRCcFhCRF83Zktibzo=
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Tue, 20 Aug 2019 14:28:40 GMT
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '1178'
-      Connection:
-      - keep-alive
-      Access-Control-Allow-Credentials:
-      - 'true'
-      Access-Control-Allow-Headers:
-      - X-RateLimit-Query, origin, content-type, content-length, user-agent, host,
-        accept, authorization
-      Access-Control-Expose-Headers:
-      - Location,www-authenticate,cache-control,pragma,content-type,expires,last-modified
-      - X-RateLimit-Window, X-RateLimit-Limit, X-RateLimit-Remain, X-RateLimit-Reset,
-        Location, www-authenticate, cache-control, pragma, content-type, expires,
-        last-modified
-      Access-Control-Max-Age:
-      - '3600'
-      Cache-Control:
-      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
-      Pragma:
-      - no-cache
-      X-Ratelimit-Limit:
-      - '600'
-      X-Ratelimit-Remain:
-      - '592'
-      X-Ratelimit-Reset:
-      - '1566311455'
-      X-Ratelimit-Window:
-      - 5m
-      Server:
-      - CompaniesHouse
-    body:
-      encoding: UTF-8
-      string: '{"type":"ltd","company_name":"0800 WASTE LTD.","has_insolvency_history":false,"accounts":{"next_due":"2019-09-30","next_made_up_to":"2018-12-31","next_accounts":{"overdue":false,"period_start_on":"2018-01-01","due_on":"2019-09-30","period_end_on":"2018-12-31"},"accounting_reference_date":{"month":"12","day":"31"},"last_accounts":{"period_end_on":"2017-12-31","period_start_on":"2017-01-01","made_up_to":"2017-12-31"},"overdue":false},"undeliverable_registered_office_address":false,"etag":"0ec9d00cab0ffee2ef1f5d59f4f714fa5b1618f5","company_number":"09360070","registered_office_address":{"postal_code":"SM3
-        9ND","locality":"Sutton","region":"Surrey","address_line_1":"21 Haslam Avenue"},"jurisdiction":"england-wales","date_of_creation":"2014-12-18","company_status":"active","has_charges":false,"sic_codes":["38110"],"last_full_members_list_date":"2015-12-18","confirmation_statement":{"overdue":false,"next_made_up_to":"2020-01-23","last_made_up_to":"2019-01-23","next_due":"2020-02-06"},"links":{"self":"/company/09360070","filing_history":"/company/09360070/filing-history","officers":"/company/09360070/officers"},"registered_office_is_in_dispute":false,"can_file":true}'
-    http_version: 
-  recorded_at: Tue, 20 Aug 2019 14:28:40 GMT
-recorded_with: VCR 4.0.0

data/spec/examples.txt

@@ -1,81 +0,0 @@
-example_id                                                                         | status | run_time        |
----------------------------------------------------------------------------------- | ------ | --------------- |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:1:1]                | passed | 0.00145 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:1]                | passed | 0.00011 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:1:1:1]          | passed | 0.00017 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:1:1:2]          | passed | 0.00445 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:2:1:1:1]        | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:2:1:1:2]        | passed | 0.00016 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:2:1:1:3]        | passed | 0.00059 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:2:2:1:1]        | passed | 0.00016 seconds |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:2:2:1:2]        | passed | 0.0002 seconds  |
-./spec/defra_ruby/validators/business_type_validator_spec.rb[1:2:2:2:2:1:3]        | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:1:1]       | passed | 0.00009 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:1:1:1] | passed | 0.00043 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:1:1:2] | passed | 0.00044 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:2:1:1] | passed | 0.00043 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:2:1:2] | passed | 0.00041 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:3:1:1] | passed | 0.00045 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:3:1:2] | passed | 0.00646 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:4:1:1] | passed | 0.00042 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:1:4:1:2] | passed | 0.00038 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:1:1:1] | passed | 0.00015 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:1:1:2] | passed | 0.00016 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:1:1:3] | passed | 0.00017 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:2:1:1] | passed | 0.00017 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:2:1:2] | passed | 0.00015 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:2:1:3] | passed | 0.0002 seconds  |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:3:1:1] | passed | 0.00046 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:3:1:2] | passed | 0.00042 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:3:1:3] | passed | 0.00043 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:4:1:1] | passed | 0.00046 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:4:1:2] | passed | 0.00046 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:2:4:1:3] | passed | 0.00044 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:3:1:1]   | passed | 0.00045 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:3:1:2]   | passed | 0.00042 seconds |
-./spec/defra_ruby/validators/companies_house_number_validator_spec.rb[1:2:3:1:3]   | passed | 0.00046 seconds |
-./spec/defra_ruby/validators/companies_house_service_spec.rb[1:1:1:1]              | passed | 0.10949 seconds |
-./spec/defra_ruby/validators/companies_house_service_spec.rb[1:1:2:1]              | passed | 0.22067 seconds |
-./spec/defra_ruby/validators/companies_house_service_spec.rb[1:1:3:1]              | passed | 0.11422 seconds |
-./spec/defra_ruby/validators/companies_house_service_spec.rb[1:1:4:1:1]            | passed | 0.01368 seconds |
-./spec/defra_ruby/validators/companies_house_service_spec.rb[1:1:4:2:1]            | passed | 0.01557 seconds |
-./spec/defra_ruby/validators/configuration_spec.rb[1:1:1]                          | passed | 0.0014 seconds  |
-./spec/defra_ruby/validators/configuration_spec.rb[1:2]                            | passed | 0.00045 seconds |
-./spec/defra_ruby/validators/configuration_spec.rb[1:3:1:1]                        | passed | 0.00113 seconds |
-./spec/defra_ruby/validators/configuration_spec.rb[1:3:2:1]                        | passed | 0.00015 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:1:1]                     | passed | 0.0001 seconds  |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:2:1]                     | passed | 0.0001 seconds  |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:2:2:1:1:1]               | passed | 0.00014 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:2:2:1:1:2]               | passed | 0.00013 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:2:2:2:1:1:1]             | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:2:2:2:1:1:2]             | passed | 0.00019 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:2:2:2:1:1:3]             | passed | 0.00023 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:3:1]                     | passed | 0.00013 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:3:2:1:1:1]               | passed | 0.00017 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:3:2:1:1:2]               | passed | 0.00015 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:3:2:2:1:1:1]             | passed | 0.00021 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:3:2:2:1:1:2]             | passed | 0.00019 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:3:2:2:1:1:3]             | passed | 0.0003 seconds  |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:4:1:1:1:1]               | passed | 0.00014 seconds |
-./spec/defra_ruby/validators/position_validator_spec.rb[1:4:1:1:1:2]               | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:1:1]                        | passed | 0.00009 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:2:1]                        | passed | 0.00012 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:2:2:1:1:1]                  | passed | 0.0002 seconds  |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:2:2:1:1:2]                  | passed | 0.00012 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:2:2:2:1:1:1]                | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:2:2:2:1:1:2]                | passed | 0.00014 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:2:2:2:1:1:3]                | passed | 0.00017 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:3:1:1:1:1]                  | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:3:1:1:1:2]                  | passed | 0.00016 seconds |
-./spec/defra_ruby/validators/token_validator_spec.rb[1:3:1:1:1:3]                  | passed | 0.00015 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:1:1]                   | passed | 0.0001 seconds  |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:1]                   | passed | 0.0001 seconds  |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:1:1:1]             | passed | 0.00014 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:1:1:2]             | passed | 0.00015 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:2:1:1:1]           | passed | 0.00017 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:2:1:1:2]           | passed | 0.00016 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:2:1:1:3]           | passed | 0.00024 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:2:2:1:1]           | passed | 0.00019 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:2:2:1:2]           | passed | 0.00018 seconds |
-./spec/defra_ruby/validators/true_false_validator_spec.rb[1:2:2:2:2:1:3]           | passed | 0.00019 seconds |
-./spec/defra_ruby/validators_spec.rb[1:1:1]                                        | passed | 0.001 seconds   |

data/spec/support/vcr.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-# Stubbing HTTP requests
-require "webmock/rspec"
-# Auto generate fake responses for web-requests
-require "vcr"
-
-VCR.configure do |c|
-  c.cassette_library_dir = "spec/cassettes"
-  c.hook_into :webmock
-
-  c.ignore_hosts "127.0.0.1", "codeclimate.com"
-
-  SECONDS_IN_DAY = 24 * 60 * 60
-
-  c.default_cassette_options = { re_record_interval: (14 * SECONDS_IN_DAY) }
-
-  # Strip out authorization info
-  c.filter_sensitive_data("Basic <API_KEY>") do |interaction|
-    auth = interaction.request.headers["Authorization"]
-    auth.first if auth.nil? || auth.empty?
-  end
-end