defra_ruby_mocks 5.4.0 → 5.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e24d648c7432078c7cc69a30923d8200fa3583702c60f573b28a02aeb46e3a73
-  data.tar.gz: 4748ab1db603a4a773ca7bd397895050606175b10c5f04ddf6f6b8aea4390cc4
+  metadata.gz: 18bac40cf18bbb2391ffc978e078f7f16be7ae7c870e2e327fc66ad65883c3ac
+  data.tar.gz: f67d7402285f994f1bae0f40dd403e8637e3ba6d53f9f2e4ec4e61521184d3e9
 SHA512:
-  metadata.gz: 5d5e22baf1ebcb28785f32a5578511ec0b5b7fd8888d7ec54a95970d7fef440f691f5ce2699b5590b601ea21b7f66d5c04556703ef5774c56f6ae96916ef637a
-  data.tar.gz: 9a4c263655f8903e6e452e1eeb996ae27c754d06dc852ae409b1cc962e3e88d25d41445f17dbe74c8200749cd1db2363c81c9fb66a2a3a29cf231d52b709e77a
+  metadata.gz: 20079bce0c8a0718e308469b2c2f1ce8b577cc66e045e56bbd63c9acd8f67cbc6909a1e950d832f16381cf1f7847fbab44a5e6b30cd21e0ffd5adc16998bb45b
+  data.tar.gz: 3747fbddf8b2ec2ecc41e25ea694551e7cb683f848bd38e2d54f33e429a7774ae21d6c2209fc6595044ce911389fc2fc54b8abb08eabb7897dcf7dd6e52ba622

data/README.md

@@ -127,6 +127,12 @@ Additionally, an `"active"` LLP company can be retrieved by using the following
 - `XX999999`
 - `YY999999`
 
+#### Registered Societies
+
+Registered Societies do not have a `company_status` field.
+
+Any company number with the prefix `IP` or `SP` will be treated as a Registered Society and not return a company_status.
+
 The list of possible statuses was taken from
 
 - [Companies House API](https://developer.companieshouse.gov.uk/api/docs/company/company_number/companyProfile-resource.html)

data/Rakefile

@@ -16,8 +16,6 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include("lib/**/*.rb")
 end
 
-load "rails/tasks/statistics.rake"
-
 Dir[File.join(File.dirname(__FILE__), "lib/tasks/**/*.rake")].each { |f| load f }
 
 Bundler::GemHelper.install_tasks

data/app/services/defra_ruby_mocks/aws_bucket_service.rb

@@ -21,7 +21,7 @@ module DefraRubyMocks
       new.remove(bucket_name, file_name)
     end
 
-    # rubocop:disable Naming/PredicateMethod
+    # rubocop:disable-next Naming/PredicateMethod
     def write(bucket_name, file_name, content)
       @bucket_name = bucket_name
       @file_name = file_name
@@ -33,7 +33,6 @@ module DefraRubyMocks
 
       true
     end
-    # rubocop:enable Naming/PredicateMethod
 
     def read(bucket_name, file_name)
       @bucket_name = bucket_name

data/app/services/defra_ruby_mocks/companies_house_service.rb

@@ -9,12 +9,16 @@ module DefraRubyMocks
     # Examples we need to validate are
     # 10997904, 09764739
     # SC534714, CE000958
-    # IP00141R, IP27702R, SP02252R
+    # IP00141R, IP27702R, SP02252R (Registered Societies)
     # https://assets.publishing.service.gov.uk/government/uploads/system/uploads/attachment_data/file/426891/uniformResourceIdentifiersCustomerGuide.pdf
     VALID_COMPANIES_HOUSE_REGISTRATION_NUMBER_REGEX = /\A(\d{8,8}$)|([a-zA-Z]{2}\d{6}$)|([a-zA-Z]{2}\d{5}[a-zA-Z]{1}$)\z/i
 
     NOT_FOUND = "99999999"
 
+    # Registered Societies do not have a company_status field.
+    # IP = England/Wales, SP = Scotland
+    REGISTERED_SOCIETY_PREFIXES = %w[IP SP].freeze
+
     def self.special_company_numbers
       {
         "05868270" => "dissolved",
@@ -37,8 +41,9 @@ module DefraRubyMocks
       raise NotFoundError unless valid_company_number?(company_number)
       raise NotFoundError if company_number == NOT_FOUND
 
-      @company_status = specials[company_number] || "active"
-      @company_type = llps.include?(company_number) ? "llp" : "ltd"
+      @company_number = company_number
+      @company_status = registered_society? ? nil : (specials[company_number] || "active")
+      @company_type = determine_type
 
       self
     end
@@ -51,6 +56,17 @@ module DefraRubyMocks
       company_number.match?(VALID_COMPANIES_HOUSE_REGISTRATION_NUMBER_REGEX)
     end
 
+    def registered_society?
+      REGISTERED_SOCIETY_PREFIXES.any? { |prefix| @company_number.upcase.start_with?(prefix) }
+    end
+
+    def determine_type
+      return "registered-society-non-jurisdictional" if registered_society?
+      return "llp" if llps.include?(@company_number)
+
+      "ltd"
+    end
+
     def specials
       self.class.special_company_numbers
     end

data/app/services/defra_ruby_mocks/govpay_create_payment_service.rb

@@ -41,7 +41,7 @@ module DefraRubyMocks
       url_root
     end
 
-    # rubocop:disable Metrics/MethodLength
+    # rubocop:disable-next Metrics/MethodLength
     def success_response(amount, description)
       {
         created_date: "2020-03-03T16:17:19.554Z",
@@ -68,7 +68,6 @@ module DefraRubyMocks
         provider_id: "10987654321"
       }
     end
-    # rubocop:enable Metrics/MethodLength
 
   end
 end

data/app/services/defra_ruby_mocks/govpay_get_payment_service.rb

@@ -25,7 +25,7 @@ module DefraRubyMocks
       response_status(response_status_filename: "test_payment_response_status", default_status: "success")
     end
 
-    # rubocop:disable Metrics/MethodLength
+    # rubocop:disable-next Metrics/MethodLength
     def response_success
       {
         amount: 10_501,
@@ -90,7 +90,6 @@ module DefraRubyMocks
         }
       }
     end
-    # rubocop:enable Metrics/MethodLength
 
   end
 end

data/app/views/defra_ruby_mocks/company/officers.json.erb

@@ -1,4 +1,4 @@
-// https://developer-specs.company-information.service.gov.uk/companies-house-public-data-api/resources/officerlist
+<%# https://developer-specs.company-information.service.gov.uk/companies-house-public-data-api/resources/officerlist %>
 {
   "items": [
     {

data/app/views/defra_ruby_mocks/company/show.json.erb

@@ -1,7 +1,9 @@
-// https://developer-specs.company-information.service.gov.uk/companies-house-public-data-api/resources/companyprofile
+<%# https://developer-specs.company-information.service.gov.uk/companies-house-public-data-api/resources/companyprofile %>
 {
     "company_name": "Acme Industries",
+<% if @company_status %>
     "company_status": "<%= @company_status %>",
+<% end %>
     "type": "<%= @company_type %>",
     "registered_office_address": {
         "address_line_1": "10 Downing St",

data/lib/defra_ruby_mocks/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DefraRubyMocks
-  VERSION = "5.4.0"
+  VERSION = "5.4.2"
 end

metadata

@@ -1,27 +1,26 @@
 --- !ruby/object:Gem::Specification
 name: defra_ruby_mocks
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.2
 platform: ruby
 authors:
 - Defra
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-03-02 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
 - !ruby/object:Gem::Dependency
@@ -128,7 +127,6 @@ licenses:
 - The Open Government Licence (OGL) Version 3
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -143,8 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Defra Ruby on Rails external API mocking engine
 test_files: []