defra_ruby_mocks 2.3.3 → 2.4.1

data/spec/examples.txt

@@ -1,130 +1,68 @@
-example_id                                                          | status | run_time        |
-------------------------------------------------------------------- | ------ | --------------- |
-./spec/defra_ruby_mocks_spec.rb[1:1:1]                              | passed | 0.0021 seconds  |
-./spec/defra_ruby_mocks_spec.rb[1:2:1:1]                            | passed | 0.00011 seconds |
-./spec/defra_ruby_mocks_spec.rb[1:2:2:1]                            | passed | 0.00012 seconds |
-./spec/lib/configuration_spec.rb[1:1:1:1]                           | passed | 0.00007 seconds |
-./spec/lib/configuration_spec.rb[1:1:2:1]                           | passed | 0.00008 seconds |
-./spec/lib/configuration_spec.rb[1:1:3:1]                           | passed | 0.00008 seconds |
-./spec/lib/configuration_spec.rb[1:1:4:1]                           | passed | 0.00091 seconds |
-./spec/lib/configuration_spec.rb[1:2:1:1]                           | passed | 0.00007 seconds |
-./spec/lib/configuration_spec.rb[1:2:2:1]                           | passed | 0.00008 seconds |
-./spec/lib/configuration_spec.rb[1:2:3:1]                           | passed | 0.00008 seconds |
-./spec/lib/configuration_spec.rb[1:2:4:1]                           | passed | 0.00007 seconds |
-./spec/requests/company_spec.rb[1:1:1:1]                            | passed | 0.00172 seconds |
-./spec/requests/company_spec.rb[1:1:2:1]                            | passed | 0.1464 seconds  |
-./spec/requests/company_spec.rb[1:1:3:1:1]                          | passed | 0.00602 seconds |
-./spec/requests/company_spec.rb[1:1:3:2:1]                          | passed | 0.00515 seconds |
-./spec/requests/company_spec.rb[1:2:1]                              | passed | 0.00241 seconds |
-./spec/requests/govpay_spec.rb[1:1:1:1:1]                           | passed | 0.00286 seconds |
-./spec/requests/govpay_spec.rb[1:1:1:1:2]                           | passed | 0.01265 seconds |
-./spec/requests/govpay_spec.rb[1:1:1:2:1]                           | passed | 0.00163 seconds |
-./spec/requests/govpay_spec.rb[1:1:2:1:1]                           | passed | 0.0029 seconds  |
-./spec/requests/govpay_spec.rb[1:1:2:2:1]                           | passed | 0.0027 seconds  |
-./spec/requests/govpay_spec.rb[1:2:1:1]                             | passed | 0.0009 seconds  |
-./spec/requests/govpay_spec.rb[1:2:2:1]                             | passed | 0.00364 seconds |
-./spec/requests/govpay_spec.rb[1:2:3:1]                             | passed | 0.00382 seconds |
-./spec/requests/officers_spec.rb[1:1:1]                             | passed | 0.00327 seconds |
-./spec/requests/officers_spec.rb[1:2:1]                             | passed | 0.00161 seconds |
-./spec/requests/worldpay_spec.rb[1:1:1:1:1:1]                       | passed | 0.00288 seconds |
-./spec/requests/worldpay_spec.rb[1:1:1:1:2:1]                       | passed | 0.00211 seconds |
-./spec/requests/worldpay_spec.rb[1:1:1:2:1:1]                       | passed | 0.00581 seconds |
-./spec/requests/worldpay_spec.rb[1:1:2:1:1:1]                       | passed | 0.00368 seconds |
-./spec/requests/worldpay_spec.rb[1:1:2:1:2:1]                       | passed | 0.0039 seconds  |
-./spec/requests/worldpay_spec.rb[1:1:2:2:1:1]                       | passed | 0.00236 seconds |
-./spec/requests/worldpay_spec.rb[1:2:1:1]                           | passed | 0.00822 seconds |
-./spec/requests/worldpay_spec.rb[1:2:2:1]                           | passed | 0.00117 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:1:1]            | passed | 0.00008 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:1:1]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:1:2]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:2:1]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:2:2]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:3:1]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:3:2]          | passed | 0.00008 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:4:1]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:4:2]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:5:1]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:5:2]          | passed | 0.00008 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:6:1]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:6:2]          | passed | 0.00008 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:7:1]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:7:2]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:8:1]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:8:2]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:9:1]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:2:9:2]          | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:3:1]            | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:3:2]            | passed | 0.00009 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:3:3]            | passed | 0.00006 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:3:4]            | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:4:1:1]          | passed | 0.00007 seconds |
-./spec/services/companies_house_service_spec.rb[1:1:4:2:1]          | passed | 0.00008 seconds |
-./spec/services/govpay_create_payment_service_spec.rb[1:1:1:1]      | passed | 0.00279 seconds |
-./spec/services/govpay_create_payment_service_spec.rb[1:1:1:2]      | passed | 0.00266 seconds |
-./spec/services/govpay_create_payment_service_spec.rb[1:1:1:3]      | passed | 1.5 seconds     |
-./spec/services/govpay_create_payment_service_spec.rb[1:1:1:4]      | passed | 0.00286 seconds |
-./spec/services/govpay_get_payment_service_spec.rb[1:1:1:1]         | passed | 0.00076 seconds |
-./spec/services/govpay_get_payment_service_spec.rb[1:1:1:2]         | passed | 0.00081 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:1:1]           | passed | 0.00012 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:1]         | passed | 0.00034 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:2]         | passed | 0.00032 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:3]         | passed | 0.00034 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:4]         | passed | 0.00045 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:5:1]       | passed | 0.0003 seconds  |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:5:2]       | passed | 0.00031 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:5:3]       | passed | 0.0004 seconds  |
-./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:6:1]       | passed | 0.00034 seconds |
-./spec/services/worldpay_payment_service_spec.rb[1:1:3:1]           | passed | 0.00027 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:1]          | passed | 0.00122 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:2]          | passed | 0.00069 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:3]          | passed | 0.00029 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:4]          | passed | 0.00032 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:5]          | passed | 0.00038 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:6]          | passed | 0.00028 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:7]          | passed | 0.00028 seconds |
-./spec/services/worldpay_refund_service_spec.rb[1:1:2:1]            | passed | 0.00304 seconds |
-./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:1:1] | passed | 0.0006 seconds  |
-./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:1:2] | passed | 0.00094 seconds |
-./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:2:1] | passed | 0.00047 seconds |
-./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:2:2] | passed | 0.00057 seconds |
-./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:3:1] | passed | 0.00052 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:1:1]          | passed | 0.00056 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:1:2]          | passed | 0.00049 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:1:3]          | passed | 0.00047 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:1:4]          | passed | 0.00047 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:1:5:1]        | passed | 0.00052 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:2:1]          | passed | 0.00061 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:2:2]          | passed | 0.00058 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:2:3]          | passed | 0.00059 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:2:4]          | passed | 0.00056 seconds |
-./spec/services/worldpay_resource_service_spec.rb[1:1:3:1]          | passed | 0.002 seconds   |
-./spec/services/worldpay_resource_service_spec.rb[1:1:4:1]          | passed | 0.00051 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:1]        | passed | 0.00048 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:2]        | passed | 0.0005 seconds  |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:3:1]      | passed | 0.00045 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:3:2]      | passed | 0.00051 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:3:3:1]    | passed | 0.00045 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:4:1]      | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:4:2]      | passed | 0.00048 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:5:1]      | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:5:2]      | passed | 0.00045 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:6:1]      | passed | 0.00048 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:6:2]      | passed | 0.0005 seconds  |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:7:1]      | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:7:2]      | passed | 0.00052 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:8:1]      | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:1:1:8:2]      | passed | 0.00051 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:1]        | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:2]        | passed | 0.01025 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:3:1]      | passed | 0.0005 seconds  |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:3:2]      | passed | 0.00049 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:4:1]      | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:4:2]      | passed | 0.00048 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:5:1]      | passed | 0.00046 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:5:2]      | passed | 0.0006 seconds  |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:6:1]      | passed | 0.0005 seconds  |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:6:2]      | passed | 0.00047 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:7:1]      | passed | 0.00051 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:7:2]      | passed | 0.00053 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:8:1]      | passed | 0.00049 seconds |
-./spec/services/worldpay_response_service_spec.rb[1:1:2:1:8:2]      | passed | 0.00051 seconds |
+example_id                                                       | status | run_time        |
+---------------------------------------------------------------- | ------ | --------------- |
+./spec/defra_ruby_mocks_spec.rb[1:1:1]                           | passed | 0.00264 seconds |
+./spec/defra_ruby_mocks_spec.rb[1:2:1:1]                         | passed | 0.00153 seconds |
+./spec/defra_ruby_mocks_spec.rb[1:2:2:1]                         | passed | 0.00021 seconds |
+./spec/lib/configuration_spec.rb[1:1:1:1]                        | passed | 0.00016 seconds |
+./spec/lib/configuration_spec.rb[1:1:2:1]                        | passed | 0.00014 seconds |
+./spec/lib/configuration_spec.rb[1:1:3:1]                        | passed | 0.00011 seconds |
+./spec/lib/configuration_spec.rb[1:1:4:1]                        | passed | 0.00132 seconds |
+./spec/lib/configuration_spec.rb[1:2:1:1]                        | passed | 0.00015 seconds |
+./spec/lib/configuration_spec.rb[1:2:2:1]                        | passed | 0.00011 seconds |
+./spec/lib/configuration_spec.rb[1:2:3:1]                        | passed | 0.00012 seconds |
+./spec/lib/configuration_spec.rb[1:2:4:1]                        | passed | 0.00011 seconds |
+./spec/requests/company_spec.rb[1:1:1:1]                         | passed | 0.0037 seconds  |
+./spec/requests/company_spec.rb[1:1:2:1]                         | passed | 0.00379 seconds |
+./spec/requests/company_spec.rb[1:1:3:1:1]                       | passed | 0.00573 seconds |
+./spec/requests/company_spec.rb[1:1:3:2:1]                       | passed | 0.02066 seconds |
+./spec/requests/company_spec.rb[1:2:1]                           | passed | 0.0021 seconds  |
+./spec/requests/govpay_spec.rb[1:1:1:1:1]                        | passed | 0.00464 seconds |
+./spec/requests/govpay_spec.rb[1:1:1:1:2]                        | passed | 0.01777 seconds |
+./spec/requests/govpay_spec.rb[1:1:1:2:1]                        | passed | 0.00307 seconds |
+./spec/requests/govpay_spec.rb[1:1:2:1:1]                        | passed | 0.0447 seconds  |
+./spec/requests/govpay_spec.rb[1:1:2:2:1]                        | passed | 0.00415 seconds |
+./spec/requests/govpay_spec.rb[1:1:3:1:1]                        | passed | 0.00269 seconds |
+./spec/requests/govpay_spec.rb[1:1:3:2:1]                        | passed | 0.0036 seconds  |
+./spec/requests/govpay_spec.rb[1:1:4:1:1]                        | passed | 0.00626 seconds |
+./spec/requests/govpay_spec.rb[1:2:1:1]                          | passed | 0.00168 seconds |
+./spec/requests/govpay_spec.rb[1:2:2:1]                          | passed | 0.00723 seconds |
+./spec/requests/govpay_spec.rb[1:2:3:1]                          | passed | 0.00976 seconds |
+./spec/requests/officers_spec.rb[1:1:1]                          | passed | 0.00514 seconds |
+./spec/requests/officers_spec.rb[1:2:1]                          | passed | 0.0021 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:1:1]         | passed | 0.00016 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:1:1]       | passed | 0.00011 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:1:2]       | passed | 0.00015 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:2:1]       | passed | 0.00014 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:2:2]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:3:1]       | passed | 0.00017 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:3:2]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:4:1]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:4:2]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:5:1]       | passed | 0.00013 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:5:2]       | passed | 0.00014 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:6:1]       | passed | 0.00013 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:6:2]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:7:1]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:7:2]       | passed | 0.00017 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:8:1]       | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:8:2]       | passed | 0.00015 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:9:1]       | passed | 0.00016 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:9:2]       | passed | 0.00017 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:1]         | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:2]         | passed | 0.00011 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:3]         | passed | 0.00013 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:4]         | passed | 0.00011 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:4:1:1]       | passed | 0.00013 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:4:2:1]       | passed | 0.00016 seconds |
+./spec/services/govpay_create_payment_service_spec.rb[1:1:1:1]   | passed | 2.29 seconds    |
+./spec/services/govpay_create_payment_service_spec.rb[1:1:1:2]   | passed | 0.00453 seconds |
+./spec/services/govpay_create_payment_service_spec.rb[1:1:1:3]   | passed | 0.00433 seconds |
+./spec/services/govpay_create_payment_service_spec.rb[1:1:1:4]   | passed | 0.00429 seconds |
+./spec/services/govpay_get_payment_service_spec.rb[1:1:1:1]      | passed | 0.00109 seconds |
+./spec/services/govpay_get_payment_service_spec.rb[1:1:1:2]      | passed | 0.00128 seconds |
+./spec/services/govpay_refund_details_service_spec.rb[1:1:1:1]   | passed | 0.0016 seconds  |
+./spec/services/govpay_refund_details_service_spec.rb[1:1:2:1:1] | passed | 0.00264 seconds |
+./spec/services/govpay_refund_details_service_spec.rb[1:1:2:2:1] | passed | 0.00247 seconds |
+./spec/services/govpay_refund_details_service_spec.rb[1:1:2:3:1] | passed | 0.003 seconds   |
+./spec/services/govpay_request_refund_service_spec.rb[1:1:1:1]   | passed | 0.00116 seconds |
+./spec/services/govpay_request_refund_service_spec.rb[1:1:1:2]   | passed | 0.17665 seconds |

data/spec/requests/govpay_spec.rb

@@ -50,7 +50,7 @@ module DefraRubyMocks
         context "when the request is missing a mandatory parameter" do
           before { payment_request[:amount] = nil }
 
-          it "returns a HTTP 500 responseß" do
+          it "returns a HTTP 500 response" do
             post path, params: payment_request.as_json
 
             expect(response.code).to eq "500"
@@ -93,6 +93,49 @@ module DefraRubyMocks
           end
         end
       end
+
+      describe "#create_refund" do
+        let(:payment_id) { "12345678901234567890123456" }
+        let(:path) { "/defra_ruby_mocks/govpay/v1/payments/#{payment_id}/refunds" }
+        let(:refund_request) do
+          {
+            "amount": 2000,
+            "refund_amount_available": 5000
+          }
+        end
+
+        context "when the request is missing a mandatory parameter" do
+          before { refund_request[:refund_amount_available] = nil }
+
+          it "returns a HTTP 500 response" do
+            post path, params: refund_request.as_json
+
+            expect(response.code).to eq "500"
+          end
+        end
+
+        context "with a valid request" do
+          it "returns a valid success response" do
+            post path, params: refund_request.as_json
+
+            expect(response.code).to eq "200"
+          end
+        end
+      end
+
+      describe "#refund_details" do
+        let(:payment_id) { "12345678901234567890123456" }
+        let(:refund_id) { "j6se0f2o427g28g8yg3u3i" }
+        let(:path) { "/defra_ruby_mocks/govpay/v1/payments/#{payment_id}/refunds/#{refund_id}" }
+
+        context "with a valid request" do
+          it "returns a valid success response" do
+            get path
+
+            expect(response.code).to eq "200"
+          end
+        end
+      end
     end
 
     context "when mocks are disabled" do

data/spec/services/govpay_refund_details_service_spec.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module DefraRubyMocks
+
+  RSpec.describe GovpayRefundDetailsService do
+    let(:payment_id) { SecureRandom.hex(26) }
+    let(:refund_id) { SecureRandom.hex(22) }
+
+    before { Helpers::Configuration.prep_for_tests }
+
+    # Note that the service currently supports only success responses.
+    describe ".run" do
+      let(:create_request_time) { Time.zone.now }
+      let(:submitted_success_lag) { "10" }
+
+      subject { described_class.run(payment_id: payment_id, refund_id: refund_id).deep_symbolize_keys }
+
+      # the service shoud return "submitted" for up to GOVPAY_REFUND_SUBMITTED_SUCCESS_LAG seconds, "success" thereafter
+      before do
+        Timecop.freeze(create_request_time)
+        allow(ENV).to receive(:fetch).with("GOVPAY_REFUND_SUBMITTED_SUCCESS_LAG", any_args).and_return(submitted_success_lag)
+        FileUtils.rm_rf("#{Dir.tmpdir}/govpay_request_refund_service_last_run_time")
+      end
+
+      context "when no refund timestamp file exists" do
+        it { expect(subject[:status]).to eq "success" }
+      end
+
+      context "when a refund has been requested" do
+        before do
+          GovpayRequestRefundService.run(payment_id: payment_id, amount: 100, refund_amount_available: 100).deep_symbolize_keys
+        end
+
+        context "when less than 10 seconds has elapsed since the last create request" do
+          before { Timecop.freeze(create_request_time + (submitted_success_lag.to_i - 8).seconds) }
+
+          it { expect(subject[:status]).to eq "submitted" }
+        end
+
+        context "when 10 seconds has elapsed since the last create request" do
+          before { Timecop.freeze(create_request_time + (submitted_success_lag.to_i + 8).seconds) }
+
+          it { expect(subject[:status]).to eq "success" }
+        end
+
+        context "when GOVPAY_REFUND_SUBMITTED_SUCCESS_LAG is not set" do
+          let(:submitted_success_lag) { nil }
+
+          before { Timecop.freeze(create_request_time + 1.hour) }
+
+          it { expect(subject[:status]).to eq "success" }
+        end
+      end
+    end
+  end
+end

data/spec/services/govpay_request_refund_service_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module DefraRubyMocks
+
+  RSpec.describe GovpayRequestRefundService do
+    let(:payment_id) { SecureRandom.hex(26) }
+    let(:amount) { 2000 }
+    let(:refund_amount_available) { amount }
+
+    before { Helpers::Configuration.prep_for_tests }
+
+    # Note that the service currently supports only "submitted" responses.
+    describe ".run" do
+
+      subject { described_class.run(payment_id: payment_id, amount: amount, refund_amount_available: refund_amount_available).deep_symbolize_keys }
+
+      context "when the refund has been successfully submitted" do
+
+        it "returns a response with the expected status" do
+          expect(subject[:status]).to eq("submitted")
+        end
+
+        it "returns a response with the expected amount" do
+          expect(subject[:amount]).to eq(amount)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: defra_ruby_mocks
 version: !ruby/object:Gem::Version
-  version: 2.3.3
+  version: 2.4.1
 platform: ruby
 authors:
 - Defra
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-30 00:00:00.000000000 Z
+date: 2023-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,20 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.7.2
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: github_changelog_generator
   requirement: !ruby/object:Gem::Requirement
@@ -150,31 +136,23 @@ files:
 - app/controllers/defra_ruby_mocks/application_controller.rb
 - app/controllers/defra_ruby_mocks/company_controller.rb
 - app/controllers/defra_ruby_mocks/govpay_controller.rb
-- app/controllers/defra_ruby_mocks/worldpay_controller.rb
 - app/jobs/defra_ruby_mocks/application_job.rb
 - app/jobs/defra_ruby_mocks/govpay_payment_callback_job.rb
 - app/services/defra_ruby_mocks/base_service.rb
 - app/services/defra_ruby_mocks/companies_house_service.rb
 - app/services/defra_ruby_mocks/govpay_create_payment_service.rb
 - app/services/defra_ruby_mocks/govpay_get_payment_service.rb
-- app/services/defra_ruby_mocks/worldpay_payment_service.rb
-- app/services/defra_ruby_mocks/worldpay_refund_service.rb
-- app/services/defra_ruby_mocks/worldpay_request_handler_service.rb
-- app/services/defra_ruby_mocks/worldpay_resource_service.rb
-- app/services/defra_ruby_mocks/worldpay_response_service.rb
+- app/services/defra_ruby_mocks/govpay_refund_details_service.rb
+- app/services/defra_ruby_mocks/govpay_request_refund_service.rb
 - app/views/defra_ruby_mocks/company/not_found.json.erb
 - app/views/defra_ruby_mocks/company/officers.json.erb
 - app/views/defra_ruby_mocks/company/show.json.erb
-- app/views/defra_ruby_mocks/worldpay/payment_request.xml.erb
-- app/views/defra_ruby_mocks/worldpay/refund_request.xml.erb
-- app/views/defra_ruby_mocks/worldpay/stuck.html.erb
 - config/routes.rb
 - lib/defra_ruby_mocks.rb
 - lib/defra_ruby_mocks/configuration.rb
 - lib/defra_ruby_mocks/engine.rb
 - lib/defra_ruby_mocks/invalid_config_error.rb
 - lib/defra_ruby_mocks/missing_resource_error.rb
-- lib/defra_ruby_mocks/unrecognised_worldpay_request_error.rb
 - lib/defra_ruby_mocks/version.rb
 - lib/tasks/changelog.rake
 - lib/tasks/defra_ruby_mocks_tasks.rake
@@ -224,25 +202,16 @@ files:
 - spec/fixtures/files/govpay/get_payment_response_not_found.json
 - spec/fixtures/files/govpay/get_payment_response_submitted.json
 - spec/fixtures/files/govpay/get_payment_response_success.json
-- spec/fixtures/files/worldpay/payment_request_invalid.xml
-- spec/fixtures/files/worldpay/payment_request_valid.xml
-- spec/fixtures/files/worldpay/refund_request_invalid.xml
-- spec/fixtures/files/worldpay/refund_request_valid.xml
-- spec/fixtures/files/worldpay/unrecognised_request.xml
 - spec/lib/configuration_spec.rb
 - spec/rails_helper.rb
 - spec/requests/company_spec.rb
 - spec/requests/govpay_spec.rb
 - spec/requests/officers_spec.rb
-- spec/requests/worldpay_spec.rb
 - spec/services/companies_house_service_spec.rb
 - spec/services/govpay_create_payment_service_spec.rb
 - spec/services/govpay_get_payment_service_spec.rb
-- spec/services/worldpay_payment_service_spec.rb
-- spec/services/worldpay_refund_service_spec.rb
-- spec/services/worldpay_request_handler_service_spec.rb
-- spec/services/worldpay_resource_service_spec.rb
-- spec/services/worldpay_response_service_spec.rb
+- spec/services/govpay_refund_details_service_spec.rb
+- spec/services/govpay_request_refund_service_spec.rb
 - spec/spec_helper.rb
 - spec/support/helpers/configuration.rb
 - spec/support/helpers/helpers.rb
@@ -314,7 +283,6 @@ test_files:
 - spec/defra_ruby_mocks_spec.rb
 - spec/requests/govpay_spec.rb
 - spec/requests/company_spec.rb
-- spec/requests/worldpay_spec.rb
 - spec/requests/officers_spec.rb
 - spec/support/simplecov.rb
 - spec/support/pry.rb
@@ -323,11 +291,6 @@ test_files:
 - spec/support/helpers/configuration.rb
 - spec/support/helpers/waste_carriers_engine.rb
 - spec/lib/configuration_spec.rb
-- spec/fixtures/files/worldpay/unrecognised_request.xml
-- spec/fixtures/files/worldpay/payment_request_invalid.xml
-- spec/fixtures/files/worldpay/refund_request_valid.xml
-- spec/fixtures/files/worldpay/payment_request_valid.xml
-- spec/fixtures/files/worldpay/refund_request_invalid.xml
 - spec/fixtures/files/govpay/get_payment_response_submitted.json
 - spec/fixtures/files/govpay/get_payment_response_not_found.json
 - spec/fixtures/files/govpay/create_payment_created_response.json
@@ -339,10 +302,7 @@ test_files:
 - spec/fixtures/files/govpay/get_payment_response_error.json
 - spec/rails_helper.rb
 - spec/services/govpay_get_payment_service_spec.rb
-- spec/services/worldpay_response_service_spec.rb
-- spec/services/worldpay_resource_service_spec.rb
+- spec/services/govpay_request_refund_service_spec.rb
 - spec/services/companies_house_service_spec.rb
-- spec/services/worldpay_payment_service_spec.rb
-- spec/services/worldpay_refund_service_spec.rb
-- spec/services/worldpay_request_handler_service_spec.rb
+- spec/services/govpay_refund_details_service_spec.rb
 - spec/services/govpay_create_payment_service_spec.rb

data/app/controllers/defra_ruby_mocks/worldpay_controller.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-module DefraRubyMocks
-  class WorldpayController < ::DefraRubyMocks::ApplicationController
-    protect_from_forgery with: :exception, except: [:payments_service]
-
-    before_action :set_default_response_format
-
-    def payments_service
-      @values = WorldpayRequestHandlerService.run(convert_request_body_to_xml)
-
-      render_payment_response if @values[:request_type] == :payment
-      render_refund_response if @values[:request_type] == :refund
-    rescue StandardError => e
-      Rails.logger.error("MOCKS: Worldpay payments service error: #{e.message}")
-      head 500
-    end
-
-    def dispatcher
-      @response = WorldpayResponseService.run(
-        success_url: params[:successURL],
-        failure_url: params[:failureURL],
-        pending_url: params[:pendingURL],
-        cancel_url: params[:cancelURL],
-        error_url: params[:errorURL]
-      )
-
-      if @response.status == :STUCK
-        render formats: :html, action: "stuck", layout: false
-      else
-        redirect_to @response.url
-      end
-    rescue StandardError => e
-      Rails.logger.error("MOCKS: Worldpay dispatcher error: #{e.message}")
-      head 500
-    end
-
-    private
-
-    def set_default_response_format
-      request.format = :xml
-    end
-
-    def convert_request_body_to_xml
-      Nokogiri::XML(request.body.read)
-    end
-
-    def render_payment_response
-      render "defra_ruby_mocks/worldpay/payment_request"
-    end
-
-    def render_refund_response
-      render "defra_ruby_mocks/worldpay/refund_request"
-    end
-
-  end
-end

data/app/services/defra_ruby_mocks/worldpay_payment_service.rb

@@ -1,47 +0,0 @@
-# frozen_string_literal: true
-
-module DefraRubyMocks
-  class WorldpayPaymentService < BaseService
-    def run(merchant_code:, xml:)
-      check_config
-
-      @merchant_code = merchant_code
-      @order_code = extract_order_code(xml)
-
-      {
-        merchant_code: @merchant_code,
-        order_code: @order_code,
-        id: generate_id,
-        url: generate_url
-      }
-    end
-
-    private
-
-    def check_config
-      domain = DefraRubyMocks.configuration.worldpay_domain
-
-      raise InvalidConfigError, :worldpay_domain if domain.blank?
-    end
-
-    def extract_order_code(xml)
-      order = xml.at_xpath("//order")
-      order.attribute("orderCode").text
-    end
-
-    def generate_id
-      # Worldpay seems to generate 10 digit numbers for all its ID's. So we
-      # replicate that here with this.
-      # https://stackoverflow.com/a/31043825
-      rand(1e9...1e10).to_i.to_s
-    end
-
-    def generate_url
-      "#{base_url}?OrderKey=#{@merchant_code}%5E#{@order_code}"
-    end
-
-    def base_url
-      File.join(DefraRubyMocks.configuration.worldpay_domain, "/worldpay/dispatcher")
-    end
-  end
-end

data/app/services/defra_ruby_mocks/worldpay_refund_service.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module DefraRubyMocks
-  class WorldpayRefundService < BaseService
-    def run(merchant_code:, xml:)
-      {
-        merchant_code: merchant_code,
-        order_code: extract_order_code(xml),
-        refund_value: extract_refund_value(xml),
-        currency_code: extract_currency_code(xml),
-        exponent: extract_exponent(xml)
-      }
-    end
-
-    private
-
-    def extract_order_code(xml)
-      order_modification = xml.at_xpath("//orderModification")
-      order_modification.attribute("orderCode").text
-    end
-
-    def extract_refund_value(xml)
-      amount = xml.at_xpath("//amount")
-      amount.attribute("value").text
-    end
-
-    def extract_currency_code(xml)
-      amount = xml.at_xpath("//amount")
-      amount.attribute("currencyCode").text
-    end
-
-    def extract_exponent(xml)
-      amount = xml.at_xpath("//amount")
-      amount.attribute("exponent").text
-    end
-  end
-end