defra_ruby_mocks 2.0.0 → 2.3.0

data/spec/examples.txt

@@ -0,0 +1,114 @@
+example_id                                                          | status | run_time        |
+------------------------------------------------------------------- | ------ | --------------- |
+./spec/defra_ruby_mocks_spec.rb[1:1:1]                              | passed | 0.00215 seconds |
+./spec/defra_ruby_mocks_spec.rb[1:2:1:1]                            | passed | 0.00018 seconds |
+./spec/defra_ruby_mocks_spec.rb[1:2:2:1]                            | passed | 0.00014 seconds |
+./spec/lib/configuration_spec.rb[1:1:1:1]                           | passed | 0.00011 seconds |
+./spec/lib/configuration_spec.rb[1:1:2:1]                           | passed | 0.00019 seconds |
+./spec/lib/configuration_spec.rb[1:1:3:1]                           | passed | 0.00017 seconds |
+./spec/lib/configuration_spec.rb[1:1:4:1]                           | passed | 0.00012 seconds |
+./spec/lib/configuration_spec.rb[1:2:1:1]                           | passed | 0.00018 seconds |
+./spec/lib/configuration_spec.rb[1:2:2:1]                           | passed | 0.00011 seconds |
+./spec/lib/configuration_spec.rb[1:2:3:1]                           | passed | 0.00016 seconds |
+./spec/lib/configuration_spec.rb[1:2:4:1]                           | passed | 0.00095 seconds |
+./spec/requests/company_spec.rb[1:1:1:1]                            | passed | 0.0082 seconds  |
+./spec/requests/company_spec.rb[1:1:2:1]                            | passed | 0.00528 seconds |
+./spec/requests/company_spec.rb[1:1:3:1:1]                          | passed | 0.0048 seconds  |
+./spec/requests/company_spec.rb[1:1:3:2:1]                          | passed | 0.00472 seconds |
+./spec/requests/company_spec.rb[1:2:1]                              | passed | 0.00226 seconds |
+./spec/requests/officers_spec.rb[1:1:1]                             | passed | 0.00903 seconds |
+./spec/requests/officers_spec.rb[1:2:1]                             | passed | 0.00429 seconds |
+./spec/requests/worldpay_spec.rb[1:1:1:1:1:1]                       | passed | 0.00703 seconds |
+./spec/requests/worldpay_spec.rb[1:1:1:1:2:1]                       | passed | 0.00379 seconds |
+./spec/requests/worldpay_spec.rb[1:1:1:2:1:1]                       | passed | 0.03276 seconds |
+./spec/requests/worldpay_spec.rb[1:1:2:1:1:1]                       | passed | 0.00538 seconds |
+./spec/requests/worldpay_spec.rb[1:1:2:1:2:1]                       | passed | 0.0063 seconds  |
+./spec/requests/worldpay_spec.rb[1:1:2:2:1:1]                       | passed | 0.00462 seconds |
+./spec/requests/worldpay_spec.rb[1:2:1:1]                           | passed | 0.01268 seconds |
+./spec/requests/worldpay_spec.rb[1:2:2:1]                           | passed | 0.0063 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:1:1]            | passed | 0.00181 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:1:1]          | passed | 0.0002 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:2:1:2]          | passed | 0.0001 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:2:2:1]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:2:2]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:3:1]          | passed | 0.0001 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:2:3:2]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:4:1]          | passed | 0.00014 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:4:2]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:5:1]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:5:2]          | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:6:1]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:6:2]          | passed | 0.00014 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:7:1]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:7:2]          | passed | 0.0001 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:2:8:1]          | passed | 0.0001 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:2:8:2]          | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:9:1]          | passed | 0.00012 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:2:9:2]          | passed | 0.00017 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:1]            | passed | 0.1475 seconds  |
+./spec/services/companies_house_service_spec.rb[1:1:3:2]            | passed | 0.00015 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:3]            | passed | 0.00014 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:3:4]            | passed | 0.00009 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:4:1:1]          | passed | 0.00017 seconds |
+./spec/services/companies_house_service_spec.rb[1:1:4:2:1]          | passed | 0.00015 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:1:1]           | passed | 0.00017 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:1]         | passed | 0.00108 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:2]         | passed | 0.00032 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:3]         | passed | 0.00032 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:4]         | passed | 0.00038 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:5:1]       | passed | 0.00038 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:5:2]       | passed | 0.00035 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:5:3]       | passed | 0.00044 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:2:1:6:1]       | passed | 0.00031 seconds |
+./spec/services/worldpay_payment_service_spec.rb[1:1:3:1]           | passed | 0.00042 seconds |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:1]          | passed | 0.00033 seconds |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:2]          | passed | 0.00042 seconds |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:3]          | passed | 0.00041 seconds |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:4]          | passed | 0.0006 seconds  |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:5]          | passed | 0.00052 seconds |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:6]          | passed | 0.00038 seconds |
+./spec/services/worldpay_refund_service_spec.rb[1:1:1:1:7]          | passed | 0.0004 seconds  |
+./spec/services/worldpay_refund_service_spec.rb[1:1:2:1]            | passed | 0.00045 seconds |
+./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:1:1] | passed | 0.00111 seconds |
+./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:1:2] | passed | 0.00087 seconds |
+./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:2:1] | passed | 0.00057 seconds |
+./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:2:2] | passed | 0.00058 seconds |
+./spec/services/worldpay_request_handler_service_spec.rb[1:1:1:3:1] | passed | 0.00036 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:1:1]          | passed | 0.00218 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:1:2]          | passed | 0.00074 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:1:3]          | passed | 0.00864 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:1:4]          | passed | 0.00076 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:2:1]          | passed | 0.00095 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:2:2]          | passed | 0.0008 seconds  |
+./spec/services/worldpay_resource_service_spec.rb[1:1:2:3]          | passed | 0.001 seconds   |
+./spec/services/worldpay_resource_service_spec.rb[1:1:2:4]          | passed | 0.0007 seconds  |
+./spec/services/worldpay_resource_service_spec.rb[1:1:3:1]          | passed | 0.00136 seconds |
+./spec/services/worldpay_resource_service_spec.rb[1:1:4:1]          | passed | 0.00066 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:1]        | passed | 0.00063 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:2]        | passed | 0.00064 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:3:1]      | passed | 0.00072 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:3:2]      | passed | 0.00069 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:4:1]      | passed | 0.0006 seconds  |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:4:2]      | passed | 0.00066 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:5:1]      | passed | 0.00074 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:5:2]      | passed | 0.0006 seconds  |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:6:1]      | passed | 0.00136 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:6:2]      | passed | 0.00105 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:7:1]      | passed | 0.00063 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:7:2]      | passed | 0.00067 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:8:1]      | passed | 0.00066 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:1:1:8:2]      | passed | 0.00069 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:1]        | passed | 0.0007 seconds  |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:2]        | passed | 0.00087 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:3:1]      | passed | 0.00795 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:3:2]      | passed | 0.00075 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:4:1]      | passed | 0.00078 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:4:2]      | passed | 0.00076 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:5:1]      | passed | 0.00093 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:5:2]      | passed | 0.00095 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:6:1]      | passed | 0.00073 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:6:2]      | passed | 0.00084 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:7:1]      | passed | 0.00063 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:7:2]      | passed | 0.0007 seconds  |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:8:1]      | passed | 0.00104 seconds |
+./spec/services/worldpay_response_service_spec.rb[1:1:2:1:8:2]      | passed | 0.00113 seconds |

data/spec/requests/company_spec.rb

@@ -29,11 +29,20 @@ module DefraRubyMocks
 
         it "returns a JSON response with a 200 code and a status that isn't 'active'" do
           get "#{path}/#{company_number}"
-          company_status = JSON.parse(response.body)["company_status"]
 
           expect(response.media_type).to eq("application/json")
           expect(response.code).to eq("200")
-          expect(company_status).not_to eq("active")
+          expect(JSON.parse(response.body).deep_symbolize_keys).to eq(
+            company_name: "Acme Industries",
+            company_status: "dissolved",
+            type: "ltd",
+            registered_office_address: {
+              address_line_1: "10 Downing St",
+              address_line_2: "Horizon House",
+              locality: "Bristol",
+              postal_code: "BS1 5AH"
+            }
+          )
         end
       end
 
@@ -44,10 +53,12 @@ module DefraRubyMocks
           it "returns a JSON response with a 200 code and a status of 'active'" do
             get "#{path}/#{company_number}"
             company_status = JSON.parse(response.body)["company_status"]
+            company_type = JSON.parse(response.body)["type"]
 
             expect(response.media_type).to eq("application/json")
             expect(response.code).to eq("200")
             expect(company_status).to eq("active")
+            expect(company_type).to eq("ltd")
           end
         end
 

data/spec/requests/officers_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module DefraRubyMocks
+  RSpec.describe "Officers", type: :request do
+    after(:all) { Helpers::Configuration.reset_for_tests }
+
+    let(:path) {  "/defra_ruby_mocks/company/company-no/officers" }
+
+    context "when mocks are enabled" do
+      before(:each) { Helpers::Configuration.prep_for_tests }
+
+      it "returns a JSON response" do
+        get path
+
+        expect(response.media_type).to eq("application/json")
+        expect(response.code).to eq("200")
+
+        expect(JSON.parse(response.body).deep_symbolize_keys[:items][0]).to eq(
+          {
+            name: "APPLE, Alice",
+            officer_role: "director"
+          }
+        )
+      end
+    end
+
+    context "when mocks are disabled" do
+      before(:all) { DefraRubyMocks.configuration.enable = false }
+
+      it "cannot load the page" do
+        expect { get path }.to raise_error(ActionController::RoutingError)
+      end
+    end
+  end
+end

data/spec/requests/worldpay_spec.rb

@@ -24,7 +24,7 @@ module DefraRubyMocks
             let(:data) { File.read("spec/fixtures/payment_request_valid.xml") }
 
             it "returns an XML response with a 200 code" do
-              get path, headers: { "RAW_POST_DATA" => data }
+              post path, headers: { "RAW_POST_DATA" => data }
 
               expect(response.media_type).to eq("application/xml")
               expect(response.code).to eq("200")
@@ -36,7 +36,7 @@ module DefraRubyMocks
             let(:data) { File.read("spec/fixtures/payment_request_invalid.xml") }
 
             it "returns a response with a 500 code" do
-              get path, headers: { "RAW_POST_DATA" => data }
+              post path, headers: { "RAW_POST_DATA" => data }
 
               expect(response.code).to eq("500")
             end
@@ -48,7 +48,7 @@ module DefraRubyMocks
             let(:data) { File.read("spec/fixtures/refund_request_valid.xml") }
 
             it "returns an XML response with a 200 code" do
-              get path, headers: { "RAW_POST_DATA" => data }
+              post path, headers: { "RAW_POST_DATA" => data }
 
               expect(response.media_type).to eq("application/xml")
               expect(response.code).to eq("200")

data/spec/services/companies_house_service_spec.rb

@@ -5,11 +5,13 @@ require "rails_helper"
 module DefraRubyMocks
   RSpec.describe CompaniesHouseService do
     describe ".run" do
+      subject { described_class.run(company_number) }
+
       context "when the company number is 99999999 for not found" do
         let(:company_number) { "99999999" }
 
         it "raises a NotFoundError" do
-          expect { described_class.run(company_number) }.to raise_error(NotFoundError)
+          expect { subject }.to raise_error(NotFoundError)
         end
       end
 
@@ -18,19 +20,39 @@ module DefraRubyMocks
 
         specials.each do |company_number, status|
           context "and the number is #{company_number}" do
-            it "returns a status of '#{status}'" do
-              expect(described_class.run(company_number)).to eq(status)
+            let(:company_number) { company_number }
+
+            it "returns a company_status of '#{status}'" do
+              expect(subject.company_status).to eq(status)
+            end
+
+            it "returns a company_type of 'ltd'" do
+              expect(subject.company_type).to eq("ltd")
             end
           end
         end
       end
 
+      context "when the company is an LLP" do
+        CompaniesHouseService.llp_company_numbers.each do |company_number|
+          let(:company_number) { company_number }
+
+          it "returns a company_status of 'active'" do
+            expect(subject.company_status).to eq("active")
+          end
+
+          it "returns a company_type of 'llp'" do
+            expect(subject.company_type).to eq("llp")
+          end
+        end
+      end
+
       context "when the company number is not from the 'specials' list" do
         context "and it is valid" do
           let(:company_number) { "SC247974" }
 
-          it "returns a status of 'active'" do
-            expect(described_class.run(company_number)).to eq("active")
+          it "returns a company_status of 'active'" do
+            expect(subject.company_status).to eq("active")
           end
         end
 
@@ -38,7 +60,7 @@ module DefraRubyMocks
           let(:company_number) { "foo" }
 
           it "raises a NotFoundError" do
-            expect { described_class.run(company_number) }.to raise_error(NotFoundError)
+            expect { subject }.to raise_error(NotFoundError)
           end
         end
       end

data/spec/services/worldpay_response_service_spec.rb

@@ -75,7 +75,6 @@ module DefraRubyMocks
 
           context "and is for a successful payment" do
             it "can generate a valid mac" do
-              puts "Test data #{mac_data.join}"
               expect(described_class.run(args).mac).to eq(mac)
             end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: defra_ruby_mocks
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Defra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-26 00:00:00.000000000 Z
+date: 2022-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.3.1
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.3.1
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: sprockets
   requirement: !ruby/object:Gem::Requirement
@@ -158,6 +158,7 @@ files:
 - app/services/defra_ruby_mocks/worldpay_resource_service.rb
 - app/services/defra_ruby_mocks/worldpay_response_service.rb
 - app/views/defra_ruby_mocks/company/not_found.json.erb
+- app/views/defra_ruby_mocks/company/officers.json.erb
 - app/views/defra_ruby_mocks/company/show.json.erb
 - app/views/defra_ruby_mocks/worldpay/payment_request.xml.erb
 - app/views/defra_ruby_mocks/worldpay/refund_request.xml.erb
@@ -203,10 +204,12 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
+- spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
+- spec/examples.txt
 - spec/fixtures/payment_request_invalid.xml
 - spec/fixtures/payment_request_valid.xml
 - spec/fixtures/refund_request_invalid.xml
@@ -215,6 +218,7 @@ files:
 - spec/lib/configuration_spec.rb
 - spec/rails_helper.rb
 - spec/requests/company_spec.rb
+- spec/requests/officers_spec.rb
 - spec/requests/worldpay_spec.rb
 - spec/services/companies_house_service_spec.rb
 - spec/services/worldpay_payment_service_spec.rb
@@ -241,7 +245,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -287,10 +291,13 @@ test_files:
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/404.html
+- spec/dummy/log/test.log
 - spec/dummy/README.rdoc
+- spec/examples.txt
 - spec/defra_ruby_mocks_spec.rb
 - spec/requests/company_spec.rb
 - spec/requests/worldpay_spec.rb
+- spec/requests/officers_spec.rb
 - spec/support/simplecov.rb
 - spec/support/pry.rb
 - spec/support/helpers/helpers.rb