defra_ruby_companies_house 1.0.2 → 1.0.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 68e70d72463c9a6e8501b921f1b868f1e373d8f5d93e902f65a26b2af44c4b3a
4
- data.tar.gz: 943f467cda91c512687f304a2fb9549a26dab9c61330da8ef9daa83fe4919eb9
3
+ metadata.gz: c462e928c4fa4a0df4dac9e4fd54781bbc05d33d38e38d8f1a03ffbda47c14f0
4
+ data.tar.gz: 8950a569c65b93e5590bd9d9e84d9272277e8f7d9c8f1626fd53b4a6de5f91d6
5
5
  SHA512:
6
- metadata.gz: 35bd325462130cbeb09c5447066645540a78d1700b213867156a23e4e4180c191b82701ea62d15a7f9df4adfb81ced7c39832f907bd2b9d500aa95fe01fa767d
7
- data.tar.gz: e8bf0259383dd718b436146681133fbbb422ed7a3fa3bcec2210f2257dfe8685bdfdd847fb9d1ccba563c478e610d789f6a4c6916cfd1d0a90e64233c0b14a1e
6
+ metadata.gz: f8fc6f0ac1bbf9f7dec364a94e5bbc92532e4c34132cdc6c17fb3d49bf791e45186e581ee9583a042dbe784b363e27740672d383722a64e01e1b9cd235e19526
7
+ data.tar.gz: f860fe73771563901fafe0928410684c33ea9bc8e71fa384f1381cf390c8effa343df4e0fc871dcd57964ca8c882f5437631e4fa5b9f5f682a9fdcab5ea3b953
@@ -75,8 +75,8 @@ module DefraRuby
75
75
  def companies_house_details
76
76
  @companies_house_details ||= {
77
77
  company_name: companies_house_api_response[:company_name],
78
- company_type: companies_house_api_response[:type].to_sym,
79
- company_status: companies_house_api_response[:company_status].to_sym,
78
+ company_type: companies_house_api_response[:type]&.to_sym,
79
+ company_status: companies_house_api_response[:company_status]&.to_sym,
80
80
  registered_office_address: registered_office_address_lines
81
81
  }
82
82
  end
@@ -100,7 +100,7 @@ module DefraRuby
100
100
  DefraRuby::CompaniesHouse.configuration.companies_house_api_key
101
101
  end
102
102
 
103
- # rubocop:disable Naming/VariableNumber
103
+ # rubocop:disable-next Naming/VariableNumber
104
104
  def registered_office_address_lines
105
105
  address = companies_house_api_response[:registered_office_address]
106
106
 
@@ -111,7 +111,6 @@ module DefraRuby
111
111
  address&.dig(:postal_code)
112
112
  ].compact
113
113
  end
114
- # rubocop:enable Naming/VariableNumber
115
114
 
116
115
  def validate_company_number
117
116
  return if company_number.match?(VALID_COMPANY_NUMBER_REGEX) && !company_number.match(/^0+$/)
@@ -127,7 +126,7 @@ module DefraRuby
127
126
  end
128
127
 
129
128
  def log_error(error)
130
- logged_error = "Error getting details for company \"#{company_number}\": #{error}"
129
+ logged_error = "Error (#{error.class}) getting details for company \"#{company_number}\": #{error}"
131
130
  DefraRuby::CompaniesHouse.logger.error logged_error
132
131
  Airbrake.notify(logged_error) if defined?(Airbrake)
133
132
  end
@@ -2,6 +2,6 @@
2
2
 
3
3
  module DefraRuby
4
4
  module CompaniesHouse
5
- VERSION = "1.0.2"
5
+ VERSION = "1.0.4"
6
6
  end
7
7
  end
metadata CHANGED
@@ -1,14 +1,13 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: defra_ruby_companies_house
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.2
4
+ version: 1.0.4
5
5
  platform: ruby
6
6
  authors:
7
7
  - Defra
8
- autorequire:
9
8
  bindir: bin
10
9
  cert_chain: []
11
- date: 2024-12-23 00:00:00.000000000 Z
10
+ date: 1980-01-02 00:00:00.000000000 Z
12
11
  dependencies:
13
12
  - !ruby/object:Gem::Dependency
14
13
  name: i18n
@@ -61,7 +60,6 @@ licenses:
61
60
  metadata:
62
61
  allowed_push_host: https://rubygems.org
63
62
  rubygems_mfa_required: 'true'
64
- post_install_message:
65
63
  rdoc_options: []
66
64
  require_paths:
67
65
  - lib
@@ -69,15 +67,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
69
67
  requirements:
70
68
  - - ">="
71
69
  - !ruby/object:Gem::Version
72
- version: '3.1'
70
+ version: '3.2'
73
71
  required_rubygems_version: !ruby/object:Gem::Requirement
74
72
  requirements:
75
73
  - - ">="
76
74
  - !ruby/object:Gem::Version
77
75
  version: '0'
78
76
  requirements: []
79
- rubygems_version: 3.3.7
80
- signing_key:
77
+ rubygems_version: 3.6.9
81
78
  specification_version: 4
82
79
  summary: Defra ruby on rails helper for Companies House API
83
80
  test_files: []