defra_ruby_area 1.0.0 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0c70a4243bf5fb3a988ebf2dee7ff7757758f605
-  data.tar.gz: 6730c29aedc4227152101469d4325c36024f9522
+SHA256:
+  metadata.gz: ae979716dbfa3c43991e2f21d67190c7bda4cfaef0dc5ae87dc2ac1beb746bae
+  data.tar.gz: df9ac3a40869869bd2bc32e2d9d713095cc529f84ff01aa1f7b31b18289d0108
 SHA512:
-  metadata.gz: 85798b2577feb39b9853390f0bf243f271c4d7657a45769d88a1a35fea8cd38202b2b7a2a2464ee66ddda00207edf659d21c0b3a9adfed6e56fbc0fe430873b4
-  data.tar.gz: bd9622f05d43ae590337b841d9e99b4e7e82ab327014ef2b6642fa87746daa085dbeb6b4640f82aac6f89d8c9245c15413a770c5a868a2d84c89e06f703ad9c3
+  metadata.gz: 89d81a16ac76041d7c92675b305da316863fe9bce4d592991198bd332cd27ee4f9912845e96c027687e4dc9467b06153cde550283fa3caa57e566a2a202bda48
+  data.tar.gz: 810ead2522a2fc25bd55b94917517cd597852405040dbe29ec2cb91883ef5e39affcffcee99b989daae27e7dd191358b2e85cfd0450a54526a169163f5dcc4a0

data/README.md

@@ -1,13 +1,13 @@
 # Defra Ruby Area
 
-[![Build Status](https://travis-ci.com/DEFRA/defra-ruby-area.svg?branch=master)](https://travis-ci.com/DEFRA/defra-ruby-area)
-[![Maintainability](https://api.codeclimate.com/v1/badges/7aeffed0588d86a5e553/maintainability)](https://codeclimate.com/github/DEFRA/defra-ruby-area/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/7aeffed0588d86a5e553/test_coverage)](https://codeclimate.com/github/DEFRA/defra-ruby-area/test_coverage)
-[![security](https://hakiri.io/github/DEFRA/defra-ruby-area/master.svg)](https://hakiri.io/github/DEFRA/defra-ruby-area/master)
+![Build Status](https://github.com/DEFRA/defra-ruby-area/workflows/CI/badge.svg?branch=main)
+[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=DEFRA_defra-ruby-area&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=DEFRA_defra-ruby-area)
+[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=DEFRA_defra-ruby-area&metric=coverage)](https://sonarcloud.io/dashboard?id=DEFRA_defra-ruby-area)
+[![security](https://hakiri.io/github/DEFRA/defra-ruby-area/main.svg)](https://hakiri.io/github/DEFRA/defra-ruby-area/main)
 [![Gem Version](https://badge.fury.io/rb/defra_ruby_area.svg)](https://badge.fury.io/rb/defra_ruby_area)
 [![Licence](https://img.shields.io/badge/Licence-OGLv3-blue.svg)](http://www.nationalarchives.gov.uk/doc/open-government-licence/version/3)
 
-This ruby gem provides a means of looking up an Environment Agency Administrative boundary from a GIS Web Feature Service (WFS). Provided with a valid [easting and northing](https://en.wikipedia.org/wiki/Easting_and_northing) it will query the WFS and return the long name for the area if a match is found.
+This ruby gem provides a means of looking up Environment Agency Administrative boundary areas from a GIS Web Feature Service (WFS). Provided with a valid [easting and northing](https://en.wikipedia.org/wiki/Easting_and_northing) it will query the WFS and return various properties for each matching area found.
 
 ## Installation
 
@@ -33,20 +33,20 @@ Each WFS is called through a service that responds with a `DefraRuby::Area::Resp
 
 ```ruby
 response.successful?
-response.area
+response.areas
 response.error
 ```
 
-If the call is successful (the query did not error and a match was found) then
+If the call is successful then
 
 - `successful?()` will be `true`
-- `area` will contain an instance of `DefraRuby::Area::Area`. It contains the code, short name and long name of the matching administrative boundary
+- `areas` will contain an array of `DefraRuby::Area::Area`. Each contains the area ID, area name, code, short name and long name of the matching administrative boundary
 - `error` will be `nil`
 
 If the call is unsuccessful (the query errored or no match was found) then
 
 - `successful?()` will be `false`
-- `area` will be `nil`
+- `areas` will be `[]` (an empty array)
 - `error` will contain the error
 
 If it's a runtime error, or an error when calling the WFS `error` will contain whatever error was raised.
@@ -62,7 +62,7 @@ easting = 408_602.61
 northing = 257_535.31
 response = DefraRuby::Area::PublicFaceAreaService.run(easting, northing)
 
-puts response.area.long_name if response.successful? # West Midlands
+puts response.areas.first.long_name if response.successful? # West Midlands
 ```
 
 ### Water Management Areas
@@ -74,9 +74,18 @@ easting = 408_602.61
 northing = 257_535.31
 response = DefraRuby::Area::WaterManagementAreaService.run(easting, northing)
 
-puts response.area.long_name if response.successful? # Staffordshire Warwickshire and West Midlands
+puts response.areas.first.long_name if response.successful? # Staffordshire Warwickshire and West Midlands
 ```
 
+### Multiple results
+
+In most cases we expect `response.areas` to contain a single result. It is possible though for a given easting and northing to return multiple administrative boundary areas. Where we see this is when a coordinate is on the boundary of 2 areas. This is why **defra-ruby-area** is setup to return multiple results.
+
+Examples:
+
+- **Public face areas** easting = `398056.684` and northing = `414748` (*Yorkshire* and *Greater Manchester Merseyside and Cheshire*)
+- **Water management areas** easting = `456330` and northing = `267000` (*Lincolnshire and Northamptonshire* and *Staffordshire Warwickshire and West Midlands*)
+
 ## Web Feature Services
 
 A [Web Feature Service (WFS)](https://en.m.wikipedia.org/wiki/Web_Feature_Service) is simply a web service that implements the Open Geospatial Consortium Web Feature Service (WFS) Interface Standard.

data/Rakefile

@@ -11,7 +11,6 @@ Bundler::GemHelper.install_tasks
 # This is wrapped to prevent an error when rake is called in environments where
 # rspec may not be available, e.g. production. As such we don't need to handle
 # the error.
-# rubocop:disable Lint/HandleExceptions
 begin
   require "rspec/core/rake_task"
 
@@ -26,8 +25,9 @@ begin
   require "github_changelog_generator/task"
 
   GitHubChangelogGenerator::RakeTask.new :changelog do |config|
+    config.user = "defra"
+    config.project = "defra-ruby-area"
   end
 rescue LoadError
   # no changelog available
 end
-# rubocop:enable Lint/HandleExceptions

data/bin/console

@@ -1,14 +1,10 @@
 #!/usr/bin/env ruby
 
 require "bundler/setup"
-require "defra/ruby/area"
+require "defra_ruby/area"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start(__FILE__)
+require "pry"
+Pry.start

data/lib/defra_ruby/area/area.rb

@@ -1,18 +1,31 @@
 # frozen_string_literal: true
 
+require "nokogiri"
+
 module DefraRuby
   module Area
     class Area
-      attr_reader :code, :long_name, :short_name
+      attr_reader :area_id, :area_name, :code, :long_name, :short_name
+
+      def initialize(wfs_xml_element)
+        @xml = wfs_xml_element
+
+        validate_xml
+        parse_xml
+      end
+
+      private
 
-      def initialize(code, long_name, short_name)
-        @code = code
-        @long_name = long_name
-        @short_name = short_name
+      def validate_xml
+        raise(ArgumentError, "wfs_xml_element is invalid") unless @xml.is_a?(Nokogiri::XML::Element)
       end
 
-      def matched?
-        "#{@code}#{@long_name}#{@short_name}" != ""
+      def parse_xml
+        @area_id = @xml.xpath("ms:area_id").text.to_i
+        @area_name = @xml.xpath("ms:area_name").text
+        @code = @xml.xpath("ms:code").text
+        @long_name = @xml.xpath("ms:long_name").text
+        @short_name = @xml.xpath("ms:short_name").text
       end
 
     end

data/lib/defra_ruby/area/response.rb

@@ -3,12 +3,11 @@
 module DefraRuby
   module Area
     class Response
-      attr_reader :error
-      attr_reader :area
+      attr_reader :error, :areas
 
       def initialize(response_exe)
         @success = true
-        @area = nil
+        @areas = []
         @error = nil
 
         capture_response(response_exe)
@@ -23,7 +22,7 @@ module DefraRuby
       attr_reader :success
 
       def capture_response(response_exe)
-        @area = response_exe.call[:area]
+        @areas = response_exe.call[:areas]
       rescue StandardError => e
         @error = e
         @success = false

data/lib/defra_ruby/area/services/base_area_service.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require "nokogiri"
 require "rest-client"
 
 module DefraRuby
@@ -31,29 +30,25 @@ module DefraRuby
             url: url,
             timeout: DefraRuby::Area.configuration.timeout
           )
-          area = parse_xml(response)
-          raise NoMatchError unless area.matched?
+          areas = extract_areas(Nokogiri::XML(response))
 
-          { area: area }
+          raise NoMatchError unless areas.any?
+
+          { areas: areas }
         end
       end
 
-      def url
-        "#{domain}/spatialdata/#{dataset}/wfs?#{url_params}"
-      end
+      def extract_areas(xml_response)
+        areas = []
+        xml_response.xpath("//wfs:FeatureCollection/gml:featureMember").each do |parent|
+          areas << Area.new(parent.first_element_child)
+        end
 
-      def parse_xml(response)
-        xml = Nokogiri::XML(response)
-        Area.new(
-          xml.xpath(response_xml_path(:code)).text,
-          xml.xpath(response_xml_path(:long_name)).text,
-          xml.xpath(response_xml_path(:short_name)).text
-        )
+        areas
       end
 
-      # XML path to the value we wish to extract in the WFS query response.
-      def response_xml_path(property)
-        "//wfs:FeatureCollection/gml:featureMember/#{type_name}/ms:#{property}"
+      def url
+        "#{domain}/spatialdata/#{dataset}/wfs?#{url_params}"
       end
 
       # Domain where the WFS is hosted
@@ -130,10 +125,16 @@ module DefraRuby
       # https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?SERVICE=WFS&VERSION=1.0.0&REQUEST=DescribeFeatureType
       #
       # In our case the administrative boundary features contain a number of
-      # properties, but we are only interested in +code+, +long_name+ and
-      # +short_name+.
+      # properties, but we are only interested in
+      #
+      # - +area_id+
+      # - +area_name+
+      # - +code+
+      # - +long_name+
+      # - +short_name+
+      #
       def property_name
-        "code,long_name,short_name"
+        "area_id,area_name,code,long_name,short_name"
       end
 
       # SRS stands for Spatial Reference System. It can also be known as a

data/lib/defra_ruby/area/version.rb

@@ -2,6 +2,6 @@
 
 module DefraRuby
   module Area
-    VERSION = "1.0.0"
+    VERSION = "2.0.2"
   end
 end

data/spec/defra_ruby/area/area_spec.rb

@@ -1,29 +1,43 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require "nokogiri"
 
 module DefraRuby
   module Area
     RSpec.describe Area do
-      describe "#matched?" do
-        context "when no attributes are populated" do
-          let(:subject) { described_class.new(nil, nil, nil) }
+      let(:valid_xml) do
+        document = Nokogiri::XML(File.read("spec/fixtures/water_management_area_valid.xml"))
+        document.xpath("//wfs:FeatureCollection/gml:featureMember").first.first_element_child
+      end
+      let(:invalid_xml) { "foo" }
 
-          it "returns false" do
-            expect(subject.matched?).to eq(false)
+      describe "#initialize" do
+        context "when `wfs_xml_element` is missing" do
+          it "raises an ArgumentError" do
+            expect { described_class.new(nil) }.to raise_error(ArgumentError, "wfs_xml_element is invalid")
+          end
+        end
+
+        context "when `wfs_xml_element` is invalid" do
+          it "raises an error" do
+            expect { described_class.new(invalid_xml) }.to raise_error(ArgumentError, "wfs_xml_element is invalid")
           end
         end
-      end
 
-      describe "#matched?" do
-        context "when at least one attribute is populated" do
-          let(:subject) { described_class.new("foo", nil, nil) }
+        context "when `wfs_xml_element` is valid" do
+          it "populates all an Area's attributes" do
+            subject = described_class.new(valid_xml)
 
-          it "returns true" do
-            expect(subject.matched?).to eq(true)
+            expect(subject.area_id).to eq(29)
+            expect(subject.area_name).to eq("Central")
+            expect(subject.code).to eq("STWKWM")
+            expect(subject.short_name).to eq("Staffs Warks and West Mids")
+            expect(subject.long_name).to eq("Staffordshire Warwickshire and West Midlands")
           end
         end
       end
+
     end
   end
 end

data/spec/defra_ruby/area/response_spec.rb

@@ -6,7 +6,13 @@ module DefraRuby
   module Area
     RSpec.describe Response do
       subject(:response) { described_class.new(response_exe) }
-      let(:successful) { -> { { area: Area.new("GFY", "Planet Gallifrey", "Gallifrey") } } }
+
+      let(:valid_xml) do
+        document = Nokogiri::XML(File.read("spec/fixtures/water_management_area_valid.xml"))
+        document.xpath("//wfs:FeatureCollection/gml:featureMember").first.first_element_child
+      end
+
+      let(:successful) { -> { { areas: [Area.new(valid_xml)] } } }
       let(:errored) { -> { raise "Boom!" } }
 
       describe "#successful?" do
@@ -18,7 +24,7 @@ module DefraRuby
           end
         end
 
-        context "when the response don't throw an error" do
+        context "when the response doesn't throw an error" do
           let(:response_exe) { successful }
 
           it "returns true" do
@@ -32,7 +38,7 @@ module DefraRuby
           let(:response_exe) { errored }
 
           it "returns nothing" do
-            expect(response.area).to be_nil
+            expect(response.areas).to be_empty
           end
         end
 
@@ -40,8 +46,8 @@ module DefraRuby
           let(:response_exe) { successful }
 
           it "returns an area" do
-            expect(response.area).to be_instance_of(Area)
-            expect(response.area.short_name).to eq("Gallifrey")
+            expect(response.areas[0]).to be_instance_of(Area)
+            expect(response.areas[0].short_name).to eq("Staffs Warks and West Mids")
           end
         end
       end

data/spec/defra_ruby/area/services/public_face_area_service_spec.rb

@@ -1,15 +1,21 @@
 # frozen_string_literal: true
 
+require "webmock/rspec"
 require "spec_helper"
 
 module DefraRuby
   module Area
     RSpec.describe PublicFaceAreaService do
-      describe "#run" do
+      let(:host) { "https://environment.data.gov.uk" }
 
+      describe "#run" do
         context "when the coordinates are valid and in England" do
-          before(:each) { VCR.insert_cassette("public_face_area_valid") }
-          after(:each) { VCR.eject_cassette }
+          before do
+            stub_request(:any, /.*#{host}.*/).to_return(
+              status: 200,
+              body: File.read("./spec/fixtures/public_face_area_valid.xml")
+            )
+          end
 
           let(:easting) { 408_602.61 }
           let(:northing) { 257_535.31 }
@@ -18,15 +24,38 @@ module DefraRuby
             response = described_class.run(easting, northing)
             expect(response).to be_a(Response)
             expect(response.successful?).to eq(true)
-            expect(response.area.long_name).to eq("West Midlands")
+            expect(response.areas[0].long_name).to eq("West Midlands")
           end
 
         end
 
+        context "when the coordinates are valid, in England but match more than one area" do
+          before do
+            stub_request(:any, /.*#{host}.*/).to_return(
+              status: 200,
+              body: File.read("./spec/fixtures/public_face_area_valid_multiple.xml")
+            )
+          end
+
+          let(:easting) { 398_056.684 }
+          let(:northing) { 414_748 }
+
+          it "returns a successful response" do
+            response = described_class.run(easting, northing)
+            expect(response).to be_a(Response)
+            expect(response.successful?).to eq(true)
+            expect(response.areas[0].long_name).to eq("Yorkshire")
+          end
+        end
+
         context "when the coordinates are invalid" do
           context "because they are blank" do
-            before(:each) { VCR.insert_cassette("public_face_area_invalid_blank") }
-            after(:each) { VCR.eject_cassette }
+            before do
+              stub_request(:any, /.*#{host}.*/).to_return(
+                status: 200,
+                body: File.read("./spec/fixtures/public_face_area_invalid_blank.xml")
+              )
+            end
 
             let(:easting) { nil }
             let(:northing) { nil }
@@ -35,14 +64,18 @@ module DefraRuby
               response = described_class.run(easting, northing)
               expect(response).to be_a(Response)
               expect(response).to_not be_successful
-              expect(response.area).to be_nil
+              expect(response.areas).to be_empty
               expect(response.error).to_not be_nil
             end
           end
 
           context "because they are not in an area" do
-            before(:each) { VCR.insert_cassette("public_face_area_invalid_coords") }
-            after(:each) { VCR.eject_cassette }
+            before do
+              stub_request(:any, /.*#{host}.*/).to_return(
+                status: 200,
+                body: File.read("./spec/fixtures/public_face_area_invalid_coords.xml")
+              )
+            end
 
             let(:easting) { 301_233.0 }
             let(:northing) { 221_592.0 }
@@ -51,7 +84,7 @@ module DefraRuby
               response = described_class.run(easting, northing)
               expect(response).to be_a(Response)
               expect(response).to_not be_successful
-              expect(response.area).to be_nil
+              expect(response.areas).to be_empty
               expect(response.error).to_not be_nil
             end
           end

data/spec/defra_ruby/area/services/water_management_area_service_spec.rb

@@ -1,15 +1,21 @@
 # frozen_string_literal: true
 
+require "webmock/rspec"
 require "spec_helper"
 
 module DefraRuby
   module Area
     RSpec.describe WaterManagementAreaService do
-      describe "#run" do
+      let(:host) { "https://environment.data.gov.uk" }
 
+      describe "#run" do
         context "when the coordinates are valid and in England" do
-          before(:each) { VCR.insert_cassette("water_management_area_valid") }
-          after(:each) { VCR.eject_cassette }
+          before do
+            stub_request(:any, /.*#{host}.*/).to_return(
+              status: 200,
+              body: File.read("./spec/fixtures/water_management_area_valid.xml")
+            )
+          end
 
           let(:easting) { 408_602.61 }
           let(:northing) { 257_535.31 }
@@ -18,15 +24,38 @@ module DefraRuby
             response = described_class.run(easting, northing)
             expect(response).to be_a(Response)
             expect(response.successful?).to eq(true)
-            expect(response.area.long_name).to eq("Staffordshire Warwickshire and West Midlands")
+            expect(response.areas[0].long_name).to eq("Staffordshire Warwickshire and West Midlands")
           end
 
         end
 
+        context "when the coordinates are valid, in England but match more than one area" do
+          before do
+            stub_request(:any, /.*#{host}.*/).to_return(
+              status: 200,
+              body: File.read("./spec/fixtures/water_management_area_valid_multiple.xml")
+            )
+          end
+
+          let(:easting) { 456_330 }
+          let(:northing) { 267_000 }
+
+          it "returns a successful response" do
+            response = described_class.run(easting, northing)
+            expect(response).to be_a(Response)
+            expect(response.successful?).to eq(true)
+            expect(response.areas[0].long_name).to eq("Lincolnshire and Northamptonshire")
+          end
+        end
+
         context "when the coordinates are invalid" do
           context "because they are blank" do
-            before(:each) { VCR.insert_cassette("water_management_area_invalid_blank") }
-            after(:each) { VCR.eject_cassette }
+            before do
+              stub_request(:any, /.*#{host}.*/).to_return(
+                status: 200,
+                body: File.read("./spec/fixtures/water_management_area_invalid_blank.xml")
+              )
+            end
 
             let(:easting) { nil }
             let(:northing) { nil }
@@ -35,14 +64,18 @@ module DefraRuby
               response = described_class.run(easting, northing)
               expect(response).to be_a(Response)
               expect(response).to_not be_successful
-              expect(response.area).to be_nil
+              expect(response.areas).to be_empty
               expect(response.error).to_not be_nil
             end
           end
 
           context "because they are not in an area" do
-            before(:each) { VCR.insert_cassette("water_management_area_invalid_coords") }
-            after(:each) { VCR.eject_cassette }
+            before do
+              stub_request(:any, /.*#{host}.*/).to_return(
+                status: 200,
+                body: File.read("./spec/fixtures/water_management_area_invalid_coords.xml")
+              )
+            end
 
             let(:easting) { 301_233.0 }
             let(:northing) { 221_592.0 }
@@ -51,7 +84,7 @@ module DefraRuby
               response = described_class.run(easting, northing)
               expect(response).to be_a(Response)
               expect(response).to_not be_successful
-              expect(response.area).to be_nil
+              expect(response.areas).to be_empty
               expect(response.error).to_not be_nil
             end
           end

data/spec/fixtures/public_face_area_invalid_blank.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<ogc:ServiceExceptionReport xmlns:ogc="http://www.opengis.net/ogc" version="1.2.0">
+  <ogc:ServiceException><![CDATA[The geometry was not recognized.]]></ogc:ServiceException>
+  <ogc:ServiceException><![CDATA[Operator 'Intersects' can't parse geometry.]]></ogc:ServiceException>
+</ogc:ServiceExceptionReport>

data/spec/fixtures/public_face_area_invalid_coords.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
+<gml:boundedBy>
+  <gml:Box srsName="EPSG:27700">
+    <gml:coordinates>0,0,0,0</gml:coordinates>
+  </gml:Box>
+</gml:boundedBy>
+</wfs:FeatureCollection>

data/spec/fixtures/public_face_area_valid.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
+<gml:boundedBy>
+  <gml:Box srsName="EPSG:27700">
+    <gml:coordinates>0,0,0,0</gml:coordinates>
+  </gml:Box>
+</gml:boundedBy>
+  <gml:featureMember>
+    <ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas fid="Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas.23">
+      <ms:OBJECTID>23</ms:OBJECTID>
+      <ms:long_name>West Midlands</ms:long_name>
+      <ms:short_name>West Midlands</ms:short_name>
+      <ms:code>WMD</ms:code>
+      <ms:st_area_shape_>14543741870.84492</ms:st_area_shape_>
+      <ms:st_perimeter_shape_>1043376.795941756</ms:st_perimeter_shape_>
+    </ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas>
+  </gml:featureMember>
+</wfs:FeatureCollection>

data/spec/fixtures/public_face_area_valid_multiple.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
+<gml:boundedBy>
+  <gml:Box srsName="EPSG:27700">
+    <gml:coordinates>0,0,0,0</gml:coordinates>
+  </gml:Box>
+</gml:boundedBy>
+  <gml:featureMember>
+    <ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas fid="Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas.19">
+      <ms:OBJECTID>19</ms:OBJECTID>
+      <ms:long_name>Yorkshire</ms:long_name>
+      <ms:short_name>Yorkshire</ms:short_name>
+      <ms:code>YOR</ms:code>
+      <ms:st_area_shape_>14482874597.24499</ms:st_area_shape_>
+      <ms:st_perimeter_shape_>820401.3233851442</ms:st_perimeter_shape_>
+    </ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas>
+  </gml:featureMember>
+  <gml:featureMember>
+    <ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas fid="Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas.20">
+      <ms:OBJECTID>20</ms:OBJECTID>
+      <ms:long_name>Greater Manchester Merseyside and Cheshire</ms:long_name>
+      <ms:short_name>Gtr Mancs Mersey and Ches</ms:short_name>
+      <ms:code>GMC</ms:code>
+      <ms:st_area_shape_>4473822349.59001</ms:st_area_shape_>
+      <ms:st_perimeter_shape_>543689.9446941023</ms:st_perimeter_shape_>
+    </ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas>
+  </gml:featureMember>
+</wfs:FeatureCollection>

data/spec/fixtures/water_management_area_invalid_blank.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<ogc:ServiceExceptionReport xmlns:ogc="http://www.opengis.net/ogc" version="1.2.0">
+  <ogc:ServiceException><![CDATA[The geometry was not recognized.]]></ogc:ServiceException>
+  <ogc:ServiceException><![CDATA[Operator 'Intersects' can't parse geometry.]]></ogc:ServiceException>
+</ogc:ServiceExceptionReport>

data/spec/fixtures/water_management_area_invalid_coords.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
+<gml:boundedBy>
+  <gml:Box srsName="EPSG:27700">
+    <gml:coordinates>0,0,0,0</gml:coordinates>
+  </gml:Box>
+</gml:boundedBy>
+</wfs:FeatureCollection>

data/spec/fixtures/water_management_area_valid.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
+<gml:boundedBy>
+  <gml:Box srsName="EPSG:27700">
+    <gml:coordinates>0,0,0,0</gml:coordinates>
+  </gml:Box>
+</gml:boundedBy>
+  <gml:featureMember>
+    <ms:Administrative_Boundaries_Water_Management_Areas fid="Administrative_Boundaries_Water_Management_Areas.15">
+      <ms:OBJECTID>15</ms:OBJECTID>
+      <ms:long_name>Staffordshire Warwickshire and West Midlands</ms:long_name>
+      <ms:short_name>Staffs Warks and West Mids</ms:short_name>
+      <ms:code>STWKWM</ms:code>
+      <ms:area_id>29</ms:area_id>
+      <ms:area_name>Central</ms:area_name>
+      <ms:st_area_shape_>6460280400.1</ms:st_area_shape_>
+      <ms:st_perimeter_shape_>759189.708848595</ms:st_perimeter_shape_>
+    </ms:Administrative_Boundaries_Water_Management_Areas>
+  </gml:featureMember>
+</wfs:FeatureCollection>

data/spec/fixtures/water_management_area_valid_multiple.xml

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
+<gml:boundedBy>
+  <gml:Box srsName="EPSG:27700">
+    <gml:coordinates>0,0,0,0</gml:coordinates>
+  </gml:Box>
+</gml:boundedBy>
+  <gml:featureMember>
+    <ms:Administrative_Boundaries_Water_Management_Areas fid="Administrative_Boundaries_Water_Management_Areas.11">
+      <ms:OBJECTID>11</ms:OBJECTID>
+      <ms:long_name>Lincolnshire and Northamptonshire</ms:long_name>
+      <ms:short_name>Lincs and Northants</ms:short_name>
+      <ms:code>LCNNTH</ms:code>
+      <ms:area_id>3</ms:area_id>
+      <ms:area_name>Northern</ms:area_name>
+      <ms:st_area_shape_>9270202427.530003</ms:st_area_shape_>
+      <ms:st_perimeter_shape_>1148848.464792307</ms:st_perimeter_shape_>
+    </ms:Administrative_Boundaries_Water_Management_Areas>
+  </gml:featureMember>
+  <gml:featureMember>
+    <ms:Administrative_Boundaries_Water_Management_Areas fid="Administrative_Boundaries_Water_Management_Areas.15">
+      <ms:OBJECTID>15</ms:OBJECTID>
+      <ms:long_name>Staffordshire Warwickshire and West Midlands</ms:long_name>
+      <ms:short_name>Staffs Warks and West Mids</ms:short_name>
+      <ms:code>STWKWM</ms:code>
+      <ms:area_id>29</ms:area_id>
+      <ms:area_name>Central</ms:area_name>
+      <ms:st_area_shape_>6460280400.1</ms:st_area_shape_>
+      <ms:st_perimeter_shape_>759189.708848595</ms:st_perimeter_shape_>
+    </ms:Administrative_Boundaries_Water_Management_Areas>
+  </gml:featureMember>
+</wfs:FeatureCollection>

data/spec/support/shared_examples/handle_request_errors.rb

@@ -2,10 +2,6 @@
 
 RSpec.shared_examples "handle request errors" do
   context "when there is a problem with the Web Feature Service" do
-    before(:each) { VCR.turn_off! }
-    after(:each) { VCR.turn_on! }
-
-    let(:host) { "https://environment.data.gov.uk/" }
     let(:easting) { 408_602.61 }
     let(:northing) { 257_535.31 }
 
@@ -16,7 +12,7 @@ RSpec.shared_examples "handle request errors" do
         response = described_class.run(easting, northing)
         expect(response).to be_a(DefraRuby::Area::Response)
         expect(response).to_not be_successful
-        expect(response.area).to be_nil
+        expect(response.areas).to be_empty
         expect(response.error).to_not be_nil
       end
     end
@@ -28,7 +24,7 @@ RSpec.shared_examples "handle request errors" do
         response = described_class.run(easting, northing)
         expect(response).to be_a(DefraRuby::Area::Response)
         expect(response).to_not be_successful
-        expect(response.area).to be_nil
+        expect(response.areas).to be_empty
         expect(response.error).to_not be_nil
       end
     end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: defra_ruby_area
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.2
 platform: ruby
 authors:
 - Defra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-10 00:00:00.000000000 Z
+date: 2021-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.11.1
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: 1.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: 1.11.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.13.0
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
@@ -138,32 +144,18 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 0.17.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 0.17.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -201,26 +193,26 @@ files:
 - lib/defra_ruby/area/services/public_face_area_service.rb
 - lib/defra_ruby/area/services/water_management_area_service.rb
 - lib/defra_ruby/area/version.rb
-- spec/cassettes/public_face_area_invalid_blank.yml
-- spec/cassettes/public_face_area_invalid_coords.yml
-- spec/cassettes/public_face_area_valid.yml
-- spec/cassettes/water_management_area_invalid_blank.yml
-- spec/cassettes/water_management_area_invalid_coords.yml
-- spec/cassettes/water_management_area_valid.yml
 - spec/defra_ruby/area/area_spec.rb
 - spec/defra_ruby/area/configuration_spec.rb
 - spec/defra_ruby/area/response_spec.rb
 - spec/defra_ruby/area/services/public_face_area_service_spec.rb
 - spec/defra_ruby/area/services/water_management_area_service_spec.rb
 - spec/defra_ruby/area_spec.rb
-- spec/examples.txt
+- spec/fixtures/public_face_area_invalid_blank.xml
+- spec/fixtures/public_face_area_invalid_coords.xml
+- spec/fixtures/public_face_area_valid.xml
+- spec/fixtures/public_face_area_valid_multiple.xml
+- spec/fixtures/water_management_area_invalid_blank.xml
+- spec/fixtures/water_management_area_invalid_coords.xml
+- spec/fixtures/water_management_area_valid.xml
+- spec/fixtures/water_management_area_valid_multiple.xml
 - spec/spec_helper.rb
 - spec/support/defra_ruby_area.rb
 - spec/support/dotenv.rb
 - spec/support/pry.rb
 - spec/support/shared_examples/handle_request_errors.rb
 - spec/support/simplecov.rb
-- spec/support/vcr.rb
 homepage: https://github.com/DEFRA/defra-ruby-area
 licenses:
 - The Open Government Licence (OGL) Version 3
@@ -241,8 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Defra ruby on rails EA administrative area lookup
@@ -254,16 +245,16 @@ test_files:
 - spec/defra_ruby/area/services/water_management_area_service_spec.rb
 - spec/defra_ruby/area/services/public_face_area_service_spec.rb
 - spec/defra_ruby/area_spec.rb
-- spec/examples.txt
-- spec/cassettes/water_management_area_invalid_coords.yml
-- spec/cassettes/public_face_area_invalid_coords.yml
-- spec/cassettes/water_management_area_invalid_blank.yml
-- spec/cassettes/public_face_area_valid.yml
-- spec/cassettes/water_management_area_valid.yml
-- spec/cassettes/public_face_area_invalid_blank.yml
 - spec/support/defra_ruby_area.rb
 - spec/support/simplecov.rb
-- spec/support/vcr.rb
 - spec/support/pry.rb
 - spec/support/dotenv.rb
 - spec/support/shared_examples/handle_request_errors.rb
+- spec/fixtures/public_face_area_valid_multiple.xml
+- spec/fixtures/water_management_area_valid_multiple.xml
+- spec/fixtures/public_face_area_invalid_blank.xml
+- spec/fixtures/public_face_area_valid.xml
+- spec/fixtures/water_management_area_valid.xml
+- spec/fixtures/water_management_area_invalid_coords.xml
+- spec/fixtures/public_face_area_invalid_coords.xml
+- spec/fixtures/water_management_area_invalid_blank.xml

data/spec/cassettes/public_face_area_invalid_blank.yml

@@ -1,49 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?Filter=(%3CFilter%3E%3CIntersects%3E%3CPropertyName%3ESHAPE%3C/PropertyName%3E%3Cgml:Point%3E%3Cgml:coordinates%3E,%3C/gml:coordinates%3E%3C/gml:Point%3E%3C/Intersects%3E%3C/Filter%3E)&REQUEST=GetFeature&SERVICE=WFS&SRSName=EPSG:27700&VERSION=1.0.0&propertyName=code,long_name,short_name&typeName=ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin18.2.0 x86_64) ruby/2.4.2p198
-      Host:
-      - environment.data.gov.uk
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Fri, 09 Aug 2019 17:08:26 GMT
-      Content-Type:
-      - application/xml
-      Content-Length:
-      - '349'
-      Connection:
-      - keep-alive
-      Cache-Control:
-      - private
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-    body:
-      encoding: UTF-8
-      string: |
-        <?xml version="1.0" encoding="utf-8" ?>
-        <ogc:ServiceExceptionReport xmlns:ogc="http://www.opengis.net/ogc" version="1.2.0">
-          <ogc:ServiceException><![CDATA[The geometry was not recognized.]]></ogc:ServiceException>
-          <ogc:ServiceException><![CDATA[Operator 'Intersects' can't parse geometry.]]></ogc:ServiceException>
-        </ogc:ServiceExceptionReport>
-    http_version: 
-  recorded_at: Fri, 09 Aug 2019 17:08:26 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/public_face_area_invalid_coords.yml

@@ -1,52 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?Filter=(%3CFilter%3E%3CIntersects%3E%3CPropertyName%3ESHAPE%3C/PropertyName%3E%3Cgml:Point%3E%3Cgml:coordinates%3E301233.0,221592.0%3C/gml:coordinates%3E%3C/gml:Point%3E%3C/Intersects%3E%3C/Filter%3E)&REQUEST=GetFeature&SERVICE=WFS&SRSName=EPSG:27700&VERSION=1.0.0&propertyName=code,long_name,short_name&typeName=ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin18.2.0 x86_64) ruby/2.4.2p198
-      Host:
-      - environment.data.gov.uk
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Fri, 09 Aug 2019 17:08:26 GMT
-      Content-Type:
-      - application/xml
-      Content-Length:
-      - '1070'
-      Connection:
-      - keep-alive
-      Cache-Control:
-      - private
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-    body:
-      encoding: UTF-8
-      string: |-
-        <?xml version="1.0" encoding="utf-8" ?>
-        <wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
-        <gml:boundedBy>
-          <gml:Box srsName="EPSG:27700">
-            <gml:coordinates>0,0,0,0</gml:coordinates>
-          </gml:Box>
-        </gml:boundedBy>
-        </wfs:FeatureCollection>
-    http_version: 
-  recorded_at: Fri, 09 Aug 2019 17:08:26 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/public_face_area_valid.yml

@@ -1,62 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?Filter=(%3CFilter%3E%3CIntersects%3E%3CPropertyName%3ESHAPE%3C/PropertyName%3E%3Cgml:Point%3E%3Cgml:coordinates%3E408602.61,257535.31%3C/gml:coordinates%3E%3C/gml:Point%3E%3C/Intersects%3E%3C/Filter%3E)&REQUEST=GetFeature&SERVICE=WFS&SRSName=EPSG:27700&VERSION=1.0.0&propertyName=code,long_name,short_name&typeName=ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin18.2.0 x86_64) ruby/2.4.2p198
-      Host:
-      - environment.data.gov.uk
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Fri, 09 Aug 2019 17:08:33 GMT
-      Content-Type:
-      - application/xml
-      Content-Length:
-      - '1693'
-      Connection:
-      - keep-alive
-      Cache-Control:
-      - private
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-    body:
-      encoding: UTF-8
-      string: |-
-        <?xml version="1.0" encoding="utf-8" ?>
-        <wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-environment-agency-and-natural-england-public-face-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
-        <gml:boundedBy>
-          <gml:Box srsName="EPSG:27700">
-            <gml:coordinates>0,0,0,0</gml:coordinates>
-          </gml:Box>
-        </gml:boundedBy>
-          <gml:featureMember>
-            <ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas fid="Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas.23">
-              <ms:OBJECTID>23</ms:OBJECTID>
-              <ms:long_name>West Midlands</ms:long_name>
-              <ms:short_name>West Midlands</ms:short_name>
-              <ms:code>WMD</ms:code>
-              <ms:st_area_shape_>14543741870.84492</ms:st_area_shape_>
-              <ms:st_perimeter_shape_>1043376.795941756</ms:st_perimeter_shape_>
-            </ms:Administrative_Boundaries_Environment_Agency_and_Natural_England_Public_Face_Areas>
-          </gml:featureMember>
-        </wfs:FeatureCollection>
-    http_version: 
-  recorded_at: Fri, 09 Aug 2019 17:08:34 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/water_management_area_invalid_blank.yml

@@ -1,49 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?Filter=(%3CFilter%3E%3CIntersects%3E%3CPropertyName%3ESHAPE%3C/PropertyName%3E%3Cgml:Point%3E%3Cgml:coordinates%3E,%3C/gml:coordinates%3E%3C/gml:Point%3E%3C/Intersects%3E%3C/Filter%3E)&REQUEST=GetFeature&SERVICE=WFS&SRSName=EPSG:27700&VERSION=1.0.0&propertyName=code,long_name,short_name&typeName=ms:Administrative_Boundaries_Water_Management_Areas
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin18.2.0 x86_64) ruby/2.4.2p198
-      Host:
-      - environment.data.gov.uk
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Fri, 09 Aug 2019 17:08:21 GMT
-      Content-Type:
-      - application/xml
-      Content-Length:
-      - '349'
-      Connection:
-      - keep-alive
-      Cache-Control:
-      - private
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-    body:
-      encoding: UTF-8
-      string: |
-        <?xml version="1.0" encoding="utf-8" ?>
-        <ogc:ServiceExceptionReport xmlns:ogc="http://www.opengis.net/ogc" version="1.2.0">
-          <ogc:ServiceException><![CDATA[The geometry was not recognized.]]></ogc:ServiceException>
-          <ogc:ServiceException><![CDATA[Operator 'Intersects' can't parse geometry.]]></ogc:ServiceException>
-        </ogc:ServiceExceptionReport>
-    http_version: 
-  recorded_at: Fri, 09 Aug 2019 17:08:21 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/water_management_area_invalid_coords.yml

@@ -1,52 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?Filter=(%3CFilter%3E%3CIntersects%3E%3CPropertyName%3ESHAPE%3C/PropertyName%3E%3Cgml:Point%3E%3Cgml:coordinates%3E301233.0,221592.0%3C/gml:coordinates%3E%3C/gml:Point%3E%3C/Intersects%3E%3C/Filter%3E)&REQUEST=GetFeature&SERVICE=WFS&SRSName=EPSG:27700&VERSION=1.0.0&propertyName=code,long_name,short_name&typeName=ms:Administrative_Boundaries_Water_Management_Areas
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin18.2.0 x86_64) ruby/2.4.2p198
-      Host:
-      - environment.data.gov.uk
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Fri, 09 Aug 2019 17:08:14 GMT
-      Content-Type:
-      - application/xml
-      Content-Length:
-      - '968'
-      Connection:
-      - keep-alive
-      Cache-Control:
-      - private
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-    body:
-      encoding: UTF-8
-      string: |-
-        <?xml version="1.0" encoding="utf-8" ?>
-        <wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
-        <gml:boundedBy>
-          <gml:Box srsName="EPSG:27700">
-            <gml:coordinates>0,0,0,0</gml:coordinates>
-          </gml:Box>
-        </gml:boundedBy>
-        </wfs:FeatureCollection>
-    http_version: 
-  recorded_at: Fri, 09 Aug 2019 17:08:14 GMT
-recorded_with: VCR 4.0.0

data/spec/cassettes/water_management_area_valid.yml

@@ -1,62 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?Filter=(%3CFilter%3E%3CIntersects%3E%3CPropertyName%3ESHAPE%3C/PropertyName%3E%3Cgml:Point%3E%3Cgml:coordinates%3E408602.61,257535.31%3C/gml:coordinates%3E%3C/gml:Point%3E%3C/Intersects%3E%3C/Filter%3E)&REQUEST=GetFeature&SERVICE=WFS&SRSName=EPSG:27700&VERSION=1.0.0&propertyName=code,long_name,short_name&typeName=ms:Administrative_Boundaries_Water_Management_Areas
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - rest-client/2.0.2 (darwin18.2.0 x86_64) ruby/2.4.2p198
-      Host:
-      - environment.data.gov.uk
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Fri, 09 Aug 2019 17:08:14 GMT
-      Content-Type:
-      - application/xml
-      Content-Length:
-      - '1530'
-      Connection:
-      - keep-alive
-      Cache-Control:
-      - private
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-    body:
-      encoding: UTF-8
-      string: |-
-        <?xml version="1.0" encoding="utf-8" ?>
-        <wfs:FeatureCollection xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:wfs="http://www.opengis.net/wfs" xmlns:gml="http://www.opengis.net/gml" xmlns:ms="https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs http://schemas.opengis.net/wfs/1.0.0/WFS-basic.xsd http://www.opengis.net/gml http://schemas.opengis.net/gml/2.1.2/feature.xsd https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs https://environment.data.gov.uk/spatialdata/administrative-boundaries-water-management-areas/wfs?service=wfs%26version=1.0.0%26request=DescribeFeatureType">
-        <gml:boundedBy>
-          <gml:Box srsName="EPSG:27700">
-            <gml:coordinates>0,0,0,0</gml:coordinates>
-          </gml:Box>
-        </gml:boundedBy>
-          <gml:featureMember>
-            <ms:Administrative_Boundaries_Water_Management_Areas fid="Administrative_Boundaries_Water_Management_Areas.15">
-              <ms:OBJECTID>15</ms:OBJECTID>
-              <ms:long_name>Staffordshire Warwickshire and West Midlands</ms:long_name>
-              <ms:short_name>Staffs Warks and West Mids</ms:short_name>
-              <ms:code>STWKWM</ms:code>
-              <ms:st_area_shape_>6460280400.1</ms:st_area_shape_>
-              <ms:st_perimeter_shape_>759189.708848595</ms:st_perimeter_shape_>
-            </ms:Administrative_Boundaries_Water_Management_Areas>
-          </gml:featureMember>
-        </wfs:FeatureCollection>
-    http_version: 
-  recorded_at: Fri, 09 Aug 2019 17:08:14 GMT
-recorded_with: VCR 4.0.0

data/spec/examples.txt

@@ -1,24 +0,0 @@
-example_id                                                                       | status | run_time        |
--------------------------------------------------------------------------------- | ------ | --------------- |
-./spec/defra_ruby/area/area_spec.rb[1:1:1:1]                                     | passed | 0.00027 seconds |
-./spec/defra_ruby/area/area_spec.rb[1:2:1:1]                                     | passed | 0.00024 seconds |
-./spec/defra_ruby/area/configuration_spec.rb[1:1]                                | passed | 0.00337 seconds |
-./spec/defra_ruby/area/response_spec.rb[1:1:1:1]                                 | passed | 0.00025 seconds |
-./spec/defra_ruby/area/response_spec.rb[1:1:2:1]                                 | passed | 0.00412 seconds |
-./spec/defra_ruby/area/response_spec.rb[1:2:1:1]                                 | passed | 0.00017 seconds |
-./spec/defra_ruby/area/response_spec.rb[1:2:2:1]                                 | passed | 0.00725 seconds |
-./spec/defra_ruby/area/response_spec.rb[1:3:1:1]                                 | passed | 0.0029 seconds  |
-./spec/defra_ruby/area/response_spec.rb[1:3:2:1]                                 | passed | 0.00023 seconds |
-./spec/defra_ruby/area/services/public_face_area_service_spec.rb[1:1:1:1]        | passed | 0.03685 seconds |
-./spec/defra_ruby/area/services/public_face_area_service_spec.rb[1:1:2:1:1]      | passed | 0.06383 seconds |
-./spec/defra_ruby/area/services/public_face_area_service_spec.rb[1:1:2:2:1]      | passed | 0.03793 seconds |
-./spec/defra_ruby/area/services/public_face_area_service_spec.rb[1:1:3:1:1]      | passed | 0.06819 seconds |
-./spec/defra_ruby/area/services/public_face_area_service_spec.rb[1:1:3:2:1]      | passed | 0.02928 seconds |
-./spec/defra_ruby/area/services/water_management_area_service_spec.rb[1:1:1:1]   | passed | 0.03675 seconds |
-./spec/defra_ruby/area/services/water_management_area_service_spec.rb[1:1:2:1:1] | passed | 0.03188 seconds |
-./spec/defra_ruby/area/services/water_management_area_service_spec.rb[1:1:2:2:1] | passed | 0.03399 seconds |
-./spec/defra_ruby/area/services/water_management_area_service_spec.rb[1:1:3:1:1] | passed | 0.02733 seconds |
-./spec/defra_ruby/area/services/water_management_area_service_spec.rb[1:1:3:2:1] | passed | 0.04418 seconds |
-./spec/defra_ruby/area_spec.rb[1:1:1]                                            | passed | 0.00637 seconds |
-./spec/defra_ruby/area_spec.rb[1:2:1:1]                                          | passed | 0.00344 seconds |
-./spec/defra_ruby/area_spec.rb[1:2:2:1]                                          | passed | 0.00018 seconds |

data/spec/support/vcr.rb

@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-# Stubbing HTTP requests
-require "webmock/rspec"
-# Auto generate fake responses for web-requests
-require "vcr"
-
-VCR.configure do |c|
-  c.cassette_library_dir = "spec/cassettes"
-  c.hook_into :webmock
-
-  c.ignore_hosts "127.0.0.1", "codeclimate.com"
-
-  SECONDS_IN_DAY = 24 * 60 * 60
-
-  c.default_cassette_options = { re_record_interval: (14 * SECONDS_IN_DAY) }
-end