defmastership 1.3.3 → 1.3.4

data/spec/unit/defmastership/modifier/update_eref_version_spec.rb

@@ -100,18 +100,20 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
         ['(a~abcd1234)', '(z~abcd1234)']
       ].each do |from, to|
         it do
-          modifier.replace_erefs("defs:eref[type, [THE_REF#{from}]]")
+          modifier.replace_erefs('', "defs:eref[type, [THE_REF#{from}]]")
           expect(ref_document).to(have_received(:ref_to_def).with('THE_REF'))
         end
 
         it do
-          modifier.replace_erefs("defs:eref[type, [THE_REF#{from}]]")
+          modifier.replace_erefs('', "defs:eref[type, [THE_REF#{from}]]")
           expect(ref_definition).to(have_received(:explicit_version))
         end
 
-        it {
-          expect(modifier.replace_erefs("defs:eref[type, [THE_REF#{from}]]")).to(eq("defs:eref[type, [THE_REF#{to}]]"))
-        }
+        it do
+          expect(
+            modifier.replace_erefs('', "defs:eref[type, [THE_REF#{from}]]")
+          ).to(eq("defs:eref[type, [THE_REF#{to}]]"))
+        end
       end
     end
 
@@ -128,18 +130,20 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
         ['(a~abcd1234)', '(~abcd1234)']
       ].each do |from, to|
         it do
-          modifier.replace_erefs("defs:eref[type, [THE_REF#{from}]]")
+          modifier.replace_erefs('', "defs:eref[type, [THE_REF#{from}]]")
           expect(ref_document).to(have_received(:ref_to_def).with('THE_REF'))
         end
 
         it do
-          modifier.replace_erefs("defs:eref[type, [THE_REF#{from}]]")
+          modifier.replace_erefs('', "defs:eref[type, [THE_REF#{from}]]")
           expect(ref_definition).to(have_received(:explicit_version))
         end
 
-        it {
-          expect(modifier.replace_erefs("defs:eref[type, [THE_REF#{from}]]")).to(eq("defs:eref[type, [THE_REF#{to}]]"))
-        }
+        it do
+          expect(
+            modifier.replace_erefs('', "defs:eref[type, [THE_REF#{from}]]")
+          ).to(eq("defs:eref[type, [THE_REF#{to}]]"))
+        end
       end
     end
 
@@ -149,15 +153,15 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
       end
 
       it do
-        modifier.replace_erefs('defs:eref[type, [BAD_REF(a)]]')
+        modifier.replace_erefs('', 'defs:eref[type, [BAD_REF(a)]]')
         expect(ref_document).to(have_received(:ref_to_def).with('BAD_REF'))
       end
 
-      it { expect(modifier.replace_erefs('defs:eref[type, [BAD_REF(a)]]')).to(eq('defs:eref[type, [BAD_REF(a)]]')) }
+      it { expect(modifier.replace_erefs('', 'defs:eref[type, [BAD_REF(a)]]')).to(eq('defs:eref[type, [BAD_REF(a)]]')) }
     end
 
     context 'when the line is not a valid eref' do
-      it { expect(modifier.replace_erefs('bla bla')).to(eq('bla bla')) }
+      it { expect(modifier.replace_erefs('', 'bla bla')).to(eq('bla bla')) }
     end
 
     context 'when the line is matching one external ref definition with more refs' do
@@ -168,7 +172,7 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
         allow(ref_document).to(receive(:ref_to_def).with('REF2').and_return(other_ref_definition))
         allow(ref_definition).to(receive(:explicit_version).and_return('a'))
         allow(other_ref_definition).to(receive(:explicit_version).and_return('z'))
-        modifier.replace_erefs('defs:eref[type, [REF1, REF2]]')
+        modifier.replace_erefs('', 'defs:eref[type, [REF1, REF2]]')
       end
 
       it { expect(ref_document).to(have_received(:ref_to_def).with('REF1')) }
@@ -176,9 +180,11 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
       it { expect(ref_definition).to(have_received(:explicit_version)) }
       it { expect(other_ref_definition).to(have_received(:explicit_version)) }
 
-      it {
-        expect(modifier.replace_erefs('defs:eref[type, [REF1, REF2]]')).to(eq('defs:eref[type, [REF1(a), REF2(z)]]'))
-      }
+      it do
+        expect(
+          modifier.replace_erefs('', 'defs:eref[type, [REF1, REF2]]')
+        ).to(eq('defs:eref[type, [REF1(a), REF2(z)]]'))
+      end
     end
 
     context 'when the modifier modifies only one eref_type' do
@@ -192,8 +198,11 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
         allow(ref_definition).to(receive(:explicit_version).and_return('a'))
       end
 
-      it { expect(modifier.replace_erefs('defs:eref[implements, [REF]]')).to(eq('defs:eref[implements, [REF(a)]]')) }
-      it { expect(modifier.replace_erefs('defs:eref[covers, [REF]]')).to(eq('defs:eref[covers, [REF]]')) }
+      it do
+        expect(modifier.replace_erefs('', 'defs:eref[implements, [REF]]')).to(eq('defs:eref[implements, [REF(a)]]'))
+      end
+
+      it { expect(modifier.replace_erefs('', 'defs:eref[covers, [REF]]')).to(eq('defs:eref[covers, [REF]]')) }
     end
 
     context 'when the modifier modifies more than one eref_type' do
@@ -207,9 +216,12 @@ RSpec.describe(Defmastership::Modifier::UpdateErefVersion) do
         allow(ref_definition).to(receive(:explicit_version).and_return('a'))
       end
 
-      it { expect(modifier.replace_erefs('defs:eref[implements, [REF]]')).to(eq('defs:eref[implements, [REF(a)]]')) }
-      it { expect(modifier.replace_erefs('defs:eref[covers, [REF]]')).to(eq('defs:eref[covers, [REF(a)]]')) }
-      it { expect(modifier.replace_erefs('defs:eref[covers_not, [REF]]')).to(eq('defs:eref[covers_not, [REF]]')) }
+      it do
+        expect(modifier.replace_erefs('', 'defs:eref[implements, [REF]]')).to(eq('defs:eref[implements, [REF(a)]]'))
+      end
+
+      it { expect(modifier.replace_erefs('', 'defs:eref[covers, [REF]]')).to(eq('defs:eref[covers, [REF(a)]]')) }
+      it { expect(modifier.replace_erefs('', 'defs:eref[covers_not, [REF]]')).to(eq('defs:eref[covers_not, [REF]]')) }
     end
   end
 end

data/spec/unit/defmastership/modifier/update_iref_checksum_spec.rb

@@ -72,17 +72,17 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefChecksum) do
         ['(a~abcd1234)', '(a~a1b2c3d4)']
       ].each do |from, to|
         it do
-          modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever")
+          modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever")
           expect(document).to(have_received(:ref_to_def).with('THE_REF'))
         end
 
         it do
-          modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever")
+          modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever")
           expect(definition).to(have_received(:sha256_short))
         end
 
         it {
-          expect(modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever"))
+          expect(modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever"))
             .to(eq("whatever defs:iref[THE_REF#{to}] whatever"))
         }
       end
@@ -94,18 +94,18 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefChecksum) do
       end
 
       it do
-        modifier.replace_irefs('whatever defs:iref[BAD_REF(a~abcd1234)] whatever')
+        modifier.replace_irefs('', 'whatever defs:iref[BAD_REF(a~abcd1234)] whatever')
         expect(document).to(have_received(:ref_to_def).with('BAD_REF'))
       end
 
       it {
-        expect(modifier.replace_irefs('whatever defs:iref[BAD_REF(a~abcd1234)] whatever'))
+        expect(modifier.replace_irefs('', 'whatever defs:iref[BAD_REF(a~abcd1234)] whatever'))
           .to(eq('whatever defs:iref[BAD_REF(a~abcd1234)] whatever'))
       }
     end
 
     context 'when the line is not a valid iref' do
-      it { expect(modifier.replace_irefs('bla bla')).to(eq('bla bla')) }
+      it { expect(modifier.replace_irefs('', 'bla bla')).to(eq('bla bla')) }
     end
 
     context 'when the line is matching more than one iref' do
@@ -116,7 +116,7 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefChecksum) do
         allow(document).to(receive(:ref_to_def).with('REF2').and_return(other_definition))
         allow(definition).to(receive(:sha256_short).and_return('~a1b2c3d4'))
         allow(other_definition).to(receive(:sha256_short).and_return('~e5f6abcd'))
-        modifier.replace_irefs('defs:iref[REF1], defs:iref[REF2]')
+        modifier.replace_irefs('', 'defs:iref[REF1], defs:iref[REF2]')
       end
 
       it { expect(document).to(have_received(:ref_to_def).with('REF1')) }
@@ -125,7 +125,7 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefChecksum) do
       it { expect(other_definition).to(have_received(:sha256_short)) }
 
       it {
-        expect(modifier.replace_irefs('defs:iref[REF1], defs:iref[REF2]'))
+        expect(modifier.replace_irefs('', 'defs:iref[REF1], defs:iref[REF2]'))
           .to(eq('defs:iref[REF1(~a1b2c3d4)], defs:iref[REF2(~e5f6abcd)]'))
       }
     end

data/spec/unit/defmastership/modifier/update_iref_version_spec.rb

@@ -72,17 +72,17 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefVersion) do
         ['(a~abcd1234)', '(z~abcd1234)']
       ].each do |from, to|
         it do
-          modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever")
+          modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever")
           expect(document).to(have_received(:ref_to_def).with('THE_REF'))
         end
 
         it do
-          modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever")
+          modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever")
           expect(definition).to(have_received(:explicit_version))
         end
 
         it {
-          expect(modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever"))
+          expect(modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever"))
             .to(eq("whatever defs:iref[THE_REF#{to}] whatever"))
         }
       end
@@ -101,17 +101,17 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefVersion) do
         ['(a~abcd1234)', '(~abcd1234)']
       ].each do |from, to|
         it do
-          modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever")
+          modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever")
           expect(document).to(have_received(:ref_to_def).with('THE_REF'))
         end
 
         it do
-          modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever")
+          modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever")
           expect(definition).to(have_received(:explicit_version))
         end
 
         it {
-          expect(modifier.replace_irefs("whatever defs:iref[THE_REF#{from}] whatever"))
+          expect(modifier.replace_irefs('', "whatever defs:iref[THE_REF#{from}] whatever"))
             .to(eq("whatever defs:iref[THE_REF#{to}] whatever"))
         }
       end
@@ -123,18 +123,18 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefVersion) do
       end
 
       it do
-        modifier.replace_irefs('whatever defs:iref[BAD_REF(a~abcd1234)] whatever')
+        modifier.replace_irefs('', 'whatever defs:iref[BAD_REF(a~abcd1234)] whatever')
         expect(document).to(have_received(:ref_to_def).with('BAD_REF'))
       end
 
       it {
-        expect(modifier.replace_irefs('whatever defs:iref[BAD_REF(a~abcd1234)] whatever'))
+        expect(modifier.replace_irefs('', 'whatever defs:iref[BAD_REF(a~abcd1234)] whatever'))
           .to(eq('whatever defs:iref[BAD_REF(a~abcd1234)] whatever'))
       }
     end
 
     context 'when the line is not a valid iref' do
-      it { expect(modifier.replace_irefs('bla bla')).to(eq('bla bla')) }
+      it { expect(modifier.replace_irefs('', 'bla bla')).to(eq('bla bla')) }
     end
 
     context 'when the line is matching more than one iref' do
@@ -145,7 +145,7 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefVersion) do
         allow(document).to(receive(:ref_to_def).with('REF2').and_return(other_definition))
         allow(definition).to(receive(:explicit_version).and_return('pouet'))
         allow(other_definition).to(receive(:explicit_version).and_return('tagada'))
-        modifier.replace_irefs('defs:iref[REF1], defs:iref[REF2]')
+        modifier.replace_irefs('', 'defs:iref[REF1], defs:iref[REF2]')
       end
 
       it { expect(document).to(have_received(:ref_to_def).with('REF1')) }
@@ -154,7 +154,7 @@ RSpec.describe(Defmastership::Modifier::UpdateIrefVersion) do
       it { expect(other_definition).to(have_received(:explicit_version)) }
 
       it {
-        expect(modifier.replace_irefs('defs:iref[REF1], defs:iref[REF2]'))
+        expect(modifier.replace_irefs('', 'defs:iref[REF1], defs:iref[REF2]'))
           .to(eq('defs:iref[REF1(pouet)], defs:iref[REF2(tagada)]'))
       }
     end

data/tasks/code_quality.rake

@@ -56,7 +56,7 @@ namespace 'quality' do
   end
 
   desc 'Runs all quality code check'
-  task(all: ['quality:rubocop', 'quality:reek', 'quality:flay', 'quality:rubycritic'])
+  task(all: ['quality:rubocop', 'quality:reek', 'quality:flay'])
 end
 # rubocop:enable Metrics/BlockLength
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: defmastership
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - Jérôme Arbez-Gindre
@@ -57,14 +57,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.3
+        version: 1.5.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.3
+        version: 1.5.5
 - !ruby/object:Gem::Dependency
   name: facets
   requirement: !ruby/object:Gem::Requirement
@@ -85,14 +85,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: gli
   requirement: !ruby/object:Gem::Requirement
@@ -135,6 +135,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.6'
+- !ruby/object:Gem::Dependency
+  name: rubyXL
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
 email: jeromearbezgindre@gmail.com
 executables:
 - defmastership
@@ -180,7 +194,11 @@ files:
 - lib/defmastership/document.rb
 - lib/defmastership/export/body_formatter.rb
 - lib/defmastership/export/csv/formatter.rb
+- lib/defmastership/export/formatter.rb
 - lib/defmastership/export/header_formatter.rb
+- lib/defmastership/export/json/formatter.rb
+- lib/defmastership/export/xlsx/formatter.rb
+- lib/defmastership/export/yaml/formatter.rb
 - lib/defmastership/filters.rb
 - lib/defmastership/hash_merge_no_new.rb
 - lib/defmastership/matching_line.rb
@@ -209,7 +227,11 @@ files:
 - spec/unit/defmastership/document_spec.rb
 - spec/unit/defmastership/export/body_formatter_spec.rb
 - spec/unit/defmastership/export/csv/formatter_spec.rb
+- spec/unit/defmastership/export/formatter_spec.rb
 - spec/unit/defmastership/export/header_formatter_spec.rb
+- spec/unit/defmastership/export/json/formatter_spec.rb
+- spec/unit/defmastership/export/xlsx/formatter_spec.rb
+- spec/unit/defmastership/export/yaml/formatter_spec.rb
 - spec/unit/defmastership/hash_spec.rb
 - spec/unit/defmastership/matching_line_spec.rb
 - spec/unit/defmastership/modifier/change_ref_spec.rb
@@ -250,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.2
 specification_version: 4
 summary: Handling of references and definitions with asciidoctor
 test_files: []