defmastership 1.0.8 → 1.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6fbf5098c8ab70e422d9c158c0a28cd876de25cfd159a131b0ddefc5f1eca86
-  data.tar.gz: 8717156666df342a45994bb455b0cc58f09fc1da9b31c48cd0d4b36a40c528b6
+  metadata.gz: 9e81c3ab45ea06b43ad767d8ab89231e05eacca67dee259a8d968d515da6adb6
+  data.tar.gz: bb2abcc00dea06b45b35373eec37923236770310cd70842770be8d1ac92149e7
 SHA512:
-  metadata.gz: 6afcfd48186a2f89426e62007dc068711ea36e26a8ecf9b9c56428a351eabb6a89be58872a96de30c9a87ccdc71366e685fd8486469a3465e661ae490c0925be
-  data.tar.gz: 275587475f39f39bbd311cdf9a0fb1cc9cdcb30c6cf766b44d9b1ff64ac9a8feb2c9117f4903f8eb806b3e73594b6c2e5e63876038483429cabd7eb66fb93575
+  metadata.gz: 3df9a3fd838a4600b66690fd30fedcbf28b8e3af6d2afbe8d1ef813ea8b3b163b854f16ff3f219550a24b9624302ea0d32b8a043f90047070425d39e1b017cc4
+  data.tar.gz: 5b2b9c5105d548c2cba1571ad36830453bec01664d7ab4edec71a1132b30bb0651dd4d5a197f1d4c13a2a09d0ea9e69b2b0f3af975f0611de32b1cd52737c92d

data/.rubocop.yml

@@ -62,3 +62,7 @@ RSpec/FilePath :
 
 RSpec/NestedGroups:
   Max: 4
+
+Layout/RedundantLineBreak:
+  Enabled: false
+  

data/features/changeref.feature

@@ -36,6 +36,39 @@ Feature: The changeref command
     [define, requirement, TOTO-0123]
     """
 
+  Scenario: Change a definition with explicit checksum and version
+    Given a file named "modifications.yml" with:
+    """
+    ---
+    :toto:
+      :type: change_ref
+      :config:
+        :from_regexp: TOTO-TEMP-[X\d]{4}
+        :to_template: TOTO-%<next_ref>04d
+        :next_ref: 123
+    """
+    And a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-TEMP-XXX1(a~12345678)]
+    """
+    When I successfully run `defmastership modify --modifications toto thedoc.adoc`
+    Then the stdout should not contain anything
+    And the stderr should not contain anything
+    And the file "modifications.yml" should contain:
+    """
+    ---
+    :toto:
+      :type: change_ref
+      :config:
+        :from_regexp: TOTO-TEMP-[X\d]{4}
+        :to_template: TOTO-%<next_ref>04d
+        :next_ref: 124
+    """
+    And the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0123(a~12345678)]
+    """
+
   Scenario: Change two definitions
     Given a file named "modifications.yml" with:
     """

data/features/definition_checksum.feature

@@ -242,3 +242,57 @@ Feature: definition checksum
     """
     And the stdout should not contain anything
     And the stderr should not contain anything
+
+  Scenario: Checksum keep explicit version in ref modification
+    Given a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_checksum:
+      :type: update_def_checksum
+      :config:
+        :def_type: requirement
+    """
+    And a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-TEMP-XXX1(toto~abcd1234)]
+    --
+    the requirement value.
+    --
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
+    Then the stdout should not contain anything
+    And the stderr should not contain anything
+    And the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-TEMP-XXX1(toto~244eed18)]
+    --
+    the requirement value.
+    --
+    """
+
+  Scenario: Checksum keep explicit version in ref setting
+    Given a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_checksum:
+      :type: update_def_checksum
+      :config:
+        :def_type: requirement
+    """
+    And a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-TEMP-XXX1(toto)]
+    --
+    the requirement value.
+    --
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
+    Then the stdout should not contain anything
+    And the stderr should not contain anything
+    And the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-TEMP-XXX1(toto~244eed18)]
+    --
+    the requirement value.
+    --
+    """

data/features/definition_version.feature

@@ -22,3 +22,183 @@ Feature: definitions version
     And the stdout should not contain anything
     And the stderr should not contain anything
 
+  Scenario: Set initial explicit version when definition has changed 
+    Given a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text.
+    --
+    """
+    Given a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: a
+        :ref_document: ./ref_doc.adoc
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    And the stderr should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(a)]
+    --
+    modified text.
+    --
+    """
+
+  Scenario: Do not set initial explicit version when definition has NOT changed 
+    Given a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text.
+    --
+    """
+    Given a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    initial text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: a
+        :ref_document: ./ref_doc.adoc
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    And the stderr should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text.
+    --
+    """
+
+  Scenario: Set initial explicit version when definition has changed and ref is not an initial version
+    Given a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(3)]
+    --
+    initial text.
+    --
+    """
+    Given a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: 1
+        :ref_document: ./ref_doc.adoc
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    And the stderr should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(4)]
+    --
+    modified text.
+    --
+    """
+
+  Scenario: No initial explicit version when definition is new
+    Given a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0002]
+    --
+    initial text.
+    --
+    """
+    Given a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: 1
+        :ref_document: ./ref_doc.adoc
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    And the stderr should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    modified text.
+    --
+    """
+
+  Scenario: update explicit version whith explicit checksum
+    Given a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text.
+    --
+    """
+    Given a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever~abcd1234)]
+    --
+    modified text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: a
+        :ref_document: ./ref_doc.adoc
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    And the stderr should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(a~abcd1234)]
+    --
+    modified text.
+    --
+    """
+

data/features/rename_included_files.feature

@@ -73,7 +73,9 @@ Feature: The rename_included_files command
     :any: one
     :path: two
     [define, requirement, TOTO-WHATEVER-123]
+    --
     include::{any}_{path}/one_file.png[]
+    --
     """
     And a directory named "one_two"
     And an empty file named "one_two/one_file.png"
@@ -85,7 +87,9 @@ Feature: The rename_included_files command
     :any: one
     :path: two
     [define, requirement, TOTO-WHATEVER-123]
+    --
     include::{any}_{path}/TOTO-WHATEVER-123_one_file.png[]
+    --
     """
     And the file "one_two/one_file.png" should not exist
     And the file "one_two/TOTO-WHATEVER-123_one_file.png" should exist

data/lib/defmastership.rb

@@ -6,6 +6,7 @@ require('defmastership/version')
 # Add requires for other files you add to your project here, so
 # you just need to require this one file in your bin file
 require('defmastership/constants')
+require('defmastership/parsing_state')
 require('defmastership/definition')
 require('defmastership/definition_parser')
 require('defmastership/filters')
@@ -25,3 +26,6 @@ require('defmastership/rename_included_files_line_modifier')
 
 require('defmastership/update_def_checksum_modifier')
 require('defmastership/update_def_checksum_line_modifier')
+
+require('defmastership/update_def_version_modifier')
+require('defmastership/update_def_version_line_modifier')

data/lib/defmastership/change_ref_line_modifier.rb

@@ -28,7 +28,7 @@ module DefMastership
         to_template: '',
         next_ref: 0
       }
-      @in_literal = false
+      @parsing_state = ParsingState.new
     end
 
     def replace(method, line)
@@ -36,10 +36,10 @@ module DefMastership
     end
 
     def replace_refdef(line)
-      if in_literal(line)
-        line
-      else
+      if @parsing_state.enabled?(line)
         do_replace_refdef(line)
+      else
+        line
       end
     end
 
@@ -66,21 +66,17 @@ module DefMastership
       regexp_str =
         "(?<before>#{REGEXP_FROM[const][:before]})" \
         "(?<from>#{from})" \
+        "#{DMRegexp::DEF_VERSION_AND_CHECKSUM}" \
         "(?<after>#{REGEXP_FROM[const][:after]})"
       Regexp.new(regexp_str, Regexp::EXTENDED)
     end
 
     def text_with(match, replacement)
-      match[:before] + replacement + match[:after]
+      match[:before] + replacement + (match[:version_and_checksum] || '') + match[:after]
     end
 
     def hmerge(match)
       @config.merge(match.names.map(&:to_sym).zip(match.captures).to_h)
     end
-
-    def in_literal(line)
-      @in_literal ^= true if line.chomp == '....'
-      @in_literal
-    end
   end
 end

data/lib/defmastership/constants.rb

@@ -20,7 +20,9 @@ module DefMastership
       (,\s*\[\s*(?<labels>.*?)\s*\])?\s*\]
     AFT
 
-    DEF_VERSION_AND_CHECKSUM = '(\((?<explicit_version>[^~]+)?(?<explicit_checksum>~[[:alnum:]]+)?\))?'
+    DEF_VERSION_AND_CHECKSUM = '(?<version_and_checksum>' \
+                               '\((?<explicit_version>[^~]+)?(?<explicit_checksum>~[[:alnum:]]+)?\)' \
+                               ')?'
 
     DEFINITION = Regexp.new(
       "#{DEF_BEFORE_REF}(?<reference>[\\w:_-]+)#{DEF_VERSION_AND_CHECKSUM}#{DEF_AFTER_REF}",

data/lib/defmastership/definition.rb

@@ -31,7 +31,7 @@ module DefMastership
     end
 
     def sha256
-      "~#{Digest::SHA2.new(256).hexdigest(value).split(//).last(8).join}"
+      "~#{Digest::SHA2.new(256).hexdigest(value).chars.last(8).join}"
     end
 
     def wrong_explicit_checksum

data/lib/defmastership/parsing_state.rb

@@ -0,0 +1,23 @@
+# Copyright (c) 2020 Jerome Arbez-Gindre
+# frozen_string_literal: true
+
+module DefMastership
+  # Allow to know if we need to parse the line or simply ignore it
+  class ParsingState
+    def initialize
+      @last_disabling_line = nil
+    end
+
+    def enabled?(line)
+      line = line.dup.chomp
+      if ['....', '----'].include?(line)
+        if @last_disabling_line == line
+          @last_disabling_line = nil
+        elsif @last_disabling_line.nil?
+          @last_disabling_line = line
+        end
+      end
+      @last_disabling_line.nil?
+    end
+  end
+end

data/lib/defmastership/rename_included_files_line_modifier.rb

@@ -96,7 +96,7 @@ module DefMastership
 
         filename.gsub!("{#{varname}}", @variables[varname.to_sym])
       end
-      filename
+      filename.chomp
     end
 
     def complete_regexp_from(from)

data/lib/defmastership/update_def_checksum_line_modifier.rb

@@ -23,9 +23,8 @@ module DefMastership
       return line unless match
       return line unless match[:type] == def_type
 
-      explicit_checksum_str = match[:explicit_checksum].nil? ? '' : "(#{match[:explicit_checksum]})"
-      line.gsub("#{match[:reference]}#{explicit_checksum_str}") do
-        "#{match[:reference]}(#{@document.ref_to_def(match[:reference]).sha256})"
+      line.gsub(Regexp.new("#{match[:reference]}#{DMRegexp::DEF_VERSION_AND_CHECKSUM}")) do
+        "#{match[:reference]}(#{match[:explicit_version]}#{@document.ref_to_def(match[:reference]).sha256})"
       end
     end
 

data/lib/defmastership/update_def_checksum_modifier.rb

@@ -2,7 +2,7 @@
 # frozen_string_literal: true
 
 module DefMastership
-  # Update definition checksum wih calculated one
+  # Update definition checksum with calculated one
   class UpdateDefChecksumModifier < ModifierBase
     def replacements
       %i[replace]

data/lib/defmastership/update_def_version_line_modifier.rb

@@ -0,0 +1,58 @@
+# Copyright (c) 2020 Jerome Arbez-Gindre
+# frozen_string_literal: true
+
+module DefMastership
+  # modify one line after another
+  class UpdateDefVersionLineModifier < LineModifierBase
+    attr_accessor :document, :ref_document
+
+    def self.from_config(hash)
+      new.from_config(hash)
+    end
+
+    def initialize
+      super
+      @config = {
+        def_type: '',
+        ref_document: '',
+        first_version: ''
+      }
+    end
+
+    def replace(line)
+      match = matched?(line)
+
+      return line unless match
+      return line unless match[:type] == def_type
+
+      version_and_checksum = ''
+      if match[:explicit_checksum] || version_string(match)
+        version_and_checksum = "(#{version_string(match)}#{match[:explicit_checksum]})"
+      end
+
+      line.gsub(Regexp.new("#{match[:reference]}#{DMRegexp::DEF_VERSION_AND_CHECKSUM}")) do
+        "#{match[:reference]}#{version_and_checksum}"
+      end
+    end
+
+    private
+
+    def matched?(line)
+      return if line.commented?
+      return unless line =~ DMRegexp::DEFINITION
+
+      Regexp.last_match
+    end
+
+    def version_string(match)
+      ref_definition = @ref_document.ref_to_def(match[:reference])
+      definition = @document.ref_to_def(match[:reference])
+
+      return if ref_definition.nil?
+      return ref_definition.explicit_version if definition.sha256 == ref_definition.sha256
+
+      ref_version = @ref_document.ref_to_def(match[:reference]).explicit_version
+      ref_version.nil? ? @config[:first_version] : ref_version.next
+    end
+  end
+end

data/lib/defmastership/update_def_version_modifier.rb

@@ -0,0 +1,25 @@
+# Copyright (c) 2020 Jerome Arbez-Gindre
+# frozen_string_literal: true
+
+module DefMastership
+  # Update definition version if the definition has change since
+  # reference document
+  class UpdateDefVersionModifier < ModifierBase
+    def replacements
+      %i[replace]
+    end
+
+    def new_line_modifier(config, adoc_texts)
+      document = Document.new
+      adoc_texts.each do |adoc_file, _|
+        document.parse_file_with_preprocessor(adoc_file)
+      end
+      ref_document = Document.new
+      ref_document.parse_file_with_preprocessor(config[:ref_document])
+      line_modifier = UpdateDefVersionLineModifier.from_config(config)
+      line_modifier.document = document
+      line_modifier.ref_document = ref_document
+      line_modifier
+    end
+  end
+end

data/lib/defmastership/version.rb

@@ -2,6 +2,6 @@
 # frozen_string_literal: true
 
 module DefMastership
-  VERSION = '1.0.8'
+  VERSION = '1.0.13'
   public_constant :VERSION
 end

data/spec/unit/defmastership/change_ref_line_modifier_spec.rb

@@ -217,6 +217,21 @@ RSpec.describe(DefMastership::ChangeRefLineModifier) do
         .to(eq('[define, whatever, TUTU]'))
     end
 
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP(a~12345678)]'))
+        .to(eq('[define, whatever, TUTU(a~12345678)]'))
+    end
+
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP(~12345678)]'))
+        .to(eq('[define, whatever, TUTU(~12345678)]'))
+    end
+
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP(a)]'))
+        .to(eq('[define, whatever, TUTU(a)]'))
+    end
+
     it do
       refchanger.replace(:refdef, '[define, whatever, TEMP]')
       expect(refchanger.replace(:irefs, 'defs:iref[TEMP]'))

data/spec/unit/defmastership/parsing_state_spec.rb

@@ -0,0 +1,48 @@
+# Copyright (c) 2020 Jerome Arbez-Gindre
+# frozen_string_literal: true
+
+require('defmastership')
+
+RSpec.describe(DefMastership::ParsingState) do
+  subject(:parsing_state) do
+    described_class.new
+  end
+
+  describe '.new' do
+    it { is_expected.not_to(be(nil)) }
+  end
+
+  describe '#enabled_with?' do
+    context 'when starting' do
+      it { expect(parsing_state.enabled?("whatever\n")).to(eq(true)) }
+      it { expect(parsing_state.enabled?("----\n")).to(eq(false)) }
+      it { expect(parsing_state.enabled?("....\n")).to(eq(false)) }
+      it { expect(parsing_state.enabled?('....')).to(eq(false)) }
+    end
+
+    context 'when disabled' do
+      before { parsing_state.enabled?("----\n") }
+
+      it { expect(parsing_state.enabled?("whatever\n")).to(eq(false)) }
+      it { expect(parsing_state.enabled?("----\n")).to(eq(true)) }
+      it { expect(parsing_state.enabled?("....\n")).to(eq(false)) }
+    end
+
+    context 'with intricated disables satrting with "...."' do
+      before do
+        ["....\n", "----\n", "whatever\n"].each { |line| parsing_state.enabled?(line) }
+      end
+
+      it { expect(parsing_state.enabled?("----\n")).to(eq(false)) }
+      it { expect(parsing_state.enabled?("....\n")).to(eq(true)) }
+    end
+
+    context 'with intricated disables satrting with "----"' do
+      before do
+        ["....\n", "----\n", "whatever\n"].each { |line| parsing_state.enabled?(line) }
+      end
+
+      it { expect(parsing_state.enabled?("....\n")).to(eq(true)) }
+    end
+  end
+end

data/spec/unit/defmastership/rename_included_files_line_modifier_spec.rb

@@ -110,32 +110,32 @@ RSpec.describe(DefMastership::RenameIncludedFilesLineModifier) do
         end
 
         it do
-          expect(includeschanger.replace('include::orig[]'))
-            .to(eq('include::dest[]'))
+          expect(includeschanger.replace("include::orig[]\n"))
+            .to(eq("include::dest[]\n"))
         end
 
         it do
-          includeschanger.replace('include::orig[]')
+          includeschanger.replace("include::orig[]\n")
           expect(File).to(have_received(:rename).with('orig', 'dest'))
         end
 
         it do
-          includeschanger.replace('include::orig[]')
+          includeschanger.replace("include::orig[]\n")
           expect(includeschanger).to(have_attributes(changes: [%w[orig dest]]))
         end
 
         it do
-          expect(includeschanger.replace('include::toto/orig[]'))
-            .to(eq('include::toto/dest[]'))
+          expect(includeschanger.replace("include::toto/orig[]\n"))
+            .to(eq("include::toto/dest[]\n"))
         end
 
         it do
-          includeschanger.replace('include::toto/orig[]')
+          includeschanger.replace("include::toto/orig[]\n")
           expect(File).to(have_received(:rename).with('toto/orig', 'toto/dest'))
         end
 
         it do
-          includeschanger.replace('include::toto/orig[]')
+          includeschanger.replace("include::toto/orig[]\n")
           expect(includeschanger).to(have_attributes(changes: [%w[toto/orig toto/dest]]))
         end
       end

data/spec/unit/defmastership/update_def_checksum_line_modifier_spec.rb

@@ -63,6 +63,16 @@ RSpec.describe(DefMastership::UpdateDefChecksumLineModifier) do
         expect(linemodifier.replace('[define,requirement,REFERENCE(~bad)]'))
           .to(eq('[define,requirement,REFERENCE(~abcd1234)]'))
       end
+
+      it do
+        expect(linemodifier.replace('[define,requirement,REFERENCE(toto~bad)]'))
+          .to(eq('[define,requirement,REFERENCE(toto~abcd1234)]'))
+      end
+
+      it do
+        expect(linemodifier.replace('[define,requirement,REFERENCE(toto)]'))
+          .to(eq('[define,requirement,REFERENCE(toto~abcd1234)]'))
+      end
     end
   end
 end

data/spec/unit/defmastership/update_def_version_line_modifier_spec.rb

@@ -0,0 +1,127 @@
+# Copyright (c) 2020 Jerome Arbez-Gindre
+# frozen_string_literal: true
+
+require('defmastership')
+
+RSpec.describe(DefMastership::UpdateDefVersionLineModifier) do
+  subject(:linemodifier) { described_class.new }
+
+  describe '.new' do
+    it { is_expected.not_to(be(nil)) }
+    it { is_expected.to(have_attributes(def_type: '')) }
+    it { is_expected.to(have_attributes(changes:  [])) }
+    it { expect { linemodifier.user_defined_attribute }.to(raise_error(NoMethodError)) }
+  end
+
+  describe '.from_config' do
+    subject(:linemodifier) do
+      described_class.from_config(
+        def_type: 'requirement',
+        first_version: 'a'
+      )
+    end
+
+    it { is_expected.not_to(be(nil)) }
+    it { is_expected.to(have_attributes(def_type: 'requirement')) }
+    it { is_expected.to(have_attributes(first_version: 'a')) }
+    it { is_expected.to(have_attributes(document: nil)) }
+    it { is_expected.to(have_attributes(ref_document: nil)) }
+  end
+
+  describe '#replace' do
+    subject(:linemodifier) do
+      described_class.from_config(
+        def_type: 'requirement',
+        first_version: 'a'
+      )
+    end
+
+    let(:document)       { instance_double(DefMastership::Document, 'document')          }
+    let(:ref_document)   { instance_double(DefMastership::Document, 'ref_document')      }
+    let(:definition)     { instance_double(DefMastership::Definition, 'definition')      }
+    let(:ref_definition) { instance_double(DefMastership::Definition, 'ref_definitions') }
+
+    before do
+      linemodifier.document = document
+      linemodifier.ref_document = ref_document
+      allow(File).to(receive(:rename))
+    end
+
+    context 'when definition has not the good type' do
+      it do
+        expect(linemodifier.replace('[define,req,REFERENCE]'))
+          .to(eq('[define,req,REFERENCE]'))
+      end
+    end
+
+    context 'when definition has the good type' do
+      before do
+        allow(document).to(receive(:ref_to_def).with('REFERENCE').and_return(definition))
+        allow(definition).to(receive(:sha256).and_return('~abcd1234'))
+      end
+
+      context 'when definition has NOT changed' do
+        before do
+          allow(ref_document).to(receive(:ref_to_def).with('REFERENCE').and_return(ref_definition))
+          allow(ref_definition).to(receive(:sha256).and_return('~abcd1234'))
+        end
+
+        it do
+          allow(ref_definition).to(receive(:explicit_version).and_return(nil))
+          expect(linemodifier.replace('[define,requirement,REFERENCE]'))
+            .to(eq('[define,requirement,REFERENCE]'))
+        end
+
+        it do
+          allow(ref_definition).to(receive(:explicit_version).and_return('c'))
+          expect(linemodifier.replace('[define,requirement,REFERENCE]'))
+            .to(eq('[define,requirement,REFERENCE(c)]'))
+        end
+
+        it do
+          allow(ref_definition).to(receive(:explicit_version).and_return('c'))
+          expect(linemodifier.replace('[define,requirement,REFERENCE(tyty~1234)]'))
+            .to(eq('[define,requirement,REFERENCE(c~1234)]'))
+        end
+      end
+
+      context 'when definition has changed' do
+        before do
+          allow(ref_document).to(receive(:ref_to_def).with('REFERENCE').and_return(ref_definition))
+          allow(ref_definition).to(receive(:sha256).and_return('~4321aaaa'))
+        end
+
+        [
+          [nil,    '',            '(a)'],
+          ['c',    '',            '(d)'],
+          ['c',    '(tyty~1234)', '(d~1234)'],
+          ['2',    '',            '(3)'],
+          ['1222', '',            '(1223)'],
+          ['abb',  '',            '(abc)']
+        ].each do |ref, from, to|
+          it do
+            allow(ref_definition).to(receive(:explicit_version).and_return(ref))
+            expect(linemodifier.replace("[define,requirement,REFERENCE#{from}]"))
+              .to(eq("[define,requirement,REFERENCE#{to}]"))
+          end
+        end
+      end
+
+      context 'when definition is new' do
+        before do
+          allow(ref_document).to(receive(:ref_to_def).with('REFERENCE').and_return(nil))
+        end
+
+        it do
+          expect(linemodifier.replace('[define,requirement,REFERENCE(whatever)]'))
+            .to(eq('[define,requirement,REFERENCE]'))
+        end
+
+        it do
+          expect(linemodifier.replace('[define,requirement,REFERENCE(~1234)]'))
+            .to(eq('[define,requirement,REFERENCE(~1234)]'))
+        end
+      end
+    end
+  end
+end

data/spec/unit/defmastership/update_def_version_modifier_spec.rb

@@ -0,0 +1,80 @@
+# Copyright (c) 2020 Jerome Arbez-Gindre
+# frozen_string_literal: true
+
+require('defmastership')
+
+RSpec.describe(DefMastership::UpdateDefVersionModifier) do
+  subject(:modifier) do
+    described_class.new(
+      ref_document: 'ref.adoc'
+    )
+  end
+
+  let(:adoc_texts) do
+    {
+      'file1.adoc' => "file1 line1\nfile1 line2",
+      'file2.adoc' => "file2 line1\nfile2 line2"
+    }
+  end
+
+  describe '.new' do
+    it { is_expected.not_to(be(nil)) }
+    it { is_expected.to(have_attributes(config: { ref_document: 'ref.adoc' })) }
+    it { is_expected.to(have_attributes(changes: [])) }
+  end
+
+  describe '#do_modifications' do
+    let(:line_modifier) { instance_double(DefMastership::UpdateDefVersionLineModifier, 'lineModifier') }
+    let(:document)      { instance_double(DefMastership::Document, 'document')                         }
+    let(:ref_document)  { instance_double(DefMastership::Document, 'ref_document')                     }
+
+    before do
+      allow(DefMastership::UpdateDefVersionLineModifier).to(
+        receive(:from_config).with(ref_document: 'ref.adoc').and_return(line_modifier)
+      )
+      allow(DefMastership::Document).to(receive(:new).and_return(document, ref_document))
+      allow(document).to(receive(:parse_file_with_preprocessor))
+      allow(ref_document).to(receive(:parse_file_with_preprocessor))
+      allow(line_modifier).to(receive(:'document=').with(document))
+      allow(line_modifier).to(receive(:'ref_document=').with(ref_document))
+      allow(line_modifier).to(receive(:replace).with("file1 line1\n").and_return("new file1 line1\n"))
+      allow(line_modifier).to(receive(:replace).with('file1 line2').and_return('new file1 line2'))
+      allow(line_modifier).to(receive(:replace).with("file2 line1\n").and_return("new file2 line1\n"))
+      allow(line_modifier).to(receive(:replace).with('file2 line2').and_return('new file2 line2'))
+      allow(line_modifier).to(receive(:config).and_return(ref_document: 'ref.adoc'))
+      allow(line_modifier).to(receive(:changes).and_return([%w[from1 to1], %w[from2 to2]]))
+    end
+
+    context 'when detailed expectations' do
+      before { modifier.do_modifications(adoc_texts) }
+
+      it do
+        expect(DefMastership::UpdateDefVersionLineModifier).to(
+          have_received(:from_config).with(ref_document: 'ref.adoc')
+        )
+      end
+
+      it { expect(document).to(have_received(:parse_file_with_preprocessor).with('file1.adoc')) }
+      it { expect(document).to(have_received(:parse_file_with_preprocessor).with('file2.adoc')) }
+      it { expect(ref_document).to(have_received(:parse_file_with_preprocessor).with('ref.adoc')) }
+      it { expect(line_modifier).to(have_received(:'document=').with(document)) }
+      it { expect(line_modifier).to(have_received(:'ref_document=').with(ref_document)) }
+      it { expect(line_modifier).to(have_received(:replace).with("file1 line1\n")) }
+      it { expect(line_modifier).to(have_received(:replace).with('file1 line2')) }
+      it { expect(line_modifier).to(have_received(:replace).with("file2 line1\n")) }
+      it { expect(line_modifier).to(have_received(:replace).with('file2 line2')) }
+      it { expect(line_modifier).to(have_received(:config)) }
+      it { expect(line_modifier).to(have_received(:changes)) }
+      it { is_expected.to(have_attributes(config: { ref_document: 'ref.adoc' })) }
+      it { is_expected.to(have_attributes(changes: [%w[from1 to1], %w[from2 to2]])) }
+    end
+
+    it do
+      expected_adoc = {
+        'file1.adoc' => "new file1 line1\nnew file1 line2",
+        'file2.adoc' => "new file2 line1\nnew file2 line2"
+      }
+      expect(modifier.do_modifications(adoc_texts)).to(eq(expected_adoc))
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: defmastership
 version: !ruby/object:Gem::Version
-  version: 1.0.8
+  version: 1.0.13
 platform: ruby
 authors:
 - Jérôme Arbez-Gindre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-11 00:00:00.000000000 Z
+date: 2021-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aruba
@@ -216,10 +216,13 @@ files:
 - lib/defmastership/filters.rb
 - lib/defmastership/line_modifier_base.rb
 - lib/defmastership/modifier_base.rb
+- lib/defmastership/parsing_state.rb
 - lib/defmastership/rename_included_files_line_modifier.rb
 - lib/defmastership/rename_included_files_modifier.rb
 - lib/defmastership/update_def_checksum_line_modifier.rb
 - lib/defmastership/update_def_checksum_modifier.rb
+- lib/defmastership/update_def_version_line_modifier.rb
+- lib/defmastership/update_def_version_modifier.rb
 - lib/defmastership/version.rb
 - spec/spec_helper.rb
 - spec/unit/defmastership/batch_modifier_spec.rb
@@ -232,10 +235,13 @@ files:
 - spec/unit/defmastership/definition_parser_spec.rb
 - spec/unit/defmastership/definition_spec.rb
 - spec/unit/defmastership/document_spec.rb
+- spec/unit/defmastership/parsing_state_spec.rb
 - spec/unit/defmastership/rename_included_files_line_modifier_spec.rb
 - spec/unit/defmastership/rename_included_files_modifier_spec.rb
 - spec/unit/defmastership/update_def_checksum_line_modifier_spec.rb
 - spec/unit/defmastership/update_def_checksum_modifier_spec.rb
+- spec/unit/defmastership/update_def_version_line_modifier_spec.rb
+- spec/unit/defmastership/update_def_version_modifier_spec.rb
 - spec/unit/defmastership_spec.rb
 homepage: https://gitlab.com/jjag/defmastership/
 licenses: