defmastership 1.0.7 → 1.0.8

data/spec/unit/defmastership/definition_spec.rb

@@ -23,6 +23,7 @@ RSpec.describe(DefMastership::Definition) do
       it { is_expected.to(have_attributes(attributes: {})) }
       it { is_expected.to(have_attributes(labels:     Set.new)) }
       it { is_expected.to(have_attributes(wrong_explicit_checksum: nil)) }
+      it { is_expected.to(have_attributes(explicit_version: nil)) }
     end
 
     context 'with labels' do
@@ -42,13 +43,13 @@ RSpec.describe(DefMastership::Definition) do
         described_class.new(
           type: 'req',
           reference: 'TUTU-001',
-          explicit_checksum: '8cc259e6'
+          explicit_checksum: '~8cc259e6'
         )
       end
 
       it do
-        definition << 'def value with a checksum != 8cc259e6'
-        expect(definition).to(have_attributes(wrong_explicit_checksum: '8cc259e6'))
+        definition << 'def value with a checksum != ~8cc259e6'
+        expect(definition).to(have_attributes(wrong_explicit_checksum: '~8cc259e6'))
       end
 
       it do
@@ -56,6 +57,20 @@ RSpec.describe(DefMastership::Definition) do
         expect(definition).to(have_attributes(wrong_explicit_checksum: nil))
       end
     end
+
+    context 'with explicit_version' do
+      subject(:definition) do
+        described_class.new(
+          type: 'req',
+          reference: 'TUTU-001',
+          explicit_version: 'pouet'
+        )
+      end
+
+      it do
+        expect(definition).to(have_attributes(explicit_version: 'pouet'))
+      end
+    end
   end
 
   describe '#<<' do
@@ -88,7 +103,7 @@ RSpec.describe(DefMastership::Definition) do
 
     it 'calculates sha256 of value' do
       definition << 'first line' << 'second line'
-      expect(definition.sha256).to(eq('beb0535a'))
+      expect(definition.sha256).to(eq('~beb0535a'))
     end
   end
 

data/spec/unit/defmastership/document_spec.rb

@@ -52,12 +52,12 @@ RSpec.describe(DefMastership::Document) do
       end
 
       context 'when simple definition line with explicit checksum' do
-        let(:input_lines) { ['[define, requirement, TOTO-0001(ab12)]'] }
+        let(:input_lines) { ['[define, requirement, TOTO-0001(~ab12)]'] }
 
         before do
           allow(DefMastership::Definition).to(
             receive(:new).with(
-              matchdata_including(type: 'requirement', reference: 'TOTO-0001', explicit_checksum: 'ab12')
+              matchdata_including(type: 'requirement', reference: 'TOTO-0001', explicit_checksum: '~ab12')
             ).and_return(definition)
           )
           document.parse(input_lines)
@@ -66,7 +66,28 @@ RSpec.describe(DefMastership::Document) do
         it do
           expect(DefMastership::Definition).to(
             have_received(:new).with(
-              matchdata_including(type: 'requirement', reference: 'TOTO-0001', explicit_checksum: 'ab12')
+              matchdata_including(type: 'requirement', reference: 'TOTO-0001', explicit_checksum: '~ab12')
+            )
+          )
+        end
+      end
+
+      context 'when simple definition line with explicit version' do
+        let(:input_lines) { ['[define, requirement, TOTO-0001(pouet)]'] }
+
+        before do
+          allow(DefMastership::Definition).to(
+            receive(:new).with(
+              matchdata_including(type: 'requirement', reference: 'TOTO-0001', explicit_version: 'pouet')
+            ).and_return(definition)
+          )
+          document.parse(input_lines)
+        end
+
+        it do
+          expect(DefMastership::Definition).to(
+            have_received(:new).with(
+              matchdata_including(type: 'requirement', reference: 'TOTO-0001', explicit_version: 'pouet')
             )
           )
         end
@@ -503,6 +524,52 @@ RSpec.describe(DefMastership::Document) do
     end
   end
 
+  describe '#explicit_version?' do
+    let(:def1) { instance_double(DefMastership::Definition, 'definition') }
+    let(:def2) { instance_double(DefMastership::Definition, 'definition') }
+    let(:input_lines) do
+      [
+        '[define, requirement, TOTO-0001]',
+        'def one',
+        '',
+        '[define, requirement, TOTO-0002]',
+        'def two'
+      ]
+    end
+
+    before do
+      allow(DefMastership::Definition).to(receive(:new).twice.and_return(def1, def2))
+      allow(def1).to(receive(:labels)).and_return([])
+      allow(def2).to(receive(:labels)).and_return([])
+      allow(def1).to(receive(:<<).and_return(def1))
+      allow(def2).to(receive(:<<).and_return(def2))
+    end
+
+    context 'when no explicit version' do
+      before do
+        allow(def1).to(receive(:explicit_version)).and_return(nil)
+        allow(def2).to(receive(:explicit_version)).and_return(nil)
+        document.parse(input_lines)
+        document.explicit_version?
+      end
+
+      it { expect(def1).to(have_received(:explicit_version)) }
+      it { expect(def2).to(have_received(:explicit_version)) }
+      it { expect(document.explicit_version?).to(eq(false)) }
+    end
+
+    context 'when one req has explicit version' do
+      before do
+        allow(def1).to(receive(:explicit_version)).and_return(nil)
+        allow(def2).to(receive(:explicit_version)).and_return('toto')
+        document.parse(input_lines)
+        document.explicit_version?
+      end
+
+      it { expect(document.explicit_version?).to(eq(true)) }
+    end
+  end
+
   describe '#ref_to_def?' do
     let(:def1) { instance_double(DefMastership::Definition, 'definition') }
     let(:def2) { instance_double(DefMastership::Definition, 'definition') }
@@ -511,7 +578,7 @@ RSpec.describe(DefMastership::Document) do
         '[define, requirement, TOTO-0001]',
         'def one',
         '',
-        '[define, requirement, TOTO-0002(1234)]',
+        '[define, requirement, TOTO-0002(~1234)]',
         'def two'
       ]
     end

data/spec/unit/defmastership/update_def_checksum_line_modifier_spec.rb

@@ -51,17 +51,17 @@ RSpec.describe(DefMastership::UpdateDefChecksumLineModifier) do
     context 'when definition has the good type' do
       before do
         allow(document).to(receive(:ref_to_def).with('REFERENCE').and_return(definition))
-        allow(definition).to(receive(:sha256).and_return('abcd1234'))
+        allow(definition).to(receive(:sha256).and_return('~abcd1234'))
       end
 
       it do
         expect(linemodifier.replace('[define,requirement,REFERENCE]'))
-          .to(eq('[define,requirement,REFERENCE(abcd1234)]'))
+          .to(eq('[define,requirement,REFERENCE(~abcd1234)]'))
       end
 
       it do
-        expect(linemodifier.replace('[define,requirement,REFERENCE(bad)]'))
-          .to(eq('[define,requirement,REFERENCE(abcd1234)]'))
+        expect(linemodifier.replace('[define,requirement,REFERENCE(~bad)]'))
+          .to(eq('[define,requirement,REFERENCE(~abcd1234)]'))
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: defmastership
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.0.8
 platform: ruby
 authors:
 - Jérôme Arbez-Gindre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-27 00:00:00.000000000 Z
+date: 2021-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aruba
@@ -193,7 +193,8 @@ files:
 - defmastership.gemspec
 - defmastership.rdoc
 - features/changeref.feature
-- features/checksum.feature
+- features/definition_checksum.feature
+- features/definition_version.feature
 - features/defmastership.feature
 - features/export.feature
 - features/modify.feature