defmastership 1.0.17 → 1.0.19

data/config/rubocop.yml

@@ -1,44 +1,88 @@
-inherit_from: ../.rubocop.yml
+# The behavior of RuboCop can be controlled via the .rubocop.yml
+# configuration file. It makes it possible to enable/disable
+# certain cops (checks) and to alter their behavior if they accept
+# any parameters. The file can be placed either in your home
+# directory or in some project directory.
+#
+# RuboCop will start looking for the configuration file in the directory
+# where the inspected file is and continue its way up to the root directory.
+#
+# See https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md
 
 require:
+  - rubocop-performance
   - rubocop-rspec
+  - rubocop-rake
 
 AllCops:
-  TargetRubyVersion: 2.5.0
+  TargetRubyVersion: 2.7
+  EnabledByDefault: true
+  DisplayCopNames: true
 
-Metrics/BlockLength:
+Style/Copyright:
+  Enabled: true
+  Notice: 'Copyright (\(c\) )?202[0-9] Jerome Arbez-Gindre'
+  AutocorrectNotice: '# Copyright (c) 2023 Jerome Arbez-Gindre'
+
+Lint/ConstantResolution: # Not available ins rubocop 0.81
+  Enabled: false
+
+Style/DocumentationMethod:
+  Enabled: false
+
+Style/StringHashKeys :
+  Enabled: true
+  Exclude:
+    - '*.gemspec'
+    - 'spec/unit/def_mastership/batch_modifier_spec.rb'
+    - 'spec/unit/def_mastership/update_def_checksum_modifier_spec.rb'
+    - 'spec/unit/def_mastership/update_def_modifier_spec.rb'
+    - 'spec/unit/def_mastership/update_def_version_modifier_spec.rb'
+
+Style/MissingElse:
+  EnforcedStyle: case
+
+Metrics/ModuleLength :
   Exclude:
-  # Ignore RSpec DSL
-    - spec/**/*
-  # Ignore gemspec DSL
+    - 'spec/**/*'
+
+Metrics/BlockLength :
+  Exclude:
+    - 'spec/**/*'
     - '*.gemspec'
 
-# Naming/FileName:
-#   Exclude:
-#     - Rakefile
+Security/Eval :
+  Exclude:
+    - 'Rakefile'
+
+Style/ConstantVisibility :
+  Exclude:
+     # there is one unique explicit constant visibility for all
+     # constants
+    - 'lib/defmastership/constants.rb'
+
+# rubocop-rspec options
+RSpec/MessageExpectation :
+  Enabled: true
+
+RSpec/SpecFilePathFormat :
+  Enabled: true
 
-# Avoid more than `Max` levels of nesting.
-BlockNesting:
-  Max: 3
+RSpec/SpecFilePathSuffix :
+  Enabled: true
 
-# Align with the style guide.
-CollectionMethods:
-  PreferredMethods:
-    collect:  'map'
-    inject:   'reduce'
-    find:     'detect'
-    find_all: 'sélect'
+RSpec/NestedGroups:
+  Max: 4
 
-# Prefer #kind_of? over #is_a?
-ClassCheck:
-  EnforcedStyle: kind_of?
+Layout/RedundantLineBreak:
+  Enabled: false
 
-Security/Eval:
+Style/DisableCopsWithinSourceCodeDirective:
+  Enabled: true
   Exclude:
-    - Rakefile
+    - 'Gemfile'
+    - 'tasks/code_quality.rake'
 
-AlignHash:
-  EnforcedColonStyle: table
+Layout/EndOfLine:
+  EnforcedStyle: lf
 
-MessageSpies:
-  EnforcedStyle: receive

data/defmastership.gemspec

@@ -33,17 +33,9 @@ Gem::Specification.new do |spec|
   spec.rdoc_options << '--title defmastership' << '--main README.rdoc' << '-ri'
   spec.bindir = 'bin'
   spec.executables << 'defmastership'
-  spec.add_development_dependency('aruba', '~> 2')
-  spec.add_development_dependency('cucumber', '~> 8')
-  spec.add_development_dependency('rake', '~> 13')
-  spec.add_development_dependency('rdoc', '~> 6')
-  spec.add_development_dependency('rspec', '~> 3')
-  spec.add_development_dependency('rubocop', '1.50')
-  spec.add_development_dependency('rubocop-performance', '~> 1.17')
-  spec.add_development_dependency('rubocop-rake', '~> 0.6')
-  spec.add_development_dependency('rubocop-rspec', '~> 2.22')
-  spec.add_development_dependency('simplecov', '~> 0')
-  spec.add_runtime_dependency('aasm', '~> 5')
-  spec.add_runtime_dependency('asciidoctor', '~> 2')
-  spec.add_runtime_dependency('gli', '~> 2')
+  spec.add_dependency('aasm', '~> 5')
+  spec.add_dependency('asciidoctor', '~> 2')
+  spec.add_dependency('csv', '~> 3')
+  spec.add_dependency('git', '~> 1')
+  spec.add_dependency('gli', '~> 2')
 end

data/features/changeref.feature

@@ -20,7 +20,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "modifications.yml" should contain:
     """
     ---
@@ -53,7 +52,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "modifications.yml" should contain:
     """
     ---
@@ -87,7 +85,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "modifications.yml" should contain:
     """
     ---
@@ -122,7 +119,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications tata_or_titi thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "modifications.yml" should contain:
     """
     ---
@@ -160,7 +156,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc thedoc2.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "modifications.yml" should contain:
     """
     ---
@@ -200,7 +195,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0123]
@@ -232,7 +226,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc thedoc2.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0123]
@@ -263,7 +256,6 @@ Feature: The changeref command
     """
     When I successfully run `defmastership modify --modifications toto thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "modifications.yml" should contain:
     """
     ---

data/features/definition_checksum.feature

@@ -82,7 +82,6 @@ Feature: definition checksum
     Second line.",~b86dcbde
     """
     And the stdout should not contain anything
-    And the stderr should not contain anything
 
   Scenario: Change one modifier
     Given a file named "modifications.yml" with:
@@ -102,7 +101,6 @@ Feature: definition checksum
     """
     When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-TEMP-XXX1(~244eed18)]
@@ -129,7 +127,6 @@ Feature: definition checksum
     """
     When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-TEMP-XXX1(~244eed18)]
@@ -159,7 +156,6 @@ Feature: definition checksum
     Second line.",~b86dcbde
     """
     And the stdout should not contain anything
-    And the stderr should not contain anything
 
   Scenario: Checksum is calculated on included file in ref modification
     Given a file named "modifications.yml" with:
@@ -191,7 +187,6 @@ Feature: definition checksum
     --
     """
     And the stdout should not contain anything
-    And the stderr should not contain anything
 
   Scenario: Checksum take into account variables in CSV export
     Given a file named "thedoc.adoc" with:
@@ -211,9 +206,8 @@ Feature: definition checksum
     Second line.",~b86dcbde
     """
     And the stdout should not contain anything
-    And the stderr should not contain anything
 
-  Scenario: Checksum take into account variables in ref modification
+  Scenario: Checksum takes into account variables in ref modification
     Given a file named "modifications.yml" with:
     """
     ---
@@ -241,7 +235,35 @@ Feature: definition checksum
     --
     """
     And the stdout should not contain anything
-    And the stderr should not contain anything
+
+  Scenario: Checksum does not take into account bad variables definition
+    Given a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_checksum:
+      :type: update_def_checksum
+      :config:
+        :def_type: requirement
+    """
+    And a file named "thedoc.adoc" with:
+    """
+    :variable:multiline
+    [define, requirement, TOTO-0001]
+    --
+    Exemple of {variable} requirement.
+    Second line.
+    --
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(~2e7dd73e)]
+    --
+    Exemple of {variable} requirement.
+    Second line.
+    --
+    """
+    And the stdout should not contain anything
 
   Scenario: Checksum keep explicit version in ref modification
     Given a file named "modifications.yml" with:
@@ -261,7 +283,6 @@ Feature: definition checksum
     """
     When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-TEMP-XXX1(toto~244eed18)]
@@ -288,7 +309,6 @@ Feature: definition checksum
     """
     When I successfully run `defmastership modify --modifications update_requirement_checksum thedoc.adoc`
     Then the stdout should not contain anything
-    And the stderr should not contain anything
     And the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-TEMP-XXX1(toto~244eed18)]

data/features/definition_version.feature

@@ -1,9 +1,9 @@
-Feature: definitions version 
-  As a Responsible of definitions for a given document 
+Feature: definitions version
+  As a Responsible of definitions for a given document
   In order to detect handle versions definitions
   I want defmastership to export explicit versions in definitions
 
-  Scenario: Extract one definition with explicit version to CSV 
+  Scenario: Extract one definition with explicit version to CSV
     Given a file named "thedoc.adoc" with:
     """
     [define, requirement, TOTO-0001(pouet)]
@@ -20,9 +20,8 @@ Feature: definitions version
     Second line.",~b86dcbde,pouet
     """
     And the stdout should not contain anything
-    And the stderr should not contain anything
 
-  Scenario: Set initial explicit version when definition has changed 
+  Scenario: Set initial explicit version when definition has changed
     Given a file named "ref_doc.adoc" with:
     """
     [define, requirement, TOTO-0001]
@@ -49,7 +48,170 @@ Feature: definitions version
     """
     When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
     And the stdout should not contain anything
-    And the stderr should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(a)]
+    --
+    modified text.
+    --
+    """
+
+  Scenario: Set initial explicit version when definition has changed with multiple ref_files
+    Given a file named "ref_doc1.adoc" with:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text 1.
+    --
+    """
+    Given a file named "ref_doc2.adoc" with:
+    """
+    [define, requirement, TOTO-0002(z)]
+    --
+    initial text 2.
+    --
+    """
+    Given a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+
+    [define, requirement, TOTO-0002(whatever)]
+    --
+    modified text again.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: a
+        :ref_document: ['./ref_doc1.adoc', './ref_doc2.adoc']
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(a)]
+    --
+    modified text.
+    --
+
+    [define, requirement, TOTO-0002(aa)]
+    --
+    modified text again.
+    --
+    """
+
+  Scenario: Update explicit version based on git tag
+    Given I initialize a git repo
+    And a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text.
+    --
+    """
+    And I add and commit the "thedoc.adoc" file
+    And I set the "THE_TAG" tag
+    And a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: a
+        :ref_tag: 'THE_TAG'
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
+    Then the file "thedoc.adoc" should contain:
+    """
+    [define, requirement, TOTO-0001(a)]
+    --
+    modified text.
+    --
+    """
+
+  Scenario: Update explicit version based on git tag on a different git repo
+    And a file named "defmastership-example.adoc" with:
+    """
+    [define, whatever, WHATEVER-0001]
+    Simplest ever definition. !modified!
+    With a single paragraph.
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: whatever
+        :first_version: a
+        :ref_tag: 'TEST_UPDATE_VERSION'
+        :ref_repo: 'https://gitlab.com/defmastership/defmastership-example.git'
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version defmastership-example.adoc`
+    And the stdout should not contain anything
+    Then the file "defmastership-example.adoc" should contain:
+    """
+    [define, whatever, WHATEVER-0001(a)]
+    Simplest ever definition. !modified!
+    With a single paragraph.
+    """
+
+  Scenario: Update explicit version based on git tag and different filename
+    Given I initialize a git repo
+    And a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0001]
+    --
+    initial text.
+    --
+    """
+    And I add and commit the "ref_doc.adoc" file
+    And I set the "THE_TAG" tag
+    And I remove the file "ref_doc.adoc"
+    And a file named "thedoc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+    """
+    And a file named "ref_doc.adoc" with:
+    """
+    [define, requirement, TOTO-0001(whatever)]
+    --
+    modified text.
+    --
+    """
+    And a file named "modifications.yml" with:
+    """
+    ---
+    :update_requirement_version:
+      :type: update_def_version
+      :config:
+        :def_type: requirement
+        :first_version: a
+        :ref_document: ./ref_doc.adoc
+        :ref_tag: 'THE_TAG'
+    """
+    When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
+    And the stdout should not contain anything
     Then the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0001(a)]
@@ -85,7 +247,6 @@ Feature: definitions version
     """
     When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
     And the stdout should not contain anything
-    And the stderr should not contain anything
     Then the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0001]
@@ -121,7 +282,6 @@ Feature: definitions version
     """
     When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
     And the stdout should not contain anything
-    And the stderr should not contain anything
     Then the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0001(4)]
@@ -157,7 +317,6 @@ Feature: definitions version
     """
     When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
     And the stdout should not contain anything
-    And the stderr should not contain anything
     Then the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0001]
@@ -193,7 +352,6 @@ Feature: definitions version
     """
     When I successfully run `defmastership modify --modifications update_requirement_version thedoc.adoc`
     And the stdout should not contain anything
-    And the stderr should not contain anything
     Then the file "thedoc.adoc" should contain:
     """
     [define, requirement, TOTO-0001(a~abcd1234)]