defmastership 1.0.17 → 1.0.18

data/spec/unit/def_mastership/change_ref_modifier_spec.rb

@@ -1,76 +1,221 @@
 # Copyright (c) 2020 Jerome Arbez-Gindre
 # frozen_string_literal: true
 
-require('defmastership')
+require('defmastership/change_ref_modifier')
 
 RSpec.describe(DefMastership::ChangeRefModifier) do
-  subject(:modifier) do
-    described_class.new(
-      'fake config'
-    )
+  subject(:refchanger) { described_class.new({}) }
+
+  describe '.new' do
+    it { expect(described_class.ancestors).to(include(DefMastership::Modifier)) }
+    it { is_expected.not_to(be_nil) }
+    it { is_expected.to(have_attributes(from_regexp: '')) }
+    it { is_expected.to(have_attributes(to_template: '')) }
+    it { is_expected.to(have_attributes(next_ref:    0)) }
   end
 
-  let(:adoc_texts) do
-    {
-      'file1.adoc' => "file1 line1\nfile1 line2",
-      'file2.adoc' => "file2 line1\nfile2 line2"
-    }
+  describe '.replacement_methods' do
+    it { expect(described_class.replacement_methods).to(eq(%i[replace_refdef replace_irefs])) }
   end
 
-  describe '.new' do
-    it { is_expected.not_to(be_nil) }
-    it { is_expected.to(have_attributes(config: 'fake config')) }
-    it { is_expected.to(have_attributes(changes: [])) }
+  describe '#config' do
+    context 'when not initalized' do
+      it do
+        expect(refchanger.config).to(
+          include(from_regexp: '', to_template: '', next_ref: 0)
+        )
+      end
+    end
   end
 
-  describe '#do_modifications' do
-    let(:line_modifier) { instance_double(DefMastership::ChangeRefLineModifier, 'lineModifier') }
+  describe '#replace_def' do
+    context 'when really simple rule' do
+      subject(:refchanger) do
+        described_class.new(
+          from_regexp: 'TEMP',
+          to_template: 'TUTU'
+        )
+      end
 
-    before do
-      allow(DefMastership::ChangeRefLineModifier).to(
-        receive(:from_config).with('fake config').and_return(line_modifier)
-      )
-      allow(line_modifier).to(receive(:replace_refdef).with("file1 line1\n").and_return("new file1 line1\n"))
-      allow(line_modifier).to(receive(:replace_refdef).with('file1 line2').and_return('new file1 line2'))
-      allow(line_modifier).to(receive(:replace_refdef).with("file2 line1\n").and_return("new file2 line1\n"))
-      allow(line_modifier).to(receive(:replace_refdef).with('file2 line2').and_return('new file2 line2'))
-      allow(line_modifier).to(receive(:replace_irefs).with("new file1 line1\n").and_return("new2 file1 line1\n"))
-      allow(line_modifier).to(receive(:replace_irefs).with('new file1 line2').and_return('new2 file1 line2'))
-      allow(line_modifier).to(receive(:replace_irefs).with("new file2 line1\n").and_return("new2 file2 line1\n"))
-      allow(line_modifier).to(receive(:replace_irefs).with('new file2 line2').and_return('new2 file2 line2'))
-      allow(line_modifier).to(receive(:config).and_return('new fake config'))
-      allow(line_modifier).to(receive(:changes).and_return([%w[from1 to1], %w[from2 to2]]))
+      context 'when valid definition' do
+        it do
+          expect(refchanger.replace_refdef('[define, whatever, TEMP]'))
+            .to(eq('[define, whatever, TUTU]'))
+        end
+      end
+
+      context 'when no valid definition' do
+        it do
+          expect(refchanger.replace_refdef('[pouet, whatever, TEMP]'))
+            .to(eq('[pouet, whatever, TEMP]'))
+        end
+      end
     end
 
-    context 'when detailed expectations' do
-      before { modifier.do_modifications(adoc_texts) }
+    context 'when template is variable' do
+      subject(:refchanger) do
+        described_class.new(
+          from_regexp: 'TEMP',
+          to_template: 'TOTO-%<next_ref>04d',
+          next_ref: 124
+        )
+      end
 
       it do
-        expect(DefMastership::ChangeRefLineModifier).to(
-          have_received(:from_config).with('fake config')
+        expect(refchanger.replace_refdef('[define, whatever, TEMP]'))
+          .to(eq('[define, whatever, TOTO-0124]'))
+      end
+
+      it do
+        refchanger.replace_refdef('[define, whatever, TEMP]')
+        expect(refchanger).to(have_attributes(next_ref: 125))
+      end
+    end
+
+    context 'when capture group in regexp' do
+      subject(:refchanger) do
+        described_class.new(
+          from_regexp: '(?<cg>TOTO|TITI)-TEMP[\d]*',
+          to_template: '%<cg>s-%<next_ref>04d',
+          next_ref: 132
+        )
+      end
+
+      it do
+        expect(refchanger.replace_refdef('[define, whatever, TOTO-TEMP]'))
+          .to(eq('[define, whatever, TOTO-0132]'))
+      end
+
+      it do
+        refchanger.replace_refdef('[define, whatever, TOTO-TEMP]')
+        expect(refchanger.replace_refdef('[define, whatever, TITI-TEMP]'))
+          .to(eq('[define, whatever, TITI-0133]'))
+      end
+
+      it do
+        refchanger.replace_refdef('[define, whatever, TOTO-TEMP1]')
+        refchanger.replace_refdef('[define, whatever, TITI-TEMP2]')
+        expect(refchanger).to(have_attributes(changes: [%w[TOTO-TEMP1 TOTO-0132], %w[TITI-TEMP2 TITI-0133]]))
+      end
+    end
+
+    context 'when definition is in literal block' do
+      subject(:refchanger) do
+        described_class.new(
+          from_regexp: 'TEMP',
+          to_template: 'TUTU'
+        )
+      end
+
+      before do
+        refchanger.replace_refdef('....')
+      end
+
+      it do
+        expect(refchanger.replace_refdef('[define, whatever, TEMP]'))
+          .to(eq('[define, whatever, TEMP]'))
+      end
+    end
+
+    context 'when defintion is after literal block' do
+      subject(:refchanger) do
+        described_class.new(
+          from_regexp: 'TEMP',
+          to_template: 'TUTU'
         )
       end
 
-      it { expect(line_modifier).to(have_received(:replace_refdef).with("file1 line1\n")) }
-      it { expect(line_modifier).to(have_received(:replace_refdef).with('file1 line2')) }
-      it { expect(line_modifier).to(have_received(:replace_refdef).with("file2 line1\n")) }
-      it { expect(line_modifier).to(have_received(:replace_refdef).with('file2 line2')) }
-      it { expect(line_modifier).to(have_received(:replace_irefs).with("new file1 line1\n")) }
-      it { expect(line_modifier).to(have_received(:replace_irefs).with('new file1 line2')) }
-      it { expect(line_modifier).to(have_received(:replace_irefs).with("new file2 line1\n")) }
-      it { expect(line_modifier).to(have_received(:replace_irefs).with('new file2 line2')) }
-      it { expect(line_modifier).to(have_received(:config)) }
-      it { expect(line_modifier).to(have_received(:changes)) }
-      it { is_expected.to(have_attributes(config: 'new fake config')) }
-      it { is_expected.to(have_attributes(changes: [%w[from1 to1], %w[from2 to2]])) }
+      before do
+        refchanger.replace_refdef("....\n")
+        refchanger.replace_refdef('[define, whatever, TEMP]')
+        refchanger.replace_refdef("....\n")
+      end
+
+      it do
+        expect(refchanger.replace_refdef('[define, whatever, TEMP]'))
+          .to(eq('[define, whatever, TUTU]'))
+      end
+    end
+  end
+
+  describe '#replace_irefs' do
+    subject(:refchanger) do
+      described_class.new(
+        from_regexp: '(?<cg>TOTO|TITI)-TEMP[\d]*',
+        to_template: '%<cg>s-%<next_ref>04d',
+        next_ref: 132
+      )
+    end
+
+    before do
+      refchanger.replace_refdef('[define, whatever, TOTO-TEMP123]')
+      refchanger.replace_refdef('[define, whatever, TITI-TEMP421]')
+    end
+
+    it do
+      expect(refchanger.replace_irefs('defs:iref[TOTO-TEMP1234]'))
+        .to(eq('defs:iref[TOTO-TEMP1234]'))
+    end
+
+    it do
+      expect(refchanger.replace_irefs('defs:iref[TOTO-TEMP123]'))
+        .to(eq('defs:iref[TOTO-0132]'))
+    end
+
+    it do
+      expect(
+        refchanger.replace_irefs(
+          'defs:iref[TOTO-TEMP123] defs:iref[TITI-TEMP421] bla'
+        )
+      ).to(eq('defs:iref[TOTO-0132] defs:iref[TITI-0133] bla'))
+    end
+
+    it do
+      expect(
+        refchanger.replace_irefs(
+          'defs:iref[TOTO-TEMP123] defs:iref[TOTO-TEMP123] bla'
+        )
+      ).to(eq('defs:iref[TOTO-0132] defs:iref[TOTO-0132] bla'))
+    end
+  end
+
+  describe '#replace' do
+    subject(:refchanger) do
+      described_class.new(
+        from_regexp: 'TEMP',
+        to_template: 'TUTU'
+      )
+    end
+
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP]'))
+        .to(eq('[define, whatever, TUTU]'))
+    end
+
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP(a~12345678)]'))
+        .to(eq('[define, whatever, TUTU(a~12345678)]'))
+    end
+
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP(~12345678)]'))
+        .to(eq('[define, whatever, TUTU(~12345678)]'))
+    end
+
+    it do
+      expect(refchanger.replace(:refdef, '[define, whatever, TEMP(a)]'))
+        .to(eq('[define, whatever, TUTU(a)]'))
+    end
+
+    it do
+      refchanger.replace(:refdef, '[define, whatever, TEMP]')
+      expect(refchanger.replace(:irefs, 'defs:iref[TEMP] defs:iref[TEMP]'))
+        .to(eq('defs:iref[TUTU] defs:iref[TUTU]'))
     end
 
     it do
-      expected_adoc = {
-        'file1.adoc' => "new2 file1 line1\nnew2 file1 line2",
-        'file2.adoc' => "new2 file2 line1\nnew2 file2 line2"
-      }
-      expect(modifier.do_modifications(adoc_texts)).to(eq(expected_adoc))
+      expect { refchanger.replace(:pouet, 'whatever') }
+        .to(raise_error(NoMethodError))
     end
   end
 end

data/spec/unit/def_mastership/csv_formatter_body_spec.rb

@@ -1,10 +1,10 @@
 # Copyright (c) 2020 Jerome Arbez-Gindre
 # frozen_string_literal: true
 
-require('defmastership')
+require('defmastership/csv_formatter_body')
 
 RSpec.describe(DefMastership::CSVFormatterBody) do
-  subject(:formatter) { described_class.new(document) }
+  subject(:formatter) { described_class.new(document, definition) }
 
   let(:document)   { instance_double(DefMastership::Document, 'document')     }
   let(:definition) { instance_double(DefMastership::Definition, 'definition') }
@@ -18,35 +18,35 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
       allow(definition).to(receive(:type).with(no_args).and_return('a'))
       allow(definition).to(receive(:reference).with(no_args).and_return('b'))
       allow(definition).to(receive(:value).with(no_args).and_return('c'))
-      allow(definition).to(receive(:sha256).with(no_args).and_return('d'))
-      formatter.fixed(definition)
+      allow(definition).to(receive(:sha256_short).with(no_args).and_return('d'))
+      formatter.fixed
     end
 
     it { expect(definition).to(have_received(:type).with(no_args)) }
     it { expect(definition).to(have_received(:reference).with(no_args)) }
     it { expect(definition).to(have_received(:value).with(no_args)) }
-    it { expect(definition).to(have_received(:sha256).with(no_args)) }
-    it { expect(formatter.fixed(definition)).to(eq(%w[a b c d])) }
+    it { expect(definition).to(have_received(:sha256_short).with(no_args)) }
+    it { expect(formatter.fixed).to(eq(%w[a b c d])) }
   end
 
   describe '#wrong_explicit_checksum' do
     context 'when no wrong_explicit checksum' do
       before do
         allow(definition).to(receive(:wrong_explicit_checksum).with(no_args).and_return(nil))
-        formatter.wrong_explicit_checksum(definition)
+        formatter.wrong_explicit_checksum
       end
 
       it { expect(definition).to(have_received(:wrong_explicit_checksum).with(no_args)) }
-      it { expect(formatter.wrong_explicit_checksum(definition)).to(eq([''])) }
+      it { expect(formatter.wrong_explicit_checksum).to(eq([''])) }
     end
 
     context 'when explicit checksum' do
       before do
         allow(definition).to(receive(:wrong_explicit_checksum).with(no_args).and_return('ab12'))
-        formatter.wrong_explicit_checksum(definition)
+        formatter.wrong_explicit_checksum
       end
 
-      it { expect(formatter.wrong_explicit_checksum(definition)).to(eq(['ab12'])) }
+      it { expect(formatter.wrong_explicit_checksum).to(eq(['ab12'])) }
     end
   end
 
@@ -54,20 +54,20 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
     context 'when no explicit_version' do
       before do
         allow(definition).to(receive(:explicit_version).with(no_args).and_return(nil))
-        formatter.explicit_version(definition)
+        formatter.explicit_version
       end
 
       it { expect(definition).to(have_received(:explicit_version).with(no_args)) }
-      it { expect(formatter.explicit_version(definition)).to(eq([''])) }
+      it { expect(formatter.explicit_version).to(eq([''])) }
     end
 
     context 'when explicit_version' do
       before do
         allow(definition).to(receive(:explicit_version).with(no_args).and_return('ab12'))
-        formatter.explicit_version(definition)
+        formatter.explicit_version
       end
 
-      it { expect(formatter.explicit_version(definition)).to(eq(['ab12'])) }
+      it { expect(formatter.explicit_version).to(eq(['ab12'])) }
     end
   end
 
@@ -77,21 +77,21 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
     context 'when no labels on definition' do
       before do
         allow(definition).to(receive(:labels).with(no_args).and_return([]))
-        formatter.labels(definition)
+        formatter.labels
       end
 
       it { expect(definition).to(have_received(:labels).once.with(no_args)) }
-      it { expect(formatter.labels(definition)).to(eq([''])) }
+      it { expect(formatter.labels).to(eq([''])) }
     end
 
     context 'when labels on definition' do
       before do
-        allow(definition).to(receive(:labels).with(no_args).and_return(%w[toto tutu]))
-        formatter.labels(definition)
+        allow(definition).to(receive(:labels).with(no_args).and_return(%w[toto tutu].to_set))
+        formatter.labels
       end
 
       it { expect(definition).to(have_received(:labels).once.with(no_args)) }
-      it { expect(formatter.labels(definition)).to(eq(["toto\ntutu"])) }
+      it { expect(formatter.labels).to(eq(["toto\ntutu"])) }
     end
   end
 
@@ -99,11 +99,11 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
     context 'when no eref on the document' do
       before do
         allow(document).to(receive(:eref).with(no_args).and_return({}))
-        formatter.eref(definition)
+        formatter.eref
       end
 
       it { expect(document).to(have_received(:eref).with(no_args)) }
-      it { expect(formatter.eref(nil)).to(eq([])) }
+      it { expect(formatter.eref).to(eq([])) }
     end
 
     context 'when eref on the document' do
@@ -114,11 +114,26 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
           )
         )
         allow(definition).to(receive(:eref).with(no_args).and_return(a: %w[A B], b: [], c: ['C']))
-        formatter.eref(definition)
+        formatter.eref
       end
 
       it { expect(definition).to(have_received(:eref).exactly(3).times.with(no_args)) }
-      it { expect(formatter.eref(definition)).to(eq(["A\nB", '', 'C'])) }
+      it { expect(formatter.eref).to(eq(["A\nB", '', 'C'])) }
+    end
+
+    context 'when missing eref on the definition' do
+      before do
+        allow(document).to(
+          receive(:eref).with(no_args).and_return(
+            a: 'whatever', b: 'whatever'
+          )
+        )
+        allow(definition).to(receive(:eref).with(no_args).and_return(b: ['B']))
+        formatter.eref
+      end
+
+      it { expect(definition).to(have_received(:eref).exactly(2).times.with(no_args)) }
+      it { expect(formatter.eref).to(eq(['', 'B'])) }
     end
   end
 
@@ -128,21 +143,21 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
     context 'when no iref on the definition' do
       before do
         allow(definition).to(receive(:iref).with(no_args).and_return([]))
-        formatter.iref(definition)
+        formatter.iref
       end
 
       it { expect(definition).to(have_received(:iref).with(no_args)) }
-      it { expect(formatter.iref(definition)).to(eq([''])) }
+      it { expect(formatter.iref).to(eq([''])) }
     end
 
     context 'when iref on the definition' do
       before do
         allow(definition).to(receive(:iref).with(no_args).and_return(%w[A B]))
-        formatter.iref(definition)
+        formatter.iref
       end
 
       it { expect(definition).to(have_received(:iref).with(no_args)) }
-      it { expect(formatter.iref(definition)).to(eq(["A\nB"])) }
+      it { expect(formatter.iref).to(eq(["A\nB"])) }
     end
   end
 
@@ -150,11 +165,11 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
     context 'when no attributes on the document' do
       before do
         allow(document).to(receive(:attributes).with(no_args).and_return({}))
-        formatter.attributes(definition)
+        formatter.attributes
       end
 
       it { expect(document).to(have_received(:attributes).with(no_args)) }
-      it { expect(formatter.attributes(nil)).to(eq([])) }
+      it { expect(formatter.attributes).to(eq([])) }
     end
 
     context 'when attributes on the document' do
@@ -164,11 +179,25 @@ RSpec.describe(DefMastership::CSVFormatterBody) do
             .and_return(a: 'whatever', b: 'whatever', c: 'whatever')
         )
         allow(definition).to(receive(:attributes).and_return(a: 'X', b: '', c: 'Y'))
-        formatter.attributes(definition)
+        formatter.attributes
+      end
+
+      it { expect(definition).to(have_received(:attributes).exactly(3).times) }
+      it { expect(formatter.attributes).to(eq(['X', '', 'Y'])) }
+    end
+
+    context 'when miing attribute on the definition' do
+      before do
+        allow(document).to(
+          receive(:attributes).with(no_args)
+            .and_return(a: 'whatever', b: 'whatever', c: 'whatever')
+        )
+        allow(definition).to(receive(:attributes).and_return(a: 'X', b: ''))
+        formatter.attributes
       end
 
       it { expect(definition).to(have_received(:attributes).exactly(3).times) }
-      it { expect(formatter.attributes(definition)).to(eq(['X', '', 'Y'])) }
+      it { expect(formatter.attributes).to(eq(['X', '', ''])) }
     end
   end
 end

data/spec/unit/def_mastership/csv_formatter_header_spec.rb

@@ -1,7 +1,7 @@
 # Copyright (c) 2020 Jerome Arbez-Gindre
 # frozen_string_literal: true
 
-require('defmastership')
+require('defmastership/csv_formatter_header')
 
 RSpec.describe(DefMastership::CSVFormatterHeader) do
   subject(:formatter) { described_class.new(document) }