deferring 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 063adf3aca91473f0ca98264db2447d2e1811bdf
-  data.tar.gz: 2ad2362263132b43e35bdf4c64abc8e15b109821
+  metadata.gz: a3f9cfb39bdad6c3d5e0c4f9e98e338dabe64b1c
+  data.tar.gz: 9555e0057cc0930aebdb32de04b4303bc2aa35a5
 SHA512:
-  metadata.gz: e4e49d6d106f758823de3516ce6fc5e3f93511f9e5c0161174a4bd8573eb1ae508570449490267a4e4e7aee49d9da0d8734f632ba1d03b9c5e965600a54c0ab6
-  data.tar.gz: 03dcc4ef9d7c2f4ed0cc0bb156dea1c4cb7b5551bfc70b6c0bb1a8756f5d792458942d375c7c363072968d138ab63e74c1d3b7c1d790577ef3538cb3d2f9094f
+  metadata.gz: 4913b6ef30424be10cf8ba5255ec0c86a502adddc687970d2f986d9f01fc9219c491650e8bf10d8b5d1737b2cb7283edd79e908125e01f5c59c0dc1e4c1d9a1b
+  data.tar.gz: 92f38c9128d3549e3c38eb933f88f9f7c89ea124b679941e2c21fc470d2e768a27b8b828f578e0f6af78e24052da2fcc0bce3aee9d44bc34b62594c7efb6ca65

data/lib/deferring.rb

@@ -47,7 +47,6 @@ module Deferring
 
   def deferred_accepts_nested_attributes_for(*args)
     options = args.extract_options!
-    inverse_association_name = options.fetch(:as, self.name.underscore.to_sym)
     reject_if = options.delete(:reject_if)
     accepts_nested_attributes_for(*args, options)
 
@@ -55,8 +54,6 @@ module Deferring
 
     # teams_attributes=
     define_method :"#{association_name}_attributes=" do |attributes_collection|
-      find_or_create_deferred_association(association_name, [], inverse_association_name)
-
       unless attributes_collection.is_a?(Hash) || attributes_collection.is_a?(Array)
         raise ArgumentError, "Hash or Array expected, got #{attributes_collection.class.name} (#{attributes_collection.inspect})"
       end

data/lib/deferring/version.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
 
 module Deferring
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/lib/deferring_has_many_spec.rb

@@ -350,4 +350,41 @@ RSpec.describe 'deferred has_many associations' do
       end
     end
   end # active record api
+
+  describe 'polymorphic association' do
+    it 'sets the parent on the associated record before saving' do
+      bob = Person.where(name: 'Bob').first
+      bob.addresses << Address.new(street: '221B Baker St.')
+
+      address = bob.addresses[0]
+      expect(address.addressable).to eq(bob)
+      expect(address.addressable_id).to eq(bob.id)
+      expect(address.addressable_type).to eq('Person')
+    end
+
+    it 'adds the associated record' do
+      bob = Person.where(name: 'Bob').first
+      bob.addresses << Address.new(street: '221B Baker St.')
+      bob.save!
+
+      bob.reload
+      address = bob.addresses[0]
+      expect(address.street).to eq('221B Baker St.')
+    end
+
+    context 'when using nested attributes' do
+      it 'sets the parent on the associated record before saving' do
+        bob = Person.where(name: 'Bob').first
+        bob.attributes = {
+          addresses_attributes: [{ street: '221B Baker St.' }]
+        }
+
+        address = bob.addresses[0]
+        expect(address.addressable).to eq(bob)
+        expect(address.addressable_id).to eq(bob.id)
+        expect(address.addressable_type).to eq('Person')
+        expect(address.street).to eq('221B Baker St.')
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ require 'deferring'
 require 'support/models/person'
 require 'support/models/team'
 require 'support/models/issue'
+require 'support/models/address'
 require 'support/models/non_validated_issue'
 require 'support/rails_versions'
 

data/spec/support/active_record.rb

@@ -25,6 +25,13 @@ ActiveRecord::Schema.define version: 0 do
     t.timestamps
   end
 
+  create_table :addresses do |t|
+    t.integer :addressable_id
+    t.string :addressable_type
+    t.string :street
+    t.timestamps
+  end
+
   create_table :non_validated_issues do |t|
     t.string :subject
     t.integer :person_id

data/spec/support/models/address.rb

@@ -0,0 +1,5 @@
+class Address < ActiveRecord::Base
+
+  belongs_to :addressable, polymorphic: true
+
+end

data/spec/support/models/person.rb

@@ -19,6 +19,11 @@ class Person < ActiveRecord::Base
                                   after_remove: :removed_issue,
                                   validate: false
 
+  # Polymorphic has-many association
+  deferred_has_many :addresses, as: :addressable,
+                                autosave: true,
+                                dependent: :delete_all
+  deferred_accepts_nested_attributes_for :addresses, allow_destroy: true
 
   validates_presence_of :name
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deferring
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Robin Roestenburg
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-20 00:00:00.000000000 Z
+date: 2015-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -128,6 +128,7 @@ files:
 - spec/lib/deferring_nested_attributes_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb
+- spec/support/models/address.rb
 - spec/support/models/issue.rb
 - spec/support/models/non_validated_issue.rb
 - spec/support/models/person.rb
@@ -163,6 +164,7 @@ test_files:
 - spec/lib/deferring_nested_attributes_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb
+- spec/support/models/address.rb
 - spec/support/models/issue.rb
 - spec/support/models/non_validated_issue.rb
 - spec/support/models/person.rb