default_value_for 3.5.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0662d4b20e5e4b6b68dbf06c16c05e9fc500250c99f6921d3c1338ed8bb3239f
-  data.tar.gz: 443f8a0c84c6b2454bca0380447b49bebbd3f3db7f7c4996df995c7136a57f5e
+  metadata.gz: 0e4ad2e33ddca870f51f8a1c4aef12281b2cc0fe679834eaebb33f6691434431
+  data.tar.gz: 862a55e06fbca022177db11193eca2572174891375510010a7e6e074a870e9e6
 SHA512:
-  metadata.gz: a2b0537c383b74d3df225ce18b91fbd53889b6e3ce0fda3bac9f5b10ff5dd4ff834be8500d1ee21db9d0db507da04edeafbac73ddd6c7821193d4adb1dab7fe5
-  data.tar.gz: 5272f4005b237bcf80502881651a113216b8136a112aeefbbc10cea4b4bd77dabafccd01e455f1a0fb0165b5b84f0d0e270ecb836a20ffaa8480cc3d7cf0faeb
+  metadata.gz: d24e7cded2995ee32877835bc8ff4eb8eccad4ee68447d5c66c869932d61fe6ef50807b88a14e64f93f8dcd9d4cb6b85fd1730f490e2266c9ffc16ca0a57054c
+  data.tar.gz: '050180f430ef62cdf88390ebe32adad62b862dbc6f7000c82ae73a286a571f6159035c258f1488864fe5f9507524c33124dd4aa633ae55210194eca0abc866f6'

data/README.md

@@ -20,21 +20,35 @@ u.last_seen  # => Mon Sep 22 17:28:38 +0200 2008
 
 ## Installation
 
-### Rails 3.2 - 4.2 / Ruby 1.9.3 and higher
+### On Rails 6.1+ / Ruby 3.0+
 
-The current version of default_value_for (3.x+) is compatible with Rails 3.2 or higher, and Ruby 1.9.3 and higher.
+The objective is to support all supported rubies and rails versions.  If you need to support end of life versions, please see the sections below and use a prior release.
 
 Add it to your Gemfile:
 
 ```ruby
-gem "default_value_for", "~> 3.0"
+gem "default_value_for", "~> 4.0"
 ```
 
-This gem is signed using PGP with the Phusion Software Signing key: http://www.phusion.nl/about/gpg. That key in turn is signed by the rubygems-openpgp Certificate Authority: http://www.rubygems-openpgp-ca.org/.
+Version 4.0.0 supports rails 6.1+ and ruby 3.0+. It adds support for rails 7.2. It drops support for rubies less than 3.0 and rails less than 6.1.  This is the reason for the major version bump as it drops support for many combinations of older ruby and rails versions.
+
+### On Rails 3.2 - 6.0 / Ruby 1.9.3 - 2.7
+
+To use default_value_for with older versions of Ruby and Rails, you must use the previous stable release, 3.6.0 or others in the 3.x.y release. This version works with Rails 3.0, 3.1, and 3.2; and Ruby 1.8.7 and higher. It **does not** work with Rails 4.
+
+default_value_for (3.x+) is compatible with Rails 3.2-6.1, and Ruby 1.9.3 and higher.
+
+Note:
+* Version 3.5.0: Added basic rails 7.0 support
+* Version 3.6.0: Added basic rails 7.1 support
 
-You can verify the authenticity of the gem by following The Complete Guide to Verifying Gems with rubygems-openpgp: http://www.rubygems-openpgp-ca.org/blog/the-complete-guide-to-verifying-gems-with-rubygems-openpgp.html
+Add it to your Gemfile:
+
+```ruby
+gem "default_value_for", "~> 3.0"
+```
 
-## Rails 3.0 - 3.1 / Ruby 1.9.3 and lower
+## On Rails 3.0 - 3.1 / Ruby 1.9.3 and lower
 
 To use default_value_for with older versions of Ruby and Rails, you must use the previous stable release, 2.0.3. This version works with Rails 3.0, 3.1, and 3.2; and Ruby 1.8.7 and higher. It **does not** work with Rails 4.
 
@@ -42,7 +56,7 @@ To use default_value_for with older versions of Ruby and Rails, you must use the
 gem "default_value_for", "~> 2.0.3"
 ```
 
-### Rails 2
+### On Rails 2
 
 To use default_value_for with Rails 2.x you must use an older version:
 
@@ -346,25 +360,30 @@ class User < ActiveRecord::Base
 end
 ```
 
-We recommend you to alias chain your initialize method in models where you use `default_value_for`:
+We recommend you to use Module#prepend in models where you use `default_value_for`:
 
 ```ruby
-class User < ActiveRecord::Base
-  default_value_for :age, 20
-
-  def initialize_with_my_app
-    initialize_without_my_app(:name => 'Name cannot be changed in constructor')
+module UserCustomInitialize
+  def initialize
+    # Do your pre-initialize work
+    super
+    # Do any post-initialize work
   end
+end
+```
 
-  alias_method_chain :initialize, :my_app
+```ruby
+class User < ActiveRecord::Base
+  default_value_for :age, 20
+  prepend UserCustomInitialize
 end
 ```
 
-Also, stick with the following rules:
+Also, take the following precautions:
 
-* There is no need to +alias_method_chain+ your initialize method in models that don't use `default_value_for`.
+* Make sure you always call super in your prepended method.
 
-* Make sure that +alias_method_chain+ is called *after* the last `default_value_for` occurrence.
+* It's generally safer to call super first and do your customizations afterwards to ensure everything is setup first.
 
 If your default value is accidentally similar to default_value_for's options hash wrap your default value like this:
 
@@ -537,13 +556,21 @@ That's an awful lot of code. Using `default_value_for` is easier, don't you thin
 
 ### What about other plugins?
 
-I've only been able to find 2 similar plugins:
+There are other ways to accomplish similar results as `default_value_for`.
+
+From Rails:
+* [attribute default](https://api.rubyonrails.org/classes/ActiveRecord/Attributes/ClassMethods.html#method-i-attribute)
+* [schema migration column defaults](https://edgeguides.rubyonrails.org/active_record_migrations.html)
 
-* Default Value: http://agilewebdevelopment.com/plugins/default_value
+Other plugins:
+* [Defaults](https://github.com/fnando/defaults)
+* [attribute-defaults](https://github.com/bsm/attribute-defaults)
+* [has_defaults](https://github.com/makandra/has_defaults)
 
-* ActiveRecord Defaults: http://agilewebdevelopment.com/plugins/activerecord_defaults
+Each of these has limitations and should be evaluated based on your use cases.  Two areas where `default_value_for` excels is deriving
+defaults based on the current object or determining the behavior for `nil` values.
 
-'Default Value' appears to be unmaintained; its SVN link is broken. This leaves only 'ActiveRecord Defaults'. However, it is semantically dubious, which leaves it wide open for corner cases. For example, it is not clearly specified what ActiveRecord Defaults will do when attributes are protected by +attr_protected+ or +attr_accessible+. It is also not clearly specified what one is supposed to do if one needs a custom +initialize+ method in the model.
+If there are other options or uses cases where you've found this gem or another one is useful, please open a pull request to update this page.
 
 I've taken my time to thoroughly document default_value_for's behavior.
 

data/Rakefile

@@ -1,6 +1,5 @@
 task :default => :test
 
-require 'bundler'
 require "bundler/gem_tasks"
 
 desc "Run unit tests."
@@ -9,16 +8,9 @@ task :test do
 end
 
 rails_versions = %w(
-  3.2
-  4.0
-  4.1
-  4.2
-  5.0
-  5.1
-  5.2
-  6.0
   6.1
   7.0
+  7.1
 )
 
 rails_versions.each do |version|

data/default_value_for.gemspec

@@ -1,23 +1,24 @@
 Gem::Specification.new do |s|
   s.name                  = %q{default_value_for}
-  s.version               = "3.5.0"
+  s.version               = "4.0.0"
   s.summary               = %q{Provides a way to specify default values for ActiveRecord models}
   s.description           = %q{The default_value_for plugin allows one to define default values for ActiveRecord models in a declarative manner}
   s.email                 = %q{software-signing@phusion.nl}
   s.homepage              = %q{https://github.com/FooBarWidget/default_value_for}
   s.authors               = ["Hongli Lai"]
   s.license               = 'MIT'
-  s.required_ruby_version = '>= 1.9.3'
+  s.required_ruby_version = '>= 3.0.0'
   s.files                 = ['default_value_for.gemspec',
     'LICENSE.TXT', 'Rakefile', 'README.md', 'test.rb',
     'init.rb',
     'lib/default_value_for.rb',
     'lib/default_value_for/railtie.rb'
   ]
-  s.add_dependency 'activerecord', '>= 3.2.0', '< 7.1'
-  s.add_development_dependency 'actionpack', '>= 3.2.0', '< 7.1'
-  s.add_development_dependency 'railties', '>= 3.2.0', '< 7.1'
-  s.add_development_dependency 'minitest', '>= 4.2'
+  s.add_dependency 'activerecord', '>= 6.1', '< 7.3'
+  s.add_development_dependency 'actionpack', '>= 6.1', '< 7.3'
+  s.add_development_dependency 'railties', '>= 6.1', '< 7.3'
+  s.add_development_dependency 'minitest', '>= 5.0'
   s.add_development_dependency 'minitest-around'
   s.add_development_dependency 'appraisal'
+  s.add_development_dependency 'bundler'
 end

data/test.rb

@@ -60,18 +60,19 @@ if rails_2_4_or_newer && arel_older_than_7_1
   end
 end
 
-begin
-  TestCaseClass = MiniTest::Test
-rescue NameError
-  TestCaseClass = MiniTest::Unit::TestCase
-end
-
 require 'default_value_for'
 
+puts "\nTesting with ruby version #{RUBY_VERSION}"
 puts "\nTesting with Active Record version #{ActiveRecord::VERSION::STRING}"
 puts "\nTesting with Action Pack version #{ActionPack::VERSION::STRING}\n\n"
 
-ActiveRecord::Base.default_timezone = :local
+if ActiveRecord.respond_to?(:default_timezone)
+  ActiveRecord.default_timezone = :local
+else
+  # Deprecated in rails 7.0, removed in 7.1
+  ActiveRecord::Base.default_timezone = :local
+end
+
 ActiveRecord::Base.logger           = Logger.new(STDERR)
 ActiveRecord::Base.logger.level     = Logger::WARN
 
@@ -101,7 +102,7 @@ if defined?(Rails::Railtie)
   DefaultValueFor.initialize_active_record_extensions
 end
 
-class DefaultValuePluginTest < TestCaseClass
+class DefaultValuePluginTest < Minitest::Test
   def around
     Object.const_set(:User, Class.new(ActiveRecord::Base))
     Object.const_set(:Book, Class.new(ActiveRecord::Base))
@@ -291,6 +292,25 @@ class DefaultValuePluginTest < TestCaseClass
     assert object.instance_variable_get('@initialized')
   end
 
+  def test_doesnt_conflict_with_prependeed_initialize_method_in_model_class
+    m = Object.const_set("BookOverride", Module.new)
+    m.define_method(:initialize) do |*args|
+      @initialized = true
+      super(:count => 5678)
+    end
+
+    Book.class_eval do
+      prepend BookOverride
+
+      default_value_for :number, 1234
+    end
+
+    object = Book.new
+    assert_equal 1234, object.number
+    assert_equal 5678, object.count
+    assert object.instance_variable_get('@initialized')
+  end
+
   def test_model_instance_is_passed_to_the_given_block
     instance = nil
     Book.default_value_for :number do |n|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: default_value_for
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Hongli Lai
@@ -16,74 +16,74 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.3'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.3'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.3'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: minitest-around
   requirement: !ruby/object:Gem::Requirement
@@ -112,6 +112,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: The default_value_for plugin allows one to define default values for
   ActiveRecord models in a declarative manner
 email: software-signing@phusion.nl
@@ -139,14 +153,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.27
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Provides a way to specify default values for ActiveRecord models