deepl-rb 2.5.3 → 3.0.1

data/spec/requests/glossary/entries_spec.rb

@@ -1,16 +1,26 @@
+# Copyright 2022 Daniel Herzog
+# Use of this source code is governed by an MIT
+# license that can be found in the LICENSE.md file.
 # frozen_string_literal: true
 
 require 'spec_helper'
 
 describe DeepL::Requests::Glossary::Entries do
+  subject(:entries_obj) { described_class.new(api, id) }
+
+  around do |tests|
+    tmp_env = replace_env_preserving_deepl_vars_except_mock_server
+    tests.call
+    ENV.replace(tmp_env)
+  end
+
   let(:api) { build_deepl_api }
-  let(:id) { '012a5576-b551-4d4c-b917-ce01bc8debb6' }
-  subject { DeepL::Requests::Glossary::Entries.new(api, id) }
+  let(:id) { '9ab5dac2-b7b2-4b4a-808a-e8e305df5ecb' }
 
   describe '#initialize' do
-    context 'When building a request' do
-      it 'should create a request object' do
-        expect(subject).to be_a(described_class)
+    context 'when building a request' do
+      it 'creates a request object' do
+        expect(entries_obj).to be_a(described_class)
       end
     end
   end
@@ -20,28 +30,32 @@ describe DeepL::Requests::Glossary::Entries do
       VCR.use_cassette('glossaries') { example.call }
     end
 
-    context 'When performing a valid request' do
-      it 'should return a list of entries in TSV format' do
-        entries = subject.request
-        expect(entries).to be_kind_of(Array)
+    context 'when performing a valid request' do
+      it 'returns a list of entries in TSV format' do
+        entries = entries_obj.request
+        expect(entries).to be_a(Array)
         expect(entries).to all(be_a(Array))
         expect(entries.size).to eq(2)
       end
     end
 
-    context 'When requesting entries with a valid but non existing glossary id' do
+    context 'when requesting entries with a valid but non existing glossary id' do
+      subject(:entries_obj) { described_class.new(api, id) }
+
       let(:id) { '00000000-0000-0000-0000-000000000000' }
-      subject { DeepL::Requests::Glossary::Entries.new(api, id) }
-      it 'should raise a not found error' do
-        expect { subject.request }.to raise_error(DeepL::Exceptions::NotFound)
+
+      it 'raises a not found error' do
+        expect { entries_obj.request }.to raise_error(DeepL::Exceptions::NotFound)
       end
     end
 
-    context 'When requesting entries with an invalid glossary id' do
+    context 'when requesting entries with an invalid glossary id' do
+      subject(:entries_obj) { described_class.new(api, id) }
+
       let(:id) { 'invalid-uuid' }
-      subject { DeepL::Requests::Glossary::Entries.new(api, id) }
-      it 'should raise a bad request error' do
-        expect { subject.request }.to raise_error(DeepL::Exceptions::BadRequest)
+
+      it 'raises a bad request error' do
+        expect { entries_obj.request }.to raise_error(DeepL::Exceptions::BadRequest)
       end
     end
   end

data/spec/requests/glossary/find_spec.rb

@@ -1,17 +1,27 @@
+# Copyright 2022 Daniel Herzog
+# Use of this source code is governed by an MIT
+# license that can be found in the LICENSE.md file.
 # frozen_string_literal: true
 
 require 'spec_helper'
 
 describe DeepL::Requests::Glossary::Find do
+  subject(:glossary_find) { described_class.new(api, id, options) }
+
+  around do |tests|
+    tmp_env = replace_env_preserving_deepl_vars_except_mock_server
+    tests.call
+    ENV.replace(tmp_env)
+  end
+
   let(:api) { build_deepl_api }
-  let(:id) { 'd9ad833f-c818-430c-a3c9-47071384fa3e' }
+  let(:id) { '9ab5dac2-b7b2-4b4a-808a-e8e305df5ecb' }
   let(:options) { {} }
-  subject { DeepL::Requests::Glossary::Find.new(api, id, options) }
 
   describe '#initialize' do
-    context 'When building a request' do
-      it 'should create a request object' do
-        expect(subject).to be_a(described_class)
+    context 'when building a request' do
+      it 'creates a request object' do
+        expect(glossary_find).to be_a(described_class)
       end
     end
   end
@@ -21,11 +31,11 @@ describe DeepL::Requests::Glossary::Find do
       VCR.use_cassette('glossaries') { example.call }
     end
 
-    context 'When performing a valid request' do
-      it 'should return a glossary object' do
-        glossary = subject.request
+    context 'when performing a valid request' do
+      it 'returns a glossary object' do
+        glossary = glossary_find.request
         expect(glossary).to be_a(DeepL::Resources::Glossary)
-        expect(glossary.id).to eq('d9ad833f-c818-430c-a3c9-47071384fa3e')
+        expect(glossary.id).to eq('9ab5dac2-b7b2-4b4a-808a-e8e305df5ecb')
         expect(glossary.name).to eq('Mi Glosario')
         expect(glossary.ready).to be(true).or be(false)
         expect(glossary.source_lang).to eq('en')
@@ -35,19 +45,23 @@ describe DeepL::Requests::Glossary::Find do
       end
     end
 
-    context 'When requesting a non existing glossary with a valid id' do
+    context 'when requesting a non existing glossary with a valid id' do
+      subject(:glossary_find) { described_class.new(api, id, options) }
+
       let(:id) { 'a0af40e1-d81b-4aab-a95c-7cafbcfd1eb1' }
-      subject { DeepL::Requests::Glossary::Find.new(api, id, options) }
-      it 'should raise a not found error' do
-        expect { subject.request }.to raise_error(DeepL::Exceptions::NotFound)
+
+      it 'raises a not found error' do
+        expect { glossary_find.request }.to raise_error(DeepL::Exceptions::NotFound)
       end
     end
 
-    context 'When requesting a non existing glossary with an invalid id' do
+    context 'when requesting a non existing glossary with an invalid id' do
+      subject(:glossary_find) { described_class.new(api, id, options) }
+
       let(:id) { 'invalid-uuid' }
-      subject { DeepL::Requests::Glossary::Find.new(api, id, options) }
-      it 'should raise a bad request error' do
-        expect { subject.request }.to raise_error(DeepL::Exceptions::BadRequest)
+
+      it 'raises a bad request error' do
+        expect { glossary_find.request }.to raise_error(DeepL::Exceptions::BadRequest)
       end
     end
   end

data/spec/requests/glossary/language_pairs_spec.rb

@@ -1,16 +1,26 @@
+# Copyright 2022 Daniel Herzog
+# Use of this source code is governed by an MIT
+# license that can be found in the LICENSE.md file.
 # frozen_string_literal: true
 
 require 'spec_helper'
 
 describe DeepL::Requests::Glossary::LanguagePairs do
+  subject(:language_pairs_obj) { described_class.new(api, options) }
+
+  around do |tests|
+    tmp_env = replace_env_preserving_deepl_vars_except_mock_server
+    tests.call
+    ENV.replace(tmp_env)
+  end
+
   let(:api) { build_deepl_api }
   let(:options) { {} }
-  subject { DeepL::Requests::Glossary::LanguagePairs.new(api, options) }
 
   describe '#initialize' do
-    context 'When building a request' do
-      it 'should create a request object' do
-        expect(subject).to be_a(described_class)
+    context 'when building a request' do
+      it 'creates a request object' do
+        expect(language_pairs_obj).to be_a(described_class)
       end
     end
   end
@@ -20,9 +30,9 @@ describe DeepL::Requests::Glossary::LanguagePairs do
       VCR.use_cassette('glossaries') { example.call }
     end
 
-    context 'When requesting a list of all language pairs supported by glossaries' do
-      it 'should return a language pairs object' do
-        language_pairs = subject.request
+    context 'when requesting a list of all language pairs supported by glossaries' do
+      it 'returns a language pairs object' do
+        language_pairs = language_pairs_obj.request
         expect(language_pairs).to be_an(Array)
       end
     end

data/spec/requests/glossary/list_spec.rb

@@ -1,16 +1,26 @@
+# Copyright 2022 Daniel Herzog
+# Use of this source code is governed by an MIT
+# license that can be found in the LICENSE.md file.
 # frozen_string_literal: true
 
 require 'spec_helper'
 
 describe DeepL::Requests::Glossary::List do
+  subject(:glossary_list) { described_class.new(api, options) }
+
+  around do |tests|
+    tmp_env = replace_env_preserving_deepl_vars_except_mock_server
+    tests.call
+    ENV.replace(tmp_env)
+  end
+
   let(:api) { build_deepl_api }
   let(:options) { {} }
-  subject { DeepL::Requests::Glossary::List.new(api, options) }
 
   describe '#initialize' do
-    context 'When building a request' do
-      it 'should create a request object' do
-        expect(subject).to be_a(described_class)
+    context 'when building a request' do
+      it 'creates a request object' do
+        expect(glossary_list).to be_a(described_class)
       end
     end
   end
@@ -20,23 +30,23 @@ describe DeepL::Requests::Glossary::List do
       VCR.use_cassette('glossaries') { example.call }
     end
 
-    context 'When requesting a list of all glossaries' do
-      it 'should return a glossaries object' do
-        glossaries = subject.request
+    context 'when requesting a list of all glossaries' do
+      it 'returns a glossaries object' do
+        glossaries = glossary_list.request
         expect(glossaries).to be_an(Array)
       end
     end
 
-    context 'When performing a bad request' do
-      context 'When using an invalid token' do
+    context 'when performing a bad request' do
+      context 'when using an invalid token' do
         let(:api) do
           api = build_deepl_api
           api.configuration.auth_key = 'invalid'
           api
         end
 
-        it 'should raise an unauthorized error' do
-          expect { subject.request }.to raise_error(DeepL::Exceptions::AuthorizationFailed)
+        it 'raises an unauthorized error' do
+          expect { glossary_list.request }.to raise_error(DeepL::Exceptions::AuthorizationFailed)
         end
       end
     end

data/spec/requests/languages_spec.rb

@@ -1,16 +1,26 @@
+# Copyright 2021 Daniel Herzog
+# Use of this source code is governed by an MIT
+# license that can be found in the LICENSE.md file.
 # frozen_string_literal: true
 
 require 'spec_helper'
 
 describe DeepL::Requests::Languages do
+  subject(:languages_obj) { described_class.new(api, options) }
+
+  around do |tests|
+    tmp_env = replace_env_preserving_deepl_vars_except_mock_server
+    tests.call
+    ENV.replace(tmp_env)
+  end
+
   let(:api) { build_deepl_api }
   let(:options) { {} }
-  subject { DeepL::Requests::Languages.new(api, options) }
 
   describe '#initialize' do
-    context 'When building a request' do
-      it 'should create a request object' do
-        expect(subject).to be_a(described_class)
+    context 'when building a request' do
+      it 'creates a request object' do
+        expect(languages_obj).to be_a(described_class)
       end
     end
   end
@@ -20,38 +30,38 @@ describe DeepL::Requests::Languages do
       VCR.use_cassette('languages') { example.call }
     end
 
-    context 'When requesting source languages' do
-      it 'should return an usage object' do
-        languages = subject.request
+    context 'when requesting source languages' do
+      it 'returns a valid list of source languages' do
+        languages = languages_obj.request
 
         expect(languages).to be_an(Array)
-        expect(languages.size).to eq(24)
-        expect(languages.any? { |l| l.code == 'EN' && l.name == 'English' }).to be_truthy
-        expect(languages.any? { |l| l.code == 'ES' && l.name == 'Spanish' }).to be_truthy
+        expect(languages.size).to eq(29)
+        expect(languages).to(be_any { |l| l.code == 'EN' && l.name == 'English' })
+        expect(languages).to(be_any { |l| l.code == 'ES' && l.name == 'Spanish' })
       end
     end
 
-    context 'When requesting target languages' do
+    context 'when requesting target languages' do
       let(:options) { { type: :target } }
 
-      it 'should return an usage object' do
-        languages = subject.request
+      it 'returns a valid list of target languages' do
+        languages = languages_obj.request
 
         expect(languages).to be_an(Array)
-        expect(languages.size).to eq(26)
-        expect(languages.any? { |l| l.code == 'EN' && l.name == 'English' }).to be_falsey
-        expect(languages.any? { |l| l.code == 'ES' && l.name == 'Spanish' }).to be_truthy
-        expect(languages.any? { |l| l.code == 'EN-US' && l.name == 'English (American)' })
-          .to be_truthy
+        expect(languages.size).to eq(31)
+        expect(languages).not_to(be_any { |l| l.code == 'EN' && l.name == 'English' })
+        expect(languages).to(be_any { |l| l.code == 'ES' && l.name == 'Spanish' })
+        expect(languages)
+          .to(be_any { |l| l.code == 'EN-US' && l.name == 'English (American)' })
       end
     end
 
-    context 'When using an invalid type' do
+    context 'when using an invalid type' do
       let(:options) { { type: :invalid } }
 
-      it 'should return an usage object' do
+      it 'returns an usage object' do
         message = "Parameter 'type' is invalid. 'source' and 'target' are valid values."
-        expect { subject.request }.to raise_error(DeepL::Exceptions::BadRequest, message)
+        expect { languages_obj.request }.to raise_error(DeepL::Exceptions::BadRequest, message)
       end
     end
   end