deep_cloneable 2.4.0 → 3.0.0

data/lib/deep_cloneable/skip_validations.rb

@@ -0,0 +1,8 @@
+module DeepCloneable
+  module SkipValidations
+    def perform_validations(options = {})
+      options[:validate] = false
+      super(options)
+    end
+  end
+end

data/readme.md

@@ -6,8 +6,8 @@ This gem gives every ActiveRecord::Base object the possibility to do a deep clon
 
 ## Requirements
 
-* Ruby 1.8.7, 1.9.2, 1.9.3, 2.0.0, 2.1.5, 2.2.2, 2.3.0, 2.4.4, 2.5.1 (tested)
-* Activerecord 3.1, 3.2, 4.0, 4.1, 4.2, 5.0, 5.1, 5.2 (tested)
+* Ruby 1.9.3, 2.0.0, 2.1.5, 2.2.2, 2.3.0, 2.4.4, 2.5.5 (tested)
+* Activerecord 3.1, 3.2, 4.0, 4.1, 4.2, 5.0, 5.1, 5.2, 6.0 (tested)
 * Rails 2.x/3.0 users, please check out the 'rails2.x-3.0' branch
 
 ## Installation
@@ -15,10 +15,19 @@ This gem gives every ActiveRecord::Base object the possibility to do a deep clon
 * Add deep_cloneable to your Gemfile:
 
 ```ruby
-gem 'deep_cloneable', '~> 2.4.0'
+gem 'deep_cloneable', '~> 3.0.0'
 ```
 
-## Upgrading from v1
+## Upgrade details
+
+### Upgrading from v2
+
+There are two breaking changes that you might need to pay attention to:
+
+* When using an optional block (see below), the block used to be evaluated before `deep_cloneable` had performed its changes (inclusions, exclusions, includes). In v3, the block is evaluated after all processing has been done, just before the copy is about to be returned.
+* When a defined association is not found, `deep_cloneable` raises an exception. The exception class has changed namespace: the class definition used to be `ActiveRecord::Base::DeepCloneable::AssociationNotFoundException` and this has changed to `DeepCloneable::AssociationNotFoundException`.
+
+### Upgrading from v1
 
 The `dup` method with arguments has been replaced in deep_cloneable 2 by the method `deep_clone`. Please update your sources accordingly.
 
@@ -158,7 +167,7 @@ end
 
 ### Skipping missing associations
 
-By default, deep_cloneable will throw a `ActiveRecord::Base::DeepCloneable::AssociationNotFoundException` error when an association cannot be found. You can also skip missing associations by specifying `skip_missing_associations` if needed, for example when you have associations on some (but not all) subclasses of an STI model:
+By default, deep_cloneable will throw a `DeepCloneable::AssociationNotFoundException` error when an association cannot be found. You can also skip missing associations by specifying `skip_missing_associations` if needed, for example when you have associations on some (but not all) subclasses of an STI model:
 
 ```ruby
 pirate.deep_clone include: [:parrot, :rum], skip_missing_associations: true

data/test/test_deep_cloneable.rb

@@ -242,7 +242,7 @@ class TestDeepCloneable < MiniTest::Unit::TestCase
     @chicken = Animal::Chicken.create :name => 'Chick', :humans => [@human], :planet => @earth
     @dove = Animal::Dove.create :name => 'Dovey', :planet => @earth
 
-    assert_raises ActiveRecord::Base::DeepCloneable::AssociationNotFoundException do
+    assert_raises ::DeepCloneable::AssociationNotFoundException do
       @earth.deep_clone(:include => { :birds => :ownerships })
     end
 
@@ -350,18 +350,19 @@ class TestDeepCloneable < MiniTest::Unit::TestCase
     assert_equal deep_clone_parent.errors.messages, :children => ['is invalid']
   end
 
-  def test_child_validations_run_on_save_after_clone_without_validation
+  def test_child_validations_dont_run_on_save_after_clone_without_validation
     child = ChildWithValidation.new
     child.save :validate => false
     parent = ParentWithValidation.create :name => 'John', :children => [child]
 
     deep_clone_parent = parent.deep_clone :include => :children, :validate => false
+    deep_clone_child = deep_clone_parent.children.first
 
     assert deep_clone_parent.save
     assert !deep_clone_parent.new_record?
-    assert !deep_clone_parent.valid?
-    assert !deep_clone_parent.children.first.valid?
-    assert_equal deep_clone_parent.errors.messages, :children => ['is invalid']
+    assert !deep_clone_child.new_record?
+    assert !deep_clone_child.valid?
+    assert_equal deep_clone_child.errors.messages, :name => ["can't be blank"]
   end
 
   def test_self_join_has_many
@@ -436,6 +437,11 @@ class TestDeepCloneable < MiniTest::Unit::TestCase
     assert_equal 2, deep_clone.subjects.size
   end
 
+  def test_should_set_association_to_nil_if_conditionals_fail
+    deep_clone = @jack.deep_clone(:include => { :ship => { :unless => lambda { |ship| ship.name == 'Black Pearl' } } })
+    assert_nil deep_clone.ship
+  end
+
   def test_should_reject_copies_if_conditionals_are_passed_with_associations
     deep_clone = @ship.deep_clone(:include => [:pirates => [:treasures, :mateys, { :unless => lambda { |pirate| pirate.name == 'Jack Sparrow' } }]])
 

data/test/test_helper.rb

@@ -24,9 +24,8 @@ def load_schema
   db_adapter = ENV['DB']
   db_adapter ||= 'sqlite3'
 
-  if db_adapter.nil?
-    raise 'No DB Adapter selected. Pass the DB= option to pick one, or install Sqlite or Sqlite3.'
-  end
+  raise 'No DB Adapter selected. Pass the DB= option to pick one, or install Sqlite or Sqlite3.' if db_adapter.nil?
+
   ActiveRecord::Base.establish_connection(config[db_adapter])
   load(File.dirname(__FILE__) + '/schema.rb')
 end

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: deep_cloneable
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Reinier de Lange
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-10 00:00:00.000000000 Z
+date: 2019-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
 description: 'Extends the functionality of ActiveRecord::Base#dup to perform a deep
   clone that includes user specified associations. '
 email: rjdelange@icloud.com
@@ -65,8 +65,13 @@ files:
 - gemfiles/5.1.gemfile.lock
 - gemfiles/5.2.gemfile
 - gemfiles/5.2.gemfile.lock
+- gemfiles/6.0.gemfile
+- gemfiles/6.0.gemfile.lock
 - init.rb
 - lib/deep_cloneable.rb
+- lib/deep_cloneable/association_not_found_exception.rb
+- lib/deep_cloneable/deep_clone.rb
+- lib/deep_cloneable/skip_validations.rb
 - readme.md
 - test/database.yml
 - test/models.rb
@@ -92,8 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: This gem gives every ActiveRecord::Base object the possibility to do a deep