decode 0.20.2 → 0.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 133b0261b7fc97e74472573ccfe28b7526409627b7ebf60ee9674ff62348b0bc
-  data.tar.gz: 79572a96b6c043d76093db8fac0835b6aeae69885f10d687e6ee18313a179e6d
+  metadata.gz: 745a2d58b25edbffce374091e5ea4fb81eb9473d2e0de28353e96835a1bfb24b
+  data.tar.gz: e7b5b0ba014dad20f2df889d981a3431920f90908381dbdd697610a0a036171f
 SHA512:
-  metadata.gz: ad5a07fac459587b2a7c2630e4a368797ab8d7c6290134640a561b4b6acd9d1cc15fc310e752fd5895718c0b4f46c04e37facc457519d9a16f3f40d5cdd122fc
-  data.tar.gz: a76d74f0eeb86f787dd6df5f859ce5235367a3e9ee2ab54aea1f22e2b5b980fac64f5620c239119406ee45492f5ed177959ccb49ade5ef58bf1ad0d676bb2bde
+  metadata.gz: 1125299d2e5f2ff38f1192622ff28f9d9da3228d1f2c2f493b7aba5920f767962e81e9a538efa6c6387e87e79ad3f276d95cd9c68edb607c8e772978b1c3209a
+  data.tar.gz: 1f87468afd6db7116947c82e2ca16ac111e2faa4ace6b945f83b87bcf47aa9743b0e830c2ea26d1024909d5daf437f00773381de8cf86a9c2acf82f3cfa8db37

data/bake/decode/index.rb

@@ -14,20 +14,44 @@ def coverage(root)
 	index = Decode::Index.new
 	index.update(paths)
 	
-	total = 0
-	documented = 0
+	missing = []
+	public_count = 0
+	documented_count = 0
 	
-	index.definitions.each do |name, definition|
-		total += 1
+	index.trie.traverse do |path, node, descend|
+		public_definition = node.values.nil?
+		
+		node.values&.each do |definition|
+			if definition.public?
+				public_count += 1
+				level = path.size
+				
+				if definition.comments.nil?
+					missing << definition.qualified_name
+				else
+					documented_count += 1
+				end
+				
+				public_definition = true
+			end
+		end
 		
-		if comments = definition.comments
-			documented += 1
-		else
-			$stderr.puts "#{name}"
+		# Don't descend into non-public definitions:
+		if public_definition
+			descend.call
 		end
 	end
 	
-	$stderr.puts "#{documented}/#{total} definitions have documentation."
+	$stderr.puts "#{documented_count} definitions have documentation, out of #{public_count} public definitions."
+	
+	if documented_count < public_count
+		$stderr.puts nil, "Missing documentation for:"
+		missing.each do |name|
+			$stderr.puts "- #{name}"
+		end
+		
+		raise RuntimeError, "Insufficient documentation!"
+	end
 end
 
 # Process the given source root and report on symbols.

data/lib/decode/definition.rb

@@ -48,6 +48,15 @@ module Decode
 		# @attribute [Array(String)]
 		attr :comments
 		
+		# Whether the definition is considered part of the public interface.
+		#
+		# This is used to determine whether the definition should be documented for coverage purposes.
+		#
+		# @returns [Boolean]
+		def public?
+			true
+		end
+		
 		# The qualified name is an absolute name which includes any and all namespacing.
 		# @returns [String]
 		def qualified_name

data/lib/decode/index.rb

@@ -37,7 +37,7 @@ module Decode
 		attr :sources
 		
 		# All definitions which have been parsed.
-		# @attribute [Array(Symbol)]
+		# @attribute [Hash(String, Definition)]
 		attr :definitions
 		
 		# A (prefix) trie of lexically scoped definitions.

data/lib/decode/language/ruby/definition.rb

@@ -11,19 +11,27 @@ module Decode
 			# A Ruby-specific definition.
 			class Definition < Decode::Definition
 				# Initialize the definition from the syntax tree node.
-				def initialize(node, *arguments, **options)
+				def initialize(node, *arguments, visibility: nil, **options)
 					super(*arguments, **options)
 					
 					@node = node
+					@visibility = visibility
 				end
 				
 				def nested_name
 					"\##{@name}"
 				end
 				
-				# The parser syntax tree node.
+				# @attribute [Parser::AST::Node] The parser syntax tree node.
 				attr :node
 				
+				# @attribute [Symbol] The visibility of the definition.
+				attr_accessor :visibility
+				
+				def public?
+					@visibility == :public
+				end
+				
 				def multiline?
 					@node.location.line != @node.location.last_line
 				end

data/lib/decode/language/ruby/parser.rb

@@ -25,6 +25,17 @@ module Decode
 			class Parser
 				def initialize(language)
 					@language = language
+					
+					@visibility = :public
+					@definitions = Hash.new.compare_by_identity
+				end
+				
+				private def assign_definition(parent, definition)
+					(@definitions[parent] ||= {})[definition.name] = definition
+				end
+				
+				private def lookup_definition(parent, name)
+					(@definitions[parent] ||= {})[name]
 				end
 				
 				# Parse the given source object, can be a string or a Source instance.
@@ -71,6 +82,14 @@ module Decode
 					end
 				end
 				
+				def with_visibility(visibility = :public, &block)
+					saved_visibility = @visibility
+					@visibility = visibility
+					yield
+				ensure
+					@visibility = saved_visibility
+				end
+				
 				# Walk over the syntax tree and extract relevant definitions with their associated comments.
 				def walk_definitions(node, comments, parent = nil, &block)
 					case node.type
@@ -82,29 +101,37 @@ module Decode
 							language: @language
 						)
 						
+						assign_definition(parent, definition)
+						
 						yield definition
 						
 						if children = node.children[1]
-							walk_definitions(children, comments, definition, &block)
+							with_visibility do
+								walk_definitions(children, comments, definition, &block)
+							end
 						end
 					when :class
 						definition = Class.new(
 							node, nested_name_for(node.children[0]),
 							comments: extract_comments_for(node, comments),
-							parent: parent, language: @language
+							parent: parent, language: @language, visibility: :public
 						)
 						
+						assign_definition(parent, definition)
+						
 						yield definition
 						
 						if children = node.children[2]
-							walk_definitions(children, comments, definition, &block)
+							with_visibility do
+								walk_definitions(children, comments, definition, &block)
+							end
 						end
 					when :sclass
 						if name = singleton_name_for(node.children[0])
 							definition = Singleton.new(
 								node, name,
 								comments: extract_comments_for(node, comments),
-								parent: parent, language: @language
+								parent: parent, language: @language, visibility: :public
 							)
 							
 							yield definition
@@ -117,7 +144,7 @@ module Decode
 						definition = Method.new(
 							node, node.children[0],
 							comments: extract_comments_for(node, comments),
-							parent: parent, language: @language
+							parent: parent, language: @language, visibility: @visibility
 						)
 						
 						yield definition
@@ -128,7 +155,7 @@ module Decode
 							node, node.children[1],
 							comments: extracted_comments,
 							parent: scope_for(extracted_comments, parent, &block),
-							language: @language
+							language: @language, visibility: @visibility
 						)
 						
 						yield definition
@@ -144,6 +171,14 @@ module Decode
 						name = node.children[1]
 						
 						case name
+						when :public, :protected, :private
+							@visibility = name
+						when :private_constant
+							constant_names_for(node.children[2..]) do |name|
+								if definition = lookup_definition(parent, name)
+									definition.visibility = :private
+								end
+							end
 						when :attr, :attr_reader, :attr_writer, :attr_accessor
 							definition = Attribute.new(
 								node, name_for(node.children[2]),
@@ -263,6 +298,14 @@ module Decode
 					return parent
 				end
 				
+				def constant_names_for(children)
+					children.each do |node|
+						if node.type == :sym
+							yield node.children[0]
+						end
+					end
+				end
+				
 				# Extract segments from the given input file.
 				def segments_for(source, &block)
 					top, comments = self.parse_source(source)

data/lib/decode/version.rb

@@ -4,5 +4,5 @@
 # Copyright, 2020-2022, by Samuel Williams.
 
 module Decode
-	VERSION = "0.20.2"
+	VERSION = "0.21.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decode
 version: !ruby/object:Gem::Version
-  version: 0.20.2
+  version: 0.21.0
 platform: ruby
 authors:
 - Samuel Williams
@@ -37,7 +37,7 @@ cert_chain:
   Q2K9NVun/S785AP05vKkXZEFYxqG6EW012U4oLcFl5MySFajYXRYbuUpH6AY+HP8
   voD0MPg1DssDLKwXyt1eKD/+Fq0bFWhwVM/1XiAXL7lyYUyOq24KHgQ2Csg=
   -----END CERTIFICATE-----
-date: 2023-12-04 00:00:00.000000000 Z
+date: 2024-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -125,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.22
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Code analysis for documentation generation.