declare_schema 4.0.0 → 4.0.1.colin.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 929f250672103aa42777cb918340e5281d100fdaf19cedb5f7aaa96504e66a8c
-  data.tar.gz: 377a3f2aaae4fa4b6294a4c4a9edd672a8626a505be6a07e06b953a28cb78ffc
+  metadata.gz: '09079a0e965a85eba22eade7bc713fcacf35d4fd6f874e9d8b41eb36f8e6901e'
+  data.tar.gz: b7f0fa06ec76c298d2b9248ef10b6a1010d36bf2edb3c3a667f57790d98bb6b5
 SHA512:
-  metadata.gz: 8d05a979184d7e93041a462b1269b7d71a6a675f37b8914e27728db0f2d28878d0436cc10eba4bd107f1cb57355c1321147659842367e9231ebb32eec5d14b79
-  data.tar.gz: 3c361cb45d57de4c4aac717155b354f34d0c654b4881c29742a9f611cf7ca8efd0c9297e70433dd7b2df4df70751bf3c1d0463824ccc8eb77f5f9a1d836e711d
+  metadata.gz: 5cb66b34c4d70e0673106ee94fec485e7e5eec25e34b75a64a94e0d3fea9f6f822157dadc8b662ba57af9878c3686807be1ab97b01ce89b8de3b3354c2dfd3a9
+  data.tar.gz: 6359500ff616315a48dd3921a9fac1b9d51e3a24c1dfb1b761160b048da1ef8222d036f60b6e5d2d5e5b74de5f12e44c2db70717a985257be420d78fcbe7f64d

data/CHANGELOG.md

@@ -4,6 +4,15 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.0.1] - 2026-05-06
+### Fixed
+- `DeferredFieldSpec` (the lazy stand-in introduced in 4.0.0 for `belongs_to`
+  foreign-key field specs) now transparently delegates the `FieldSpec` read
+  API (`.options`, `.type`, `.limit`, `.null`, etc.) to its memoized resolved
+  spec. Application code that reads `Model.field_specs[name].options` at
+  runtime would raise `NoMethodError: undefined method 'options' for an
+  instance of DeclareSchema::Model::DeferredFieldSpec`.
+
 ## [4.0.0] - 2026-05-05
 ### Added
 - Generalized `belongs_to` foreign keys to always match the primary key they point at, including

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    declare_schema (4.0.0)
+    declare_schema (4.0.1.colin.1)
       rails (>= 7.0)
 
 GEM

data/lib/declare_schema/model/deferred_field_spec.rb

@@ -12,7 +12,7 @@ module DeclareSchema
     # The migrator calls {#resolve} on every value in `field_specs` at the start
     # of migration generation (see `Migrator#generate`); for plain {FieldSpec}s
     # `#resolve` is a no-op returning self, while for instances of this class it
-    # invokes the block (memoized) with the default spec and returns the produced
+    # invokes the resolver block with the default spec and returns the produced
     # {FieldSpec}.
     class DeferredFieldSpec
       # @param default_spec [FieldSpec] the eager placeholder spec
@@ -24,14 +24,26 @@ module DeclareSchema
         @resolver = resolver
       end
 
-      # Invoke the resolver block with the default spec and return its result.
-      # The migrator's `transform_values!(&:resolve)` swaps this DeferredFieldSpec
-      # out of `field_specs` for the produced FieldSpec, so resolve is called
-      # exactly once per instance in production -- no memoization needed.
+      # Resolve and memoize the produced FieldSpec. Memoization matters because
+      # application code can hit several FieldSpec accessors per request (e.g.
+      # ModelReport reads `.options`, ApplicationModel reads `.limit`); without
+      # it each one would re-run the resolver and re-touch `reflection.klass`.
       #
       # @return [FieldSpec]
       def resolve
-        @resolver.call(@default_spec)
+        @resolved ||= @resolver.call(@default_spec)
+      end
+
+      def respond_to_missing?(name, include_private = false)
+        resolve.respond_to?(name, include_private) || super
+      end
+
+      def method_missing(name, *args, **kwargs, &)
+        if resolve.respond_to?(name)
+          resolve.public_send(name, *args, **kwargs, &)
+        else
+          super
+        end
       end
     end
   end

data/lib/declare_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeclareSchema
-  VERSION = "4.0.0"
+  VERSION = "4.0.1.colin.1"
 end

data/spec/lib/declare_schema/deferred_field_spec_spec.rb

@@ -24,5 +24,61 @@ RSpec.describe DeclareSchema::Model::DeferredFieldSpec do
       expect(deferred.resolve).to equal(mirrored_spec)
       expect(captured).to equal(default_spec)
     end
+
+    it 'memoizes the resolver result so repeated calls invoke it only once' do
+      call_count = 0
+      deferred = described_class.new(default_spec) do |_|
+        call_count += 1
+        mirrored_spec
+      end
+
+      3.times { deferred.resolve }
+
+      expect(call_count).to eq(1)
+    end
+  end
+
+  # Application code (e.g. ModelReport reading `field_specs[name].options[:rr_report_options]`)
+  # reads from `field_specs` without first calling `.resolve`. The deferred spec must
+  # therefore quack like the resolved FieldSpec; otherwise we get NoMethodError at runtime
+  # in apps that read FieldSpec attributes, AND we'd return a wrong default-typed answer
+  # (e.g. :bigint when the parent's PK is actually :integer or :binary).
+  describe 'FieldSpec API delegation' do
+    let(:deferred) { described_class.new(default_spec) { mirrored_spec } }
+
+    it 'delegates #options to the resolved spec (parent-mirrored, not default)' do
+      expect(deferred.options).to eq(mirrored_spec.options)
+    end
+
+    it 'delegates #type to the resolved spec' do
+      expect(deferred.type).to eq(:string)
+    end
+
+    it 'delegates #limit to the resolved spec' do
+      expect(deferred.limit).to eq(36)
+    end
+
+    it 'delegates #null to the resolved spec' do
+      expect(deferred.null).to eq(false)
+    end
+
+    it 'reports respond_to? for delegated methods' do
+      expect(deferred).to respond_to(:options, :type, :limit, :null, :name, :position)
+    end
+
+    it 'invokes the resolver only once across many delegated reads' do
+      call_count = 0
+      deferred = described_class.new(default_spec) do |_|
+        call_count += 1
+        mirrored_spec
+      end
+
+      deferred.options
+      deferred.type
+      deferred.limit
+      deferred.null
+
+      expect(call_count).to eq(1)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1.colin.1
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke