declare_schema 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31dd49e36793094f670d30211da95c08739c4f0c65d11ef1824ab0cacff6508a
-  data.tar.gz: 0f74f11ad7d6a6b6631dbf695cadcae1d59554ba956306ddda0cd26eee1316c4
+  metadata.gz: 32cd73e09d5530729bfef42e4277d229d3688c826a8f8c28575175508fe023ee
+  data.tar.gz: 8ce537e1883effbb466242547580c2de3db9ca87064b1ae6a778a3422a3e5f61
 SHA512:
-  metadata.gz: 73cec99029586a2e9250848013a86548a14fb64eb46d2f2aecc6c5ed4d1679de8d264e06fde1db9640293ee7e2705d13dfd770c62aecb1f7ab089ca8c805d213
-  data.tar.gz: bc61c8db52f1890398dfd663c0e7f0d76441fc1d1713f89d095a2cb40bed654ae14a2dfd40a007013cc762f8ae397368e1a89d210e5b9e853953db595ec9ec1d
+  metadata.gz: 51a55ba1f327ba291d5b0efece8fa168520ebfd91cd984dad9a4a36cb6b9abfa03379563ff170969124d31e09fd908e2de29c3cb0f9ae8ee4fa840a11c0d3e03
+  data.tar.gz: f869a73076a408d5b229d125f59d64af06fc7d1908f6e139fd1a032559a9f6e9476ec3bef93bab43190e264f1f05e35e310c390c14eb990b541ee7944c7d5612

data/CHANGELOG.md

@@ -4,6 +4,11 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.3.1] - Unreleased
+### Fixed
+- Fixed bug where a new model with `belongs_to :owner, polymorphic: true` would cause
+  a "Mysql2::Error: Table '<new table>' doesn't exist:" exception when generating a migration.
+
 ## [2.3.0] - 2024-10-31
 ### Updated
 - Updated the `current_adapter` method to use `connection_db_config` for Rails 6.1 and higher, while retaining `connection_config` for earlier versions

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    declare_schema (2.3.0)
+    declare_schema (2.3.1)
       rails (>= 6.0)
 
 GEM

data/lib/declare_schema/model.rb

@@ -240,7 +240,7 @@ module DeclareSchema
 
       def _infer_fk_limit(foreign_key_column, reflection)
         if reflection.options[:polymorphic]
-          if (foreign_key_column = columns_hash[foreign_key_column.to_s]) && foreign_key_column.type == :integer
+          if (foreign_key_column = _column(foreign_key_column)) && foreign_key_column.type == :integer
             foreign_key_column.limit
           end
         else

data/lib/declare_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeclareSchema
-  VERSION = "2.3.0"
+  VERSION = "2.3.1"
 end

data/lib/generators/declare_schema/migration/migration_generator.rb

@@ -68,7 +68,7 @@ module DeclareSchema
       final_migration_name =
         name.presence ||
         if !options[:default_name]
-          choose("\nMigration filename (spaces will be converted to _) [#{default_migration_name}]:", /^[a-z0-9_ ]*$/,
+          choose("Migration filename (spaces will be converted to _) [#{default_migration_name}]:", /^[a-z0-9_ ]*$/,
                  default_migration_name).strip.gsub(' ', '_').presence
         end ||
         default_migration_name

data/spec/lib/declare_schema/migration_generator_spec.rb

@@ -1305,6 +1305,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
               belongs_to :id_default
               belongs_to :id4
               belongs_to :id8
+              belongs_to :owner, polymorphic: true
             end
           end
 
@@ -1332,20 +1333,24 @@ RSpec.describe 'DeclareSchema Migration Generator' do
           it 'infers the correct FK type from the create_table id: type' do
             up = Generators::DeclareSchema::Migration::Migrator.run.first
 
-            create_fks = up.split("\n").grep(/t\.integer /).map { |command| command.gsub(', null: false', '').gsub(/^ +/, '') }
+            create_fks = up.split("\n").grep(/t\.integer|string /).map { |command| command.gsub(', null: false', '').gsub(/^ +/, '') }
             if current_adapter == 'sqlite3'
               create_fks.map! { |command| command.gsub(/limit: [a-z0-9]+/, 'limit: X') }
               expect(create_fks).to eq([
                                          't.integer :id_default_id, limit: X',
                                          't.integer :id4_id, limit: X',
-                                         't.integer :id8_id, limit: X'
-                                       ]), up
+                                         't.integer :id8_id, limit: X',
+                                         't.integer :owner_id, limit: X',
+                                         't.string  :owner_type, limit: X'
+                                       ])
             else
               expect(create_fks).to eq([
                                          't.integer :id_default_id, limit: 8',
                                          't.integer :id4_id, limit: 4',
-                                         't.integer :id8_id, limit: 8'
-                                       ]), up
+                                         't.integer :id8_id, limit: 8',
+                                         't.integer :owner_id, limit: 8',
+                                         "t.string  :owner_type, limit: 255#{charset_and_collation}"
+                                       ])
             end
           end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-31 00:00:00.000000000 Z
+date: 2024-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails