declare_schema 1.2.3 → 1.3.0.colin.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 669711ed418b80efe0de5f500d4aaf4bbe2c05e156f699d371949c03d623f681
-  data.tar.gz: eccfcbf169e9bc8fcb7fe704fac82a7fed44b56fba5b676dfefaeb4c37b8f47b
+  metadata.gz: a1ca385b5ea18e46f1d2c9faa5f21f05dd1d76783806fcd10041c5102464115b
+  data.tar.gz: f96cbe0cf82a99087f4dbfbc4c35199236d75ec64c79d9f290df2b7f6266920d
 SHA512:
-  metadata.gz: 7531ce0c2af9f5fd4c6b73299575cd4676e4cb56e2f6fbb5881af9a6af7aa4671cf63bda306fc21edf7bd4a4eb47806c46e0daa2a514061f1e86cadcedc1e67f
-  data.tar.gz: 41477b8de840d038c4abe7816f2b8f9f26322ec95b9cd6c50e97ebca256280098aa97fa9b3df889aba0ba1629b0feafdf427432f885904b29e796bd2e28dfe39
+  metadata.gz: a203a826b62f2d37ac5f5cef73f660b5ebb14ec0009ba50d196612090a1445fe9c20e6ce90be9371b005248cf1391fb5565246bf87cb50f261f4f228b63848c2
+  data.tar.gz: 66cda6583ab4b15c0592220369f75a23b9c5cf2467338dca4082ac4e497d787cf40ad3a48b01b1e4b306715a026e1f79f0718b0271a32bbb8a5c4cc8f200c884

data/CHANGELOG.md

@@ -4,6 +4,10 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.3.0] - Unreleased
+### Added
+- Added `DeclareSchema.max_index_and_constraint_name_length` with default of 64.
+
 ## [1.2.3] - 2023-04-04
 ### Changed
 - Fixed a bug where renaming a foreign key resulted in an incorrect migration
@@ -256,41 +260,3 @@ using the appropriate Rails configuration attributes.
 ## [0.1.1] - 2020-09-24
 ### Added
 - Initial version from https://github.com/Invoca/hobo_fields v4.1.0.
-
-[1.2.1]: https://github.com/Invoca/declare_schema/compare/v1.2.0...v1.2.1
-[1.2.0]: https://github.com/Invoca/declare_schema/compare/v1.1.0...v1.2.0
-[1.1.0]: https://github.com/Invoca/declare_schema/compare/v1.0.2...v1.1.0
-[1.0.2]: https://github.com/Invoca/declare_schema/compare/v1.0.1...v1.0.2
-[1.0.1]: https://github.com/Invoca/declare_schema/compare/v1.0.0...v1.0.1
-[1.0.0]: https://github.com/Invoca/declare_schema/compare/v0.14.3...v1.0.0
-[0.14.3]: https://github.com/Invoca/declare_schema/compare/v0.14.2...v0.14.3
-[0.14.2]: https://github.com/Invoca/declare_schema/compare/v0.14.1...v0.14.2
-[0.14.1]: https://github.com/Invoca/declare_schema/compare/v0.14.0...v0.14.1
-[0.14.0]: https://github.com/Invoca/declare_schema/compare/v0.13.1...v0.14.0
-[0.13.1]: https://github.com/Invoca/declare_schema/compare/v0.13.0...v0.13.1
-[0.13.0]: https://github.com/Invoca/declare_schema/compare/v0.12.1...v0.13.0
-[0.12.1]: https://github.com/Invoca/declare_schema/compare/v0.12.0...v0.12.1
-[0.12.0]: https://github.com/Invoca/declare_schema/compare/v0.11.1...v0.12.0
-[0.11.1]: https://github.com/Invoca/declare_schema/compare/v0.11.0...v0.11.1
-[0.11.0]: https://github.com/Invoca/declare_schema/compare/v0.10.1...v0.11.0
-[0.10.1]: https://github.com/Invoca/declare_schema/compare/v0.10.0...v0.10.1
-[0.10.0]: https://github.com/Invoca/declare_schema/compare/v0.9.0...v0.10.0
-[0.9.0]: https://github.com/Invoca/declare_schema/compare/v0.8.0...v0.9.0
-[0.8.0]: https://github.com/Invoca/declare_schema/compare/v0.7.1...v0.8.0
-[0.7.1]: https://github.com/Invoca/declare_schema/compare/v0.7.0...v0.7.1
-[0.7.0]: https://github.com/Invoca/declare_schema/compare/v0.6.3...v0.7.0
-[0.6.4]: https://github.com/Invoca/declare_schema/compare/v0.6.3...v0.6.4
-[0.6.3]: https://github.com/Invoca/declare_schema/compare/v0.6.2...v0.6.3
-[0.6.2]: https://github.com/Invoca/declare_schema/compare/v0.6.1...v0.6.2
-[0.6.1]: https://github.com/Invoca/declare_schema/compare/v0.6.0...v0.6.1
-[0.6.0]: https://github.com/Invoca/declare_schema/compare/v0.5.0...v0.6.0
-[0.5.0]: https://github.com/Invoca/declare_schema/compare/v0.4.2...v0.5.0
-[0.4.2]: https://github.com/Invoca/declare_schema/compare/v0.4.1...v0.4.2
-[0.4.1]: https://github.com/Invoca/declare_schema/compare/v0.4.0...v0.4.1
-[0.4.0]: https://github.com/Invoca/declare_schema/compare/v0.3.1...v0.4.0
-[0.3.1]: https://github.com/Invoca/declare_schema/compare/v0.3.0...v0.3.1
-[0.3.0]: https://github.com/Invoca/declare_schema/compare/v0.2.0...v0.3.0
-[0.2.0]: https://github.com/Invoca/declare_schema/compare/v0.1.3...v0.2.0
-[0.1.3]: https://github.com/Invoca/declare_schema/compare/v0.1.2...v0.1.3
-[0.1.2]: https://github.com/Invoca/declare_schema/compare/v0.1.1...v0.1.2
-[0.1.1]: https://github.com/Invoca/declare_schema/tree/v0.1.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    declare_schema (1.2.3)
+    declare_schema (1.3.0.colin.1)
       rails (>= 5.0)
 
 GEM

data/README.md

@@ -258,6 +258,18 @@ For example:
 ]
 ```
 
+## Maximum Length of Index and Constraint Names
+
+MySQL limits the length of index and constraint names to 64 characters.
+Because the migrations generated by `DecleareSchema` are intended to be portable to any database type that
+ActiveRecord supports, `DeclareSchema` will generate names that do not exceed the
+configurable value:
+```ruby
+DeclareSchema.max_index_and_constraint_name_length = 64
+```
+If you know that your migrations will only be used on a database type with a different limit, you can
+adjust this configuration value. A `nil` value means "unlimited".
+
 ## Declaring Character Set and Collation
 _Note: This feature currently only works for MySQL database configurations._
 

data/lib/declare_schema/model/index_definition.rb

@@ -12,18 +12,17 @@ module DeclareSchema
       class IndexNameTooLongError < RuntimeError; end
 
       PRIMARY_KEY_NAME = "PRIMARY"
-      MYSQL_INDEX_NAME_MAX_LENGTH = 64
 
       def initialize(model, fields, **options)
         @model = model
         @table = options.delete(:table_name) || model.table_name
         @fields = Array.wrap(fields).map(&:to_s)
         @explicit_name = options[:name] unless options.delete(:allow_equivalent)
-        @name = options.delete(:name) || self.class.default_index_name(@fields)
+        @name = options.delete(:name) || self.class.default_index_name(@table, @fields)
         @unique = options.delete(:unique) || name == PRIMARY_KEY_NAME || false
 
-        if @name.length > MYSQL_INDEX_NAME_MAX_LENGTH
-          raise IndexNameTooLongError, "Index '#{@name}' exceeds MySQL limit of #{MYSQL_INDEX_NAME_MAX_LENGTH} characters. Give it a shorter name."
+        if DeclareSchema.max_index_and_constraint_name_length && @name.length > DeclareSchema.max_index_and_constraint_name_length
+          raise IndexNameTooLongError, "Index '#{@name}' exceeds configured limit of #{DeclareSchema.max_index_and_constraint_name_length} characters. Give it a shorter name, or adjust DeclareSchema.max_index_and_constraint_name_length if you know your database can accept longer names."
         end
 
         if (where = options[:where])
@@ -57,8 +56,25 @@ module DeclareSchema
           index_definitions
         end
 
-        def default_index_name(columns)
-          "on_#{Array(columns).join("_and_")}"
+        def default_index_name(table, fields)
+          index_name = nil
+          [:long_index_name, :short_index_name].find do |method_name|
+            index_name = send(method_name, table, fields)
+            if DeclareSchema.max_index_and_constraint_name_length.nil? || index_name.length <= DeclareSchema.max_index_and_constraint_name_length
+              break index_name
+            end
+          end or raise IndexNameTooLongError,
+                       "Index '#{index_name}' exceeds configured limit of #{DeclareSchema.max_index_and_constraint_name_length} characters."
+        end
+
+        private
+
+        def long_index_name(table_name, columns)
+          "index_#{table_name}_on_#{Array(columns).join("_and_")}"
+        end
+
+        def short_index_name(table_name, columns)
+          "#{table_name}__#{Array(columns).join("_")}"
         end
       end
 

data/lib/declare_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeclareSchema
-  VERSION = "1.2.3"
+  VERSION = "1.3.0.colin.1"
 end

data/lib/declare_schema.rb

@@ -29,10 +29,12 @@ module DeclareSchema
   @default_generate_foreign_keys = true
   @default_generate_indexing     = true
   @db_migrate_command            = "bundle exec rails db:migrate"
+  @max_index_and_constraint_name_length = 64  # limit for MySQL
 
   class << self
     attr_reader :default_charset, :default_collation, :default_text_limit, :default_string_limit, :default_null,
-                :default_generate_foreign_keys, :default_generate_indexing, :db_migrate_command
+                :default_generate_foreign_keys, :default_generate_indexing, :db_migrate_command,
+                :max_index_and_constraint_name_length
 
     def to_class(type)
       case type
@@ -97,6 +99,11 @@ module DeclareSchema
       db_migrate_command.is_a?(String) or raise ArgumentError, "db_migrate_command must be a string (got #{db_migrate_command.inspect})"
       @db_migrate_command = db_migrate_command
     end
+
+    def max_index_and_constraint_name_length=(length)
+      length.is_a?(Integer) || length.nil? or raise ArgumentError, "max_index_and_constraint_name_length must be an Integer or nil (meaning unlimited)"
+      @max_index_and_constraint_name_length = length
+    end
   end
 end
 

data/spec/lib/declare_schema/migration_generator_spec.rb

@@ -359,12 +359,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(Generators::DeclareSchema::Migration::Migrator.run).to(
         migrate_up(<<~EOS.strip)
           add_column :adverts, :category_id, :integer, limit: 8, null: false
-          add_index :adverts, [:category_id], name: :on_category_id
+          add_index :adverts, [:category_id], name: :index_adverts_on_category_id
           #{"add_foreign_key :adverts, :categories, column: :category_id, name: :index_adverts_on_category_id\n" if defined?(Mysql2)}
         EOS
         .and migrate_down(<<~EOS.strip)
           #{"remove_foreign_key :adverts, name: :index_adverts_on_category_id" if defined?(Mysql2)}
-          remove_index :adverts, name: :on_category_id
+          remove_index :adverts, name: :index_adverts_on_category_id
           remove_column :adverts, :category_id
         EOS
       )
@@ -383,7 +383,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(Generators::DeclareSchema::Migration::Migrator.run).to(
         migrate_up(<<~EOS.strip)
           add_column :adverts, :c_id, :integer, limit: 8, null: false
-          add_index :adverts, [:c_id], name: :on_c_id
+          add_index :adverts, [:c_id], name: :index_adverts_on_c_id
           #{"add_foreign_key :adverts, :categories, column: :category_id, name: :index_adverts_on_category_id\n" +
             "add_foreign_key :adverts, :categories, column: :c_id, name: :index_adverts_on_c_id" if defined?(Mysql2)}
         EOS
@@ -477,7 +477,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(Generators::DeclareSchema::Migration::Migrator.run).to(
         migrate_up(<<~EOS.strip)
           add_column :adverts, :title, :string, limit: 250, null: true#{charset_and_collation}
-          add_index :adverts, [:title], name: :on_title
+          add_index :adverts, [:title], name: :index_adverts_on_title
           #{"add_foreign_key :adverts, :categories, column: :category_id, name: :index_adverts_on_category_id\n" +
             "add_foreign_key :adverts, :categories, column: :c_id, name: :index_adverts_on_c_id" if defined?(Mysql2)}
         EOS
@@ -496,7 +496,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(Generators::DeclareSchema::Migration::Migrator.run).to(
         migrate_up(<<~EOS.strip)
           add_column :adverts, :title, :string, limit: 250, null: true#{charset_and_collation}
-          add_index :adverts, [:title], name: :on_title, unique: true
+          add_index :adverts, [:title], name: :index_adverts_on_title, unique: true
           #{"add_foreign_key :adverts, :categories, column: :category_id, name: :index_adverts_on_category_id\n" +
             "add_foreign_key :adverts, :categories, column: :c_id, name: :index_adverts_on_c_id" if defined?(Mysql2)}
         EOS
@@ -532,7 +532,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(Generators::DeclareSchema::Migration::Migrator.run).to(
         migrate_up(<<~EOS.strip)
           add_column :adverts, :title, :string, limit: 250, null: true#{charset_and_collation}
-          add_index :adverts, [:title], name: :on_title
+          add_index :adverts, [:title], name: :index_adverts_on_title
           #{"add_foreign_key :adverts, :categories, column: :category_id, name: :index_adverts_on_category_id\n" +
             "add_foreign_key :adverts, :categories, column: :c_id, name: :index_adverts_on_c_id" if defined?(Mysql2)}
         EOS
@@ -566,7 +566,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(Generators::DeclareSchema::Migration::Migrator.run).to(
         migrate_up(<<~EOS.strip)
           add_column :adverts, :title, :string, limit: 250, null: true#{charset_and_collation}
-          add_index :adverts, [:title, :category_id], name: :on_title_and_category_id
+          add_index :adverts, [:title, :category_id], name: :index_adverts_on_title_and_category_id
           #{"add_foreign_key :adverts, :categories, column: :category_id, name: :index_adverts_on_category_id\n" +
             "add_foreign_key :adverts, :categories, column: :c_id, name: :index_adverts_on_c_id" if defined?(Mysql2)}
         EOS
@@ -866,8 +866,8 @@ RSpec.describe 'DeclareSchema Migration Generator' do
             t.string  :name, limit: 250, null: true, charset: "utf8mb4", collation: "utf8mb4_bin"
             t.integer :category_id, limit: 8, null: false
           end
-          add_index :advertisers, [:category_id], name: :on_category_id
-          add_index :affiliates, [:category_id], name: :on_category_id
+          add_index :advertisers, [:category_id], name: :index_adverts_on_category_id
+          add_index :affiliates, [:category_id], name: :index_adverts_on_category_id
           add_foreign_key :advertisers, :categories, column: :category_id, name: :index_advertisers_on_category_id
           add_foreign_key :affiliates, :categories, column: :category_id, name: :index_affiliates_on_category_id
         EOS

data/spec/lib/declare_schema/model/index_definition_spec.rb

@@ -40,75 +40,100 @@ RSpec.describe DeclareSchema::Model::IndexDefinition do
 
       it 'has index_definitions' do
         expect(model_class.index_definitions).to be_kind_of(Array)
-        expect(model_class.index_definitions.map(&:name)).to eq(['on_name'])
+        expect(model_class.index_definitions.map(&:name)).to eq(['index_index_definition_test_models_on_name'])
         expect([:name, :fields, :unique].map { |attr| model_class.index_definitions[0].send(attr)}).to eq(
-                                                                                                           ['on_name', ['name'], false]
-                                                                                                       )
+          ['index_index_definition_test_models_on_name', ['name'], false]
+        )
       end
 
       it 'has index_definitions_with_primary_key' do
         expect(model_class.index_definitions_with_primary_key).to be_kind_of(Array)
         result = model_class.index_definitions_with_primary_key.sort_by(&:name)
-        expect(result.map(&:name)).to eq(['PRIMARY', 'on_name'])
+        expect(result.map(&:name)).to eq(['PRIMARY', 'index_index_definition_test_models_on_name'])
         expect([:name, :fields, :unique].map { |attr| result[0].send(attr)}).to eq(
-                                                                                    ['PRIMARY', ['id'], true]
-                                                                                )
+          ['PRIMARY', ['id'], true]
+        )
         expect([:name, :fields, :unique].map { |attr| result[1].send(attr)}).to eq(
-                                                                                    ['on_name', ['name'], false]
-                                                                                )
+          ['index_index_definition_test_models_on_name', ['name'], false]
+        )
       end
     end
 
-    describe 'class << self' do
-      context 'with a migrated database' do
-        before do
-          ActiveRecord::Base.connection.execute <<~EOS
-            CREATE TABLE index_definition_test_models (
-              id INTEGER NOT NULL PRIMARY KEY,
-              name #{if defined?(SQLite3) then 'TEXT' else 'VARCHAR(255)' end} NOT NULL
-            )
-          EOS
-          ActiveRecord::Base.connection.execute <<~EOS
+    context 'with a migrated database' do
+      before do
+        ActiveRecord::Base.connection.execute <<~EOS
+          CREATE TABLE index_definition_test_models (
+            id INTEGER NOT NULL PRIMARY KEY,
+            name #{if defined?(SQLite3) then 'TEXT' else 'VARCHAR(255)' end} NOT NULL
+          )
+        EOS
+        ActiveRecord::Base.connection.execute <<~EOS
           CREATE UNIQUE INDEX index_definition_test_models_on_name ON index_definition_test_models(name)
-          EOS
-          ActiveRecord::Base.connection.execute <<~EOS
-            CREATE TABLE index_definition_compound_index_models (
-              fk1_id INTEGER NOT NULL,
-              fk2_id INTEGER NOT NULL,
-              PRIMARY KEY (fk1_id, fk2_id)
-            )
-          EOS
-          ActiveRecord::Base.connection.schema_cache.clear!
-        end
+        EOS
+        ActiveRecord::Base.connection.execute <<~EOS
+          CREATE TABLE index_definition_compound_index_models (
+            fk1_id INTEGER NOT NULL,
+            fk2_id INTEGER NOT NULL,
+            PRIMARY KEY (fk1_id, fk2_id)
+          )
+        EOS
+        ActiveRecord::Base.connection.schema_cache.clear!
+      end
+
+      describe 'for_model' do
+        subject { described_class.for_model(model_class) }
 
-        describe 'for_model' do
-          subject { described_class.for_model(model_class) }
-
-          context 'with single-column PK' do
-            it 'returns the indexes for the model' do
-              expect(subject.size).to eq(2), subject.inspect
-              expect([:name, :columns, :unique].map { |attr| subject[0].send(attr) }).to eq(
-                                                                                             ['index_definition_test_models_on_name', ['name'], true]
-                                                                                         )
-              expect([:name, :columns, :unique].map { |attr| subject[1].send(attr) }).to eq(
-                                                                                             ['PRIMARY', ['id'], true]
-                                                                                         )
-            end
+        context 'with single-column PK' do
+          it 'returns the indexes for the model' do
+            expect(subject.size).to eq(2), subject.inspect
+            expect([:name, :columns, :unique].map { |attr| subject[0].send(attr) }).to eq(
+              ['index_definition_test_models_on_name', ['name'], true]
+            )
+            expect([:name, :columns, :unique].map { |attr| subject[1].send(attr) }).to eq(
+              ['PRIMARY', ['id'], true]
+            )
           end
+        end
 
-          context 'with compound-column PK' do
-            let(:model_class) { IndexDefinitionCompoundIndexModel }
+        context 'with compound-column PK' do
+          let(:model_class) { IndexDefinitionCompoundIndexModel }
 
-            it 'returns the indexes for the model' do
-              expect(subject.size).to eq(1), subject.inspect
-              expect([:name, :columns, :unique].map { |attr| subject[0].send(attr) }).to eq(
-                                                                                             ['PRIMARY', ['fk1_id', 'fk2_id'], true]
-                                                                                         )
-            end
+          it 'returns the indexes for the model' do
+            expect(subject.size).to eq(1), subject.inspect
+            expect([:name, :columns, :unique].map { |attr| subject[0].send(attr) }).to eq(
+              ['PRIMARY', ['fk1_id', 'fk2_id'], true]
+            )
           end
         end
       end
     end
   end
+
+  context 'with no side effects' do
+    describe '.default_index_name' do
+      let(:table_name2) { 'users' }
+      let(:columns2) { ['last_name', 'first_name', 'middle_name', ] }
+      subject { described_class.default_index_name(table_name2, columns2) }
+      around do |spec|
+        orig_value = DeclareSchema.max_index_and_constraint_name_length
+        DeclareSchema.max_index_and_constraint_name_length = max_index_and_constraint_name_length
+        spec.run
+      ensure
+        DeclareSchema.max_index_and_constraint_name_length = orig_value
+      end
+
+      context 'with unlimited max_index_and_constraint_name_length' do
+        let(:max_index_and_constraint_name_length) { nil }
+
+        it { is_expected.to eq("index_users_on_last_name_and_first_name_and_middle_name") }
+      end
+
+      context 'with short max_index_and_constraint_name_length' do
+        let(:max_index_and_constraint_name_length) { 40 }
+
+        it { is_expected.to eq("users__last_name_first_name_middle_name") }
+      end
+    end
+  end
   # TODO: fill out remaining tests
 end

data/spec/lib/declare_schema_spec.rb

@@ -5,13 +5,13 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_charset }
 
     context 'when not explicitly set' do
-      it { should eq("utf8mb4") }
+      it { is_expected.to eq("utf8mb4") }
     end
 
     context 'when explicitly set' do
       before { described_class.default_charset = "utf8" }
       after  { described_class.default_charset = "utf8mb4" }
-      it     { should eq("utf8") }
+      it     { is_expected.to eq("utf8") }
     end
   end
 
@@ -19,13 +19,13 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_collation }
 
     context 'when not explicitly set' do
-      it { should eq("utf8mb4_bin") }
+      it { is_expected.to eq("utf8mb4_bin") }
     end
 
     context 'when explicitly set' do
       before { described_class.default_collation = "utf8mb4_general_ci" }
       after  { described_class.default_collation = "utf8mb4_bin" }
-      it     { should eq("utf8mb4_general_ci") }
+      it     { is_expected.to eq("utf8mb4_general_ci") }
     end
   end
 
@@ -33,13 +33,13 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_text_limit }
 
     context 'when not explicitly set' do
-      it { should eq(0xffff_ffff) }
+      it { is_expected.to eq(0xffff_ffff) }
     end
 
     context 'when explicitly set' do
       before { described_class.default_text_limit = 0xffff }
       after  { described_class.default_text_limit = 0xffff_ffff }
-      it     { should eq(0xffff) }
+      it     { is_expected.to eq(0xffff) }
     end
   end
 
@@ -47,13 +47,13 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_string_limit }
 
     context 'when not explicitly set' do
-      it { should eq(nil) }
+      it { is_expected.to eq(nil) }
     end
 
     context 'when explicitly set' do
       before { described_class.default_string_limit = 225 }
       after  { described_class.default_string_limit = nil }
-      it     { should eq(225) }
+      it     { is_expected.to eq(225) }
     end
   end
 
@@ -61,13 +61,13 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_null }
 
     context 'when not explicitly set' do
-      it { should eq(false) }
+      it { is_expected.to eq(false) }
     end
 
     context 'when explicitly set' do
       before { described_class.default_null = true }
       after  { described_class.default_null = false }
-      it     { should eq(true) }
+      it     { is_expected.to eq(true) }
     end
   end
 
@@ -75,13 +75,13 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_generate_foreign_keys }
 
     context 'when not explicitly set' do
-      it { should eq(true) }
+      it { is_expected.to eq(true) }
     end
 
     context 'when explicitly set' do
       before { described_class.default_generate_foreign_keys = false }
       after  { described_class.default_generate_foreign_keys = true }
-      it     { should eq(false) }
+      it     { is_expected.to eq(false) }
     end
   end
 
@@ -89,13 +89,43 @@ RSpec.describe DeclareSchema do
     subject { described_class.default_generate_indexing }
 
     context 'when not explicitly set' do
-      it { should eq(true) }
+      it { is_expected.to eq(true) }
     end
 
     context 'when explicitly set' do
       before { described_class.default_generate_indexing = false }
       after  { described_class.default_generate_indexing = true }
-      it     { should eq(false) }
+      it     { is_expected.to eq(false) }
+    end
+  end
+
+  describe '#max_index_and_constraint_name_length' do
+    subject { described_class.max_index_and_constraint_name_length }
+
+    context 'when not explicitly set' do
+      it { is_expected.to eq(64) }
+    end
+
+    context 'when explicitly set' do
+      around do |spec|
+        orig_value = described_class.max_index_and_constraint_name_length
+        described_class.max_index_and_constraint_name_length = max_index_and_constraint_name_length
+        spec.run
+      rescue
+        described_class.max_index_and_constraint_name_length = orig_value
+      end
+
+      context 'when set to an Integer' do
+        let(:max_index_and_constraint_name_length) { 255 }
+
+        it { is_expected.to eq(255)}
+      end
+
+      context 'when set to nil' do
+        let(:max_index_and_constraint_name_length) { nil }
+
+        it { is_expected.to eq(nil)}
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.3.0.colin.1
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-04 00:00:00.000000000 Z
+date: 2023-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -127,7 +127,7 @@ homepage: https://github.com/Invoca/declare_schema
 licenses: []
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -143,7 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubygems_version: 3.1.6
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Database schema declaration and migration generator for Rails
 test_files: []