declare_schema 1.2.3.pre.ga.7 → 1.2.3.pre.ga.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 308421d49ba0007340aad10be1ca95b4798d1c3a98c3e7bb52e41d81f903530e
-  data.tar.gz: 7e1c75911502f841c935308a8b1f8a8997702839eb348f07b45eee05cc3440b3
+  metadata.gz: ac52b40b3a13a99d43517d2755123ba3a836140fcf9862d10b35a586eaad9ef7
+  data.tar.gz: d84e7782e16652da230cb9e51ee4c951bba67c692ab58f12056f9e895738d203
 SHA512:
-  metadata.gz: 2e4d907b428190cdb3cfa5b99c27e9a751a110144092e9498888b79a5050596bb849afb73feb38d6f4bba73617f4a3d00e0c8d4cde9634c124472f93a5003022
-  data.tar.gz: 1774ac3658dccd0f32f280b04358cfa80707053d8d595b3527f467e97c8b91f66651de3737fea969abd01c2454bc028aca12ae98380e7a1d76d0ef4dc0a37eb5
+  metadata.gz: c03703d46e1ed3c149f51ad479e2baacc88bc174a1b5239419c9f906cf0a638b26f0299ac50845660734151e18ef1b0048479abf491b685dd81ba9d55649edf3
+  data.tar.gz: e20b98d2651485183f4df433eb482715d492175c8fb6407e7030ed08c90ae8c5845d633044a335c91578531f3e5c11df23348b81f95cf9d7871204e20a4f4178

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    declare_schema (1.2.3.pre.ga.7)
+    declare_schema (1.2.3.pre.ga.8)
       rails (>= 5.0)
 
 GEM

data/lib/declare_schema/model/habtm_model_shim.rb

@@ -37,10 +37,6 @@ module DeclareSchema
         join_table
       end
 
-      def index_name
-        "index_#{table_name}_on_#{foreign_keys.first}_#{foreign_keys.last}"
-      end
-
       def field_specs
         foreign_keys.each_with_index.each_with_object({}) do |(v, position), result|
           result[v] = ::DeclareSchema::Model::FieldSpec.new(self, v, :bigint, position: position, null: false)
@@ -57,7 +53,7 @@ module DeclareSchema
 
       def index_definitions_with_primary_key
         [
-          IndexDefinition.new(self, foreign_keys, unique: true, name: index_name), # creates a primary composite key on both foreign keys
+          IndexDefinition.new(self, foreign_keys, unique: true, name: "PRIMARY KEY"), # creates a primary composite key on both foreign keys
           IndexDefinition.new(self, foreign_keys.last) # not unique by itself; combines with primary key to be unique
         ]
       end

data/lib/declare_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeclareSchema
-  VERSION = "1.2.3.pre.ga.7"
+  VERSION = "1.2.3.pre.ga.8"
 end

data/spec/lib/declare_schema/model/habtm_model_shim_spec.rb

@@ -102,12 +102,37 @@ RSpec.describe DeclareSchema::Model::HabtmModelShim do
         expect(result.size).to eq(2), result.inspect
 
         expect(result.first).to be_a(::DeclareSchema::Model::IndexDefinition)
-        expect(result.first.name).to eq('index_parent_1_parent_2_on_parent_1_id_parent_2_id')
+        expect(result.first.name).to eq('PRIMARY KEY')
         expect(result.first.fields).to eq(['parent_1_id', 'parent_2_id'])
         expect(result.first.unique).to be_truthy
       end
     end
 
+    context 'when table and foreign key names are long' do
+      let(:join_table) { "advertiser_campaigns_tracking_pixels" }
+      let(:foreign_keys) { ['advertiser_campaign', 'tracking_pixel'] }
+      let(:foreign_key_classes) { [Table1, Table2] }
+
+      before do
+        class Table1 < ActiveRecord::Base
+          self.table_name = 'advertiser_campaign'
+        end
+
+        class Table2 < ActiveRecord::Base
+          self.table_name = 'tracking_pixel'
+        end
+      end
+
+      it 'returns two index definitions and does not raise a IndexNameTooLongError' do
+        result = subject.index_definitions_with_primary_key
+        expect(result.size).to eq(2), result.inspect
+        expect(result.first).to be_a(::DeclareSchema::Model::IndexDefinition)
+        expect(result.first.name).to eq('PRIMARY KEY')
+        expect(result.first.fields).to eq(['advertiser_campaign', 'tracking_pixel'])
+        expect(result.first.unique).to be_truthy
+      end
+    end
+
     describe '#index_definitions' do
       it 'returns index_definitions_with_primary_key' do
         result = subject.index_definitions

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 1.2.3.pre.ga.7
+  version: 1.2.3.pre.ga.8
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke