declare_schema 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65a5d6f6ca6a81d44fe5ff1d1fa0cc73249e2e20f02017e53c9dd3c6a03156b3
-  data.tar.gz: 167a53b05577190b8bb68b6871c41199ef4a2697fa2bc165fb4ed65355fecfeb
+  metadata.gz: e974685df9b53809688f8903ceb82a475e50b24a4725275c3cde5949396fcd85
+  data.tar.gz: 6efca4e93e98e3880418821c2f3969600a8ac48b8b967a96fcc959824fd0e1fd
 SHA512:
-  metadata.gz: 11722905e9a2761a84124aadf10f20221eb8c5bab9aec35e65a2db216b14607f958db2fe2076920d4bcd6e537ca8dabad5c60ef514a5ff843e6675d4e042ac84
-  data.tar.gz: 103f1a41b5176b575b60141ed207c8e57d0c4ed8bc55a0235c318f928ff0a2dbf20bc2b889d8a6260c43fd0bcb1549a43581e594f1b2ebb70dc8312f68ab6476
+  metadata.gz: 1f2dac19cdac8a2a5b59f7d20f34c6230e69981a89b180e47080f5c77ba047962ed1f1badeeb69230b14c8a074e96b0588bb9ff9e2430ff2a5496c1d60318cc9
+  data.tar.gz: 90098f7d95782c943e17f04b8fc4f1ed23a4cecf63f6208b54fdfff60af19ca4c43ab661eacd055319ca5ec290b1ac1591586a8ec852eda41375d2b2d020346a

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+* @Invoca/octothorpe

data/CHANGELOG.md

@@ -4,6 +4,20 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.1.0] - 2022-07-22
+### Changed
+- Fixed a bug where `DeclareSchema::Model::HabtmModelShim` `indexes` and `integer limits` were not being generated properly. Use `limit 8` for ids and primary composite key for habtm model.
+- `index_definitions_with_primary_key`
+
+## [1.0.2] - 2022-07-18
+### Fixed
+- Fixed a bug where `SchemaChange::ColumnRemove` was not loaded and causing an exception to raise
+when a column was being removed during migration generation
+
+## [1.0.1] - 2022-07-12
+### Fixed
+- Remove lingering usage of `fallback_find_primary_key` method that was removed in `0.14.0`
+
 ## [1.0.0] - 2022-03-28
 ### Added
 - Added support for Ruby 3+
@@ -215,6 +229,9 @@ using the appropriate Rails configuration attributes.
 ### Added
 - Initial version from https://github.com/Invoca/hobo_fields v4.1.0.
 
+[1.1.0]: https://github.com/Invoca/declare_schema/compare/v1.0.2...v1.1.0
+[1.0.2]: https://github.com/Invoca/declare_schema/compare/v1.0.1...v1.0.2
+[1.0.1]: https://github.com/Invoca/declare_schema/compare/v1.0.0...v1.0.1
 [1.0.0]: https://github.com/Invoca/declare_schema/compare/v0.14.3...v1.0.0
 [0.14.3]: https://github.com/Invoca/declare_schema/compare/v0.14.2...v0.14.3
 [0.14.2]: https://github.com/Invoca/declare_schema/compare/v0.14.1...v0.14.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    declare_schema (1.0.0)
+    declare_schema (1.1.0)
       rails (>= 5.0)
 
 GEM

data/lib/declare_schema/model/foreign_key_definition.rb

@@ -36,7 +36,7 @@ module DeclareSchema
               parent_table:    parent_table,
               foreign_key:     foreign_key
             }
-            options[:dependent] = :delete if fkc['ON DELETE CASCADE']
+            options[:dependent] = :delete if fkc['ON DELETE CASCADE'] || model.is_a?(DeclareSchema::Model::HabtmModelShim)
 
             new(model, foreign_key, **options)
           end

data/lib/declare_schema/model/habtm_model_shim.rb

@@ -37,9 +37,13 @@ module DeclareSchema
         join_table
       end
 
+      def index_name
+        "index_#{table_name}_on_#{foreign_keys.first}_#{foreign_keys.last}"
+      end
+
       def field_specs
         foreign_keys.each_with_index.each_with_object({}) do |(v, position), result|
-          result[v] = ::DeclareSchema::Model::FieldSpec.new(self, v, :integer, position: position, null: false)
+          result[v] = ::DeclareSchema::Model::FieldSpec.new(self, v, :bigint, position: position, null: false)
         end
       end
 
@@ -53,7 +57,7 @@ module DeclareSchema
 
       def index_definitions_with_primary_key
         [
-          IndexDefinition.new(self, foreign_keys, unique: true, name: ::DeclareSchema::Model::IndexDefinition::PRIMARY_KEY_NAME),
+          IndexDefinition.new(self, foreign_keys, unique: true, name: index_name), # creates a primary composite key on both foriegn keys
           IndexDefinition.new(self, foreign_keys.last) # not unique by itself; combines with primary key to be unique
         ]
       end

data/lib/declare_schema/model/index_definition.rb

@@ -33,11 +33,14 @@ module DeclareSchema
 
       class << self
         # extract IndexSpecs from an existing table
-        # always includes the PRIMARY KEY index
+        # always includes the PRIMARY KEY index for Model unless it is a HABTM Model.
         def for_model(model, old_table_name = nil)
           t = old_table_name || model.table_name
 
-          primary_key_columns = Array(model.connection.primary_key(t)).presence || fallback_find_primary_key(model, t) or
+          habtm_model = model.is_a?(DeclareSchema::Model::HabtmModelShim)
+
+          primary_key_columns = Array(model.connection.primary_key(t)).presence
+          primary_key_columns || habtm_model or
             raise "could not find primary key for table #{t} in #{model.connection.columns(t).inspect}"
 
           primary_key_found = false
@@ -47,14 +50,14 @@ module DeclareSchema
               i.columns == primary_key_columns && i.unique or
                 raise "primary key on #{t} was not unique on #{primary_key_columns} (was unique=#{i.unique} on #{i.columns})"
               primary_key_found = true
-            elsif i.columns == primary_key_columns && i.unique
+            elsif i.columns == primary_key_columns && i.unique && !habtm_model
               # skip this primary key index since we'll create it below, with PRIMARY_KEY_NAME
               next
             end
             new(model, i.columns, name: i.name, unique: i.unique, where: i.where, table_name: old_table_name)
           end.compact
 
-          if !primary_key_found
+          if !primary_key_found && !habtm_model
             index_definitions << new(model, primary_key_columns, name: PRIMARY_KEY_NAME, unique: true, where: nil, table_name: old_table_name)
           end
           index_definitions

data/lib/declare_schema/schema_change/all.rb

@@ -7,6 +7,7 @@ module DeclareSchema
     autoload :Base, 'declare_schema/schema_change/base'
     autoload :ColumnAdd, 'declare_schema/schema_change/column_add'
     autoload :ColumnChange, 'declare_schema/schema_change/column_change'
+    autoload :ColumnRemove, 'declare_schema/schema_change/column_remove'
     autoload :ColumnRename, 'declare_schema/schema_change/column_rename'
     autoload :ForeignKeyAdd, 'declare_schema/schema_change/foreign_key_add'
     autoload :ForeignKeyRemove, 'declare_schema/schema_change/foreign_key_remove'

data/lib/declare_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeclareSchema
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/spec/lib/declare_schema/model/habtm_model_shim_spec.rb

@@ -102,14 +102,9 @@ RSpec.describe DeclareSchema::Model::HabtmModelShim do
         expect(result.size).to eq(2), result.inspect
 
         expect(result.first).to be_a(::DeclareSchema::Model::IndexDefinition)
-        expect(result.first.name).to eq('PRIMARY')
+        expect(result.first.name).to eq('index_parent_1_parent_2_on_parent_1_id_parent_2_id')
         expect(result.first.fields).to eq(['parent_1_id', 'parent_2_id'])
         expect(result.first.unique).to be_truthy
-
-        expect(result.last).to be_a(::DeclareSchema::Model::IndexDefinition)
-        expect(result.last.name).to eq('on_parent_2_id')
-        expect(result.last.unique).to be_falsey
-        expect(result.last.fields).to eq(['parent_2_id'])
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-28 00:00:00.000000000 Z
+date: 2022-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -32,7 +32,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/dependabot.yml"
+- ".github/CODEOWNERS"
 - ".github/workflows/declare_schema_build.yml"
 - ".github/workflows/gem_release.yml"
 - ".gitignore"
@@ -141,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.11
 signing_key:
 specification_version: 4
 summary: Database schema declaration and migration generator for Rails

data/.github/dependabot.yml

@@ -1,14 +0,0 @@
-version: 2
-updates:
-- package-ecosystem: bundler
-  directory: "/"
-  schedule:
-    interval: weekly
-    day: friday
-    time: "22:00"
-    timezone: PST8PDT
-  open-pull-requests-limit: 99
-  versioning-strategy: lockfile-only
-  commit-message:
-    prefix: No-Jira
-    include: scope