declare_schema 0.6.1 → 0.7.1

data/spec/lib/declare_schema/model/column_spec.rb

@@ -0,0 +1,141 @@
+# frozen_string_literal: true
+
+require 'rails'
+
+begin
+  require 'mysql2'
+rescue LoadError
+end
+
+require_relative '../../../../lib/declare_schema/model/column'
+
+RSpec.describe DeclareSchema::Model::Column do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  describe 'class methods' do
+    describe '.native_type?' do
+      if Rails::VERSION::MAJOR >= 5
+        let(:native_types) { [:string, :text, :integer, :float, :decimal, :datetime, :time, :date, :binary, :boolean, :json] }
+      else
+        let(:native_types) { [:string, :text, :integer, :float, :decimal, :datetime, :time, :date, :binary, :boolean] }
+      end
+
+      it 'is falsey for :primary_key' do
+        expect(described_class.native_type?(:primary_key)).to be_falsey
+      end
+
+      it 'is truthy for native types' do
+        native_types.each do |type|
+          expect(described_class.native_type?(type)).to be_truthy, type.inspect
+        end
+      end
+
+      it 'is falsey for other types' do
+        [:email, :url].each do |type|
+          expect(described_class.native_type?(type)).to be_falsey
+        end
+      end
+    end
+
+    describe '.native_types' do
+      subject { described_class.native_types }
+
+      it 'returns the native type for :primary_key' do
+        expect(subject[:primary_key]).to match(/auto_increment PRIMARY KEY|PRIMARY KEY AUTOINCREMENT NOT NULL/)
+      end
+
+      it 'returns the native type for :string' do
+        expect(subject.dig(:string, :name)).to eq('varchar')
+      end
+
+      it 'returns the native type for :integer' do
+        expect(subject.dig(:integer, :name)).to match(/int/)
+      end
+
+      it 'returns the native type for :datetime' do
+        expect(subject.dig(:datetime, :name)).to eq('datetime')
+      end
+    end
+
+    describe '.sql_type' do
+      it 'returns the sql type for :string' do
+        expect(described_class.sql_type(:string)).to eq(:string)
+      end
+
+      it 'returns the sql type for :integer' do
+        expect(described_class.sql_type(:integer)).to match(:integer)
+      end
+
+      it 'returns the sql type for :datetime' do
+        expect(described_class.sql_type(:datetime)).to eq(:datetime)
+      end
+
+      it 'raises UnknownSqlType' do
+        expect do
+          described_class.sql_type(:email)
+        end.to raise_exception(::DeclareSchema::UnknownSqlTypeError, /:email for type :email/)
+      end
+    end
+
+    describe '.deserialize_default_value' do
+      require 'rails'
+
+      if ::Rails::VERSION::MAJOR >= 5
+        it 'deserializes :boolean' do
+          expect(described_class.deserialize_default_value(nil, :boolean, 'true')).to eq(true)
+          expect(described_class.deserialize_default_value(nil, :boolean, 'false')).to eq(false)
+        end
+
+        it 'deserializes :integer' do
+          expect(described_class.deserialize_default_value(nil, :integer, '12')).to eq(12)
+        end
+
+        it 'deserializes :json' do
+          expect(described_class.deserialize_default_value(nil, :json, '{}')).to eq({})
+        end
+      end
+    end
+  end
+
+  describe 'instance methods' do
+    before do
+      class ColumnTestModel < ActiveRecord::Base
+        fields do
+          title :string, limit: 127, null: false
+          count :integer, null: false
+        end
+      end
+    end
+    let(:model) { ColumnTestModel }
+    let(:current_table_name) { model.table_name }
+    let(:column) { double("ActiveRecord Column",
+                          name: 'count',
+                          type: :integer,
+                          limit: nil,
+                          precision: nil,
+                          scale: nil,
+                          type_cast_from_database: nil,
+                          null: false,
+                          default: nil,
+                          sql_type_metadata: {}) }
+    subject { described_class.new(model, current_table_name, column) }
+
+    describe '#sql_type' do
+      it 'returns sql type' do
+        expect(subject.sql_type).to match(/int/)
+      end
+    end
+
+    describe '#schema_attributes' do
+      it 'returns a hash with relevant key/values' do
+        if defined?(Mysql2)
+          expect(subject.schema_attributes).to eq(type: :integer, null: false, limit: 4)
+        else
+          expect(subject.schema_attributes).to eq(type: :integer, null: false)
+        end
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/model/foreign_key_definition_spec.rb

@@ -0,0 +1,93 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/model/foreign_key_definition'
+
+RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+
+    class Network < ActiveRecord::Base
+      fields do
+        name :string, limit: 127, index: true
+
+        timestamps
+      end
+    end
+  end
+
+  let(:model_class) { Network }
+
+  describe 'instance methods' do
+    let(:connection) { instance_double(ActiveRecord::Base.connection.class) }
+    let(:model) { instance_double('Model', table_name: 'models', connection: connection) }
+    let(:foreign_key) { :network_id }
+    let(:options) { {} }
+    subject { described_class.new(model, foreign_key, options)}
+
+    before do
+      allow(connection).to receive(:index_name).with('models', column: 'network_id') { 'on_network_id' }
+    end
+
+    describe '#initialize' do
+      it 'normalizes symbols to strings' do
+        expect(subject.foreign_key).to eq('network_id')
+        expect(subject.parent_table_name).to eq('networks')
+      end
+
+      context 'when most options passed' do
+        let(:options) { { parent_table: :networks, foreign_key: :the_network_id, index_name: :index_on_network_id } }
+
+        it 'normalizes symbols to strings' do
+          expect(subject.foreign_key).to eq('network_id')
+          expect(subject.foreign_key_name).to eq('the_network_id')
+          expect(subject.parent_table_name).to eq('networks')
+          expect(subject.foreign_key).to eq('network_id')
+          expect(subject.constraint_name).to eq('index_on_network_id')
+          expect(subject.on_delete_cascade).to be_falsey
+        end
+      end
+
+      context 'when all options passed' do
+        let(:foreign_key) { nil }
+        let(:options) { { parent_table: :networks, foreign_key: :the_network_id, index_name: :index_on_network_id,
+                          constraint_name: :constraint_1, dependent: :delete } }
+
+        it 'normalizes symbols to strings' do
+          expect(subject.foreign_key).to be_nil
+          expect(subject.foreign_key_name).to eq('the_network_id')
+          expect(subject.parent_table_name).to eq('networks')
+          expect(subject.constraint_name).to eq('constraint_1')
+          expect(subject.on_delete_cascade).to be_truthy
+        end
+      end
+    end
+
+    describe '#to_add_statement' do
+      it 'returns add_foreign_key command' do
+        expect(subject.to_add_statement).to eq('add_foreign_key("models", "networks", column: "network_id", name: "on_network_id")')
+      end
+    end
+  end
+
+  describe 'class << self' do
+    let(:connection) { instance_double(ActiveRecord::Base.connection.class) }
+    let(:model) { instance_double('Model', table_name: 'models', connection: connection) }
+    let(:old_table_name) { 'networks' }
+    before do
+      allow(connection).to receive(:quote_table_name).with('networks') { 'networks' }
+      allow(connection).to receive(:select_rows) { [['CONSTRAINT `constraint` FOREIGN KEY (`network_id`) REFERENCES `networks` (`id`)']] }
+      allow(connection).to receive(:index_name).with('models', column: 'network_id') { }
+    end
+
+    describe '.for_model' do
+      subject { described_class.for_model(model, old_table_name) }
+
+      it 'returns new object' do
+        expect(subject.size).to eq(1), subject.inspect
+        expect(subject.first).to be_kind_of(described_class)
+        expect(subject.first.foreign_key).to eq('network_id')
+      end
+    end
+  end
+  # TODO: fill out remaining tests
+end

data/spec/lib/generators/declare_schema/migration/migrator_spec.rb

@@ -18,17 +18,8 @@ module Generators
         subject { described_class.new }
 
         describe 'format_options' do
-          let(:mysql_longtext_limit) { 0xffff_ffff }
-          let(:limit_option) do
-            if defined?(Mysql2)
-              ["limit: #{mysql_longtext_limit}"]
-            else
-              []
-            end
-          end
-
-          it 'returns text limits if supported' do
-            expect(subject.format_options({ limit: mysql_longtext_limit }, :text)).to eq(limit_option)
+          it 'returns an array of option .inspect strings, with symbols using the modern : hash notation' do
+            expect(subject.format_options({ limit: 4, 'key' => 'value "quoted"' })).to eq(["limit: 4", '"key" => "value \"quoted\""'])
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.1
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-06 00:00:00.000000000 Z
+date: 2021-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -61,6 +61,7 @@ files:
 - lib/declare_schema/extensions/module.rb
 - lib/declare_schema/field_declaration_dsl.rb
 - lib/declare_schema/model.rb
+- lib/declare_schema/model/column.rb
 - lib/declare_schema/model/field_spec.rb
 - lib/declare_schema/model/foreign_key_definition.rb
 - lib/declare_schema/model/index_definition.rb
@@ -82,6 +83,8 @@ files:
 - spec/lib/declare_schema/generator_spec.rb
 - spec/lib/declare_schema/interactive_primary_key_spec.rb
 - spec/lib/declare_schema/migration_generator_spec.rb
+- spec/lib/declare_schema/model/column_spec.rb
+- spec/lib/declare_schema/model/foreign_key_definition_spec.rb
 - spec/lib/declare_schema/model/index_definition_spec.rb
 - spec/lib/declare_schema/model/table_options_definition_spec.rb
 - spec/lib/declare_schema/prepare_testapp.rb