declare_schema 0.5.0 → 0.6.4

data/spec/lib/declare_schema/field_spec_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+RSpec.describe 'DeclareSchema Model FieldSpec' do
+  before do
+    load File.expand_path('prepare_testapp.rb', __dir__)
+  end
+
+  context 'There are no model columns to change' do
+    it '#different_to should return false for int8 == int8' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :integer, limit: 8, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::Integer.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "integer(8)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "integer(8)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+
+    it '#different_to should return false for bigint == bigint' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :bigint, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::BigInteger.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "bigint(20)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "bigint(20)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+
+    it '#different_to should return false for int8 == bigint' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :integer, limit: 8, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::BigInteger.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "bigint(20)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "bigint(20)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+
+    it '#different_to should return false for bigint == int8' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :bigint, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::Integer.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "integer(8)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "integer(8)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+  end
+end

data/spec/lib/declare_schema/generator_spec.rb

@@ -30,7 +30,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     case Rails::VERSION::MAJOR
     when 4, 5
       expect_test_definition_to_eq('alpha/beta', <<~EOS)
-        require 'test_helper'
+        require "test_helper"
 
         class Alpha::BetaTest < ActiveSupport::TestCase
           # test "the truth" do
@@ -101,7 +101,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(File.exist?('db/schema.rb')).to be_truthy
 
-    expect(File.exist?("db/development.sqlite3") || File.exist?("db/test.sqlite3")).to be_truthy
+    if defined?(SQLite3)
+      expect(File.exist?("db/development.sqlite3") || File.exist?("db/test.sqlite3")).to be_truthy
+    end
 
     module Alpha; end
     require 'alpha/beta'

data/spec/lib/declare_schema/interactive_primary_key_spec.rb

@@ -1,5 +1,11 @@
 # frozen_string_literal: true
 
+require 'rails'
+begin
+  require 'mysql2'
+rescue LoadError
+end
+
 RSpec.describe 'DeclareSchema Migration Generator interactive primary key' do
   before do
     load File.expand_path('prepare_testapp.rb', __dir__)
@@ -31,8 +37,8 @@ RSpec.describe 'DeclareSchema Migration Generator interactive primary key' do
 
     ### migrate to
 
-    if Rails::VERSION::MAJOR >= 5
-      # rename to custom primary_key
+    if Rails::VERSION::MAJOR >= 5 && !defined?(Mysql2) # TODO TECH-4814 Put this test back for Mysql2
+      # replace custom primary_key
       class Foo < ActiveRecord::Base
         fields do
         end

data/spec/lib/declare_schema/migration_generator_spec.rb

@@ -1,12 +1,53 @@
 # frozen_string_literal: true
 
 require 'rails'
+begin
+  require 'mysql2'
+rescue LoadError
+end
 
 RSpec.describe 'DeclareSchema Migration Generator' do
   before do
     load File.expand_path('prepare_testapp.rb', __dir__)
   end
 
+  let(:charset_alter_table) do
+    if defined?(Mysql2)
+      <<~EOS
+
+
+        execute "ALTER TABLE `adverts` CHARACTER SET utf8mb4 COLLATE utf8mb4_bin"
+      EOS
+    end
+  end
+  let(:text_limit) do
+    if defined?(Mysql2)
+      ", limit: 4294967295"
+    end
+  end
+  let(:charset_and_collation) do
+    if defined?(Mysql2)
+      ', charset: "utf8mb4", collation: "utf8mb4_bin"'
+    end
+  end
+  let(:datetime_precision) do
+    if defined?(Mysql2) && Rails::VERSION::MAJOR >= 5
+      ', precision: 0'
+    end
+  end
+  let(:table_options) do
+    if defined?(Mysql2)
+      ", options: \"#{'ENGINE=InnoDB ' if Rails::VERSION::MAJOR == 5}DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin\"" +
+        if Rails::VERSION::MAJOR >= 6
+          ', charset: "utf8mb4", collation: "utf8mb4_bin"'
+        else
+          ''
+        end
+    else
+      ", id: :integer" unless Rails::VERSION::MAJOR < 5
+    end
+  end
+
   # DeclareSchema - Migration Generator
   it 'generates migrations' do
     ## The migration generator -- introduction
@@ -25,7 +66,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
       end
     end
 
@@ -33,8 +74,8 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(migrations).to(
         migrate_up(<<~EOS.strip)
           create_table :adverts, id: :bigint do |t|
-            t.string :name, limit: 255
-          end
+            t.string :name, limit: 250#{charset_and_collation}
+          end#{charset_alter_table}
         EOS
         .and migrate_down("drop_table :adverts")
       )
@@ -44,14 +85,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Advert.columns.map(&:name)).to eq(["id", "name"])
 
     if Rails::VERSION::MAJOR < 5
-      # Rails 4 sqlite driver doesn't create PK properly. Fix that by dropping and recreating.
+      # Rails 4 drivers don't always create PK properly. Fix that by dropping and recreating.
       ActiveRecord::Base.connection.execute("drop table adverts")
-      ActiveRecord::Base.connection.execute('CREATE TABLE "adverts" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar(255))')
+      if defined?(Mysql2)
+        ActiveRecord::Base.connection.execute("CREATE TABLE adverts (id integer PRIMARY KEY AUTO_INCREMENT NOT NULL, name varchar(250)) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin")
+      else
+        ActiveRecord::Base.connection.execute("CREATE TABLE adverts (id integer PRIMARY KEY AUTOINCREMENT  NOT NULL, name varchar(250))")
+      end
     end
 
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
         body :text, null: true
         published_at :datetime, null: true
       end
@@ -62,7 +107,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(migrate).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :body, :text
+        add_column :adverts, :body, :text#{text_limit}#{charset_and_collation}
         add_column :adverts, :published_at, :datetime
       EOS
       .and migrate_down(<<~EOS.strip)
@@ -74,33 +119,33 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     Advert.field_specs.clear # not normally needed
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
         body :text, null: true
       end
     end
 
     expect(migrate).to(
       migrate_up("remove_column :adverts, :published_at").and(
-        migrate_down("add_column :adverts, :published_at, :datetime")
+        migrate_down("add_column :adverts, :published_at, :datetime#{datetime_precision}")
       )
     )
 
     nuke_model_class(Advert)
     class Advert < ActiveRecord::Base
       fields do
-        title :string, limit: 255, null: true
+        title :string, limit: 250, null: true
         body :text, null: true
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
         remove_column :adverts, :name
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :adverts, :title
-        add_column :adverts, :name, :string, limit: 255
+        add_column :adverts, :name, :string, limit: 250#{charset_and_collation}
       EOS
     )
 
@@ -120,24 +165,24 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up("change_column :adverts, :title, :text").and(
-        migrate_down("change_column :adverts, :title, :string, limit: 255")
+      migrate_up("change_column :adverts, :title, :text#{text_limit}#{charset_and_collation}").and(
+        migrate_down("change_column :adverts, :title, :string, limit: 250#{charset_and_collation}")
       )
     )
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, default: "Untitled", limit: 255, null: true
+        title :string, default: "Untitled", limit: 250, null: true
         body :text, null: true
       end
     end
 
     expect(migrate).to(
       migrate_up(<<~EOS.strip)
-        change_column :adverts, :title, :string, limit: 255, default: "Untitled"
+        change_column :adverts, :title, :string, limit: 250, default: "Untitled"#{charset_and_collation}
       EOS
       .and migrate_down(<<~EOS.strip)
-        change_column :adverts, :title, :string, limit: 255
+        change_column :adverts, :title, :string, limit: 250#{charset_and_collation}
       EOS
     )
 
@@ -187,7 +232,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     # If a `limit` is given, it will only be used in MySQL, to choose the smallest TEXT field that will accommodate
     # that limit (0xff for TINYTEXT, 0xffff for TEXT, 0xffffff for MEDIUMTEXT, 0xffffffff for LONGTEXT).
 
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_falsey
+    if defined?(SQLite3)
+      expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_falsey
+    end
+
     class Advert < ActiveRecord::Base
       fields do
         notes :text
@@ -198,113 +246,107 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
         add_column :adverts, :price, :decimal
-        add_column :adverts, :notes, :text, null: false
-        add_column :adverts, :description, :text, null: false
+        add_column :adverts, :notes, :text, null: false#{text_limit}#{charset_and_collation}
+        add_column :adverts, :description, :text, null: false#{', limit: 65535' if defined?(Mysql2)}#{charset_and_collation}
       EOS
     )
 
-    # (There is no limit on `add_column ... :description` above since these tests are run against SQLite.)
-
     Advert.field_specs.delete :price
     Advert.field_specs.delete :notes
     Advert.field_specs.delete :description
 
     # In MySQL, limits are applied, rounded up:
 
-    ::DeclareSchema::Model::FieldSpec::instance_variable_set(:@mysql_text_limits, true)
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
-    class Advert < ActiveRecord::Base
-      fields do
-        notes :text
-        description :text, limit: 200
-      end
-    end
-
-    expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up(<<~EOS.strip)
-        add_column :adverts, :notes, :text, null: false, limit: 4294967295
-        add_column :adverts, :description, :text, null: false, limit: 255
-      EOS
-    )
-
-    Advert.field_specs.delete :notes
-
-    # Limits that are too high for MySQL will raise an exception.
+    if defined?(Mysql2)
+      expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
 
-    ::DeclareSchema::Model::FieldSpec::instance_variable_set(:@mysql_text_limits, true)
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
-    expect do
       class Advert < ActiveRecord::Base
         fields do
           notes :text
-          description :text, limit: 0x1_0000_0000
+          description :text, limit: 250
         end
       end
-    end.to raise_exception(ArgumentError, "limit of 4294967296 is too large for MySQL")
 
-    Advert.field_specs.delete :notes
+      expect(Generators::DeclareSchema::Migration::Migrator.run).to(
+        migrate_up(<<~EOS.strip)
+          add_column :adverts, :notes, :text, null: false, limit: 4294967295#{charset_and_collation}
+          add_column :adverts, :description, :text, null: false, limit: 255#{charset_and_collation}
+        EOS
+      )
 
-    # And in MySQL, unstated text limits are treated as the maximum (LONGTEXT) limit.
+      Advert.field_specs.delete :notes
 
-    # To start, we'll set the database schema for `description` to match the above limit of 255.
+      # Limits that are too high for MySQL will raise an exception.
 
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
-    Advert.connection.execute "ALTER TABLE adverts ADD COLUMN description TINYTEXT"
-    Advert.connection.schema_cache.clear!
-    Advert.reset_column_information
-    expect(Advert.connection.tables - Generators::DeclareSchema::Migration::Migrator.always_ignore_tables).
-      to eq(["adverts"])
-    expect(Advert.columns.map(&:name)).to eq(["id", "body", "title", "description"])
+      expect do
+        class Advert < ActiveRecord::Base
+          fields do
+            notes :text
+            description :text, limit: 0x1_0000_0000
+          end
+        end
+      end.to raise_exception(ArgumentError, "limit of 4294967296 is too large for MySQL")
 
-    # Now migrate to an unstated text limit:
+      Advert.field_specs.delete :notes
 
-    class Advert < ActiveRecord::Base
-      fields do
-        description :text
-      end
-    end
+      # And in MySQL, unstated text limits are treated as the maximum (LONGTEXT) limit.
 
-    expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up(<<~EOS.strip)
-        change_column :adverts, :description, :text, limit: 4294967295, null: false
-      EOS
-      .and migrate_down(<<~EOS.strip)
-        change_column :adverts, :description, :text
-      EOS
-    )
+      # To start, we'll set the database schema for `description` to match the above limit of 250.
 
-    # TODO TECH-4814: The above test should have this output:
-    # TODO => "change_column :adverts, :description, :text, limit: 255
+      Advert.connection.execute "ALTER TABLE adverts ADD COLUMN description TINYTEXT"
+      Advert.connection.schema_cache.clear!
+      Advert.reset_column_information
+      expect(Advert.connection.tables - Generators::DeclareSchema::Migration::Migrator.always_ignore_tables).
+        to eq(["adverts"])
+      expect(Advert.columns.map(&:name)).to eq(["id", "body", "title", "description"])
 
-    # And migrate to a stated text limit that is the same as the unstated one:
+      # Now migrate to an unstated text limit:
 
-    class Advert < ActiveRecord::Base
-      fields do
-        description :text, limit: 0xffffffff
+      class Advert < ActiveRecord::Base
+        fields do
+          description :text
+        end
       end
-    end
 
-    expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up(<<~EOS.strip)
-        change_column :adverts, :description, :text, limit: 4294967295, null: false
-      EOS
-      .and migrate_down(<<~EOS.strip)
-        change_column :adverts, :description, :text
-      EOS
-    )
-    ::DeclareSchema::Model::FieldSpec::instance_variable_set(:@mysql_text_limits, false)
+      expect(Generators::DeclareSchema::Migration::Migrator.run).to(
+        migrate_up(<<~EOS.strip)
+          change_column :adverts, :description, :text, limit: 4294967295, null: false#{charset_and_collation}
+        EOS
+        .and migrate_down(<<~EOS.strip)
+          change_column :adverts, :description, :text#{', limit: 255' if defined?(Mysql2)}#{charset_and_collation}
+        EOS
+      )
+
+      # And migrate to a stated text limit that is the same as the unstated one:
+
+      class Advert < ActiveRecord::Base
+        fields do
+          description :text, limit: 0xffffffff
+        end
+      end
+
+      expect(Generators::DeclareSchema::Migration::Migrator.run).to(
+        migrate_up(<<~EOS.strip)
+          change_column :adverts, :description, :text, limit: 4294967295, null: false#{charset_and_collation}
+        EOS
+        .and migrate_down(<<~EOS.strip)
+          change_column :adverts, :description, :text#{', limit: 255' if defined?(Mysql2)}#{charset_and_collation}
+        EOS
+      )
+    end
 
     Advert.field_specs.clear
     Advert.connection.schema_cache.clear!
     Advert.reset_column_information
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
       end
     end
 
     up = Generators::DeclareSchema::Migration::Migrator.run.first
     ActiveRecord::Migration.class_eval up
+
     Advert.connection.schema_cache.clear!
     Advert.reset_column_information
 
@@ -316,7 +358,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     class Category < ActiveRecord::Base; end
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
       end
       belongs_to :category
     end
@@ -326,11 +368,15 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :category_id, :integer, limit: 8, null: false
 
         add_index :adverts, [:category_id], name: 'on_category_id'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" if defined?(Mysql2)}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :adverts, :category_id
 
         remove_index :adverts, name: :on_category_id rescue ActiveRecord::StatementInvalid
+
+        #{"remove_foreign_key(\"adverts\", name: \"index_adverts_on_category_id\")\n" if defined?(Mysql2)}
       EOS
     )
 
@@ -350,6 +396,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :c_id, :integer, limit: 8, null: false
 
         add_index :adverts, [:c_id], name: 'on_c_id'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -367,6 +416,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
         add_column :adverts, :category_id, :integer, limit: 8, null: false
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -386,6 +438,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :category_id, :integer, limit: 8, null: false
 
         add_index :adverts, [:category_id], name: 'my_index'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -409,11 +464,17 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :created_at, :datetime
         add_column :adverts, :updated_at, :datetime
         add_column :adverts, :lock_version, :integer, null: false, default: 1
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :adverts, :created_at
         remove_column :adverts, :updated_at
         remove_column :adverts, :lock_version
+
+        #{"remove_foreign_key(\"adverts\", name: \"index_adverts_on_category_id\")\n" +
+          "remove_foreign_key(\"adverts\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -427,15 +488,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, index: true, limit: 255, null: true
+        title :string, index: true, limit: 250, null: true
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], name: 'on_title'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -445,15 +509,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, index: true, unique: true, null: true, limit: 255
+        title :string, index: true, unique: true, null: true, limit: 250
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], unique: true, name: 'on_title'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -463,15 +530,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, index: 'my_index', limit: 255, null: true
+        title :string, index: 'my_index', limit: 250, null: true
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], name: 'my_index'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -485,9 +555,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], name: 'on_title'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -501,9 +574,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], unique: true, name: 'my_index'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -517,9 +593,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title, :category_id], name: 'on_title_and_category_id'
+
+        #{"add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+          "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")" if defined?(Mysql2)}
       EOS
     )
 
@@ -536,7 +615,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     class Advert < ActiveRecord::Base
       self.table_name = "ads"
       fields do
-        title :string, limit: 255, null: true
+        title :string, limit: 250, null: true
         body :text, null: true
       end
     end
@@ -548,10 +627,16 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       migrate_up(<<~EOS.strip)
         rename_table :adverts, :ads
 
-        add_column :ads, :title, :string, limit: 255
-        add_column :ads, :body, :text
+        add_column :ads, :title, :string, limit: 250#{charset_and_collation}
+        add_column :ads, :body, :text#{', limit: 4294967295' if defined?(Mysql2)}#{charset_and_collation}
 
-        add_index :ads, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :ads, [:id], unique: true, name: 'PRIMARY'\n"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE ads DROP PRIMARY KEY, ADD PRIMARY KEY (id)\"\n\n" +
+            "add_foreign_key(\"adverts\", \"categories\", column: \"category_id\", name: \"index_adverts_on_category_id\")\n" +
+            "add_foreign_key(\"adverts\", \"categories\", column: \"c_id\", name: \"index_adverts_on_c_id\")"
+          end}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :ads, :title
@@ -559,14 +644,20 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
         rename_table :ads, :adverts
 
-        add_index :adverts, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :adverts, [:id], unique: true, name: 'PRIMARY'\n"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE adverts DROP PRIMARY KEY, ADD PRIMARY KEY (id)\"\n\n" +
+            "remove_foreign_key(\"adverts\", name: \"index_adverts_on_category_id\")\n" +
+            "remove_foreign_key(\"adverts\", name: \"index_adverts_on_c_id\")"
+          end}
       EOS
     )
 
     # Set the table name back to what it should be and confirm we're in sync:
 
-    Advert.field_specs.delete(:title)
-    Advert.field_specs.delete(:body)
+    nuke_model_class(Advert)
+
     class Advert < ActiveRecord::Base
       self.table_name = "adverts"
     end
@@ -581,7 +672,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advertisement < ActiveRecord::Base
       fields do
-        title :string, limit: 255, null: true
+        title :string, limit: 250, null: true
         body :text, null: true
       end
     end
@@ -590,20 +681,28 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       migrate_up(<<~EOS.strip)
         rename_table :adverts, :advertisements
 
-        add_column :advertisements, :title, :string, limit: 255
-        add_column :advertisements, :body, :text
+        add_column :advertisements, :title, :string, limit: 250#{charset_and_collation}
+        add_column :advertisements, :body, :text#{', limit: 4294967295' if defined?(Mysql2)}#{charset_and_collation}
         remove_column :advertisements, :name
 
-        add_index :advertisements, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :advertisements, [:id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE advertisements DROP PRIMARY KEY, ADD PRIMARY KEY (id)\""
+          end}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :advertisements, :title
         remove_column :advertisements, :body
-        add_column :adverts, :name, :string, limit: 255
+        add_column :adverts, :name, :string, limit: 250#{charset_and_collation}
 
         rename_table :advertisements, :adverts
 
-        add_index :adverts, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :adverts, [:id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE adverts DROP PRIMARY KEY, ADD PRIMARY KEY (id)\""
+          end}
       EOS
     )
 
@@ -615,23 +714,15 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     # Dropping tables is where the automatic down-migration really comes in handy:
 
-    rails4_table_create = <<~EOS.strip
-      create_table "adverts", force: :cascade do |t|
-        t.string "name", limit: 255
-      end
-    EOS
-
-    rails5_table_create = <<~EOS.strip
-      create_table "adverts", id: :integer, force: :cascade do |t|
-        t.string "name", limit: 255
-      end
-    EOS
-
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
         drop_table :adverts
       EOS
-      .and migrate_down(Rails::VERSION::MAJOR >= 5 ? rails5_table_create : rails4_table_create)
+      .and migrate_down(<<~EOS.strip)
+        create_table "adverts"#{table_options}, force: :cascade do |t|
+          t.string "name", limit: 250#{charset_and_collation}
+        end
+      EOS
     )
 
     ## STI
@@ -643,7 +734,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     class Advert < ActiveRecord::Base
       fields do
         body :text, null: true
-        title :string, default: "Untitled", limit: 255, null: true
+        title :string, default: "Untitled", limit: 250, null: true
       end
     end
     up = Generators::DeclareSchema::Migration::Migrator.run.first
@@ -657,7 +748,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     up, _ = Generators::DeclareSchema::Migration::Migrator.run do |migrations|
       expect(migrations).to(
         migrate_up(<<~EOS.strip)
-          add_column :adverts, :type, :string, limit: 255
+          add_column :adverts, :type, :string, limit: 250#{charset_and_collation}
 
           add_index :adverts, [:type], name: 'on_type'
         EOS
@@ -696,7 +787,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        name :string, default: "No Name", limit: 255, null: true
+        name :string, default: "No Name", limit: 250, null: true
         body :text, null: true
       end
     end
@@ -704,11 +795,11 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Generators::DeclareSchema::Migration::Migrator.run(adverts: { title: :name })).to(
       migrate_up(<<~EOS.strip)
         rename_column :adverts, :title, :name
-        change_column :adverts, :name, :string, limit: 255, default: "No Name"
+        change_column :adverts, :name, :string, limit: 250, default: "No Name"#{charset_and_collation}
       EOS
       .and migrate_down(<<~EOS.strip)
         rename_column :adverts, :name, :title
-        change_column :adverts, :title, :string, limit: 255, default: "Untitled"
+        change_column :adverts, :title, :string, limit: 250, default: "Untitled"#{charset_and_collation}
       EOS
     )
 
@@ -717,7 +808,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     nuke_model_class(Advert)
     class Ad < ActiveRecord::Base
       fields do
-        title      :string, default: "Untitled", limit: 255
+        title      :string, default: "Untitled", limit: 250
         body       :text, null: true
         created_at :datetime
       end
@@ -728,16 +819,20 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         rename_table :adverts, :ads
 
         add_column :ads, :created_at, :datetime, null: false
-        change_column :ads, :title, :string, limit: 255, null: false, default: \"Untitled\"
+        change_column :ads, :title, :string, limit: 250, null: false, default: \"Untitled\"#{charset_and_collation}
 
-        add_index :ads, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :ads, [:id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+            'execute "ALTER TABLE ads DROP PRIMARY KEY, ADD PRIMARY KEY (id)"'
+          end}
       EOS
     )
 
     class Advert < ActiveRecord::Base
       fields do
         body :text, null: true
-        title :string, default: "Untitled", limit: 255, null: true
+        title :string, default: "Untitled", limit: 250, null: true
       end
     end
 
@@ -758,7 +853,11 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       migrate_up(<<~EOS.strip)
         rename_column :adverts, :id, :advert_id
 
-        add_index :adverts, [:advert_id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :adverts, [:advert_id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+          'execute "ALTER TABLE adverts DROP PRIMARY KEY, ADD PRIMARY KEY (advert_id)"'
+          end}
       EOS
     )
 
@@ -771,7 +870,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class User < ActiveRecord::Base
       fields do
-        company :string, limit: 255, ruby_default: -> { "BigCorp" }
+        company :string, limit: 250, ruby_default: -> { "BigCorp" }
       end
     end
     expect(User.field_specs.keys).to eq(['company'])
@@ -790,7 +889,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Ad).to receive(:validates).with(:company, presence: true, uniqueness: { case_sensitive: false })
     class Ad < ActiveRecord::Base
       fields do
-        company :string, limit: 255, index: true, unique: true, validates: { presence: true, uniqueness: { case_sensitive: false } }
+        company :string, limit: 250, index: true, unique: true, validates: { presence: true, uniqueness: { case_sensitive: false } }
       end
       self.primary_key = "advert_id"
     end
@@ -828,10 +927,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'converts defaults with .to_yaml' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: true, null: true, default: []
-            allow_hash :string, limit: 255, serialize: true, null: true, default: {}
-            allow_string :string, limit: 255, serialize: true, null: true, default: ['abc']
-            allow_null :string, limit: 255, serialize: true, null: true, default: nil
+            allow_list :string, limit: 250, serialize: true, null: true, default: []
+            allow_hash :string, limit: 250, serialize: true, null: true, default: {}
+            allow_string :string, limit: 250, serialize: true, null: true, default: ['abc']
+            allow_null :string, limit: 250, serialize: true, null: true, default: nil
           end
         end
 
@@ -846,7 +945,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: Array' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: Array, null: true
+            allow_list :string, limit: 250, serialize: Array, null: true
           end
         end
 
@@ -856,10 +955,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows Array defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: Array, null: true, default: [2]
-            allow_string :string, limit: 255, serialize: Array, null: true, default: ['abc']
-            allow_empty :string, limit: 255, serialize: Array, null: true, default: []
-            allow_null :string, limit: 255, serialize: Array, null: true, default: nil
+            allow_list :string, limit: 250, serialize: Array, null: true, default: [2]
+            allow_string :string, limit: 250, serialize: Array, null: true, default: ['abc']
+            allow_empty :string, limit: 250, serialize: Array, null: true, default: []
+            allow_null :string, limit: 250, serialize: Array, null: true, default: nil
           end
         end
 
@@ -874,7 +973,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: Hash' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: Hash, null: true
+            allow_list :string, limit: 250, serialize: Hash, null: true
           end
         end
 
@@ -884,9 +983,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows Hash defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_loc :string, limit: 255, serialize: Hash, null: true, default: { 'state' => 'CA' }
-            allow_hash :string, limit: 255, serialize: Hash, null: true, default: {}
-            allow_null :string, limit: 255, serialize: Hash, null: true, default: nil
+            allow_loc :string, limit: 250, serialize: Hash, null: true, default: { 'state' => 'CA' }
+            allow_hash :string, limit: 250, serialize: Hash, null: true, default: {}
+            allow_null :string, limit: 250, serialize: Hash, null: true, default: nil
           end
         end
 
@@ -900,7 +999,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: JSON' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: JSON
+            allow_list :string, limit: 250, serialize: JSON
           end
         end
 
@@ -910,10 +1009,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows JSON defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_hash :string, limit: 255, serialize: JSON, null: true, default: { 'state' => 'CA' }
-            allow_empty_array :string, limit: 255, serialize: JSON, null: true, default: []
-            allow_empty_hash :string, limit: 255, serialize: JSON, null: true, default: {}
-            allow_null :string, limit: 255, serialize: JSON, null: true, default: nil
+            allow_hash :string, limit: 250, serialize: JSON, null: true, default: { 'state' => 'CA' }
+            allow_empty_array :string, limit: 250, serialize: JSON, null: true, default: []
+            allow_empty_hash :string, limit: 250, serialize: JSON, null: true, default: {}
+            allow_null :string, limit: 250, serialize: JSON, null: true, default: nil
           end
         end
 
@@ -950,7 +1049,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: ValueClass' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: ValueClass
+            allow_list :string, limit: 250, serialize: ValueClass
           end
         end
 
@@ -960,9 +1059,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows ValueClass defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_hash :string, limit: 255, serialize: ValueClass, null: true, default: ValueClass.new([2])
-            allow_empty_array :string, limit: 255, serialize: ValueClass, null: true, default: ValueClass.new([])
-            allow_null :string, limit: 255, serialize: ValueClass, null: true, default: nil
+            allow_hash :string, limit: 250, serialize: ValueClass, null: true, default: ValueClass.new([2])
+            allow_empty_array :string, limit: 250, serialize: ValueClass, null: true, default: ValueClass.new([])
+            allow_null :string, limit: 250, serialize: ValueClass, null: true, default: nil
           end
         end
 
@@ -1003,7 +1102,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
         class Advert < ActiveRecord::Base
           fields do
-            name :string, limit: 255, null: true
+            name :string, limit: 250, null: true
             category_id :integer, limit: 8
             nullable_category_id :integer, limit: 8, null: true
           end
@@ -1093,4 +1192,33 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(base_class).to eq("(Rails::VERSION::MAJOR >= 5 ? ActiveRecord::Migration[4.2] : ActiveRecord::Migration)")
     end
   end
+
+  context 'Does not generate migrations' do
+    it 'for aliased fields bigint -> integer limit 8' do
+      if Rails::VERSION::MAJOR >= 5 || !ActiveRecord::Base.connection.class.name.match?(/SQLite3Adapter/)
+        class Advert < active_record_base_class.constantize
+          fields do
+            price :bigint
+          end
+        end
+
+        generate_migrations '-n', '-m'
+
+        migrations = Dir.glob('db/migrate/*declare_schema_migration*.rb')
+        expect(migrations.size).to eq(1), migrations.inspect
+
+        if defined?(Mysql2) && Rails::VERSION::MAJOR < 5
+          ActiveRecord::Base.connection.execute("ALTER TABLE adverts ADD PRIMARY KEY (id)")
+        end
+
+        class Advert < active_record_base_class.constantize
+          fields do
+            price :integer, limit: 8
+          end
+        end
+
+        expect { generate_migrations '-n', '-g' }.to output("Database and models match -- nothing to change\n").to_stdout
+      end
+    end
+  end
 end