declare_schema 0.5.0.pre.1 → 0.6.1

data/lib/declare_schema/model/table_options_definition.rb

@@ -26,12 +26,14 @@ module DeclareSchema
 
         def mysql_table_options(connection, table_name)
           database = connection.current_database
-          defaults = connection.select_one(<<~EOS)
+          defaults = connection.select_one(<<~EOS) or raise "no defaults found for table #{table_name}"
             SELECT CCSA.character_set_name, CCSA.collation_name
-            FROM information_schema.`TABLES` T, information_schema.`COLLATION_CHARACTER_SET_APPLICABILITY` CCSA
-            WHERE CCSA.collation_name = T.table_collation AND
-                  T.table_schema = #{connection.quote_string(database)} AND
-                  T.table_name = #{connection.quote_string(table_name)};
+            FROM information_schema.TABLES as T
+              JOIN information_schema.COLLATION_CHARACTER_SET_APPLICABILITY as CCSA
+                ON CCSA.collation_name = T.table_collation
+            WHERE
+              T.table_schema = '#{connection.quote_string(database)}' AND
+              T.table_name = '#{connection.quote_string(table_name)}'
           EOS
 
           defaults["character_set_name"] or raise "character_set_name missing from #{defaults.inspect}"
@@ -75,7 +77,7 @@ module DeclareSchema
       alias to_s settings
 
       def alter_table_statement
-        statement = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} #{to_s};"
+        statement = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} #{to_s}"
         "execute #{statement.inspect}"
       end
     end

data/lib/declare_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeclareSchema
-  VERSION = "0.5.0.pre.1"
+  VERSION = "0.6.1"
 end

data/lib/generators/declare_schema/migration/migrator.rb

@@ -23,6 +23,10 @@ module Generators
           end
         end
 
+        def table_options
+          {}
+        end
+
         def table_name
           join_table
         end
@@ -33,11 +37,9 @@ module Generators
 
         def field_specs
           i = 0
-          foreign_keys.reduce({}) do |h, v|
-            # some trickery to avoid an infinite loop when FieldSpec#initialize tries to call model.field_specs
-            h[v] = ::DeclareSchema::Model::FieldSpec.new(self, v, :integer, position: i, null: false)
+          foreign_keys.each_with_object({}) do |v, result|
+            result[v] = ::DeclareSchema::Model::FieldSpec.new(self, v, :integer, position: i, null: false)
             i += 1
-            h
           end
         end
 
@@ -69,8 +71,8 @@ module Generators
       class Migrator
         class Error < RuntimeError; end
 
-        DEFAULT_CHARSET   = :utf8mb4
-        DEFAULT_COLLATION = :utf8mb4_general
+        DEFAULT_CHARSET   = "utf8mb4"
+        DEFAULT_COLLATION = "utf8mb4_bin"
 
         @ignore_models                        = []
         @ignore_tables                        = []
@@ -80,9 +82,18 @@ module Generators
         @default_collation                    = DEFAULT_COLLATION
 
         class << self
-          attr_accessor :ignore_models, :ignore_tables, :disable_indexing, :disable_constraints,
-                        :active_record_class, :default_charset, :default_collation
-          attr_reader :before_generating_migration_callback
+          attr_accessor :ignore_models, :ignore_tables, :disable_indexing, :disable_constraints
+          attr_reader :active_record_class, :default_charset, :default_collation, :before_generating_migration_callback
+
+          def default_charset=(charset)
+            charset.is_a?(String) or raise ArgumentError, "charset must be a string (got #{charset.inspect})"
+            @default_charset = charset
+          end
+
+          def default_collation=(collation)
+            collation.is_a?(String) or raise ArgumentError, "collation must be a string (got #{collation.inspect})"
+            @default_collation = collation
+          end
 
           def active_record_class
             @active_record_class.is_a?(Class) or @active_record_class = @active_record_class.to_s.constantize
@@ -423,7 +434,7 @@ module Generators
               else
                 [":integer"]
               end
-            "add_column :#{new_table_name}, :#{c}, #{args.join(', ')}"
+            ["add_column :#{new_table_name}, :#{c}", *args].join(', ')
           end
           undo_adds = to_add.map do |c|
             "remove_column :#{new_table_name}, :#{c}"
@@ -452,8 +463,8 @@ module Generators
               change_spec[:scale]         = spec.scale         unless spec.scale.nil?
               change_spec[:null]          = spec.null          unless spec.null && col.null
               change_spec[:default]       = spec.default       unless spec.default.nil? && col.default.nil?
-              change_spec[:collation]     = spec.collation     unless spec.collation.nil?
               change_spec[:charset]       = spec.charset       unless spec.charset.nil?
+              change_spec[:collation]     = spec.collation     unless spec.collation.nil?
 
               changes << "change_column :#{new_table_name}, :#{c}, " +
                          ([":#{spec.sql_type}"] + format_options(change_spec, spec.sql_type, changing: true)).join(", ")
@@ -462,7 +473,7 @@ module Generators
             end
           end.compact
 
-          index_changes, undo_index_changes = change_indexes(model, current_table_name)
+          index_changes, undo_index_changes = change_indexes(model, current_table_name, to_remove)
           fk_changes, undo_fk_changes = if ActiveRecord::Base.connection.class.name.match?(/SQLite3Adapter/)
                                           [[], []]
                                         else
@@ -484,7 +495,7 @@ module Generators
            undo_table_options_changes * "\n"]
         end
 
-        def change_indexes(model, old_table_name)
+        def change_indexes(model, old_table_name, to_remove)
           return [[], []] if Migrator.disable_constraints
 
           new_table_name = model.table_name
@@ -497,7 +508,10 @@ module Generators
               end
             end || i
           end
-          existing_has_primary_key = existing_indexes.any? { |i| i.name == ::DeclareSchema::Model::IndexDefinition::PRIMARY_KEY_NAME }
+          existing_has_primary_key = existing_indexes.any? do |i|
+            i.name == ::DeclareSchema::Model::IndexDefinition::PRIMARY_KEY_NAME &&
+              !i.fields.all? { |f| to_remove.include?(f) } # if we're removing the primary key column(s), the primary key index will be removed too
+          end
           model_has_primary_key    = model_indexes.any?    { |i| i.name == ::DeclareSchema::Model::IndexDefinition::PRIMARY_KEY_NAME }
 
           add_indexes_init = model_indexes - existing_indexes
@@ -555,12 +569,13 @@ module Generators
 
         def format_options(options, type, changing: false)
           options.map do |k, v|
-            unless changing
-              next if k == :limit && (type == :decimal || v == native_types[type][:limit])
-              next if k == :null && v == true
+            if !changing && ((k == :limit && type == :decimal) || (k == :null && v == true))
+              next
             end
 
-            next if k == :limit && type == :text && !::DeclareSchema::Model::FieldSpec.mysql_text_limits?
+            if !::DeclareSchema::Model::FieldSpec.mysql_text_limits? && k == :limit && type == :text
+              next
+            end
 
             if k.is_a?(Symbol)
               "#{k}: #{v.inspect}"
@@ -574,9 +589,9 @@ module Generators
           foreign_key = model.constraint_specs.find { |fk| field_name == fk.foreign_key.to_s }
           if foreign_key && (parent_table = foreign_key.parent_table_name)
             parent_columns = connection.columns(parent_table) rescue []
-            pk_limit  =
+            pk_limit =
               if (pk_column = parent_columns.find { |column| column.name.to_s == "id" }) # right now foreign keys assume id is the target
-                if Rails::VERSION::MAJOR <= 4
+                if Rails::VERSION::MAJOR < 5
                   pk_column.cast_type.limit
                 else
                   pk_column.limit
@@ -605,6 +620,16 @@ module Generators
           end
         end
 
+        # TODO: TECH-4814 remove all methods from here through end of file
+        def default_collation_from_charset(charset)
+          case charset
+          when "utf8"
+            "utf8_general_ci"
+          when "utf8mb4"
+            "utf8mb4_general_ci"
+          end
+        end
+
         def revert_table(table)
           res = StringIO.new
           schema_dumper_klass = case Rails::VERSION::MAJOR
@@ -614,30 +639,55 @@ module Generators
                                   ActiveRecord::ConnectionAdapters::SchemaDumper
                                 end
           schema_dumper_klass.send(:new, ActiveRecord::Base.connection).send(:table, table, res)
-          res.string.strip.gsub("\n  ", "\n")
+
+          result = res.string.strip.gsub("\n  ", "\n")
+          if connection.class.name.match?(/mysql/i)
+            if !result['options: ']
+              result = result.sub('",', "\", options: \"DEFAULT CHARSET=#{Generators::DeclareSchema::Migration::Migrator.default_charset} "+
+                                   "COLLATE=#{Generators::DeclareSchema::Migration::Migrator.default_collation}\",")
+            end
+            default_charset   = result[/CHARSET=(\w+)/, 1]   or raise "unable to find charset in #{result.inspect}"
+            default_collation = result[/COLLATE=(\w+)/, 1] || default_collation_from_charset(default_charset) or
+              raise "unable to find collation in #{result.inspect} or charset #{default_charset.inspect}"
+            result = result.split("\n").map do |line|
+              if line['t.text'] || line['t.string']
+                if !line['charset: ']
+                  if line['collation: ']
+                    line = line.sub('collation: ', "charset: #{default_charset.inspect}, collation: ")
+                  else
+                    line += ", charset: #{default_charset.inspect}"
+                  end
+                end
+                line['collation: '] or line += ", collation: #{default_collation.inspect}"
+              end
+              line
+            end.join("\n")
+          end
+          result
         end
 
-        def column_options_from_reverted_table(table, col_name)
+        def column_options_from_reverted_table(table, column)
           revert = revert_table(table)
-          if (md = revert.match(/\s*t\.column\s+"#{col_name}",\s+(:[a-zA-Z0-9_]+)(?:,\s+(.*?)$)?/m))
+          if (md = revert.match(/\s*t\.column\s+"#{column}",\s+(:[a-zA-Z0-9_]+)(?:,\s+(.*?)$)?/m))
             # Ugly migration
             _, type, options = *md
-          elsif (md = revert.match(/\s*t\.([a-z_]+)\s+"#{col_name}"(?:,\s+(.*?)$)?/m))
+          elsif (md = revert.match(/\s*t\.([a-z_]+)\s+"#{column}"(?:,\s+(.*?)$)?/m))
             # Sexy migration
-            _, type, options = *md
-            type = ":#{type}"
+            _, string_type, options = *md
+            type = ":#{string_type}"
           end
+          type or raise "unable to find column options for #{table}.#{column} in #{revert.inspect}"
           [type, options]
         end
 
-        def change_column_back(table, col_name)
-          type, options = column_options_from_reverted_table(table, col_name)
-          "change_column :#{table}, :#{col_name}, #{type}#{', ' + options.strip if options}"
+        def change_column_back(table, column)
+          type, options = column_options_from_reverted_table(table, column)
+          ["change_column :#{table}, :#{column}, #{type}", options&.strip].compact.join(', ')
         end
 
         def revert_column(table, column)
           type, options = column_options_from_reverted_table(table, column)
-          "add_column :#{table}, :#{column}, #{type}#{', ' + options.strip if options}"
+          ["add_column :#{table}, :#{column}, #{type}", options&.strip].compact.join(', ')
         end
       end
     end

data/spec/lib/declare_schema/field_spec_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+RSpec.describe 'DeclareSchema Model FieldSpec' do
+  before do
+    load File.expand_path('prepare_testapp.rb', __dir__)
+  end
+
+  context 'There are no model columns to change' do
+    it '#different_to should return false for int8 == int8' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :integer, limit: 8, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::Integer.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "integer(8)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "integer(8)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+
+    it '#different_to should return false for bigint == bigint' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :bigint, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::BigInteger.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "bigint(20)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "bigint(20)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+
+    it '#different_to should return false for int8 == bigint' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :integer, limit: 8, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::BigInteger.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "bigint(20)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "bigint(20)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+
+    it '#different_to should return false for bigint == int8' do
+      subject = DeclareSchema::Model::FieldSpec.new(Object, :price, :bigint, null: false, position: 0)
+
+      case Rails::VERSION::MAJOR
+      when 4
+        cast_type = ActiveRecord::Type::Integer.new(limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, cast_type, "integer(8)", false)
+      else
+        sql_type_metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: "integer(8)", type: :integer, limit: 8)
+        col = ActiveRecord::ConnectionAdapters::Column.new("price", nil, sql_type_metadata, false, "adverts")
+      end
+
+      expect(subject.different_to?(subject.name, col)).to eq(false)
+    end
+  end
+end

data/spec/lib/declare_schema/generator_spec.rb

@@ -27,15 +27,28 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       end
     EOS
 
-    expect_test_definition_to_eq('alpha/beta', <<~EOS)
-      require 'test_helper'
-
-      class Alpha::BetaTest < ActiveSupport::TestCase
-        # test "the truth" do
-        #   assert true
-        # end
-      end
-    EOS
+    case Rails::VERSION::MAJOR
+    when 4, 5
+      expect_test_definition_to_eq('alpha/beta', <<~EOS)
+        require "test_helper"
+
+        class Alpha::BetaTest < ActiveSupport::TestCase
+          # test "the truth" do
+          #   assert true
+          # end
+        end
+      EOS
+    else
+      expect_test_definition_to_eq('alpha/beta', <<~EOS)
+        require "test_helper"
+
+        class Alpha::BetaTest < ActiveSupport::TestCase
+          # test "the truth" do
+          #   assert true
+          # end
+        end
+      EOS
+    end
 
     case Rails::VERSION::MAJOR
     when 4
@@ -88,7 +101,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(File.exist?('db/schema.rb')).to be_truthy
 
-    expect(File.exist?("db/development.sqlite3") || File.exist?("db/test.sqlite3")).to be_truthy
+    if defined?(SQLite3)
+      expect(File.exist?("db/development.sqlite3") || File.exist?("db/test.sqlite3")).to be_truthy
+    end
 
     module Alpha; end
     require 'alpha/beta'

data/spec/lib/declare_schema/interactive_primary_key_spec.rb

@@ -1,5 +1,11 @@
 # frozen_string_literal: true
 
+require 'rails'
+begin
+  require 'mysql2'
+rescue LoadError
+end
+
 RSpec.describe 'DeclareSchema Migration Generator interactive primary key' do
   before do
     load File.expand_path('prepare_testapp.rb', __dir__)
@@ -31,8 +37,8 @@ RSpec.describe 'DeclareSchema Migration Generator interactive primary key' do
 
     ### migrate to
 
-    if Rails::VERSION::MAJOR >= 5
-      # rename to custom primary_key
+    if Rails::VERSION::MAJOR >= 5 && !defined?(Mysql2) # TODO TECH-4814 Put this test back for Mysql2
+      # replace custom primary_key
       class Foo < ActiveRecord::Base
         fields do
         end

data/spec/lib/declare_schema/migration_generator_spec.rb

@@ -1,12 +1,53 @@
 # frozen_string_literal: true
 
 require 'rails'
+begin
+  require 'mysql2'
+rescue LoadError
+end
 
 RSpec.describe 'DeclareSchema Migration Generator' do
   before do
     load File.expand_path('prepare_testapp.rb', __dir__)
   end
 
+  let(:charset_alter_table) do
+    if defined?(Mysql2)
+      <<~EOS
+
+
+        execute "ALTER TABLE `adverts` CHARACTER SET utf8mb4 COLLATE utf8mb4_bin"
+      EOS
+    end
+  end
+  let(:text_limit) do
+    if defined?(Mysql2)
+      ", limit: 4294967295"
+    end
+  end
+  let(:charset_and_collation) do
+    if defined?(Mysql2)
+      ', charset: "utf8mb4", collation: "utf8mb4_bin"'
+    end
+  end
+  let(:datetime_precision) do
+    if defined?(Mysql2) && Rails::VERSION::MAJOR >= 5
+      ', precision: 0'
+    end
+  end
+  let(:table_options) do
+    if defined?(Mysql2)
+      ", options: \"#{'ENGINE=InnoDB ' if Rails::VERSION::MAJOR == 5}DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin\"" +
+        if Rails::VERSION::MAJOR >= 6
+          ', charset: "utf8mb4", collation: "utf8mb4_bin"'
+        else
+          ''
+        end
+    else
+      ", id: :integer" unless Rails::VERSION::MAJOR < 5
+    end
+  end
+
   # DeclareSchema - Migration Generator
   it 'generates migrations' do
     ## The migration generator -- introduction
@@ -25,7 +66,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
       end
     end
 
@@ -33,8 +74,8 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(migrations).to(
         migrate_up(<<~EOS.strip)
           create_table :adverts, id: :bigint do |t|
-            t.string :name, limit: 255
-          end
+            t.string :name, limit: 250#{charset_and_collation}
+          end#{charset_alter_table}
         EOS
         .and migrate_down("drop_table :adverts")
       )
@@ -44,14 +85,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Advert.columns.map(&:name)).to eq(["id", "name"])
 
     if Rails::VERSION::MAJOR < 5
-      # Rails 4 sqlite driver doesn't create PK properly. Fix that by dropping and recreating.
+      # Rails 4 drivers don't always create PK properly. Fix that by dropping and recreating.
       ActiveRecord::Base.connection.execute("drop table adverts")
-      ActiveRecord::Base.connection.execute('CREATE TABLE "adverts" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar(255))')
+      if defined?(Mysql2)
+        ActiveRecord::Base.connection.execute("CREATE TABLE adverts (id integer PRIMARY KEY AUTO_INCREMENT NOT NULL, name varchar(250)) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin")
+      else
+        ActiveRecord::Base.connection.execute("CREATE TABLE adverts (id integer PRIMARY KEY AUTOINCREMENT  NOT NULL, name varchar(250))")
+      end
     end
 
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
         body :text, null: true
         published_at :datetime, null: true
       end
@@ -62,7 +107,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(migrate).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :body, :text
+        add_column :adverts, :body, :text#{text_limit}#{charset_and_collation}
         add_column :adverts, :published_at, :datetime
       EOS
       .and migrate_down(<<~EOS.strip)
@@ -74,33 +119,33 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     Advert.field_specs.clear # not normally needed
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
         body :text, null: true
       end
     end
 
     expect(migrate).to(
       migrate_up("remove_column :adverts, :published_at").and(
-        migrate_down("add_column :adverts, :published_at, :datetime")
+        migrate_down("add_column :adverts, :published_at, :datetime#{datetime_precision}")
       )
     )
 
     nuke_model_class(Advert)
     class Advert < ActiveRecord::Base
       fields do
-        title :string, limit: 255, null: true
+        title :string, limit: 250, null: true
         body :text, null: true
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
         remove_column :adverts, :name
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :adverts, :title
-        add_column :adverts, :name, :string, limit: 255
+        add_column :adverts, :name, :string, limit: 250#{charset_and_collation}
       EOS
     )
 
@@ -120,24 +165,24 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up("change_column :adverts, :title, :text").and(
-        migrate_down("change_column :adverts, :title, :string, limit: 255")
+      migrate_up("change_column :adverts, :title, :text#{text_limit}#{charset_and_collation}").and(
+        migrate_down("change_column :adverts, :title, :string, limit: 250#{charset_and_collation}")
       )
     )
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, default: "Untitled", limit: 255, null: true
+        title :string, default: "Untitled", limit: 250, null: true
         body :text, null: true
       end
     end
 
     expect(migrate).to(
       migrate_up(<<~EOS.strip)
-        change_column :adverts, :title, :string, limit: 255, default: "Untitled"
+        change_column :adverts, :title, :string, limit: 250, default: "Untitled"#{charset_and_collation}
       EOS
       .and migrate_down(<<~EOS.strip)
-        change_column :adverts, :title, :string, limit: 255
+        change_column :adverts, :title, :string, limit: 250#{charset_and_collation}
       EOS
     )
 
@@ -187,7 +232,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     # If a `limit` is given, it will only be used in MySQL, to choose the smallest TEXT field that will accommodate
     # that limit (0xff for TINYTEXT, 0xffff for TEXT, 0xffffff for MEDIUMTEXT, 0xffffffff for LONGTEXT).
 
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_falsey
+    if defined?(SQLite3)
+      expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_falsey
+    end
+
     class Advert < ActiveRecord::Base
       fields do
         notes :text
@@ -198,113 +246,107 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
         add_column :adverts, :price, :decimal
-        add_column :adverts, :notes, :text, null: false
-        add_column :adverts, :description, :text, null: false
+        add_column :adverts, :notes, :text, null: false#{text_limit}#{charset_and_collation}
+        add_column :adverts, :description, :text, null: false#{', limit: 65535' if defined?(Mysql2)}#{charset_and_collation}
       EOS
     )
 
-    # (There is no limit on `add_column ... :description` above since these tests are run against SQLite.)
-
     Advert.field_specs.delete :price
     Advert.field_specs.delete :notes
     Advert.field_specs.delete :description
 
     # In MySQL, limits are applied, rounded up:
 
-    ::DeclareSchema::Model::FieldSpec::instance_variable_set(:@mysql_text_limits, true)
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
-    class Advert < ActiveRecord::Base
-      fields do
-        notes :text
-        description :text, limit: 200
-      end
-    end
-
-    expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up(<<~EOS.strip)
-        add_column :adverts, :notes, :text, null: false, limit: 4294967295
-        add_column :adverts, :description, :text, null: false, limit: 255
-      EOS
-    )
-
-    Advert.field_specs.delete :notes
-
-    # Limits that are too high for MySQL will raise an exception.
+    if defined?(Mysql2)
+      expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
 
-    ::DeclareSchema::Model::FieldSpec::instance_variable_set(:@mysql_text_limits, true)
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
-    expect do
       class Advert < ActiveRecord::Base
         fields do
           notes :text
-          description :text, limit: 0x1_0000_0000
+          description :text, limit: 250
         end
       end
-    end.to raise_exception(ArgumentError, "limit of 4294967296 is too large for MySQL")
 
-    Advert.field_specs.delete :notes
+      expect(Generators::DeclareSchema::Migration::Migrator.run).to(
+        migrate_up(<<~EOS.strip)
+          add_column :adverts, :notes, :text, null: false, limit: 4294967295#{charset_and_collation}
+          add_column :adverts, :description, :text, null: false, limit: 255#{charset_and_collation}
+        EOS
+      )
 
-    # And in MySQL, unstated text limits are treated as the maximum (LONGTEXT) limit.
+      Advert.field_specs.delete :notes
 
-    # To start, we'll set the database schema for `description` to match the above limit of 255.
+      # Limits that are too high for MySQL will raise an exception.
 
-    expect(::DeclareSchema::Model::FieldSpec.mysql_text_limits?).to be_truthy
-    Advert.connection.execute "ALTER TABLE adverts ADD COLUMN description TINYTEXT"
-    Advert.connection.schema_cache.clear!
-    Advert.reset_column_information
-    expect(Advert.connection.tables - Generators::DeclareSchema::Migration::Migrator.always_ignore_tables).
-      to eq(["adverts"])
-    expect(Advert.columns.map(&:name)).to eq(["id", "body", "title", "description"])
+      expect do
+        class Advert < ActiveRecord::Base
+          fields do
+            notes :text
+            description :text, limit: 0x1_0000_0000
+          end
+        end
+      end.to raise_exception(ArgumentError, "limit of 4294967296 is too large for MySQL")
 
-    # Now migrate to an unstated text limit:
+      Advert.field_specs.delete :notes
 
-    class Advert < ActiveRecord::Base
-      fields do
-        description :text
-      end
-    end
+      # And in MySQL, unstated text limits are treated as the maximum (LONGTEXT) limit.
 
-    expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up(<<~EOS.strip)
-        change_column :adverts, :description, :text, limit: 4294967295, null: false
-      EOS
-      .and migrate_down(<<~EOS.strip)
-        change_column :adverts, :description, :text
-      EOS
-    )
+      # To start, we'll set the database schema for `description` to match the above limit of 250.
 
-    # TODO TECH-4814: The above test should have this output:
-    # TODO => "change_column :adverts, :description, :text, limit: 255
+      Advert.connection.execute "ALTER TABLE adverts ADD COLUMN description TINYTEXT"
+      Advert.connection.schema_cache.clear!
+      Advert.reset_column_information
+      expect(Advert.connection.tables - Generators::DeclareSchema::Migration::Migrator.always_ignore_tables).
+        to eq(["adverts"])
+      expect(Advert.columns.map(&:name)).to eq(["id", "body", "title", "description"])
 
-    # And migrate to a stated text limit that is the same as the unstated one:
+      # Now migrate to an unstated text limit:
 
-    class Advert < ActiveRecord::Base
-      fields do
-        description :text, limit: 0xffffffff
+      class Advert < ActiveRecord::Base
+        fields do
+          description :text
+        end
       end
-    end
 
-    expect(Generators::DeclareSchema::Migration::Migrator.run).to(
-      migrate_up(<<~EOS.strip)
-        change_column :adverts, :description, :text, limit: 4294967295, null: false
-      EOS
-      .and migrate_down(<<~EOS.strip)
-        change_column :adverts, :description, :text
-      EOS
-    )
-    ::DeclareSchema::Model::FieldSpec::instance_variable_set(:@mysql_text_limits, false)
+      expect(Generators::DeclareSchema::Migration::Migrator.run).to(
+        migrate_up(<<~EOS.strip)
+          change_column :adverts, :description, :text, limit: 4294967295, null: false#{charset_and_collation}
+        EOS
+        .and migrate_down(<<~EOS.strip)
+          change_column :adverts, :description, :text#{', limit: 255' if defined?(Mysql2)}#{charset_and_collation}
+        EOS
+      )
+
+      # And migrate to a stated text limit that is the same as the unstated one:
+
+      class Advert < ActiveRecord::Base
+        fields do
+          description :text, limit: 0xffffffff
+        end
+      end
+
+      expect(Generators::DeclareSchema::Migration::Migrator.run).to(
+        migrate_up(<<~EOS.strip)
+          change_column :adverts, :description, :text, limit: 4294967295, null: false#{charset_and_collation}
+        EOS
+        .and migrate_down(<<~EOS.strip)
+          change_column :adverts, :description, :text#{', limit: 255' if defined?(Mysql2)}#{charset_and_collation}
+        EOS
+      )
+    end
 
     Advert.field_specs.clear
     Advert.connection.schema_cache.clear!
     Advert.reset_column_information
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
       end
     end
 
     up = Generators::DeclareSchema::Migration::Migrator.run.first
     ActiveRecord::Migration.class_eval up
+
     Advert.connection.schema_cache.clear!
     Advert.reset_column_information
 
@@ -316,7 +358,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     class Category < ActiveRecord::Base; end
     class Advert < ActiveRecord::Base
       fields do
-        name :string, limit: 255, null: true
+        name :string, limit: 250, null: true
       end
       belongs_to :category
     end
@@ -326,11 +368,15 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :category_id, :integer, limit: 8, null: false
 
         add_index :adverts, [:category_id], name: 'on_category_id'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" if defined?(Mysql2)}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :adverts, :category_id
 
         remove_index :adverts, name: :on_category_id rescue ActiveRecord::StatementInvalid
+
+        #{"remove_foreign_key('adverts', name: '')\n" if defined?(Mysql2)}
       EOS
     )
 
@@ -350,6 +396,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :c_id, :integer, limit: 8, null: false
 
         add_index :adverts, [:c_id], name: 'on_c_id'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -367,6 +416,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
         add_column :adverts, :category_id, :integer, limit: 8, null: false
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -386,6 +438,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :category_id, :integer, limit: 8, null: false
 
         add_index :adverts, [:category_id], name: 'my_index'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -409,11 +464,17 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         add_column :adverts, :created_at, :datetime
         add_column :adverts, :updated_at, :datetime
         add_column :adverts, :lock_version, :integer, null: false, default: 1
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :adverts, :created_at
         remove_column :adverts, :updated_at
         remove_column :adverts, :lock_version
+
+        #{"remove_foreign_key('adverts', name: '')\n" +
+          "remove_foreign_key('adverts', name: '')" if defined?(Mysql2)}
       EOS
     )
 
@@ -427,15 +488,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, index: true, limit: 255, null: true
+        title :string, index: true, limit: 250, null: true
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], name: 'on_title'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -445,15 +509,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, index: true, unique: true, null: true, limit: 255
+        title :string, index: true, unique: true, null: true, limit: 250
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], unique: true, name: 'on_title'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -463,15 +530,18 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        title :string, index: 'my_index', limit: 255, null: true
+        title :string, index: 'my_index', limit: 250, null: true
       end
     end
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], name: 'my_index'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -485,9 +555,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], name: 'on_title'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -501,9 +574,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title], unique: true, name: 'my_index'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -517,9 +593,12 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
-        add_column :adverts, :title, :string, limit: 255
+        add_column :adverts, :title, :string, limit: 250#{charset_and_collation}
 
         add_index :adverts, [:title, :category_id], name: 'on_title_and_category_id'
+
+        #{"execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\n" +
+          "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \"" if defined?(Mysql2)}
       EOS
     )
 
@@ -536,7 +615,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     class Advert < ActiveRecord::Base
       self.table_name = "ads"
       fields do
-        title :string, limit: 255, null: true
+        title :string, limit: 250, null: true
         body :text, null: true
       end
     end
@@ -548,10 +627,15 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       migrate_up(<<~EOS.strip)
         rename_table :adverts, :ads
 
-        add_column :ads, :title, :string, limit: 255
-        add_column :ads, :body, :text
+        add_column :ads, :title, :string, limit: 250#{charset_and_collation}
+        add_column :ads, :body, :text#{', limit: 4294967295' if defined?(Mysql2)}#{charset_and_collation}
 
-        add_index :ads, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :ads, [:id], unique: true, name: 'PRIMARY'\n"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE ads DROP PRIMARY KEY, ADD PRIMARY KEY (id)\"\n\n" +
+            "execute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_category_id FOREIGN KEY index_adverts_on_category_id(category_id) REFERENCES categories(id) \"\nexecute \"ALTER TABLE adverts ADD CONSTRAINT index_adverts_on_c_id FOREIGN KEY index_adverts_on_c_id(c_id) REFERENCES categories(id) \""
+          end}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :ads, :title
@@ -559,14 +643,20 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
         rename_table :ads, :adverts
 
-        add_index :adverts, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :adverts, [:id], unique: true, name: 'PRIMARY'\n"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE adverts DROP PRIMARY KEY, ADD PRIMARY KEY (id)\"\n\n" +
+            "remove_foreign_key('adverts', name: '')\n" +
+            "remove_foreign_key('adverts', name: '')"
+          end}
       EOS
     )
 
     # Set the table name back to what it should be and confirm we're in sync:
 
-    Advert.field_specs.delete(:title)
-    Advert.field_specs.delete(:body)
+    nuke_model_class(Advert)
+
     class Advert < ActiveRecord::Base
       self.table_name = "adverts"
     end
@@ -581,7 +671,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advertisement < ActiveRecord::Base
       fields do
-        title :string, limit: 255, null: true
+        title :string, limit: 250, null: true
         body :text, null: true
       end
     end
@@ -590,20 +680,28 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       migrate_up(<<~EOS.strip)
         rename_table :adverts, :advertisements
 
-        add_column :advertisements, :title, :string, limit: 255
-        add_column :advertisements, :body, :text
+        add_column :advertisements, :title, :string, limit: 250#{charset_and_collation}
+        add_column :advertisements, :body, :text#{', limit: 4294967295' if defined?(Mysql2)}#{charset_and_collation}
         remove_column :advertisements, :name
 
-        add_index :advertisements, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :advertisements, [:id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE advertisements DROP PRIMARY KEY, ADD PRIMARY KEY (id)\""
+          end}
       EOS
       .and migrate_down(<<~EOS.strip)
         remove_column :advertisements, :title
         remove_column :advertisements, :body
-        add_column :adverts, :name, :string, limit: 255
+        add_column :adverts, :name, :string, limit: 250#{charset_and_collation}
 
         rename_table :advertisements, :adverts
 
-        add_index :adverts, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :adverts, [:id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+            "execute \"ALTER TABLE adverts DROP PRIMARY KEY, ADD PRIMARY KEY (id)\""
+          end}
       EOS
     )
 
@@ -615,23 +713,15 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     # Dropping tables is where the automatic down-migration really comes in handy:
 
-    rails4_table_create = <<~EOS.strip
-      create_table "adverts", force: :cascade do |t|
-        t.string "name", limit: 255
-      end
-    EOS
-
-    rails5_table_create = <<~EOS.strip
-      create_table "adverts", id: :integer, force: :cascade do |t|
-        t.string "name", limit: 255
-      end
-    EOS
-
     expect(Generators::DeclareSchema::Migration::Migrator.run).to(
       migrate_up(<<~EOS.strip)
         drop_table :adverts
       EOS
-      .and migrate_down(Rails::VERSION::MAJOR >= 5 ? rails5_table_create : rails4_table_create)
+      .and migrate_down(<<~EOS.strip)
+        create_table "adverts"#{table_options}, force: :cascade do |t|
+          t.string "name", limit: 250#{charset_and_collation}
+        end
+      EOS
     )
 
     ## STI
@@ -643,7 +733,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     class Advert < ActiveRecord::Base
       fields do
         body :text, null: true
-        title :string, default: "Untitled", limit: 255, null: true
+        title :string, default: "Untitled", limit: 250, null: true
       end
     end
     up = Generators::DeclareSchema::Migration::Migrator.run.first
@@ -657,7 +747,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     up, _ = Generators::DeclareSchema::Migration::Migrator.run do |migrations|
       expect(migrations).to(
         migrate_up(<<~EOS.strip)
-          add_column :adverts, :type, :string, limit: 255
+          add_column :adverts, :type, :string, limit: 250#{charset_and_collation}
 
           add_index :adverts, [:type], name: 'on_type'
         EOS
@@ -696,7 +786,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class Advert < ActiveRecord::Base
       fields do
-        name :string, default: "No Name", limit: 255, null: true
+        name :string, default: "No Name", limit: 250, null: true
         body :text, null: true
       end
     end
@@ -704,11 +794,11 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Generators::DeclareSchema::Migration::Migrator.run(adverts: { title: :name })).to(
       migrate_up(<<~EOS.strip)
         rename_column :adverts, :title, :name
-        change_column :adverts, :name, :string, limit: 255, default: "No Name"
+        change_column :adverts, :name, :string, limit: 250, default: "No Name"#{charset_and_collation}
       EOS
       .and migrate_down(<<~EOS.strip)
         rename_column :adverts, :name, :title
-        change_column :adverts, :title, :string, limit: 255, default: "Untitled"
+        change_column :adverts, :title, :string, limit: 250, default: "Untitled"#{charset_and_collation}
       EOS
     )
 
@@ -717,7 +807,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     nuke_model_class(Advert)
     class Ad < ActiveRecord::Base
       fields do
-        title      :string, default: "Untitled", limit: 255
+        title      :string, default: "Untitled", limit: 250
         body       :text, null: true
         created_at :datetime
       end
@@ -728,16 +818,20 @@ RSpec.describe 'DeclareSchema Migration Generator' do
         rename_table :adverts, :ads
 
         add_column :ads, :created_at, :datetime, null: false
-        change_column :ads, :title, :string, limit: 255, null: false, default: \"Untitled\"
+        change_column :ads, :title, :string, limit: 250, null: false, default: \"Untitled\"#{charset_and_collation}
 
-        add_index :ads, [:id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :ads, [:id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+            'execute "ALTER TABLE ads DROP PRIMARY KEY, ADD PRIMARY KEY (id)"'
+          end}
       EOS
     )
 
     class Advert < ActiveRecord::Base
       fields do
         body :text, null: true
-        title :string, default: "Untitled", limit: 255, null: true
+        title :string, default: "Untitled", limit: 250, null: true
       end
     end
 
@@ -758,7 +852,11 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       migrate_up(<<~EOS.strip)
         rename_column :adverts, :id, :advert_id
 
-        add_index :adverts, [:advert_id], unique: true, name: 'PRIMARY'
+        #{if defined?(SQLite3)
+            "add_index :adverts, [:advert_id], unique: true, name: 'PRIMARY'"
+          elsif defined?(Mysql2)
+          'execute "ALTER TABLE adverts DROP PRIMARY KEY, ADD PRIMARY KEY (advert_id)"'
+          end}
       EOS
     )
 
@@ -771,7 +869,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
     class User < ActiveRecord::Base
       fields do
-        company :string, limit: 255, ruby_default: -> { "BigCorp" }
+        company :string, limit: 250, ruby_default: -> { "BigCorp" }
       end
     end
     expect(User.field_specs.keys).to eq(['company'])
@@ -790,7 +888,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
     expect(Ad).to receive(:validates).with(:company, presence: true, uniqueness: { case_sensitive: false })
     class Ad < ActiveRecord::Base
       fields do
-        company :string, limit: 255, index: true, unique: true, validates: { presence: true, uniqueness: { case_sensitive: false } }
+        company :string, limit: 250, index: true, unique: true, validates: { presence: true, uniqueness: { case_sensitive: false } }
       end
       self.primary_key = "advert_id"
     end
@@ -828,10 +926,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'converts defaults with .to_yaml' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: true, null: true, default: []
-            allow_hash :string, limit: 255, serialize: true, null: true, default: {}
-            allow_string :string, limit: 255, serialize: true, null: true, default: ['abc']
-            allow_null :string, limit: 255, serialize: true, null: true, default: nil
+            allow_list :string, limit: 250, serialize: true, null: true, default: []
+            allow_hash :string, limit: 250, serialize: true, null: true, default: {}
+            allow_string :string, limit: 250, serialize: true, null: true, default: ['abc']
+            allow_null :string, limit: 250, serialize: true, null: true, default: nil
           end
         end
 
@@ -846,7 +944,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: Array' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: Array, null: true
+            allow_list :string, limit: 250, serialize: Array, null: true
           end
         end
 
@@ -856,10 +954,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows Array defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: Array, null: true, default: [2]
-            allow_string :string, limit: 255, serialize: Array, null: true, default: ['abc']
-            allow_empty :string, limit: 255, serialize: Array, null: true, default: []
-            allow_null :string, limit: 255, serialize: Array, null: true, default: nil
+            allow_list :string, limit: 250, serialize: Array, null: true, default: [2]
+            allow_string :string, limit: 250, serialize: Array, null: true, default: ['abc']
+            allow_empty :string, limit: 250, serialize: Array, null: true, default: []
+            allow_null :string, limit: 250, serialize: Array, null: true, default: nil
           end
         end
 
@@ -874,7 +972,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: Hash' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: Hash, null: true
+            allow_list :string, limit: 250, serialize: Hash, null: true
           end
         end
 
@@ -884,9 +982,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows Hash defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_loc :string, limit: 255, serialize: Hash, null: true, default: { 'state' => 'CA' }
-            allow_hash :string, limit: 255, serialize: Hash, null: true, default: {}
-            allow_null :string, limit: 255, serialize: Hash, null: true, default: nil
+            allow_loc :string, limit: 250, serialize: Hash, null: true, default: { 'state' => 'CA' }
+            allow_hash :string, limit: 250, serialize: Hash, null: true, default: {}
+            allow_null :string, limit: 250, serialize: Hash, null: true, default: nil
           end
         end
 
@@ -900,7 +998,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: JSON' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: JSON
+            allow_list :string, limit: 250, serialize: JSON
           end
         end
 
@@ -910,10 +1008,10 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows JSON defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_hash :string, limit: 255, serialize: JSON, null: true, default: { 'state' => 'CA' }
-            allow_empty_array :string, limit: 255, serialize: JSON, null: true, default: []
-            allow_empty_hash :string, limit: 255, serialize: JSON, null: true, default: {}
-            allow_null :string, limit: 255, serialize: JSON, null: true, default: nil
+            allow_hash :string, limit: 250, serialize: JSON, null: true, default: { 'state' => 'CA' }
+            allow_empty_array :string, limit: 250, serialize: JSON, null: true, default: []
+            allow_empty_hash :string, limit: 250, serialize: JSON, null: true, default: {}
+            allow_null :string, limit: 250, serialize: JSON, null: true, default: nil
           end
         end
 
@@ -950,7 +1048,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows serialize: ValueClass' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_list :string, limit: 255, serialize: ValueClass
+            allow_list :string, limit: 250, serialize: ValueClass
           end
         end
 
@@ -960,9 +1058,9 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       it 'allows ValueClass defaults' do
         class Ad < ActiveRecord::Base
           fields do
-            allow_hash :string, limit: 255, serialize: ValueClass, null: true, default: ValueClass.new([2])
-            allow_empty_array :string, limit: 255, serialize: ValueClass, null: true, default: ValueClass.new([])
-            allow_null :string, limit: 255, serialize: ValueClass, null: true, default: nil
+            allow_hash :string, limit: 250, serialize: ValueClass, null: true, default: ValueClass.new([2])
+            allow_empty_array :string, limit: 250, serialize: ValueClass, null: true, default: ValueClass.new([])
+            allow_null :string, limit: 250, serialize: ValueClass, null: true, default: nil
           end
         end
 
@@ -1003,7 +1101,7 @@ RSpec.describe 'DeclareSchema Migration Generator' do
 
         class Advert < ActiveRecord::Base
           fields do
-            name :string, limit: 255, null: true
+            name :string, limit: 250, null: true
             category_id :integer, limit: 8
             nullable_category_id :integer, limit: 8, null: true
           end
@@ -1093,4 +1191,33 @@ RSpec.describe 'DeclareSchema Migration Generator' do
       expect(base_class).to eq("(Rails::VERSION::MAJOR >= 5 ? ActiveRecord::Migration[4.2] : ActiveRecord::Migration)")
     end
   end
+
+  context 'Does not generate migrations' do
+    it 'for aliased fields bigint -> integer limit 8' do
+      if Rails::VERSION::MAJOR >= 5 || !ActiveRecord::Base.connection.class.name.match?(/SQLite3Adapter/)
+        class Advert < active_record_base_class.constantize
+          fields do
+            price :bigint
+          end
+        end
+
+        generate_migrations '-n', '-m'
+
+        migrations = Dir.glob('db/migrate/*declare_schema_migration*.rb')
+        expect(migrations.size).to eq(1), migrations.inspect
+
+        if defined?(Mysql2) && Rails::VERSION::MAJOR < 5
+          ActiveRecord::Base.connection.execute("ALTER TABLE adverts ADD PRIMARY KEY (id)")
+        end
+
+        class Advert < active_record_base_class.constantize
+          fields do
+            price :integer, limit: 8
+          end
+        end
+
+        expect { generate_migrations '-n', '-g' }.to output("Database and models match -- nothing to change\n").to_stdout
+      end
+    end
+  end
 end