declare_schema 0.10.0 → 0.12.0.pre.2

data/spec/lib/declare_schema/model/column_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails'
-
 begin
   require 'mysql2'
 rescue LoadError
@@ -16,7 +14,7 @@ RSpec.describe DeclareSchema::Model::Column do
 
   describe 'class methods' do
     describe '.native_type?' do
-      if Rails::VERSION::MAJOR >= 5
+      if ActiveSupport::VERSION::MAJOR >= 5
         let(:native_types) { [:string, :text, :integer, :float, :decimal, :datetime, :time, :date, :binary, :boolean, :json] }
       else
         let(:native_types) { [:string, :text, :integer, :float, :decimal, :datetime, :time, :date, :binary, :boolean] }
@@ -65,9 +63,7 @@ RSpec.describe DeclareSchema::Model::Column do
     end
 
     describe '.deserialize_default_value' do
-      require 'rails'
-
-      if ::Rails::VERSION::MAJOR >= 5
+      if ::ActiveSupport::VERSION::MAJOR >= 5
         it 'deserializes :boolean' do
           expect(described_class.deserialize_default_value(nil, :boolean, 'true')).to eq(true)
           expect(described_class.deserialize_default_value(nil, :boolean, 'false')).to eq(false)

data/spec/lib/declare_schema/model/foreign_key_definition_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
       subject { described_class.new(model, foreign_key, options)}
 
       before do
-        allow(connection).to receive(:index_name).with('models', column: 'network_id') { 'on_network_id' }
+        allow(model.connection).to receive(:index_name).with(any_args) { 'index_on_network_id' }
       end
 
       describe '#initialize' do
@@ -36,7 +36,7 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
         end
 
         context 'when most options passed' do
-          let(:options) { { parent_table: :networks, foreign_key: :the_network_id, index_name: :index_on_network_id } }
+          let(:options) { { parent_table: :networks, foreign_key: :the_network_id } }
 
           it 'normalizes symbols to strings' do
             expect(subject.foreign_key).to eq('network_id')
@@ -50,8 +50,7 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
 
         context 'when all options passed' do
           let(:foreign_key) { nil }
-          let(:options) { { parent_table: :networks, foreign_key: :the_network_id, index_name: :index_on_network_id,
-                            constraint_name: :constraint_1, dependent: :delete } }
+          let(:options) { { parent_table: :networks, foreign_key: :the_network_id, constraint_name: :constraint_1, dependent: :delete } }
 
           it 'normalizes symbols to strings' do
             expect(subject.foreign_key).to be_nil
@@ -61,11 +60,18 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
             expect(subject.on_delete_cascade).to be_truthy
           end
         end
-      end
 
-      describe '#to_add_statement' do
-        it 'returns add_foreign_key command' do
-          expect(subject.to_add_statement).to eq('add_foreign_key("models", "networks", column: "network_id", name: "on_network_id")')
+        context 'when constraint name passed as empty string' do
+          let(:options) { { constraint_name: "" } }
+          it 'defaults to rails constraint name' do
+            expect(subject.constraint_name).to eq("index_on_network_id")
+          end
+        end
+
+        context 'when no constraint name passed' do
+          it 'defaults to rails constraint name' do
+            expect(subject.constraint_name).to eq("index_on_network_id")
+          end
         end
       end
     end
@@ -113,7 +119,7 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
       subject { described_class.new(model, foreign_key, options)}
 
       before do
-        allow(connection).to receive(:index_name).with('models', column: 'network_id') { 'on_network_id' }
+        allow(model.connection).to receive(:index_name).with(any_args) { 'index_on_network_id' }
       end
 
       describe '#initialize' do
@@ -123,7 +129,7 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
         end
 
         context 'when most options passed' do
-          let(:options) { { parent_table: :networks, foreign_key: :the_network_id, index_name: :index_on_network_id } }
+          let(:options) { { parent_table: :networks, foreign_key: :the_network_id } }
 
           it 'normalizes symbols to strings' do
             expect(subject.foreign_key).to eq('network_id')
@@ -137,8 +143,7 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
 
         context 'when all options passed' do
           let(:foreign_key) { nil }
-          let(:options) { { parent_table: :networks, foreign_key: :the_network_id, index_name: :index_on_network_id,
-                            constraint_name: :constraint_1, dependent: :delete } }
+          let(:options) { { parent_table: :networks, foreign_key: :the_network_id, constraint_name: :constraint_1, dependent: :delete } }
 
           it 'normalizes symbols to strings' do
             expect(subject.foreign_key).to be_nil
@@ -148,11 +153,18 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
             expect(subject.on_delete_cascade).to be_truthy
           end
         end
-      end
 
-      describe '#to_add_statement' do
-        it 'returns add_foreign_key command' do
-          expect(subject.to_add_statement).to eq('add_foreign_key("models", "networks", column: "network_id", name: "on_network_id")')
+        context 'when constraint name passed as empty string' do
+          let(:options) { { constraint_name: "" } }
+          it 'defaults to rails constraint name' do
+            expect(subject.constraint_name).to eq("index_on_network_id")
+          end
+        end
+
+        context 'when no constraint name passed' do
+          it 'defaults to rails constraint name' do
+            expect(subject.constraint_name).to eq("index_on_network_id")
+          end
         end
       end
     end

data/spec/lib/declare_schema/model/habtm_model_shim_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails'
-
 begin
   require 'mysql2'
 rescue LoadError
@@ -57,7 +55,7 @@ RSpec.describe DeclareSchema::Model::HabtmModelShim do
 
     describe '#table_options' do
       it 'returns empty hash' do
-        expect(subject.table_options).to eq({})
+        expect(subject._table_options).to eq({})
       end
     end
 
@@ -88,13 +86,13 @@ RSpec.describe DeclareSchema::Model::HabtmModelShim do
 
     describe '#primary_key' do
       it 'returns false' do
-        expect(subject._defined_primary_key).to eq(false)
+        expect(subject._declared_primary_key).to eq(false)
       end
     end
 
-    describe '#_defined_primary_key' do
+    describe '#_declared_primary_key' do
       it 'returns false' do
-        expect(subject._defined_primary_key).to eq(false)
+        expect(subject._declared_primary_key).to eq(false)
       end
     end
 

data/spec/lib/declare_schema/model/index_definition_spec.rb

@@ -75,7 +75,7 @@ RSpec.describe DeclareSchema::Model::IndexDefinition do
           ActiveRecord::Base.connection.execute <<~EOS
               CREATE TABLE index_definition_test_models (
                 id INTEGER NOT NULL PRIMARY KEY,
-                name #{if defined?(Sqlite3) then 'TEXT' else 'VARCHAR(255)' end} NOT NULL
+                name #{if defined?(SQLite3) then 'TEXT' else 'VARCHAR(255)' end} NOT NULL
               )
           EOS
           ActiveRecord::Base.connection.execute <<~EOS
@@ -110,7 +110,7 @@ RSpec.describe DeclareSchema::Model::IndexDefinition do
             let(:model_class) { IndexDefinitionCompoundIndexModel }
 
             it 'returns the indexes for the model' do
-              if Rails::VERSION::MAJOR < 5
+              if ActiveSupport::VERSION::MAJOR < 5
                 expect(model_class.connection).to receive(:primary_key).with('index_definition_compound_index_models').and_return(nil)
                 connection_stub = instance_double(ActiveRecord::Base.connection.class, "connection")
                 expect(connection_stub).to receive(:indexes).
@@ -184,7 +184,7 @@ RSpec.describe DeclareSchema::Model::IndexDefinition do
           ActiveRecord::Base.connection.execute <<~EOS
             CREATE TABLE index_definition_test_models (
               id INTEGER NOT NULL PRIMARY KEY,
-              name #{if defined?(Sqlite3) then 'TEXT' else 'VARCHAR(255)' end} NOT NULL
+              name #{if defined?(SQLite3) then 'TEXT' else 'VARCHAR(255)' end} NOT NULL
             )
           EOS
           ActiveRecord::Base.connection.execute <<~EOS
@@ -219,7 +219,7 @@ RSpec.describe DeclareSchema::Model::IndexDefinition do
             let(:model_class) { IndexDefinitionCompoundIndexModel }
 
             it 'returns the indexes for the model' do
-              if Rails::VERSION::MAJOR < 5
+              if ActiveSupport::VERSION::MAJOR < 5
                 expect(model_class.connection).to receive(:primary_key).with('index_definition_compound_index_models').and_return(nil)
                 connection_stub = instance_double(ActiveRecord::Base.connection.class, "connection")
                 expect(connection_stub).to receive(:indexes).

data/spec/lib/declare_schema/schema_change/base_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/base'
+
+RSpec.describe DeclareSchema::SchemaChange::Base do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  before :all do
+    class ChangeDefault < described_class
+      attr_reader :up_command, :down_command
+
+      def initialize(up:, down:)
+        @up_command = up
+        @down_command = down
+      end
+    end
+
+    class ChangeOverride < described_class
+      attr_reader :up_command, :down_command
+
+      def initialize(up:, down:)
+        @up_command = up
+        @down_command = down
+      end
+    end
+  end
+
+  describe 'class methods' do
+    describe 'format_options' do
+      subject { { limit: 8, 'key' => 'value', subhash: { subkey: :subvalue } } }
+
+      it 'formats using Ruby 2.0 symbol notation' do
+        expect(described_class.format_options(subject)).to eq(['limit: 8', '"key" => "value"', 'subhash: { subkey: :subvalue }'])
+      end
+    end
+  end
+
+  describe 'instance methods' do
+    describe '#up/#down' do
+      context 'with single-line commands' do
+        subject { ChangeDefault.new(up: "up_command", down: "down_command" )}
+
+        describe '#up' do
+          it 'responds with command and single spacing' do
+            expect(subject.up).to eq("up_command\n")
+          end
+        end
+
+        describe '#down' do
+          it 'responds with command and single spacing' do
+            expect(subject.down).to eq("down_command\n")
+          end
+        end
+      end
+
+      context 'with multi-line commands' do
+        subject { ChangeDefault.new(up: "up_command 1\nup_command 2", down: "down_command 1\ndown_command 2" )}
+
+        describe '#up' do
+          it 'responds with command and double spacing' do
+            expect(subject.up).to eq("up_command 1\nup_command 2\n\n")
+          end
+        end
+
+        describe '#down' do
+          it 'responds with command and spacing' do
+            expect(subject.down).to eq("down_command 1\ndown_command 2\n\n")
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_add_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_add'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnAdd do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:column_name) { 'title' }
+  let(:column_type) { :integer }
+  let(:column_options) { { limit: 8 } }
+  let(:column_options_string) { "limit: 8" }
+  subject { described_class.new(table_name, column_name, column_type, column_options) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("add_column :#{table_name}, :#{column_name}, :#{column_type}, #{column_options_string}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("remove_column :#{table_name}, :#{column_name}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_change_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_change'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnChange do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:column_name) { 'title' }
+  let(:old_type) { :string }
+  let(:old_options) { { limit: 255, null: false } }
+  let(:old_options_string) { "limit: 255, null: false" }
+  let(:new_type) { :text }
+  let(:new_options) { { limit: 0xffff, null: true } }
+  let(:new_options_string) { "limit: 65535, null: true" }
+  subject { described_class.new(table_name, column_name, old_type: old_type, old_options: old_options, new_type: new_type, new_options: new_options) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("change_column :#{table_name}, :#{column_name}, :#{new_type}, #{new_options_string}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("change_column :#{table_name}, :#{column_name}, :#{old_type}, #{old_options_string}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_remove_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_remove'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnRemove do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:column_name) { 'title' }
+  let(:column_type) { :integer }
+  let(:column_options) { { limit: 8 } }
+  let(:column_options_string) { "limit: 8" }
+  subject { described_class.new(table_name, column_name, column_type, column_options) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("remove_column :#{table_name}, :#{column_name}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("add_column :#{table_name}, :#{column_name}, :#{column_type}, #{column_options_string}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_rename_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_rename'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnRename do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:old_name) { 'title' }
+  let(:new_name) { 'summary' }
+  subject { described_class.new(table_name, old_name, new_name) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("rename_column :#{table_name}, :#{old_name}, :#{new_name}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("rename_column :#{table_name}, :#{new_name}, :#{old_name}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/foreign_key_add_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/foreign_key_add'
+
+RSpec.describe DeclareSchema::SchemaChange::ForeignKeyAdd do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:parent_table_name) { 'organization' }
+  let(:column_name) { :organization_id }
+  let(:name) { 'on_organization_id' }
+  subject { described_class.new(table_name, parent_table_name, column_name: column_name, name: name) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("add_foreign_key :#{table_name}, :#{parent_table_name}, column: #{column_name.to_sym.inspect}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("remove_foreign_key :#{table_name}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/foreign_key_remove_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/foreign_key_remove'
+
+RSpec.describe DeclareSchema::SchemaChange::ForeignKeyRemove do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:parent_table_name) { 'organization' }
+  let(:column_name) { :organization_id }
+  let(:name) { 'on_organization_id' }
+  subject { described_class.new(table_name, parent_table_name, column_name: column_name, name: name) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("remove_foreign_key :#{table_name}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("add_foreign_key :#{table_name}, :#{parent_table_name}, column: #{column_name.to_sym.inspect}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+  end
+end