declare_schema 0.10.0 → 0.10.1

data/spec/lib/declare_schema/model/foreign_key_definition_spec.rb

@@ -62,12 +62,6 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
           end
         end
       end
-
-      describe '#to_add_statement' do
-        it 'returns add_foreign_key command' do
-          expect(subject.to_add_statement).to eq('add_foreign_key("models", "networks", column: "network_id", name: "on_network_id")')
-        end
-      end
     end
 
     describe 'class << self' do
@@ -149,12 +143,6 @@ RSpec.describe DeclareSchema::Model::ForeignKeyDefinition do
           end
         end
       end
-
-      describe '#to_add_statement' do
-        it 'returns add_foreign_key command' do
-          expect(subject.to_add_statement).to eq('add_foreign_key("models", "networks", column: "network_id", name: "on_network_id")')
-        end
-      end
     end
 
     describe 'class << self' do

data/spec/lib/declare_schema/schema_change/base_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/base'
+
+RSpec.describe DeclareSchema::SchemaChange::Base do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  before :all do
+    class ChangeDefault < described_class
+      attr_reader :up_command, :down_command
+
+      def initialize(up:, down:)
+        @up_command = up
+        @down_command = down
+      end
+    end
+
+    class ChangeOverride < described_class
+      attr_reader :up_command, :down_command
+
+      def initialize(up:, down:)
+        @up_command = up
+        @down_command = down
+      end
+    end
+  end
+
+  describe 'class methods' do
+    describe 'format_options' do
+      subject { { limit: 8, 'key' => 'value', subhash: { subkey: :subvalue } } }
+
+      it 'formats using Ruby 2.0 symbol notation' do
+        expect(described_class.format_options(subject)).to eq(['limit: 8', '"key" => "value"', 'subhash: { subkey: :subvalue }'])
+      end
+    end
+  end
+
+  describe 'instance methods' do
+    describe '#up/#down' do
+      context 'with single-line commands' do
+        subject { ChangeDefault.new(up: "up_command", down: "down_command" )}
+
+        describe '#up' do
+          it 'responds with command and single spacing' do
+            expect(subject.up).to eq("up_command\n")
+          end
+        end
+
+        describe '#down' do
+          it 'responds with command and single spacing' do
+            expect(subject.down).to eq("down_command\n")
+          end
+        end
+      end
+
+      context 'with multi-line commands' do
+        subject { ChangeDefault.new(up: "up_command 1\nup_command 2", down: "down_command 1\ndown_command 2" )}
+
+        describe '#up' do
+          it 'responds with command and double spacing' do
+            expect(subject.up).to eq("up_command 1\nup_command 2\n\n")
+          end
+        end
+
+        describe '#down' do
+          it 'responds with command and spacing' do
+            expect(subject.down).to eq("down_command 1\ndown_command 2\n\n")
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_add_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_add'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnAdd do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:column_name) { 'title' }
+  let(:column_type) { :integer }
+  let(:column_options) { { limit: 8 } }
+  let(:column_options_string) { "limit: 8" }
+  subject { described_class.new(table_name, column_name, column_type, column_options) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("add_column :#{table_name}, :#{column_name}, :#{column_type}, #{column_options_string}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("remove_column :#{table_name}, :#{column_name}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_change_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_change'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnChange do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:column_name) { 'title' }
+  let(:old_type) { :string }
+  let(:old_options) { { limit: 255, null: false } }
+  let(:old_options_string) { "limit: 255, null: false" }
+  let(:new_type) { :text }
+  let(:new_options) { { limit: 0xffff, null: true } }
+  let(:new_options_string) { "limit: 65535, null: true" }
+  subject { described_class.new(table_name, column_name, old_type: old_type, old_options: old_options, new_type: new_type, new_options: new_options) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("change_column :#{table_name}, :#{column_name}, :#{new_type}, #{new_options_string}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("change_column :#{table_name}, :#{column_name}, :#{old_type}, #{old_options_string}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_remove_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_remove'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnRemove do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:column_name) { 'title' }
+  let(:column_type) { :integer }
+  let(:column_options) { { limit: 8 } }
+  let(:column_options_string) { "limit: 8" }
+  subject { described_class.new(table_name, column_name, column_type, column_options) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("remove_column :#{table_name}, :#{column_name}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("add_column :#{table_name}, :#{column_name}, :#{column_type}, #{column_options_string}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/column_rename_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/column_rename'
+
+RSpec.describe DeclareSchema::SchemaChange::ColumnRename do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'networks' }
+  let(:old_name) { 'title' }
+  let(:new_name) { 'summary' }
+  subject { described_class.new(table_name, old_name, new_name) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("rename_column :#{table_name}, :#{old_name}, :#{new_name}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("rename_column :#{table_name}, :#{new_name}, :#{old_name}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/foreign_key_add_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/foreign_key_add'
+
+RSpec.describe DeclareSchema::SchemaChange::ForeignKeyAdd do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:parent_table_name) { 'organization' }
+  let(:column_name) { :organization_id }
+  let(:name) { 'on_organization_id' }
+  subject { described_class.new(table_name, parent_table_name, column_name: column_name, name: name) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("add_foreign_key :#{table_name}, :#{parent_table_name}, column: #{column_name.to_sym.inspect}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("remove_foreign_key :#{table_name}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/foreign_key_remove_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/foreign_key_remove'
+
+RSpec.describe DeclareSchema::SchemaChange::ForeignKeyRemove do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:parent_table_name) { 'organization' }
+  let(:column_name) { :organization_id }
+  let(:name) { 'on_organization_id' }
+  subject { described_class.new(table_name, parent_table_name, column_name: column_name, name: name) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("remove_foreign_key :#{table_name}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("add_foreign_key :#{table_name}, :#{parent_table_name}, column: #{column_name.to_sym.inspect}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/index_add_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/index_add'
+
+RSpec.describe DeclareSchema::SchemaChange::IndexAdd do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:column_names) { [:last_name, 'first_name'] }
+  let(:name) { 'on_last_name_and_first_name' }
+  let(:unique) { false }
+  subject { described_class.new(table_name, column_names, name: name, unique: unique) }
+
+  describe '#up/down' do
+    describe '#up' do
+      context 'without where:' do
+        it 'responds with command' do
+          expect(subject.up).to eq("add_index :#{table_name}, #{column_names.map(&:to_sym).inspect}, name: #{name.to_sym.inspect}\n")
+        end
+      end
+
+      context 'with empty where:' do
+        subject { described_class.new(table_name, column_names, name: name, unique: unique, where: nil) }
+
+        it 'responds with command' do
+          expect(subject.up).to eq("add_index :#{table_name}, #{column_names.map(&:to_sym).inspect}, name: #{name.to_sym.inspect}\n")
+        end
+      end
+
+      context 'with where:' do
+        let(:where) { "'last_name like 'A%'"}
+        subject { described_class.new(table_name, column_names, name: name, unique: unique, where: where) }
+
+        it 'responds with command' do
+          expect(subject.up).to eq("add_index :#{table_name}, #{column_names.map(&:to_sym).inspect}, name: #{name.to_sym.inspect}, where: #{where.inspect}\n")
+        end
+      end
+
+      context 'with unique: true' do
+        let(:unique) { true }
+
+        it 'responds with command' do
+          expect(subject.up).to eq("add_index :#{table_name}, #{column_names.map(&:to_sym).inspect}, name: #{name.to_sym.inspect}, unique: true\n")
+        end
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("remove_index :#{table_name}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/index_remove_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/index_remove'
+
+RSpec.describe DeclareSchema::SchemaChange::IndexRemove do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:column_names) { [:last_name, 'first_name'] }
+  let(:name) { 'on_last_name_and_first_name' }
+  let(:unique) { true }
+  subject { described_class.new(table_name, column_names, name: name, unique: unique) }
+
+  describe '#up/down' do
+    describe '#up' do
+      it 'responds with command' do
+        expect(subject.up).to eq("remove_index :#{table_name}, name: #{name.to_sym.inspect}\n")
+      end
+    end
+
+    describe '#down' do
+      it 'responds with command' do
+        expect(subject.down).to eq("add_index :#{table_name}, #{column_names.map(&:to_sym).inspect}, name: #{name.to_sym.inspect}, unique: #{unique}\n")
+      end
+    end
+  end
+end

data/spec/lib/declare_schema/schema_change/primary_key_change_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+require_relative '../../../../lib/declare_schema/schema_change/primary_key_change'
+
+RSpec.describe DeclareSchema::SchemaChange::PrimaryKeyChange do
+  before do
+    load File.expand_path('../prepare_testapp.rb', __dir__)
+  end
+
+  let(:table_name) { 'users' }
+  let(:old_column_names) { ['id'] }
+  let(:new_column_names) { [:last_name, 'first_name'] }
+  let(:name) { 'PRIMARY' }
+  subject { described_class.new(table_name, old_column_names, new_column_names) }
+
+  describe '#up/down' do
+    context 'when PRIMARY KEY set -> set' do
+      describe '#up' do
+        it 'responds with command' do
+          command = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} DROP PRIMARY KEY, ADD PRIMARY KEY (#{new_column_names.join(', ')})"
+          expect(subject.up).to eq("execute #{command.inspect}\n")
+        end
+      end
+
+      describe '#down' do
+        it 'responds with command' do
+          command = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} DROP PRIMARY KEY, ADD PRIMARY KEY (#{old_column_names.join(', ')})"
+          expect(subject.down).to eq("execute #{command.inspect}\n")
+        end
+      end
+    end
+
+    context 'when PRIMARY KEY unset -> set' do
+      let(:old_column_names) { nil }
+
+      describe '#up' do
+        it 'responds with command' do
+          command = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} ADD PRIMARY KEY (#{new_column_names.join(', ')})"
+          expect(subject.up).to eq("execute #{command.inspect}\n")
+        end
+      end
+
+      describe '#down' do
+        it 'responds with command' do
+          command = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} DROP PRIMARY KEY"
+          expect(subject.down).to eq("execute #{command.inspect}\n")
+        end
+      end
+    end
+
+    context 'when PRIMARY KEY set -> unset' do
+      let(:new_column_names) { nil }
+
+      describe '#up' do
+        it 'responds with command' do
+          command = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} DROP PRIMARY KEY"
+          expect(subject.up).to eq("execute #{command.inspect}\n")
+        end
+      end
+
+      describe '#down' do
+        it 'responds with command' do
+          command = "ALTER TABLE #{ActiveRecord::Base.connection.quote_table_name(table_name)} ADD PRIMARY KEY (#{old_column_names.join(', ')})"
+          expect(subject.down).to eq("execute #{command.inspect}\n")
+        end
+      end
+    end
+  end
+end