declare_schema 0.1.0 → 0.2.0

data/spec/lib/declare_schema/prepare_testapp.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require 'tmpdir'
+
+TESTAPP_PATH = ENV['TESTAPP_PATH'] || File.join(Dir.tmpdir, 'declare_schema_testapp') unless defined?(TESTAPP_PATH)
+FileUtils.chdir(TESTAPP_PATH)
+
+system "rm -rf app/models/ad* app/models/alpha*"
+system "rm -rf test/models/ad* test/models/alpha*"
+system "rm -rf test/fixtures/ad* test/fixtures/alpha*"
+system "rm -rf db/migrate/*"
+system "mkdir -p #{TESTAPP_PATH}/app/assets/config"
+system "echo '' >> #{TESTAPP_PATH}/app/assets/config/manifest.js"
+
+require "#{TESTAPP_PATH}/config/environment"
+
+require 'rails/generators'
+Rails::Generators.configure!(Rails.application.config.generators)
+
+(ActiveRecord::Base.connection.tables - Generators::DeclareSchema::Migration::Migrator.always_ignore_tables).each do |table|
+  ActiveRecord::Base.connection.execute("DROP TABLE #{ActiveRecord::Base.connection.quote_table_name(table)}")
+end
+
+ActiveRecord::Base.send(:descendants).each do |model|
+  unless model.name['Active'] || model.name['Application']
+    nuke_model_class(model)
+  end
+end

data/spec/lib/generators/declare_schema/migration/migrator_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rails'
+require 'rails/generators'
+
+module Generators
+  module DeclareSchema
+    module Migration
+      RSpec.describe Migrator do
+        before do
+          ActiveRecord::Base.connection.tables
+        end
+
+        subject { described_class.new }
+
+        describe 'format_options' do
+          let(:mysql_longtext_limit) { 0xffff_ffff }
+
+          context 'MySQL' do
+            before do
+              expect(::DeclareSchema::Model::FieldSpec).to receive(:mysql_text_limits?).and_return(true)
+            end
+
+            it 'returns text limits' do
+              expect(subject.format_options({ limit: mysql_longtext_limit }, :text)).to eq(["limit: #{mysql_longtext_limit}"])
+            end
+          end
+
+          context 'non-MySQL' do
+            before do
+              expect(::DeclareSchema::Model::FieldSpec).to receive(:mysql_text_limits?).and_return(false)
+            end
+
+            it 'returns text limits' do
+              expect(subject.format_options({ limit: mysql_longtext_limit }, :text)).to eq([])
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -22,6 +22,32 @@ RSpec.configure do |config|
 
   RSpec::Support::ObjectFormatter.default_instance.max_formatted_output_length = 2_000
 
+  def active_record_base_class
+    if Rails::VERSION::MAJOR == 4
+      'ActiveRecord::Base'
+    else
+      'ApplicationRecord'
+    end
+  end
+
+  def migrate(renames = {})
+    up, down = Generators::DeclareSchema::Migration::Migrator.run(renames)
+    ActiveRecord::Migration.class_eval(up)
+    ActiveRecord::Base.send(:descendants).each { |model| model.reset_column_information }
+    [up, down]
+  end
+
+  def nuke_model_class(klass)
+    ActiveSupport::DescendantsTracker.instance_eval do
+      direct_descendants = class_variable_get('@@direct_descendants')
+      direct_descendants[ActiveRecord::Base] = direct_descendants[ActiveRecord::Base].to_a.reject { |descendant| descendant == klass }
+      if defined?(ApplicationRecord)
+        direct_descendants[ApplicationRecord] = direct_descendants[ApplicationRecord].to_a.reject { |descendant| descendant == klass }
+      end
+    end
+    Object.instance_eval { remove_const(klass.name.to_sym) rescue nil }
+  end
+
   def with_modified_env(options, &block)
     ClimateControl.modify(options, &block)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: declare_schema
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Invoca Development adapted from hobo_fields by Tom Locke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-23 00:00:00.000000000 Z
+date: 2020-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -35,11 +35,10 @@ files:
 - ".dependabot/config.yml"
 - ".github/workflows/gem_release.yml"
 - ".gitignore"
-- ".jenkins/Jenkinsfile"
-- ".jenkins/ruby_build_pod.yml"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
+- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -69,19 +68,17 @@ files:
 - lib/generators/declare_schema/migration/templates/migration.rb.erb
 - lib/generators/declare_schema/model/USAGE
 - lib/generators/declare_schema/model/model_generator.rb
-- lib/generators/declare_schema/model/templates/model_injection.rb.erb
 - lib/generators/declare_schema/support/eval_template.rb
 - lib/generators/declare_schema/support/model.rb
 - lib/generators/declare_schema/support/thor_shell.rb
+- spec/lib/declare_schema/api_spec.rb
 - spec/lib/declare_schema/field_declaration_dsl_spec.rb
+- spec/lib/declare_schema/generator_spec.rb
+- spec/lib/declare_schema/interactive_primary_key_spec.rb
+- spec/lib/declare_schema/migration_generator_spec.rb
+- spec/lib/declare_schema/prepare_testapp.rb
+- spec/lib/generators/declare_schema/migration/migrator_spec.rb
 - spec/spec_helper.rb
-- test/api.rdoctest
-- test/doc-only.rdoctest
-- test/generators.rdoctest
-- test/interactive_primary_key.rdoctest
-- test/migration_generator.rdoctest
-- test/migration_generator_comments.rdoctestDISABLED
-- test/prepare_testapp.rb
 - test_responses.txt
 homepage: https://github.com/Invoca/declare_schema
 licenses: []

data/.jenkins/Jenkinsfile

@@ -1,72 +0,0 @@
-#!/usr/bin/groovy
-@Library('jenkins-pipeline@v0.5.1')
-import com.invoca.ci.*;
-
-pipeline {
-  agent {
-    kubernetes {
-      defaultContainer 'ruby'
-      yamlFile '.jenkins/ruby_build_pod.yml'
-    }
-  }
-
-  environment {
-    GITHUB_TOKEN         = credentials('github_token')
-    BUNDLE_GEM__FURY__IO = credentials('gemfury_deploy_token')
-  }
-
-  stages {
-    stage('Setup') {
-      steps {
-        updateGitHubStatus('clean-build', 'pending', "Running unit tests")
-        sh 'bundle install'
-        sh 'bundle exec appraisal install'
-      }
-    }
-
-    stage("Current Unit Tests") {
-      steps {
-        sh 'bundle exec rake test:prepare_testapp[force]'
-        sh 'bundle exec rake test:all < test_responses.txt'
-      }
-    }
-
-    stage("Rails 4 Appraisal") {
-      steps {
-        sh 'bundle exec appraisal rails-4 rake test:prepare_testapp[force]'
-        sh 'bundle exec appraisal rails-4 rake test:all < test_responses.txt'
-      }
-    }
-
-    stage("Rails 5 Appraisal") {
-      steps {
-        sh 'bundle exec appraisal rails-5 rake test:prepare_testapp[force]'
-        sh 'bundle exec appraisal rails-5 rake test:all < test_responses.txt'
-      }
-    }
-
-    stage("Rails 6 Appraisal") {
-      steps {
-        sh 'bundle exec appraisal rails-6 rake test:prepare_testapp[force]'
-        sh 'bundle exec appraisal rails-6 rake test:all < test_responses.txt'
-      }
-    }
-  }
-
-  post {
-    success { updateGitHubStatus('clean-build', 'success', "Unit tests passed") }
-    failure { updateGitHubStatus('clean-build', 'failure', "Unit tests failed") }
-  }
-}
-
-void updateGitHubStatus(String context, String status, String description) {
-  gitHubStatus([
-    repoSlug:    'Invoca/declare_schema',
-    sha:         env.GIT_COMMIT,
-    description: description,
-    context:     context,
-    targetURL:   env.RUN_DISPLAY_URL,
-    token:       env.GITHUB_TOKEN,
-    status:      status
-  ])
-}

data/.jenkins/ruby_build_pod.yml

@@ -1,19 +0,0 @@
-
----
-apiVersion: v1
-kind: Pod
-metadata:
-  labels:
-    jenkins/declare_schema: 'true'
-  namespace: jenkins
-  name: declare_schema
-spec:
-  containers:
-  - name: ruby
-    image: ruby:2.6.5
-    tty: true
-    resources:
-      requests:
-        memory: "100Mi"
-    command:
-      - cat

data/lib/generators/declare_schema/model/templates/model_injection.rb.erb

@@ -1,25 +0,0 @@
-
-  fields do
-<% for attribute in field_attributes -%>
-    <%= "%-#{max_attribute_length}s" % attribute.name %> :<%= attribute.type %><%=
-      case attribute.type.to_s
-      when 'string'
-        ', limit: 255'
-      else
-        ''
-      end
-    %>
-<% end -%>
-<% if options[:timestamps] -%>
-    timestamps
-<% end -%>
-  end
-
-<% for bt in bts -%>
-  belongs_to :<%= bt %>
-<% end -%>
-<%= "\n" unless bts.empty? -%>
-<% for hm in hms -%>
-  has_many :<%= hm %>, dependent: :destroy
-<% end -%>
-<%= "\n" unless hms.empty? -%>

data/test/api.rdoctest

@@ -1,136 +0,0 @@
-# DeclareSchema API
-
-In order for the API examples to run we need to load the rails generators of our testapp:
-{.hidden}
-
-    doctest: prepare testapp environment
-    doctest_require: 'prepare_testapp'
-{.hidden}
-
-## Example Models
-
-Let's define some example models that we can use to demonstrate the API. With DeclareSchema we can use the 'declare_schema:model' generator like so:
-
-    $ rails generate declare_schema:model advert title:string body:text
-
-This will generate the test, fixture and a model file like this:
-
-    >> Rails::Generators.invoke 'declare_schema:model', %w(advert title:string body:text)
-{.hidden}
-
-    class Advert < ActiveRecord::Base
-      fields do
-        title :string
-        body :text, limit: 0xffff, null: true
-      end
-    end
-
-The migration generator uses this information to create a migration. The following creates and runs the migration so we're ready to go.
-
-    $ rails generate declare_schema:migration -n -m
-
-We're now ready to start demonstrating the API
-
-    >> require_relative "#{Rails.root}/app/models/advert.rb" if Rails::VERSION::MAJOR > 5
-    >> Rails::Generators.invoke 'declare_schema:migration', %w(-n -m)
-    >> Rails::Generators.invoke 'declare_schema:migration', %w(-n -m)
-{.hidden}
-
-## The Basics
-
-The main feature of DeclareSchema, aside from the migration generator, is the ability to declare rich types for your fields. For example, you can declare that a field is an email address, and the field will be automatically validated for correct email address syntax.
-
-### Field Types
-
-Field values are returned as the type you specify.
-
-        >> a = Advert.new :body => "This is the body", id: 1, title: "title"
-        >> a.body.class
-        => String
-
-This also works after a round-trip to the database
-
-        >> a.save
-        >> b = Advert.find(a.id)
-        >> b.body.class
-        => String
-
-## Names vs. Classes
-
-The full set of available symbolic names is
-
- * `:integer`
- * `:float`
- * `:decimal`
- * `:string`
- * `:text`
- * `:boolean`
- * `:date`
- * `:datetime`
- * `:html`
- * `:textile`
- * `:markdown`
- * `:password`
-
-You can add your own types too. More on that later.
-
-
-## Model extensions
-
-DeclareSchema adds a few features to your models.
-
-### `Model.attr_type`
-
-Returns the type (i.e. class) declared for a given field or attribute
-
-        >> Advert.connection.schema_cache.clear!
-        >> Advert.reset_column_information
-        >> Advert.attr_type :title
-        => String
-        >> Advert.attr_type :body
-        => String
-
-## Field validations
-
-DeclareSchema gives you some shorthands for declaring some common validations right in the field declaration
-
-### Required fields
-
-The `:required` argument to a field gives a `validates_presence_of`:
-
-        >>
-         class Advert
-           fields do
-             title :string, :required, limit: 255
-           end
-         end
-        >> a = Advert.new
-        >> a.valid?
-        => false
-        >> a.errors.full_messages
-        => ["Title can't be blank"]
-        >> a.id = 2
-        >> a.body = "hello"
-        >> a.title = "Jimbo"
-        >> a.save
-        => true
-
-
-### Unique fields
-
-The `:unique` argument in a field declaration gives `validates_uniqueness_of`:
-
-        >>
-         class Advert
-           fields do
-             title :string, :unique, limit: 255
-           end
-         end
-        >> a = Advert.new :title => "Jimbo", id: 3, body: "hello"
-        >> a.valid?
-        => false
-        >> a.errors.full_messages
-        => ["Title has already been taken"]
-        >> a.title = "Sambo"
-        >> a.save
-        => true

data/test/doc-only.rdoctest

@@ -1,76 +0,0 @@
-# DeclareSchema
-
-## Introduction
-
-Welcome to DeclareSchema -- a spin-off from HoboFields part of the Hobo project (Hobo not required!).
-
-**DeclareSchema writes your Rails migrations for you! Your migration writing days are over!**
-
-All we ask is that you declare your fields in the model. It's still perfectly DRY because you're not having to repeat that in the migration -- DeclareSchema does that for you. In fact, you'll come to love having them there.
-
-It still has all the benefits of writing your own migrations, for example if you want to add some special code to migrate your old data, you can just edit the generated migration.
-
-## Example
-
-First off, pass the `--skip-migration` option when generating your models:
-
-        $ rails generate model blog_post --skip-migration
-
-Now edit your model as follows:
-
-    class BlogPost < ActiveRecord::Base
-      fields do
-        title :string
-        body  :text
-        timestamps
-      end
-    end
-{: .ruby}
-
-
-Then, simply run
-
-        $ rails generate declare_schema:migration
-
-And voila
-
-        ---------- Up Migration ----------
-        create_table :blog_posts do |t|
-          t.string   :title
-          t.text     :body
-          t.datetime :created_at
-          t.datetime :updated_at
-        end
-        ----------------------------------
-
-        ---------- Down Migration --------
-        drop_table :blog_posts
-        ----------------------------------
-{: .ruby}
-
-The migration generator has created a migration to change from the schema that is currently in your database, to the schema that your models need. That's really all there is to it. You are now free to simply hack away on your app and run the migration generator every time the database needs to play catch-up.
-
-Note that the migration generator is interactive -- it can't tell the difference between renaming something vs. adding one thing and removing another, so sometimes it will ask you to clarify. It's a bit picky about what it makes you type in response, because we really don't want you to lose data when someone's amazing twitter distracts you at the wrong moment.
-
-## Installing
-
-The simplest and recommended way to install DeclareSchema is as a gem:
-
-        $ gem install declare_schema
-
-## API
-
-## Migration Generator Details
-
-The migration generator doctests provide a lot more detail. They're not really that great as documentation because doctests run in a single irb session, and that doesn't fit well with the concept of a generator. Skip these unless you're really keen to see the details of the migration generator in action
-
- - [Migration Generator Details](/manual/declare_schema/migration_generator)
-
-## About Doctests
-
-DeclareSchema is documented and tested using *doctests*. This is an idea that comes from Python that we've been experimenting with for Hobo. Whenever you see code-blocks that start "`>>`", read them as IRB sessions. The `rdoctest` tool extracts these and runs them to verify they behave as advertised.
-
-Doctests are a great way to get both documentation and tests from the same source. We're still experimenting with exactly how this all works though, so if the docs seem strange in places, please bear with us!
-
-You may download rubydoctest via [github](http://www.github.com/tablatom/rubydoctest)
-