deckar01-task_list 2.3.2 → 2.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 811229aaf38f084d46658e2f9a97322546f0888816f97d9c0fdf8644e53547f6
-  data.tar.gz: 1f246072e4ba01c3e00b194df924d91052621487baf885f6b984c72464ddabae
+  metadata.gz: a298b08198908753ccb6e7d75d867daf8d12c596586bfbc45ab54baf8cff1e3f
+  data.tar.gz: c1e7f45c0f827b697813cd5c45d3b3dd9d8d9063e8a219a7cc2292affb25a21c
 SHA512:
-  metadata.gz: 002cd2dd383fe55de9694cd7160dc49af5fa8986a5745d1cc88f9a9507512a092e82af100d53505552ddc135fe399de120abc4ddf1b4876064482cdca9eae77f
-  data.tar.gz: 10f495655ec32696adca0ba524c8790163c52ca27a5b57f11b277dcf6fbf5c14cfc3766db803cfe4691af9b49f072783448f7f8cbb3637a94d1612cc9a9abd74
+  metadata.gz: fc40c8f60bb4f1bd6d61919d7252de08f007bd64a2cb6318c420c3c9893c332e84cbcfb77e6215166ff3e5de0cede45fd9941512093aa5366895b515f3e1565b
+  data.tar.gz: 1cafaea6e577823575588d5636fc83e607877584a859981c4ed63fcf6bc5e214920ada3d8d92252c7b264bc9184f96b7b5e422cae6208b482081396229d6a3bb

data/.gitignore

@@ -19,3 +19,4 @@ tmp
 bower_components
 node_modules
 vendor/gems/
+vendor/bundle/

data/.gitlab-ci.yml

@@ -0,0 +1,22 @@
+.test: &test
+  stage: test
+  before_script:
+    - ./script/bootstrap
+  script:
+    - ./script/cibuild
+
+test 3.0:
+  image: "ruby:3.0"
+  <<: *test
+
+test 3.1:
+  image: "ruby:3.1"
+  <<: *test
+
+test 3.2:
+  image: "ruby:3.2"
+  <<: *test
+
+test 3.3:
+  image: "ruby:3.3-rc"
+  <<: *test

data/README.md

@@ -1,8 +1,6 @@
 # Task Lists
 
-[![Build Status](http://img.shields.io/travis/deckar01/task_list.svg)][travis]
-
-[travis]: https://travis-ci.org/deckar01/task_list
+[![pipeline status](https://gitlab.com/deckar01/task_list/badges/master/pipeline.svg)](https://gitlab.com/deckar01/task_list/-/commits/master)
 
 This is a community fork of GitHub's archived [`task_list`][task_list] gem.
 
@@ -85,7 +83,7 @@ NOTE: Updates are not persisted to the server automatically. Persistence is the
 
 Read through the documented behaviors and samples [in the source][frontend_behaviors] for more detail, including documented events.
 
-[frontend_behaviors]: https://github.com/deckar01/task_list/blob/master/app/assets/javascripts/task_list.coffee
+[frontend_behaviors]: https://gitlab.com/deckar01/task_list/blob/master/app/assets/javascripts/task_list.coffee
 
 ## Installation
 

data/bower.json

@@ -2,10 +2,9 @@
   "name": "deckar01-task_list",
   "version": "2.0.1",
   "description": "Markdown TaskList components",
-  "homepage": "https://github.com/deckar01/task_list",
+  "homepage": "https://gitlab.com/deckar01/task_list",
   "devDependencies": {
     "jquery": ">= 1.9.1 <3",
-    "qunit": "^1.0.0",
     "rails-behaviors": "^0.8.4"
   },
   "main": [

data/build.mjs

@@ -0,0 +1,26 @@
+import { build } from 'esbuild';
+import coffeeScriptPlugin from 'esbuild-coffeescript';
+import { umdWrapper } from 'esbuild-plugin-umd-wrapper';
+
+await build({
+  entryPoints: ['app/assets/javascripts/task_list.coffee'],
+  bundle: true,
+  minify: true,
+  format: 'umd',
+  outfile: 'dist/task_list.js',
+  plugins: [
+    coffeeScriptPlugin(),
+    umdWrapper({libraryName: 'TaskList'}),
+  ],
+  logLevel: 'info',
+});
+
+await build({
+  entryPoints: ['test/unit/*.coffee'],
+  bundle: true,
+  outdir: 'bin/test/unit/',
+  plugins: [
+    coffeeScriptPlugin(),
+  ],
+  logLevel: 'info',
+});

data/lib/task_list/filter.rb

@@ -40,7 +40,7 @@ class TaskList
     # Pattern used to identify all task list items.
     # Useful when you need iterate over all items.
     ItemPattern = /
-      ^
+      \A
       (?:\s*[-+*]|(?:\d+\.))? # optional list prefix
       \s*                     # optional whitespace prefix
       (                       # checkbox
@@ -50,17 +50,22 @@ class TaskList
       (?=\s)                  # followed by whitespace
     /x
 
-    ListItemSelector = ".//li[task_list_item(.)]".freeze
+    ListItemSelector = ".//li[nokogiri:task_list_item(.)]".freeze
 
     class XPathSelectorFunction
       def self.task_list_item(nodes)
-        nodes.select { |node| node.text =~ ItemPattern }
+        nodes.select { |li| Filter::item_container(li).inner_html =~ ItemPattern }
       end
     end
 
     # Selects first P tag of an LI, if present
     ItemParaSelector = "./p[1]".freeze
 
+    # The the node directly containing the checkbox text
+    def self.item_container(li)
+      li.xpath(ItemParaSelector)[0] || li
+    end
+
     # List of `TaskList::Item` objects that were recognized in the document.
     # This is available in the result hash as `:task_list_items`.
     #
@@ -80,6 +85,7 @@ class TaskList
       />)
     end
 
+    # Deprecated: Removed in v3
     # Public: Marks up the task list item checkbox with metadata and behavior.
     #
     # NOTE: produces a string that, when assigned to a Node's `inner_html`,
@@ -95,6 +101,7 @@ class TaskList
         item.source.sub(ItemPattern, render_item_checkbox(item)), 'utf-8'
     end
 
+    # Deprecated: Removed in v3
     # Public: Select all task list items within `container`.
     #
     # Returns an Array of Nokogiri::XML::Element objects for ordered and
@@ -114,24 +121,15 @@ class TaskList
     # Returns nothing.
     def filter!
       list_items(doc).reverse.each do |li|
-        next if list_items(li.parent).empty?
-
-        add_css_class(li.parent, 'task-list')
-
-        outer, inner =
-          if p = li.xpath(ItemParaSelector)[0]
-            [p, p.inner_html]
-          else
-            [li, li.inner_html]
-          end
-        if match = (inner.chomp =~ ItemPattern && $1)
-          item = TaskList::Item.new(match, inner)
-          # prepend because we're iterating in reverse
-          task_list_items.unshift item
-
-          add_css_class(li, 'task-list-item')
-          outer.inner_html = render_task_list_item(item)
-        end
+        outer = self.class.item_container(li)
+        inner = outer.inner_html
+        checkbox = inner.match(ItemPattern).captures[0]
+        item = TaskList::Item.new(checkbox, inner)
+        # prepend because we're iterating in reverse
+        task_list_items.unshift item
+        li.parent.add_class('task-list')
+        li.add_class('task-list-item')
+        outer.inner_html = render_task_list_item(item)
       end
     end
 
@@ -140,6 +138,7 @@ class TaskList
       doc
     end
 
+    # Deprecated: Removed in v3
     # Private: adds a CSS class name to a node, respecting existing class
     # names.
     def add_css_class(node, *new_class_names)

data/lib/task_list/version.rb

@@ -1,3 +1,3 @@
 class TaskList
-  VERSION = [2, 3, 2].join('.')
+  VERSION = [2, 3, 4].join('.')
 end