decision_agent 0.1.2 → 0.1.3

data/spec/versioning_spec.rb

@@ -156,9 +156,9 @@ RSpec.describe "DecisionAgent Versioning System" do
       end
 
       it "raises error for nonexistent version" do
-        expect {
+        expect do
           adapter.activate_version(version_id: "nonexistent")
-        }.to raise_error(DecisionAgent::NotFoundError)
+        end.to raise_error(DecisionAgent::NotFoundError)
       end
     end
 
@@ -227,17 +227,17 @@ RSpec.describe "DecisionAgent Versioning System" do
       end
 
       it "validates rule content" do
-        expect {
+        expect do
           manager.save_version(rule_id: rule_id, rule_content: nil)
-        }.to raise_error(DecisionAgent::ValidationError, /cannot be nil/)
+        end.to raise_error(DecisionAgent::ValidationError, /cannot be nil/)
 
-        expect {
+        expect do
           manager.save_version(rule_id: rule_id, rule_content: "not a hash")
-        }.to raise_error(DecisionAgent::ValidationError, /must be a Hash/)
+        end.to raise_error(DecisionAgent::ValidationError, /must be a Hash/)
 
-        expect {
+        expect do
           manager.save_version(rule_id: rule_id, rule_content: {})
-        }.to raise_error(DecisionAgent::ValidationError, /cannot be empty/)
+        end.to raise_error(DecisionAgent::ValidationError, /cannot be empty/)
       end
 
       it "generates default changelog if not provided" do
@@ -263,18 +263,48 @@ RSpec.describe "DecisionAgent Versioning System" do
     end
 
     describe "#rollback" do
-      it "activates a previous version and creates new version" do
+      it "activates a previous version without creating a duplicate" do
         v1 = manager.save_version(rule_id: rule_id, rule_content: rule_content, changelog: "v1")
         manager.save_version(rule_id: rule_id, rule_content: rule_content, changelog: "v2")
+        manager.save_version(rule_id: rule_id, rule_content: rule_content, changelog: "v3")
 
+        # Rollback to v1 should just activate it, not create a duplicate
         rolled_back = manager.rollback(version_id: v1[:id], performed_by: "admin")
 
         expect(rolled_back[:status]).to eq("active")
+        expect(rolled_back[:id]).to eq(v1[:id])
 
-        # Should create a new version documenting the rollback
+        # Should NOT create a new version - just activate the old one
         versions = manager.get_versions(rule_id: rule_id)
-        expect(versions.length).to eq(3)  # v1, v2, and rollback version
-        expect(versions.first[:changelog]).to include("Rolled back")
+        expect(versions.length).to eq(3) # Still just v1, v2, v3
+
+        # v1 should be active, v2 and v3 should be archived
+        active_version = manager.get_active_version(rule_id: rule_id)
+        expect(active_version[:id]).to eq(v1[:id])
+        expect(active_version[:version_number]).to eq(1)
+      end
+
+      it "maintains version history integrity after rollback" do
+        v1 = manager.save_version(rule_id: rule_id, rule_content: rule_content.merge(data: "v1"), changelog: "Version 1")
+        v2 = manager.save_version(rule_id: rule_id, rule_content: rule_content.merge(data: "v2"), changelog: "Version 2")
+        v3 = manager.save_version(rule_id: rule_id, rule_content: rule_content.merge(data: "v3"), changelog: "Version 3")
+
+        # Rollback to v2
+        manager.rollback(version_id: v2[:id])
+
+        # All original versions should still exist with original data
+        loaded_v1 = manager.get_version(version_id: v1[:id])
+        loaded_v2 = manager.get_version(version_id: v2[:id])
+        loaded_v3 = manager.get_version(version_id: v3[:id])
+
+        expect(loaded_v1[:content][:data]).to eq("v1")
+        expect(loaded_v2[:content][:data]).to eq("v2")
+        expect(loaded_v3[:content][:data]).to eq("v3")
+
+        # v2 should be active
+        expect(loaded_v2[:status]).to eq("active")
+        expect(loaded_v1[:status]).to eq("archived")
+        expect(loaded_v3[:status]).to eq("archived")
       end
     end
 
@@ -296,9 +326,9 @@ RSpec.describe "DecisionAgent Versioning System" do
 
     describe "edge cases and error handling" do
       it "handles empty rule_id gracefully" do
-        expect {
+        expect do
           manager.save_version(rule_id: "", rule_content: rule_content)
-        }.not_to raise_error
+        end.not_to raise_error
       end
 
       it "handles special characters in rule_id" do
@@ -390,7 +420,7 @@ RSpec.describe "DecisionAgent Versioning System" do
           Thread.new do
             manager.save_version(
               rule_id: rule_id,
-              rule_content: rule_content.merge(version: "#{i}"),
+              rule_content: rule_content.merge(version: i.to_s),
               created_by: "thread_#{i}"
             )
           end
@@ -450,13 +480,13 @@ RSpec.describe "DecisionAgent Versioning System" do
         }
 
         content_v2 = {
-          version: "2.0",  # changed
+          version: "2.0", # changed
           ruleset: "test",
           rules: [
-            { id: "rule_1", if: { field: "a", op: "eq", value: 2 }, then: { decision: "reject", weight: 0.9, reason: "Updated" } },  # modified
-            { id: "rule_2", if: { field: "b", op: "gt", value: 100 }, then: { decision: "approve", weight: 0.7, reason: "New" } }  # added
+            { id: "rule_1", if: { field: "a", op: "eq", value: 2 }, then: { decision: "reject", weight: 0.9, reason: "Updated" } }, # modified
+            { id: "rule_2", if: { field: "b", op: "gt", value: 100 }, then: { decision: "approve", weight: 0.7, reason: "New" } } # added
           ],
-          new_field: "added"  # added field
+          new_field: "added" # added field
         }
 
         v1 = manager.save_version(rule_id: rule_id, rule_content: content_v1)
@@ -470,7 +500,7 @@ RSpec.describe "DecisionAgent Versioning System" do
     end
 
     describe "rollback scenarios" do
-      it "creates proper audit trail on rollback" do
+      it "activates previous version without creating duplicates" do
         v1 = manager.save_version(rule_id: rule_id, rule_content: rule_content, changelog: "Version 1")
         manager.save_version(rule_id: rule_id, rule_content: rule_content, changelog: "Version 2")
         manager.save_version(rule_id: rule_id, rule_content: rule_content, changelog: "Version 3")
@@ -478,26 +508,33 @@ RSpec.describe "DecisionAgent Versioning System" do
         manager.rollback(version_id: v1[:id], performed_by: "admin")
 
         history = manager.get_history(rule_id: rule_id)
-        expect(history[:total_versions]).to eq(4)  # v1, v2, v3, rollback version
+        expect(history[:total_versions]).to eq(3) # Still just v1, v2, v3 - no duplicate
 
-        rollback_version = history[:versions].first
-        expect(rollback_version[:changelog]).to include("Rolled back")
-        expect(rollback_version[:changelog]).to include("version 1")
+        # v1 should be the active version
+        expect(history[:active_version][:id]).to eq(v1[:id])
+        expect(history[:active_version][:changelog]).to eq("Version 1")
       end
 
-      it "handles multiple consecutive rollbacks" do
+      it "handles multiple consecutive rollbacks without duplication" do
         v1 = manager.save_version(rule_id: rule_id, rule_content: rule_content)
         v2 = manager.save_version(rule_id: rule_id, rule_content: rule_content)
-        manager.save_version(rule_id: rule_id, rule_content: rule_content)
+        v3 = manager.save_version(rule_id: rule_id, rule_content: rule_content)
 
         # Rollback to v1
-        manager.rollback(version_id: v1[:id], performed_by: "user1")
+        result1 = manager.rollback(version_id: v1[:id], performed_by: "user1")
+        expect(result1[:id]).to eq(v1[:id])
 
         # Rollback to v2
-        manager.rollback(version_id: v2[:id], performed_by: "user2")
+        result2 = manager.rollback(version_id: v2[:id], performed_by: "user2")
+        expect(result2[:id]).to eq(v2[:id])
+
+        # Rollback to v3
+        result3 = manager.rollback(version_id: v3[:id], performed_by: "user3")
+        expect(result3[:id]).to eq(v3[:id])
 
         history = manager.get_history(rule_id: rule_id)
-        expect(history[:total_versions]).to eq(5)  # Original 3 + 2 rollback versions
+        expect(history[:total_versions]).to eq(3) # Still just the original 3 versions
+        expect(history[:active_version][:id]).to eq(v3[:id])
       end
     end
 
@@ -517,13 +554,11 @@ RSpec.describe "DecisionAgent Versioning System" do
       end
 
       it "handles versions across multiple rules" do
-        rule_ids = ["rule_a", "rule_b", "rule_c"]
+        rule_ids = %w[rule_a rule_b rule_c]
 
         rule_ids.each do |rid|
           3.times { manager.save_version(rule_id: rid, rule_content: rule_content) }
-        end
 
-        rule_ids.each do |rid|
           versions = manager.get_versions(rule_id: rid)
           expect(versions.length).to eq(3)
           expect(versions.all? { |v| v[:rule_id] == rid }).to be true
@@ -537,7 +572,7 @@ RSpec.describe "DecisionAgent Versioning System" do
         manager.save_version(rule_id: rule_id, rule_content: rule_content)
 
         begin
-          manager.save_version(rule_id: rule_id, rule_content: nil)  # This should fail
+          manager.save_version(rule_id: rule_id, rule_content: nil) # This should fail
         rescue DecisionAgent::ValidationError
           # Expected error
         end
@@ -623,11 +658,12 @@ RSpec.describe "DecisionAgent Versioning System" do
         )
 
         expect(rolled_back[:status]).to eq("active")
+        expect(rolled_back[:id]).to eq(v2[:id])
 
         # 6. Verify history
         history = manager.get_history(rule_id: "approval_001")
-        expect(history[:total_versions]).to eq(4)  # v1, v2, v3, rollback
-        expect(history[:active_version][:version_number]).to be > 3
+        expect(history[:total_versions]).to eq(3) # v1, v2, v3 - no duplicate created
+        expect(history[:active_version][:version_number]).to eq(2) # v2 is active
       end
     end
 
@@ -647,7 +683,7 @@ RSpec.describe "DecisionAgent Versioning System" do
           "review" => {
             version: "1.0",
             ruleset: "review",
-            rules: [{ id: "review_1", if: { field: "amount", op: "gte", value: 10000 }, then: { decision: "manual_review", weight: 0.9, reason: "Large transaction" } }]
+            rules: [{ id: "review_1", if: { field: "amount", op: "gte", value: 10_000 }, then: { decision: "manual_review", weight: 0.9, reason: "Large transaction" } }]
           }
         }
 
@@ -662,12 +698,80 @@ RSpec.describe "DecisionAgent Versioning System" do
         end
 
         # Verify each has its own version history
-        rulesets.keys.each do |name|
+        rulesets.each_key do |name|
           history = manager.get_history(rule_id: name)
           expect(history[:total_versions]).to eq(1)
           expect(history[:active_version][:rule_id]).to eq(name)
         end
       end
     end
+
+    describe "status validation" do
+      let(:rule_id) { "test_status_rule" }
+      let(:rule_content) do
+        {
+          version: "1.0",
+          ruleset: "test",
+          rules: [{ id: "test", if: { field: "x", op: "eq", value: 1 }, then: { decision: "approve", weight: 0.8, reason: "Test" } }]
+        }
+      end
+
+      it "rejects invalid status values when creating versions" do
+        expect do
+          adapter.create_version(
+            rule_id: rule_id,
+            content: rule_content,
+            metadata: { status: "banana" }
+          )
+        end.to raise_error(DecisionAgent::ValidationError, /Invalid status 'banana'/)
+
+        expect do
+          adapter.create_version(
+            rule_id: rule_id,
+            content: rule_content,
+            metadata: { status: "pending" }
+          )
+        end.to raise_error(DecisionAgent::ValidationError, /Invalid status 'pending'/)
+
+        expect do
+          adapter.create_version(
+            rule_id: rule_id,
+            content: rule_content,
+            metadata: { status: "deleted" }
+          )
+        end.to raise_error(DecisionAgent::ValidationError, /Invalid status 'deleted'/)
+      end
+
+      it "accepts valid status values" do
+        v1 = adapter.create_version(
+          rule_id: rule_id,
+          content: rule_content,
+          metadata: { status: "draft" }
+        )
+        expect(v1[:status]).to eq("draft")
+
+        v2 = adapter.create_version(
+          rule_id: "rule_002",
+          content: rule_content,
+          metadata: { status: "active" }
+        )
+        expect(v2[:status]).to eq("active")
+
+        v3 = adapter.create_version(
+          rule_id: "rule_003",
+          content: rule_content,
+          metadata: { status: "archived" }
+        )
+        expect(v3[:status]).to eq("archived")
+      end
+
+      it "uses default status 'active' when not provided" do
+        version = adapter.create_version(
+          rule_id: rule_id,
+          content: rule_content
+        )
+        expect(version[:status]).to eq("active")
+      end
+    end
   end
 end

data/spec/web_ui_rack_spec.rb

@@ -0,0 +1,135 @@
+require "spec_helper"
+require "rack/test"
+require_relative "../lib/decision_agent/web/server"
+
+RSpec.describe "DecisionAgent Web UI Rack Integration" do
+  include Rack::Test::Methods
+
+  def app
+    DecisionAgent::Web::Server
+  end
+
+  describe "Rack interface" do
+    it "responds to .call for Rack compatibility" do
+      expect(DecisionAgent::Web::Server).to respond_to(:call)
+    end
+
+    it "serves the main page" do
+      get "/"
+      expect(last_response).to be_ok
+      expect(last_response.body).to include("DecisionAgent")
+    end
+
+    it "serves the health endpoint" do
+      get "/health"
+      expect(last_response).to be_ok
+      expect(last_response.content_type).to include("application/json")
+
+      json = JSON.parse(last_response.body)
+      expect(json["status"]).to eq("ok")
+      expect(json["version"]).to eq(DecisionAgent::VERSION)
+    end
+
+    it "validates rules via POST /api/validate" do
+      valid_rules = {
+        version: "1.0",
+        ruleset: "test_rules",
+        rules: [{
+          id: "test_rule",
+          if: { field: "amount", op: "gt", value: 100 },
+          then: { decision: "approve", weight: 0.9, reason: "Test" }
+        }]
+      }
+
+      post "/api/validate", valid_rules.to_json, { "CONTENT_TYPE" => "application/json" }
+
+      expect(last_response).to be_ok
+      json = JSON.parse(last_response.body)
+      expect(json["valid"]).to be true
+    end
+
+    it "returns error for invalid rules" do
+      invalid_rules = {
+        version: "1.0",
+        ruleset: "test_rules",
+        rules: [{
+          id: "bad_rule"
+          # Missing required fields
+        }]
+      }
+
+      post "/api/validate", invalid_rules.to_json, { "CONTENT_TYPE" => "application/json" }
+
+      expect(last_response.status).to eq(422)
+      json = JSON.parse(last_response.body)
+      expect(json["valid"]).to be false
+      expect(json["errors"]).to be_an(Array)
+    end
+
+    it "evaluates rules via POST /api/evaluate" do
+      rules = {
+        version: "1.0",
+        ruleset: "test_rules",
+        rules: [{
+          id: "high_value",
+          if: { field: "amount", op: "gt", value: 1000 },
+          then: { decision: "approve", weight: 0.9, reason: "High value" }
+        }]
+      }
+
+      payload = {
+        rules: rules,
+        context: { amount: 1500 }
+      }
+
+      post "/api/evaluate", payload.to_json, { "CONTENT_TYPE" => "application/json" }
+
+      expect(last_response).to be_ok
+      json = JSON.parse(last_response.body)
+      expect(json["success"]).to be true
+      expect(json["decision"]).to eq("approve")
+      expect(json["weight"]).to eq(0.9)
+      expect(json["reason"]).to eq("High value")
+    end
+
+    it "serves example rules" do
+      get "/api/examples"
+
+      expect(last_response).to be_ok
+      json = JSON.parse(last_response.body)
+      expect(json).to be_an(Array)
+      expect(json.length).to be > 0
+      expect(json.first).to have_key("name")
+      expect(json.first).to have_key("rules")
+    end
+
+    it "handles CORS preflight requests" do
+      options "/api/validate"
+
+      expect(last_response.status).to eq(200)
+      expect(last_response.headers["Access-Control-Allow-Origin"]).to eq("*")
+      expect(last_response.headers["Access-Control-Allow-Methods"]).to include("POST")
+    end
+  end
+
+  describe "Rails mounting compatibility" do
+    it "can be mounted in a Rack app" do
+      # Simulate a Rails-style mount
+      rack_app = Rack::Builder.new do
+        map "/decision_agent" do
+          run DecisionAgent::Web::Server
+        end
+      end
+
+      # Create a test session for the mounted app
+      test_session = Rack::Test::Session.new(Rack::MockSession.new(rack_app))
+
+      # Test that the health endpoint works when mounted
+      test_session.get "/decision_agent/health"
+      expect(test_session.last_response).to be_ok
+
+      json = JSON.parse(test_session.last_response.body)
+      expect(json["status"]).to eq("ok")
+    end
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: decision_agent
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Sam Aswin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-12-20 00:00:00.000000000 Z
+date: 2025-12-24 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: json-canonicalization
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -25,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,11 +66,39 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.12'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.60'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.60'
 description: A production-grade decision agent that provides deterministic rule evaluation,
   conflict resolution, and full audit replay capabilities. Framework-agnostic and
   AI-optional.
 email:
-- samaswin87@gmail.com
+- samaswin@gmail.com
 executables:
 - decision_agent
 extensions: []
@@ -77,9 +119,18 @@ files:
 - lib/decision_agent/dsl/schema_validator.rb
 - lib/decision_agent/errors.rb
 - lib/decision_agent/evaluation.rb
+- lib/decision_agent/evaluation_validator.rb
 - lib/decision_agent/evaluators/base.rb
 - lib/decision_agent/evaluators/json_rule_evaluator.rb
 - lib/decision_agent/evaluators/static_evaluator.rb
+- lib/decision_agent/monitoring/alert_manager.rb
+- lib/decision_agent/monitoring/dashboard/public/dashboard.css
+- lib/decision_agent/monitoring/dashboard/public/dashboard.js
+- lib/decision_agent/monitoring/dashboard/public/index.html
+- lib/decision_agent/monitoring/dashboard_server.rb
+- lib/decision_agent/monitoring/metrics_collector.rb
+- lib/decision_agent/monitoring/monitored_agent.rb
+- lib/decision_agent/monitoring/prometheus_exporter.rb
 - lib/decision_agent/replay/replay.rb
 - lib/decision_agent/scoring/base.rb
 - lib/decision_agent/scoring/consensus.rb
@@ -100,6 +151,7 @@ files:
 - lib/generators/decision_agent/install/templates/migration.rb
 - lib/generators/decision_agent/install/templates/rule.rb
 - lib/generators/decision_agent/install/templates/rule_version.rb
+- spec/activerecord_thread_safety_spec.rb
 - spec/agent_spec.rb
 - spec/api_contract_spec.rb
 - spec/audit_adapters_spec.rb
@@ -107,13 +159,23 @@ files:
 - spec/context_spec.rb
 - spec/dsl_validation_spec.rb
 - spec/edge_cases_spec.rb
+- spec/examples.txt
 - spec/examples/feedback_aware_evaluator_spec.rb
+- spec/issue_verification_spec.rb
 - spec/json_rule_evaluator_spec.rb
+- spec/monitoring/alert_manager_spec.rb
+- spec/monitoring/metrics_collector_spec.rb
+- spec/monitoring/monitored_agent_spec.rb
+- spec/monitoring/prometheus_exporter_spec.rb
 - spec/replay_edge_cases_spec.rb
 - spec/replay_spec.rb
+- spec/rfc8785_canonicalization_spec.rb
 - spec/scoring_spec.rb
 - spec/spec_helper.rb
+- spec/thread_safety_spec.rb
+- spec/thread_safety_spec.rb.broken
 - spec/versioning_spec.rb
+- spec/web_ui_rack_spec.rb
 homepage: https://github.com/samaswin87/decision_agent
 licenses:
 - MIT
@@ -121,6 +183,7 @@ metadata:
   homepage_uri: https://github.com/samaswin87/decision_agent
   source_code_uri: https://github.com/samaswin87/decision_agent
   changelog_uri: https://github.com/samaswin87/decision_agent/blob/main/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: