decidim 0.8.4 → 0.9.0

data/docs/managing_translations_i18n.md

@@ -11,9 +11,9 @@ Decidim uses [Crowdin](https://crowdin.com/) to manage the translations.
 ## Adding a new language
 
 - Setup the new language in [_Crowdin's Decidim project_](https://crowdin.com/project/decidim) (or open an issue on Github asking an admin to do that).
+- Add the locale mapping in the `crowdin.yml` file
 - Translate at least one key from every engine, so, your _yaml_ files are not empty. The easiest way to do this is to automatically translate and sync all the content. Later you'll be able to fix the content that wasn't properly translated.
 - Add [Foundation Datepicker](https://github.com/najlepsiwebdesigner/foundation-datepicker/tree/master/js/locales)'s translations ([PR](https://github.com/decidim/decidim/pull/2039)).
-- Add Select2 translations ([PR](https://github.com/decidim/decidim/pull/2214)).
 - Add the new language to `available_locales` ([PR](https://github.com/decidim/decidim/pull/1991)).
 - Announce the new language in the Readme ([PR](https://github.com/decidim/decidim/pull/2125)).
 

data/docs/migrate_to_0.8.0.md

@@ -0,0 +1,137 @@
+# Migration from 0.7.0 to 0.8.0
+
+## Note about this guide.
+
+This is a work-in-progress guide for all those people that needs to adapt his existing source code from Decidim
+0.7.0 to Decidim 0.8.0. If you find a mistake or missing parts in this  document do not hesitate to make a pull request
+and add your discoveries.
+
+
+## Upgrading the gem.
+
+You need to alter the following files:
+
+### Gemspec file.
+
+You must set the decidim version to 0.8.0 or higher in your gemspec.
+
+```ruby
+...
+s.add-dependency "decidim-core", "~> 0.8.0"
+...
+```
+
+### Gemfile
+You must adjust the decidim version in your gem file as well. You also need to add the new engine 'decidim-verifications':
+
+```ruby
+...
+gem "decidim", "~> 0.8.0"
+gem "decidim-verifications"
+...
+```
+### bundle update
+Finally run *bundle update* to get the required gems updated.
+
+```bash
+$ bundle update --full-index
+```
+
+## Updating your sources.
+
+### Factories
+Decidim 0.8.0 has migratied from FactoryGirl gem to FactoryBot. Cause this you need to update your factories. Usually the *factories.rb* file looks like this:
+
+```ruby
+# frozen_string_literal: true
+
+require 'decidim/faker/localized'
+require 'decidim/dev'
+
+FactoryGirl.define do
+  ...
+end
+
+```
+
+You must replace FactoryGirl by FactoryBot. After the change it should look like this:
+
+```ruby
+# frozen_string_literal: true
+
+require 'decidim/faker/localized'
+require 'decidim/dev'
+
+FactoryBot.define do
+  ...
+end
+
+```
+
+### Spec tests examples.
+
+Some examples have changed its name to be more descriptive. In order to have your tests up and running again you must perform the following substitions in the specs folder:
+
+* *include_context "feature"* now is *include_context "with a feature"*
+
+* *include_context "feature admin"* now is *include_context "when managing a feature as an admin"*
+
+### Capybara
+
+After I have upgraded to the last version of decidim I have realized that some test that were valid in the previous version now were failing. The reason was the following exception:
+
+```ruby
+RSpec::Core::MultipleExceptionError: unexpected alert open: {Alert text : Are you sure?}
+```
+
+That was caused by a confirmation dialog. In order to get rid of these issue I had to add the following line in the point
+where the dialog was supposed to be accepted:
+
+```ruby
+accept_confirm { click_button "Submit" }
+```
+
+## Steps to do after migrating your source code.
+
+### Adapting code for an existing engine:
+
+You must remove the external test app and regenerate it:
+
+```bash
+$ rm -Rf spec/decidim_dummy_app
+$ bundle exec rails decidim:generate_external_test_app
+```
+
+After regenerating the test app you should recreate the test database as well:
+
+```bash
+$ cd spec/decidim_dummy_app
+$ bundle exec rails db:drop
+$ bundle exec rails db:create
+$ bundle exec rails db:migrate
+$ bundle exec rails db:migrate RAILS_ENV=test
+$ bundle exec rails db:seed
+```
+### Adapting code for an existing Decidim implementation.
+
+After updating the decidim gems you should import the new migrations and execute them:
+
+```bash
+$ rails decidim:upgraded
+$ rails db:migrate
+```
+
+Additionally you should change the way uglifier is used in your app:
+
+Edit the file *config/environments/production.rb* and make the following changes:
+
+```ruby
+# Original value
+# config.assets.js_compressor = :uglifier
+
+# Enable ES6 support
+config.assets.js_compressor = Uglifier.new(harmony: true)
+```
+# To sum it up.
+
+Take a cold beer and enjoy democracy.

data/lib/decidim.rb

@@ -9,12 +9,7 @@ require "decidim/version"
 require "decidim/verifications"
 
 require "decidim/participatory_processes"
-
-begin
-  require "decidim/assemblies"
-rescue LoadError
-  nil
-end
+require "decidim/assemblies"
 
 require "decidim/pages"
 require "decidim/comments"
@@ -23,6 +18,7 @@ require "decidim/proposals"
 require "decidim/budgets"
 require "decidim/surveys"
 require "decidim/accountability"
+require "decidim/debates"
 
 # Module declaration.
 module Decidim

data/lib/decidim/component_manager.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+module Decidim
+  #
+  # Handles a decidim components.
+  #
+  # Allows to perform custom operations on all modules in a given folder, or on
+  # specific module folders.
+  #
+  # Potential operations are:
+  #
+  # * Running custom commands, via the `run` method, such as releasing it, or
+  #   installing it locally.
+  #
+  # * Updating version files from the main `.decidim-version` file in the root
+  #   of the repository.
+  #
+  class ComponentManager
+    def initialize(dir)
+      @dir = File.expand_path(dir)
+    end
+
+    def run(command, out: STDOUT)
+      command = command.gsub("%version", version).gsub("%name", name)
+      status = system(command, out: out)
+      abort unless status || ENV["FAIL_FAST"] == "false"
+    end
+
+    def replace_version
+      self.class.replace_file(
+        "lib/#{name.tr("-", "/")}/version.rb",
+        /def self\.version(\s*)"[^"]*"/,
+        "def self.version\\1\"#{version}\""
+      )
+    end
+
+    class << self
+      def replace_versions
+        replace_file(
+          "package.json",
+          /^  "version": "[^"]*"/,
+          "  \"version\": \"#{version.gsub(/\.pre/, "-pre")}\""
+        )
+
+        in_all_dirs do |dir|
+          new(dir).replace_version
+        end
+      end
+
+      def run_all(command, out: STDOUT, include_root: true)
+        in_all_dirs(include_root: include_root) do |dir|
+          new(dir).run(command, out: out)
+        end
+      end
+
+      def version
+        File.read(version_file).strip
+      end
+
+      def version_file
+        File.expand_path(File.join("..", "..", ".decidim-version"), __dir__)
+      end
+
+      def replace_file(name, regexp, replacement)
+        new_content = File.read(name).gsub(regexp, replacement)
+
+        File.open(name, "w") { |f| f.write(new_content) }
+      end
+
+      private
+
+      def all_dirs(include_root: true)
+        Dir.glob(include_root ? "{decidim-*,.}" : "decidim-*")
+           .select { |f| File.directory?(f) }
+      end
+
+      def in_all_dirs(include_root: true)
+        all_dirs(include_root: include_root).each do |dir|
+          Dir.chdir(dir) { yield(dir) }
+        end
+      end
+    end
+
+    private
+
+    def name
+      File.basename(@dir)
+    end
+
+    def short_name
+      name.gsub(/decidim-/, "")
+    end
+
+    def version
+      self.class.version
+    end
+  end
+end

data/lib/decidim/version.rb

@@ -3,6 +3,6 @@
 # This holds the decidim version and the faker version it uses.
 module Decidim
   def self.version
-    "0.8.4"
+    "0.9.0"
   end
 end

data/lib/generators/decidim/app_generator.rb

@@ -24,28 +24,35 @@ module Decidim
 
       source_root File.expand_path("templates", __dir__)
 
-      class_option :path, type: :string, default: nil,
+      class_option :path, type: :string,
+                          default: nil,
                           desc: "Path to the gem"
 
-      class_option :edge, type: :boolean, default: false,
+      class_option :edge, type: :boolean,
+                          default: false,
                           desc: "Use GitHub's edge version from master branch"
 
-      class_option :branch, type: :string, default: nil,
+      class_option :branch, type: :string,
+                            default: nil,
                             desc: "Use a specific branch from GitHub's version"
 
-      class_option :database, type: :string, aliases: "-d", default: "postgresql",
+      class_option :database, type: :string,
+                              default: "postgresql",
                               desc: "Configure for selected database (options: #{DATABASES.join("/")})"
 
-      class_option :recreate_db, type: :boolean, default: false,
+      class_option :recreate_db, type: :boolean,
+                                 default: false,
                                  desc: "Recreate test database"
 
-      class_option :seed_db, type: :boolean, default: false,
+      class_option :seed_db, type: :boolean,
+                             default: false,
                              desc: "Seed test database"
 
       class_option :app_const_base, type: :string,
                                     desc: "The application constant name"
 
-      class_option :skip_bundle, type: :boolean, aliases: "-B", default: true,
+      class_option :skip_bundle, type: :boolean,
+                                 default: true,
                                  desc: "Don't run bundle install"
 
       class_option :skip_gemfile, type: :boolean,
@@ -97,9 +104,7 @@ module Decidim
       end
 
       def add_ignore_uploads
-        unless options["skip_git"]
-          append_file ".gitignore", "\n# Ignore public uploads\npublic/uploads"
-        end
+        append_file ".gitignore", "\n# Ignore public uploads\npublic/uploads" unless options["skip_git"]
       end
 
       def remove_default_error_pages
@@ -110,9 +115,7 @@ module Decidim
       def authorization_handler
         template "initializer.rb", "config/initializers/decidim.rb"
 
-        if options[:demo]
-          template "example_authorization_handler.rb", "app/services/example_authorization_handler.rb"
-        end
+        template "example_authorization_handler.rb", "app/services/example_authorization_handler.rb" if options[:demo]
       end
 
       def install

data/lib/generators/decidim/install_generator.rb

@@ -76,17 +76,6 @@ module Decidim
             |    :enable_starttls_auto => Rails.application.secrets.smtp_starttls_auto,
             |    :openssl_verify_mode => 'none'
             |  }
-            |
-            |  if Rails.application.secrets.sendgrid
-            |    config.action_mailer.default_options = {
-            |      "X-SMTPAPI" => {
-            |        filters:  {
-            |          clicktrack: { settings: { enable: 0 } },
-            |          opentrack:  { settings: { enable: 0 } }
-            |        }
-            |      }.to_json
-            |    }
-            |  end
           RUBY
         end
       end

data/lib/generators/decidim/templates/README.md.erb

@@ -4,10 +4,6 @@ Citizen Participation and Open Government application.
 
 This is the open-source repository for <%= app_name %>, based on [Decidim](https://github.com/decidim/decidim).
 
-## Deploying the app
-
-An opinionated guide to deploy this app to Heroku can be found at [https://github.com/codegram/decidim-deploy-heroku](https://github.com/codegram/decidim-deploy-heroku).
-
 ## Setting up the application
 
 You will need to do some steps before having the app working properly once you've deployed it:

data/lib/generators/decidim/templates/database.yml.erb

@@ -73,7 +73,7 @@ test:
 # for a full rundown on how to provide these environment variables in a
 # production deployment.
 #
-# On Heroku and other platform providers, you may have a full connection URL
+# On some platform providers, you may have a full connection URL
 # available as an environment variable. For example:
 #
 #   DATABASE_URL="postgres://myuser:mypass@localhost/somedatabase"

data/lib/generators/decidim/templates/secrets.yml.erb

@@ -52,11 +52,10 @@ test:
 production:
   <<: *default
   secret_key_base: <%%= ENV["SECRET_KEY_BASE"] %>
-  sendgrid: <%%= !ENV["SENDGRID_USERNAME"].blank? %>
-  smtp_username: <%%= ENV["SMTP_USERNAME"] || ENV["SENDGRID_USERNAME"] %>
-  smtp_password: <%%= ENV["SMTP_PASSWORD"] || ENV["SENDGRID_PASSWORD"] %>
-  smtp_address: <%%= ENV["SMTP_ADDRESS"] || "smtp.sendgrid.net" %>
-  smtp_domain: <%%= ENV["SMTP_DOMAIN"] || "heroku.com" %>
+  smtp_username: <%%= ENV["SMTP_USERNAME"] %>
+  smtp_password: <%%= ENV["SMTP_PASSWORD"] %>
+  smtp_address: <%%= ENV["SMTP_ADDRESS"] %>
+  smtp_domain: <%%= ENV["SMTP_DOMAIN"] %>
   smtp_port: "587"
   smtp_starttls_auto: true
   smtp_authentication: "plain"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.9.0
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-16 00:00:00.000000000 Z
+date: 2018-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: decidim-accountability
@@ -18,182 +18,210 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-admin
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
+- !ruby/object:Gem::Dependency
+  name: decidim-assemblies
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-budgets
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-comments
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+- !ruby/object:Gem::Dependency
+  name: decidim-debates
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-meetings
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-pages
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-participatory_processes
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-proposals
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-surveys
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-system
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: decidim-verifications
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -253,20 +281,30 @@ files:
 - Rakefile
 - bin/decidim
 - docs/analytics.md
+- docs/content_processors.md
 - docs/create_followers_from_comment_authors.md
 - docs/create_followers_from_resource_authors.md
+- docs/customization/authorizations.md
+- docs/customization/code.md
+- docs/customization/gemfile.md
+- docs/customization/images.md
+- docs/customization/javascript.md
+- docs/customization/styles.md
+- docs/customization/texts.md
+- docs/customization/views.md
 - docs/features_and_components.md
 - docs/geocoding.md
 - docs/getting_started.md
-- docs/how_to_create_a_plugin.md
+- docs/how_to_create_a_module.md
 - docs/managing_translations_i18n.md
+- docs/migrate_to_0.8.0.md
 - docs/social_providers.md
 - docs/testing.md
 - docs/view_hooks.md
 - lib/decidim.rb
+- lib/decidim/component_manager.rb
 - lib/decidim/version.rb
 - lib/generators/decidim/app_generator.rb
-- lib/generators/decidim/docker_generator.rb
 - lib/generators/decidim/install_generator.rb
 - lib/generators/decidim/templates/Dockerfile.erb
 - lib/generators/decidim/templates/README.md.erb
@@ -292,7 +330,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.1
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -300,7 +338,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Citizen participation framework for Ruby on Rails.