decidim 0.26.2 → 0.27.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e85c73da0320bfee1b42c6529cbeec6b39a32b4c9d85c2d44368000a08f5e5e8
-  data.tar.gz: 00ea21f9dbc54c585756c0b1805cb53adf063ff5eb6224e44631903fa5dedc5a
+  metadata.gz: 58a87f6ee1265f077357268f25e89a09dd7352f017c44b270eefe809d8963533
+  data.tar.gz: 9f9ec6a81b1bf82213ab6c06c01ec66b7628dd5b37778fecd35d88709ef17343
 SHA512:
-  metadata.gz: 2b3011c7d57b4231f8d1018a3007c37d4b2091c0b294a1e5d1ef6b920c9c9c945a0cd05fa8c40aca0eacc678e5b05fb1547e98648d67072a6157a168445009c9
-  data.tar.gz: 353c8b6cbb1fd04f94f857520a94f9e1f9657344b6d2495ef4e72fecfcfcdfe2d7fa961e99e1cf639cf3370842d5250098e6fbe7bc5e88d8cd303445b886978e
+  metadata.gz: 20d0bdd9f98d7ebe21432228ee53ace624123c5a247030ea52c880bedf5929d7e5e7c563b8d3d9dc56fd0b73d6091ac3e6f945fa159a8fa920cf898ce00f1517
+  data.tar.gz: 882881918201e390e2ff6790f1d83a73f003ed46895766e869627d06525baf09ca4856d38be661721ebbfc3a6daf010b8dc26100d06b38eb8f93eeee0672f014

data/Rakefile

@@ -57,14 +57,32 @@ task :uninstall_all do
 end
 
 desc "Pushes a new build for each gem and package."
-task release_all: [:update_versions, :check_locale_completeness] do
-  Decidim::GemManager.run_all("rake release")
-  Decidim::GemManager.run_packages("npm publish --access public")
+task release_all: [:update_versions, :check_uncommitted_changes, :check_locale_completeness] do
+  commands = {}
+  Decidim::GemManager.all_dirs { |dir| commands[dir] = "rake release" }
+  Decidim::GemManager.package_dirs { |dir| commands[dir] = "npm publish --access public" }
+
+  commands.each do |dir, command|
+    status = Decidim::GemManager.run_at(dir, command)
+
+    break if !status && Decidim::GemManager.fail_fast?
+  end
+end
+
+desc "Makes sure there are no uncommitted changes."
+task :check_uncommitted_changes do
+  unless system("git diff --exit-code --quiet")
+    puts "There are uncommitted changes, run `git diff` to see them."
+    abort "Please commit your changes before release!"
+  end
 end
 
 desc "Makes sure all official locales are complete and clean."
 task :check_locale_completeness do
-  system({ "ENFORCED_LOCALES" => "en,ca,es", "SKIP_NORMALIZATION" => "true" }, "rspec spec/i18n_spec.rb")
+  unless system({ "ENFORCED_LOCALES" => "en,ca,es", "SKIP_NORMALIZATION" => "true" }, "rspec spec/i18n_spec.rb")
+    puts "The officially supported locales have problems in them."
+    abort "Please correct these problems by following the instructions from the above outputs before release!"
+  end
 end
 
 load "decidim-dev/lib/tasks/generators.rake"

data/babel.config.json

@@ -20,11 +20,9 @@
         "corejs": false
       }
     ],
-    [
-      "@babel/plugin-transform-regenerator",
-      {
-        "async": false
-      }
-    ]
+    [ "@babel/plugin-transform-regenerator", { "async": false }],
+    [ "@babel/plugin-proposal-private-property-in-object", { "loose": true }],
+    ["@babel/plugin-proposal-private-methods", { "loose": true }],
+    ["@babel/plugin-proposal-class-properties", { "loose": true }]
   ]
 }

data/decidim-core/lib/decidim/webpacker/thread_safe_compiler.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+# This fixes a thread safety issue with the Webpacker compiler explained here:
+# https://github.com/rails/webpacker/issues/2801
+#
+# The fix is partly from the issue and partly from this commit at Shakapacker:
+# https://github.com/shakacode/shakapacker/commit/f2dc437ecd9914f394780d4c3150fc4a70d40f9d
+
+require "webpacker/compiler"
+
+module Decidim
+  module Webpacker
+    module ThreadSafeCompiler
+      private
+
+      def watched_files_digest
+        warn "Webpacker::Compiler.watched_paths has been deprecated. Set additional_paths in webpacker.yml instead." unless watched_paths.empty?
+        root_path = Pathname.new(File.expand_path(config.root_path))
+        expanded_paths = [*default_watched_paths, *watched_paths].map do |path|
+          root_path.join(path)
+        end
+        files = Dir[*expanded_paths].reject { |f| File.directory?(f) }
+        file_ids = files.sort.map { |f| "#{File.basename(f)}/#{Digest::SHA1.file(f).hexdigest}" }
+        Digest::SHA1.hexdigest(file_ids.join("/"))
+      end
+    end
+  end
+end
+
+Webpacker::Compiler.prepend(Decidim::Webpacker::ThreadSafeCompiler)

data/decidim-core/lib/decidim/webpacker/webpack/custom.js

@@ -1,7 +1,6 @@
 /* eslint-disable */
-
-const path = require("path");
 const { config } = require("@rails/webpacker");
+const { InjectManifest } = require("workbox-webpack-plugin");
 
 module.exports = {
   module: {
@@ -93,5 +92,18 @@ module.exports = {
   optimization: {
     runtimeChunk: false
   },
-  entry: config.entrypoints
+  entry: config.entrypoints,
+  plugins: [
+    new InjectManifest({
+      swSrc: "src/decidim/sw/sw.js",
+
+      /**
+       * NOTE:
+       * @rails/webpacker outputs to '/packs',
+       * in order to make the SW run properly
+       * they must be put at the project's root folder '/'
+       */
+      swDest: "../sw.js"
+    })
+  ]
 }

data/decidim-core/lib/decidim/webpacker/webpacker.yml

@@ -33,7 +33,7 @@ development:
     hmr: false
     client:
       # Should we show a full-screen overlay in the browser when there are compiler errors or warnings?
-      overlay: true
+      overlay: false
       # May also be a string
       # webSocketURL:
       #  hostname: "0.0.0.0"

data/docs/README.adoc

@@ -36,20 +36,7 @@ If you want to try changes in this folder and how it'd be shown in https://docs.
 . Build the antora playbook
 . Open the generated website with your web browser
 
-In detail each one of these steps are:
-
-[source,bash]
-----
-# 1. Clone the repository
-git clone https://github.com/decidim/documentation
-# 2. Install dependencies
-npm
-# 3. Change the antora-playbook.yml url key in source
-# 4. Build the antora playbook
-npm run build
-# 5. Open the generated website with your web browser
-xdg-open build/site/index.html
-----
+For instructions on how to clone the repository, install dependencies, build the antora playbook and open the generated webiste, see https://github.com/decidim/documentation[Decidim's documentation repository README file].
 
 Regarding "3. Change the antora-playbook.yml url key in source", if this is the configuration at antora-playbook.yml:
 
@@ -69,6 +56,8 @@ Then the result would be:
      branches: develop
 ----
 
+If building locally doesn't show any change, then check also that the branch corresponds with the one that you're working locally.
+
 == Add a new link in the sidebar
 
 For adding a new link in the sidebar you need to add it in https://raw.githubusercontent.com/decidim/documentation/master/en/modules/ROOT/nav.adoc[nav.adoc file]