decidim 0.0.4 → 0.0.5

data/decidim-admin/spec/commands/update_newsletter_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe UpdateNewsletter, :db do
+      describe "call" do
+        let(:user) { create(:user, organization: organization) }
+        let(:organization) { create(:organization) }
+        let(:newsletter) { create(:newsletter, organization: organization) }
+
+        let(:form) do
+          double(
+            subject: Decidim::Faker::Localized.paragraph(3),
+            body: Decidim::Faker::Localized.paragraph(3),
+            valid?: true
+          )
+        end
+
+        let(:command) { described_class.new(newsletter, form, user) }
+
+        describe "when the form is not valid" do
+          before do
+            expect(form).to receive(:valid?).and_return(false)
+          end
+
+          it "broadcasts invalid" do
+            expect { command.call }.to broadcast(:invalid)
+          end
+
+          it "doesn't create a newsletter" do
+            expect do
+              command.call
+            end.not_to change { newsletter.reload.updated_at }
+          end
+        end
+
+        describe "when the newsletter can't be edited by this user" do
+          let(:user) { create(:user) }
+
+          it "broadcasts invalid" do
+            expect { command.call }.to broadcast(:invalid)
+          end
+        end
+
+        describe "when the form is valid" do
+          it "broadcasts ok" do
+            expect { command.call }.to broadcast(:ok)
+          end
+
+          it "updates the newsletter" do
+            command.call
+            newsletter.reload
+
+            expect(newsletter.author).to eq(user)
+            expect(newsletter.subject).to eq(form.subject.stringify_keys)
+            expect(newsletter.sent?).to eq(false)
+            expect(newsletter.body).to eq(form.body.stringify_keys)
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-admin/spec/features/admin_manages_newsletters_spec.rb

@@ -0,0 +1,147 @@
+# coding: utf-8
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Admin manages newsletters", type: :feature do
+  let(:organization) { create(:organization) }
+  let(:user) { create(:user, :admin, :confirmed, name: "Sarah Kerrigan", organization: organization) }
+  let!(:deliverable_users) { create_list(:user, 5, newsletter_notifications: true, organization: organization) }
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+  end
+
+  around do |example|
+    perform_enqueued_jobs do
+      example.run
+    end
+  end
+
+  describe "creates and previews a newsletter" do
+    it "allows a newsletter to be created" do
+      visit decidim_admin.newsletters_path
+
+      find("#newsletters .actions .new").click
+
+      within ".new_newsletter" do
+        fill_in_i18n(
+          :newsletter_subject,
+          "#subject-tabs",
+          en: "A fancy newsletter for %{name}",
+          es: "Un correo electrónico muy chulo para %{name}",
+          ca: "Un correu electrònic flipant per a %{name}"
+        )
+
+        fill_in_i18n_editor(
+          :newsletter_body,
+          "#body-tabs",
+          en: "Hello %{name}! Relevant content.",
+          es: "Hola, %{name}! Contenido relevante.",
+          ca: "Hola, %{name}! Contingut rellevant."
+        )
+
+        find("*[type=submit]").click
+      end
+
+      expect(page).to have_content("Preview")
+      expect(page).to have_content("A fancy newsletter for #{user.name}")
+    end
+  end
+
+  describe "previews a newsletter" do
+    let!(:newsletter) do
+      create(:newsletter,
+             organization: organization,
+             subject: {
+               en: "A fancy newsletter for %{name}",
+               es: "Un correo electrónico muy chulo para %{name}",
+               ca: "Un correu electrònic flipant per a %{name}"
+             },
+             body: {
+               en: "Hello %{name}! Relevant content.",
+               es: "Hola, %{name}! Contenido relevante.",
+               ca: "Hola, %{name}! Contingut rellevant."
+             })
+    end
+
+    it "previews a newsletter" do
+      visit decidim_admin.newsletter_path(newsletter)
+
+      expect(page).to have_content("A fancy newsletter for Sarah Kerrigan")
+      expect(page).to have_css("iframe.email-preview[src=\"#{decidim_admin.preview_newsletter_path(newsletter)}\"]")
+
+      visit decidim_admin.preview_newsletter_path(newsletter)
+      expect(page).to have_content("Hello Sarah Kerrigan! Relevant content.")
+    end
+  end
+
+  describe "update newsletter" do
+    let!(:newsletter) { create(:newsletter, organization: organization)}
+
+    it "allows a newsletter to be updated" do
+      visit decidim_admin.newsletters_path
+      within("tr[data-newsletter-id=\"#{newsletter.id}\"]") do
+        click_link "Edit"
+      end
+
+      within ".edit_newsletter" do
+        fill_in_i18n(
+          :newsletter_subject,
+          "#subject-tabs",
+          en: "A fancy newsletter",
+          es: "Un correo electrónico muy chulo",
+          ca: "Un correu electrònic flipant"
+        )
+
+        fill_in_i18n_editor(
+          :newsletter_body,
+          "#body-tabs",
+          en: "Relevant content.",
+          es: "Contenido relevante.",
+          ca: "Contingut rellevant."
+        )
+
+        find("*[type=submit]").click
+      end
+
+      expect(page).to have_content("Preview")
+      expect(page).to have_content("A fancy newsletter")
+    end
+  end
+
+  describe "deliver a newsletter" do
+    let!(:newsletter) { create(:newsletter, organization: organization)}
+
+    it "allows a newsletter to be created" do
+      visit decidim_admin.newsletter_path(newsletter)
+
+      within ".actions" do
+        find("*", text: "Deliver").click
+      end
+
+      expect(page).to have_content("Newsletters")
+      expect(page).to have_content("successfully")
+
+      within ".newsletters tbody" do
+        expect(page).to have_content("5 / 5")
+      end
+    end
+  end
+
+  describe "destroy a newsletter" do
+    let!(:newsletter) { create(:newsletter, organization: organization)}
+
+    it "destroys a newsletter" do
+      visit decidim_admin.newsletters_path
+
+      within("tr[data-newsletter-id=\"#{newsletter.id}\"]") do
+        click_link "Destroy"
+      end
+
+      expect(page).to have_content("successfully")
+      expect(page).to have_no_css("tr[data-newsletter-id=\"#{newsletter.id}\"]")
+    end
+  end
+end

data/decidim-admin/spec/features/admin_manages_participatory_processes_spec.rb

@@ -58,12 +58,8 @@ describe "Admin manage participatory processes", type: :feature do
       expect(page).to have_content("successfully")
     end
 
-    within "table" do
+    within ".tabs-content" do
       expect(page).to have_content("My participatory process")
-      click_link("My participatory process")
-    end
-
-    within "dl" do
       expect(page).to have_css("img[src*='#{image1_filename}']")
       expect(page).to have_css("img[src*='#{image2_filename}']")
     end

data/decidim-admin/spec/features/static_pages_spec.rb

@@ -11,6 +11,22 @@ describe "Content pages", type: :feature do
     switch_to_host(organization.host)
   end
 
+  describe "Showing pages" do
+    let!(:decidim_pages) { create_list(:static_page, 5, organization: organization) }
+
+    before do
+      visit decidim.pages_path
+    end
+
+    it "shows the list of all the pages" do
+      decidim_pages.each do |decidim_page|
+        expect(page).to have_css(
+                          "a[href=\"#{decidim.page_path(decidim_page)}\"]",
+                          text: decidim_page.title[I18n.locale.to_s].upcase)
+      end
+    end
+  end
+
   describe "Managing pages" do
     before do
       login_as admin, scope: :user

data/decidim-admin/spec/forms/newsletter_form_spec.rb

@@ -0,0 +1,47 @@
+# coding: utf-8
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe NewsletterForm do
+      let(:organization) { create(:organization) }
+      let(:newsletter_subject) do
+        {
+          en: "Subject",
+          es: "Asunto",
+          ca: "Assumpte"
+        }
+      end
+
+      let(:body) do
+        {
+          en: "Body",
+          es: "Cuerpo",
+          ca: "Cos"
+        }
+      end
+
+      subject do
+        described_class.new(subject: newsletter_subject, body: body).
+          with_context(current_organization: organization)
+      end
+
+      context "when everything is OK" do
+        it { is_expected.to be_valid }
+      end
+
+      context "when there's no subject" do
+        let(:newsletter_subject) { nil }
+
+        it { is_expected.to be_invalid }
+      end
+
+      context "when there's no body" do
+        let(:body) { nil }
+
+        it { is_expected.to be_invalid }
+      end
+    end
+  end
+end

data/decidim-admin/spec/jobs/newsletter_delivery_job_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe NewsletterDeliveryJob do
+      let(:user) { create(:user) }
+      let(:organization) { create(:organization) }
+      let(:newsletter) { create(:newsletter, organization: organization, total_deliveries: 0) }
+
+      it "delivers a newsletter to a single user" do
+        NewsletterDeliveryJob.perform_now(user, newsletter)
+
+        expect(last_email.subject).to include(newsletter.subject[I18n.locale.to_s])
+        expect(last_email.to).to include(user.email)
+      end
+
+      it "increments the delivery count" do
+        expect {
+          NewsletterDeliveryJob.perform_now(user, newsletter)
+        }.to change { newsletter.reload.total_deliveries }.by(1)
+      end
+    end
+  end
+end

data/decidim-admin/spec/jobs/newsletter_job_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe NewsletterJob do
+      let!(:newsletter) { create(:newsletter, organization: organization, total_deliveries: 0) }
+      let!(:organization) { create(:organization) }
+      let!(:deliverable_user) { create(:user, :confirmed, newsletter_notifications: true, organization: organization) }
+      let!(:non_deliverable_user) { create(:user, :confirmed, newsletter_notifications: false, organization: organization) }
+
+      it "delivers a newsletter to a the eligible users" do
+        expect(NewsletterDeliveryJob).to receive(:perform_later).with(deliverable_user, newsletter)
+
+        NewsletterJob.perform_now(newsletter)
+      end
+
+      it "updates the recipients count" do
+        NewsletterJob.perform_now(newsletter)
+        expect(newsletter.reload.total_recipients).to eq(1)
+      end
+
+      it "updates the deliveries count" do
+        NewsletterJob.perform_now(newsletter)
+        expect(newsletter.reload.total_deliveries).to eq(0)
+      end
+    end
+  end
+end

data/decidim-admin/spec/models/abilities/collaborator_user_spec.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe Decidim::Admin::Abilities::CollaboratorUser do
+  let(:user) { build(:user, :collaborator) }
+
+  subject { described_class.new(user, {}) }
+
+  context "when the user is not a collaborator" do
+    let(:user) { build(:user) }
+
+    it "doesn't have any permission" do
+      expect(subject.permissions[:can]).to be_empty
+      expect(subject.permissions[:cannot]).to be_empty
+    end
+  end
+
+  it { is_expected.to be_able_to(:preview, Decidim::ParticipatoryProcess) }
+
+  context "when a page is a default one" do
+    let(:page) { build(:static_page, :default) }
+    let(:form) { Decidim::Admin::StaticPageForm.new(slug: page.slug) }
+
+    it { is_expected.not_to be_able_to(:update_slug, page) }
+    it { is_expected.not_to be_able_to(:update_slug, form) }
+    it { is_expected.not_to be_able_to(:destroy, page) }
+    it { is_expected.not_to be_able_to(:destroy, form) }
+  end
+
+  context "when a page is not default one" do
+    let(:page) { build(:static_page) }
+    let(:form) { Decidim::Admin::StaticPageForm.new(slug: page.slug) }
+
+    it { is_expected.not_to be_able_to(:update_slug, page) }
+    it { is_expected.not_to be_able_to(:update_slug, form) }
+    it { is_expected.not_to be_able_to(:destroy, page) }
+    it { is_expected.not_to be_able_to(:destroy, form) }
+  end
+
+  context "when the organization is the one they belong to" do
+    let(:organization) { user.organization }
+
+    it { is_expected.not_to be_able_to(:update, organization) }
+    it { is_expected.not_to be_able_to(:read, organization) }
+  end
+
+  context "when the organization is different form the one they belong to" do
+    let(:organization) { build(:organization) }
+
+    it { is_expected.not_to be_able_to(:update, organization) }
+    it { is_expected.not_to be_able_to(:read, organization) }
+  end
+
+  context "when destroying a user" do
+    context "when the user is themselves" do
+      let(:user_to_destroy) { user }
+      it { is_expected.not_to be_able_to(:destroy, user_to_destroy) }
+    end
+
+    context "when it is another user" do
+      let(:user_to_destroy) { build(:user) }
+
+      it { is_expected.not_to be_able_to(:destroy, user_to_destroy) }
+    end
+  end
+end

data/decidim-admin/spec/organization_dashboard_constraint_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe OrganizationDashboardConstraint do
+      let(:organization) { create(:organization) }
+      let(:request) do
+        double(
+          env: {
+            "decidim.current_organization" => organization,
+            "warden" => warden
+          }
+        )
+      end
+      let(:warden) do
+        double(
+          authenticate!: authenticated,
+          user: user
+        )
+      end
+
+      subject { described_class.new(request).matches? }
+
+      context "when authenticated" do
+        let(:authenticated) { true }
+
+        context "a regular user" do
+          let(:user) { create(:user, :confirmed, organization: organization) }
+
+          it { is_expected.to be_falsey }
+        end
+
+        context "an organization admin" do
+          let(:user) { create(:user, :confirmed, :admin, organization: organization) }
+          it { is_expected.to be_truthy }
+        end
+
+        context "an admin from another organization" do
+          let(:other_organization) { create(:organization) }
+          let(:user) { create(:user, :confirmed, :admin, organization: other_organization) }
+
+          it { is_expected.to be_falsey }
+        end
+      end
+
+      describe "when unauthenticated" do
+        let(:authenticated) { false }
+        let(:user) { nil }
+
+        it { is_expected.to be_falsey }
+      end
+    end
+  end
+end