decidim 0.0.1 → 0.0.2

data/decidim-comments/spec/types/comment_type_spec.rb

@@ -12,8 +12,21 @@ module Decidim
       describe "createdAt" do
         let(:query) { "{ createdAt }" }
 
-        it "returns its created_at field" do
-          expect(response).to include("createdAt" => model.created_at.to_s)
+        it "returns its created_at field to iso format" do
+          expect(response).to include("createdAt" => model.created_at.iso8601)
+        end
+      end
+
+      describe "hasReplies" do
+        let (:query) { "{ hasReplies }" }
+
+        it "returns false if the comment has not replies" do
+          expect(response).to include("hasReplies" => false)
+        end
+
+        it "returns true if the comment has replies" do
+          FactoryGirl.create(:comment, commentable: model)
+          expect(response).to include("hasReplies" => true)
         end
       end
 
@@ -27,7 +40,8 @@ module Decidim
 
       describe "replies" do
         let!(:random_comment) { FactoryGirl.create(:comment) }
-        let!(:replies) { 3.times.map { FactoryGirl.create(:comment, commentable: model) } }
+        let!(:replies) { 3.times.map { |n| FactoryGirl.create(:comment, commentable: model, created_at: Time.now - n.days) } }
+
 
         let(:query) { "{ replies { id } }" }
 
@@ -37,6 +51,12 @@ module Decidim
           end
           expect(response["replies"]).to_not include("id" => random_comment.id.to_s)
         end
+
+        it "return comment's replies ordered by date" do
+          response_ids = response["replies"].map{|reply| reply["id"].to_i }
+          replies_ids = replies.sort_by(&:created_at).map(&:id)
+          expect(response_ids).to eq(replies_ids)
+        end
       end
 
       describe "alignment" do
@@ -46,6 +66,40 @@ module Decidim
           expect(response).to include("alignment" => model.alignment)
         end
       end
+
+      describe "upVotes" do
+        let(:query) { "{ upVotes }" }
+
+        it "returns the up_votes count" do
+          expect(response).to include("upVotes" => model.up_votes.count)
+        end
+      end
+
+      describe "downVotes" do
+        let(:query) { "{ downVotes }" }
+
+        it "returns the down_votes count" do
+          expect(response).to include("downVotes" => model.down_votes.count)
+        end
+      end
+
+      describe "upVoted" do
+        let(:query) { "{ upVoted }" }
+
+        it "returns the up_voted_by? method evaluation with the current user" do
+          expect(model).to receive(:up_voted_by?).with(current_user).and_return(true)
+          expect(response).to include("upVoted" => true)
+        end
+      end
+
+      describe "downVoted" do
+        let(:query) { "{ downVoted }" }
+
+        it "returns the down_voted_by? method evaluation with the current user" do
+          expect(model).to receive(:down_voted_by?).with(current_user).and_return(true)
+          expect(response).to include("downVoted" => true)
+        end
+      end
     end
   end
 end

data/{decidim-api → decidim-comments}/spec/types/mutation_type_spec.rb

@@ -33,6 +33,17 @@ module Decidim
           end
         end
       end
+
+      describe "comment" do
+        let!(:comment) { create(:comment) }
+        let(:query) {
+          "{ comment(id: \"#{comment.id}\") { id } }"
+        }          
+
+        it "should fetch the comment given its id" do
+          expect(response["comment"]).to include("id" => comment.id.to_s)
+        end
+      end
     end
   end
 end

data/decidim-dev/README.md

@@ -1,14 +1,15 @@
-# Decidim::System
-Short description and motivation.
+# Decidim::Dev
+
+This gem allows local development of decidim's features and other features.
 
 ## Usage
-How to use my plugin.
+TODO: Write docs.
 
 ## Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'decidim-system'
+gem 'decidim-dev'
 ```
 
 And then execute:
@@ -16,13 +17,8 @@ And then execute:
 $ bundle
 ```
 
-Or install it yourself as:
-```bash
-$ gem install decidim-system
-```
-
 ## Contributing
-Contribution directions go here.
+See [Decidim](https://github.com/AjuntamentdeBarcelona/decidim).
 
 ## License
-The gem is available as open source under the terms of the [AGPLv3 License](https://opensource.org/licenses/AGPL-3.0).
+See [Decidim](https://github.com/AjuntamentdeBarcelona/decidim).

data/decidim-dev/decidim-dev.gemspec

@@ -14,6 +14,7 @@ Gem::Specification.new do |s|
 
   s.files = Dir["{app,config,db,lib,vendor}/**/*", "LICENSE.txt", "Rakefile", "README.md"]
 
+  s.add_dependency "decidim", Decidim.version
   s.add_dependency "factory_girl_rails"
   s.add_dependency "database_cleaner", "~> 1.5.0"
   s.add_dependency "capybara", "~> 2.11.0"
@@ -24,12 +25,12 @@ Gem::Specification.new do |s|
   s.add_dependency "wisper-rspec"
   s.add_dependency "listen", "~> 3.1.0"
   s.add_dependency "launchy"
-  s.add_dependency "i18n-tasks", "~> 0.9.6"
-  s.add_dependency "bullet", "~> 5.4.3"
-  s.add_dependency "faker", "~> 1.6.6"
+  s.add_dependency "i18n-tasks", "0.9.8"
+  s.add_dependency "faker", "~> 1.7.2"
   s.add_dependency "poltergeist", "~> 1.12.0"
   s.add_dependency "rails-controller-testing", "~> 1.0.1"
   s.add_dependency "simplecov", "~> 0.12"
   s.add_dependency "codecov", "~> 0.1.9"
-  s.add_dependency "rubocop", "~> 0.46"
+  s.add_dependency "rubocop", "~> 0.47"
+  s.add_dependency "db-query-matchers", "~> 0.7.0"
 end

data/decidim-dev/lib/decidim/dev.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Decidim
+  # Decidim::Dev holds all the convenience logic and libraries to be able to
+  # create external libraries that create test apps and test themselves against
+  # them.
+  module Dev
+    # Public: Finds an asset.
+    #
+    # Returns a String with the path for a particular asset.
+    def self.asset(name)
+      File.join(
+        File.dirname(__FILE__),
+        "dev",
+        "assets",
+        name
+      )
+    end
+  end
+end

data/decidim-dev/lib/decidim/dev/assets/avatar.svg

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Generator: Adobe Illustrator 16.0.4, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
+	 width="200px" height="200px" viewBox="0 0 200 200" enable-background="new 0 0 200 200" xml:space="preserve">
+<g>
+	<path fill="#C5C5C5" d="M200-0.5H0v200h26.099c2.885-35.293,24.07-64.381,52.419-74.319C64.372,117.596,54.75,102.674,54.75,85.5
+		c0-24.853,20.146-45,45-45c24.853,0,45,20.147,45,45c0,17.095-9.533,31.963-23.572,39.58c28.5,9.837,49.828,39.002,52.724,74.42
+		H200V-0.5z"/>
+	<path fill="#FFFFFF" d="M121.178,125.08c14.039-7.617,23.572-22.485,23.572-39.58c0-24.853-20.147-45-45-45
+		c-24.854,0-45,20.147-45,45c0,17.174,9.622,32.096,23.768,39.681c-28.349,9.938-49.534,39.026-52.419,74.319h147.803
+		C171.006,164.082,149.678,134.917,121.178,125.08z"/>
+</g>
+</svg>

data/decidim-dev/lib/decidim/{common_rake.rb → dev/common_rake.rb}

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
-require_relative "../generators/decidim/dummy_generator"
+require_relative "../../generators/decidim/dummy_generator"
 
 engine_path = Dir.pwd
 engine_name = engine_path.split("/").last

data/decidim-dev/lib/decidim/{dummy_authorization_handler.rb → dev/dummy_authorization_handler.rb}

@@ -8,14 +8,14 @@ module Decidim
     validates :document_number, presence: true
     validate :valid_document_number
 
-    def authorized?
-      valid?
-    end
-
     def metadata
       super.merge(document_number: document_number)
     end
 
+    def unique_id
+      document_number
+    end
+
     private
 
     def valid_document_number

data/decidim-dev/lib/decidim/{test → dev/test}/authorization_shared_examples.rb

@@ -6,14 +6,6 @@ RSpec.shared_examples "an authorization handler" do
     end
   end
 
-  describe "authorized?" do
-    it "is implemented" do
-      expect do
-        handler.authorized?
-      end.to_not raise_error
-    end
-  end
-
   describe "to_partial_path" do
     subject { handler.to_partial_path }
     it { is_expected.to be_kind_of(String) }

data/decidim-dev/lib/decidim/{test → dev/test}/base_spec_helper.rb

@@ -6,6 +6,8 @@ dummy_app_path = File.expand_path(File.join(Dir.pwd, "spec", "#{engine_name}_dum
 
 if ENV["CI"]
   require "simplecov"
+  SimpleCov.root(ENV["TRAVIS_BUILD_DIR"])
+
   SimpleCov.start do
     filters.clear
     add_filter "/test/"
@@ -43,11 +45,12 @@ require "database_cleaner"
 require "byebug"
 require "cancan/matchers"
 require "rectify/rspec"
+require "wisper/rspec/stub_wisper_publisher"
+require "db-query-matchers"
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/rspec_support/**/*.rb"].each { |f| require f }
-Dir[File.join(File.dirname(__FILE__), "..", "..", "..", "..", engine_name, "spec", "support", "**", "*.rb")].each { |f| require f }
 
 RSpec.configure do |config|
   config.color = true

data/decidim-dev/lib/decidim/{test → dev/test}/i18n_spec.rb

@@ -2,7 +2,7 @@
 require "i18n/tasks"
 
 RSpec.describe "I18n" do
-  let(:i18n) { I18n::Tasks::BaseTask.new(locales: ["en"]) }
+  let(:i18n) { I18n::Tasks::BaseTask.new(locales: [I18n.default_locale]) }
   let(:missing_keys) { i18n.missing_keys }
   let(:unused_keys) { i18n.unused_keys }
 

data/decidim-dev/lib/decidim/{test → dev/test}/rspec_support/authorization_handlers.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require "decidim/dummy_authorization_handler"
+require "decidim/dev/dummy_authorization_handler"
 RSpec.configure do |config|
   config.before(:each) do
     Decidim.config.authorization_handlers = [Decidim::DummyAuthorizationHandler]

data/decidim-dev/lib/decidim/{test → dev/test}/rspec_support/capybara.rb

@@ -21,23 +21,16 @@ module Decidim
   end
 end
 
-node_modules_path = File.join(
-  File.dirname(__FILE__), "..", "..", "..", "..", "..", "node_modules"
-)
-
 capybara_options = {
-  phantomjs: File.expand_path(
-    File.join(node_modules_path, ".bin", "phantomjs")
-  ),
   extensions: [
     File.expand_path(
-      File.join(node_modules_path, "promise-polyfill", "promise.js")
+      File.join(File.dirname(__FILE__), "phantomjs_polyfills", "promise.js")
     ),
     File.expand_path(
-      File.join(node_modules_path, "phantomjs-polyfill", "bind-polyfill.js")
+      File.join(File.dirname(__FILE__), "phantomjs_polyfills", "bind-polyfill.js")
     ),
     File.expand_path(
-      File.join(node_modules_path, "phantomjs-polyfill-object-assign", "object-assign-polyfill.js")
+      File.join(File.dirname(__FILE__), "phantomjs_polyfills", "object-assign-polyfill.js")
     )
   ],
   js_errors: true,

data/decidim-dev/lib/decidim/{test → dev/test}/rspec_support/feature.rb

@@ -13,6 +13,16 @@ end
 
 Decidim.register_feature(:dummy) do |feature|
   feature.engine = Decidim::DummyEngine
+
+  feature.settings(:global) do |settings|
+    settings.attribute :dummy_global_attribute_1, type: :boolean
+    settings.attribute :dummy_global_attribute_2, type: :boolean
+  end
+
+  feature.settings(:step) do |settings|
+    settings.attribute :dummy_step_attribute_1, type: :boolean
+    settings.attribute :dummy_step_attribute_2, type: :boolean
+  end
 end
 
 RSpec.configure do |config|

data/decidim-dev/lib/decidim/{test → dev/test}/rspec_support/feature_context.rb

@@ -6,7 +6,7 @@ RSpec.shared_context "feature" do
   let!(:organization) { create(:organization) }
 
   let(:participatory_process) do
-    create(:participatory_process, organization: organization)
+    create(:participatory_process, :with_steps, organization: organization)
   end
 
   let!(:feature) do
@@ -20,7 +20,7 @@ RSpec.shared_context "feature" do
   end
 
   def visit_feature
-    visit decidim.feature_path(participatory_process, feature)
+    page.visit decidim.feature_path(participatory_process, feature)
   end
 end
 

data/decidim-dev/lib/decidim/{test → dev/test}/rspec_support/helpers.rb

@@ -31,6 +31,10 @@ module Decidim::FeatureTestHelpers
       yield
     end
   end
+
+  def expect_user_logged
+    expect(page).to have_css(".topbar__user__logged")
+  end
 end
 
 def stripped(text)

data/decidim-dev/lib/decidim/{test → dev/test}/rspec_support/i18n.rb

@@ -2,6 +2,7 @@
 RSpec.configure do |config|
   config.before(:suite) do
     I18n.config.enforce_available_locales = false
+    Rails.application.config.action_view.raise_on_missing_translations = true
   end
 
   config.around(:each) do |example|

data/decidim-dev/lib/decidim/dev/test/rspec_support/phantomjs_polyfills/bind-polyfill.js

@@ -0,0 +1,18 @@
+if (typeof Function.prototype.bind != 'function') {
+    Function.prototype.bind = function bind(obj) {
+        var args = Array.prototype.slice.call(arguments, 1),
+            self = this,
+            nop = function() {
+            },
+            bound = function() {
+                return self.apply(
+                    this instanceof nop ? this : (obj || {}), args.concat(
+                        Array.prototype.slice.call(arguments)
+                    )
+                );
+            };
+        nop.prototype = this.prototype || {};
+        bound.prototype = new nop();
+        return bound;
+    };
+}

data/decidim-dev/lib/decidim/dev/test/rspec_support/phantomjs_polyfills/object-assign-polyfill.js

@@ -0,0 +1,24 @@
+//https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill
+if (typeof Object.assign != 'function') {
+  (function () {
+    Object.assign = function (target) {
+      'use strict';
+      if (target === undefined || target === null) {
+        throw new TypeError('Cannot convert undefined or null to object');
+      }
+
+      var output = Object(target);
+      for (var index = 1; index < arguments.length; index++) {
+        var source = arguments[index];
+        if (source !== undefined && source !== null) {
+          for (var nextKey in source) {
+            if (source.hasOwnProperty(nextKey)) {
+              output[nextKey] = source[nextKey];
+            }
+          }
+        }
+      }
+      return output;
+    };
+  })();
+}