decidim 0.0.1.alpha9 → 0.0.1

data/decidim-proposals/spec/features/process_admin_manages_proposals_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative "../shared/admin_shared_context"
+require_relative "../shared/manage_proposals_examples"
+
+describe "Process admin manages proposals", type: :feature do
+  include_context "admin"
+  let(:user) { process_admin }
+  it_behaves_like "manage proposals"
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+    visit decidim_admin.manage_feature_path(participatory_process_id: participatory_process, feature_id: current_feature)
+  end
+end

data/decidim-proposals/spec/features/proposals_spec.rb

@@ -0,0 +1,117 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe "Proposals", type: :feature do
+  let(:feature) { create(:proposal_feature) }
+  let(:organization) { feature.organization }
+  let(:participatory_process) { feature.participatory_process }
+  let!(:proposals) { create_list(:proposal, 3, feature: feature) }
+  let!(:category) { create :category, participatory_process: participatory_process }
+  let!(:scope) { create :scope, organization: organization }
+  let!(:user) { create :user, :confirmed, organization: organization }
+
+  before do
+    switch_to_host(organization.host)
+    visit decidim.root_path
+  end
+
+  context "creating a new proposal" do
+    context "when the user is logged in" do
+      before do
+        login_as user, scope: :user
+      end
+
+      it "creates a new proposal" do
+        click_link "Processes"
+        click_link participatory_process.title["en"]
+        click_link "Proposals"
+        click_link "New proposal"
+
+        within ".new_proposal" do
+          fill_in :proposal_title, with: "Oriol for president"
+          fill_in :proposal_body, with: "He will solve everything"
+          select category.name["en"], from: :proposal_category_id
+          select scope.name["en"], from: :proposal_scope_id
+
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_content("successfully")
+        expect(page).to have_content("Oriol for president")
+        expect(page).to have_content("He will solve everything")
+        expect(page).to have_content(category.name["en"])
+        expect(page).to have_content(scope.name["en"])
+      end
+    end
+  end
+
+  context "when it is an official proposal" do
+    let!(:official_proposal) { create(:proposal, feature: feature, author: nil) }
+
+    it "shows the author as official" do
+      click_link "Processes"
+      click_link participatory_process.title["en"]
+      click_link "Proposals"
+      click_link official_proposal.title
+
+      expect(page).to have_content("Official proposal")
+    end
+  end
+
+  context "when a proposal has comments" do
+    let(:proposal) { create(:proposal, feature: feature)}
+    let(:author) { create(:user, :confirmed, organization: feature.organization)}
+    let!(:comments) { create_list(:comment, 3, commentable: proposal) }
+
+    before do
+      click_link "Processes"
+      click_link participatory_process.title["en"]
+      click_link "Proposals"
+    end
+
+    it "shows the comments" do
+      click_link proposal.title
+
+      comments.each do |comment| 
+        expect(page).to have_content(comment.body)
+      end
+    end
+  end
+
+  context "listing proposals in a participatory process" do
+    before do
+      click_link "Processes"
+      click_link participatory_process.title["en"]
+      click_link "Proposals"
+    end
+
+    it "lists all the proposals" do
+      expect(page).to have_css(".card--proposal", 3)
+    end
+
+    it "allows viewing a single proposal" do
+      proposal = proposals.first
+
+      click_link proposal.title
+
+      expect(page).to have_content(proposal.title)
+      expect(page).to have_content(proposal.body)
+      expect(page).to have_content(proposal.author.name)
+    end
+
+    context "when there are a lot of proposals" do
+      before do
+        create_list(:proposal, 20, feature: feature)
+        visit current_path
+      end
+
+      it "paginates them" do
+        expect(page).to have_css(".card--proposal", 12)
+
+        find(".pagination-next a").click
+
+        expect(page).to have_css(".card--proposal", 8)
+      end
+    end
+  end
+end

data/decidim-proposals/spec/forms/decidim/proposals/proposal_form_spec.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Proposals
+    describe ProposalForm do
+      let(:feature) { create(:feature)}
+      let(:title) { "Oriol for president!" }
+      let(:body) { "Everything would be better" }
+      let(:author) { create(:user, organization: feature.organization) }
+      let(:category) { create(:category, participatory_process: feature.participatory_process) }
+      let(:scope) { create(:scope, organization: feature.organization) }
+      let(:category_id) { category.try(:id)}
+      let(:scope_id) { scope.try(:id)}
+      let(:params) do
+        {
+          title: title,
+          body: body,
+          author: author,
+          category_id: category_id,
+          scope_id: scope_id,
+          feature: feature
+        }
+      end
+
+      subject { described_class.from_params(params) }
+
+      context "when everything is OK" do
+        it { is_expected.to be_valid }
+      end
+
+      context "when there's no title" do
+        let(:title) { nil }
+        it { is_expected.to be_invalid }
+      end
+
+      context "when there's no body" do
+        let(:body) { nil }
+        it { is_expected.to be_invalid }
+      end
+
+      context "when there's no author" do
+        let(:author) { nil }
+        it { is_expected.to be_invalid }
+      end
+
+      context "when no category_id" do
+        let(:category_id) { nil }
+        it { is_expected.to be_valid }
+      end
+
+      context "when no scope_id" do
+        let(:scope_id) { nil }
+        it { is_expected.to be_valid }
+      end
+
+      context "with invalid category_id" do
+        let(:category_id) { 987 }
+        it { is_expected.to be_invalid}
+      end
+
+      context "with invalid scope_id" do
+        let(:scope_id) { 987 }
+        it { is_expected.to be_invalid}
+      end
+
+      describe "category" do
+        subject { described_class.from_params(params).category }
+
+        context "when the category exists" do
+          it { is_expected.to be_kind_of(Decidim::Category) }
+        end
+
+        context "when the category does not exist" do
+          let(:category_id) { 7654 }
+          it { is_expected.to eq(nil) }
+        end
+
+        context "when the category is from another process" do
+          let(:category_id) { create(:category).id }
+          it { is_expected.to eq(nil) }
+        end
+      end
+
+      describe "scope" do
+        subject { described_class.from_params(params).scope }
+
+        context "when the scope exists" do
+          it { is_expected.to be_kind_of(Decidim::Scope) }
+        end
+
+        context "when the scope does not exist" do
+          let(:scope_id) { 3456 }
+          it { is_expected.to eq(nil) }
+        end
+
+        context "when the scope is from another organization" do
+          let(:scope_id) { create(:scope).id }
+          it { is_expected.to eq(nil) }
+        end
+      end
+    end
+  end
+end

data/decidim-proposals/spec/lib/decidim/proposals/feature_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe "Proposals feature" do
+  let!(:feature) { create(:proposal_feature) }
+
+  describe "on destroy" do
+    context "when there are no proposals for the feature" do
+      it "destroys the feature" do
+        expect do
+          Decidim::Admin::DestroyFeature.call(feature)
+        end.to change { Decidim::Feature.count }.by(-1)
+
+        expect(feature).to be_destroyed
+      end
+    end
+
+    context "when there are proposals for the feature" do
+      before do
+        create(:proposal, feature: feature)
+      end
+
+      it "raises an error" do
+        expect do
+          Decidim::Admin::DestroyFeature.call(feature)
+        end.to raise_error
+
+        expect(feature).to_not be_destroyed
+      end
+    end
+  end
+end

data/decidim-proposals/spec/models/decidim/proposals/proposal_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Proposals
+    describe Proposal do
+      subject { create(:proposal) }
+
+      it { is_expected.to be_valid }
+
+      context "when the category is from another feature" do
+        subject { create(:proposal, category: create(:category))}
+
+        it { is_expected.to be_invalid}
+      end
+
+      context "when the author is from another organization" do
+        subject { create(:proposal, author: create(:user))}
+
+        it { is_expected.to be_invalid}
+      end
+
+      context "when the scope is from another organization" do
+        subject { create(:proposal, scope: create(:scope))}
+
+        it { is_expected.to be_invalid}
+      end
+    end
+  end
+end

data/decidim-proposals/spec/services/decidim/proposals/proposal_search_spec.rb

@@ -0,0 +1,62 @@
+require "spec_helper"
+
+module Decidim
+  module Proposals
+    describe ProposalSearch do
+      let(:feature) { create(:feature) }
+      let!(:proposal) { create(:proposal, feature: feature)}
+      let(:page) { 1 }
+
+      describe "proposals" do
+        let(:random_seed) { 0.2 }
+
+        subject { described_class.new(feature, page, random_seed).proposals }
+
+        context "when given a random seed" do
+          it "sets the seed at the database" do
+            allow(Proposal.connection).to receive(:execute).with(anything)
+            expect(Proposal.connection).to receive(:execute).with("SELECT setseed(0.2)").and_call_original
+            subject
+          end
+        end
+
+        it "only includes proposals from the given feature" do
+          other_proposal = create(:proposal)
+
+          expect(subject).to include(proposal)
+          expect(subject).to_not include(other_proposal)
+        end
+
+        it "randomizes the order of proposals" do
+          allow(Proposal.connection).to receive(:execute).with(anything)
+          expect_any_instance_of(Decidim::Proposals::Proposal::ActiveRecord_Relation).to receive(:reorder).with("RANDOM()").and_call_original
+          subject
+        end
+
+        it "filters the proposals per page" do
+          create_list(:proposal, 3, feature: feature)
+          proposals = described_class.new(feature, page, random_seed, 2).proposals
+
+          expect(proposals.total_pages).to eq(2)
+          expect(proposals.total_count).to eq(4)
+        end
+      end
+
+      describe "random_seed" do
+        subject { described_class.new(feature, page, random_seed).random_seed }
+
+        context "without a given random seed" do
+          let(:random_seed) { nil }
+
+          it { is_expected.to be_within(1).of(0.0) }
+        end
+
+        context "with an invalid random seed" do
+          let(:random_seed) { ["foo", 2, -10].sample }
+
+          it { is_expected.to be_within(1).of(0.0) }
+        end
+      end
+    end
+  end
+end

data/decidim-proposals/spec/shared/admin_shared_context.rb

@@ -0,0 +1,11 @@
+RSpec.shared_context "admin" do
+  let(:organization) { create(:organization) }
+  let!(:user) { create(:user, :admin, :confirmed, organization: organization) }
+  let(:participatory_process) { create(:participatory_process, organization: organization) }
+  let(:process_admin) { create :user, :confirmed, organization: organization }
+  let!(:user_role) { create :participatory_process_user_role, user: process_admin, participatory_process: participatory_process }
+  let(:current_feature) { create :proposal_feature, participatory_process: participatory_process }
+  let!(:proposal) { create :proposal, feature: current_feature }
+  let!(:category) { create :category, participatory_process: participatory_process }
+  let!(:scope) { create :scope, organization: organization }
+end

data/decidim-proposals/spec/shared/manage_proposals_examples.rb

@@ -0,0 +1,40 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "manage proposals" do
+  context "previewing proposals" do
+    it "allows the user to preview the proposal" do
+      new_window = window_opened_by { click_link proposal.title }
+
+      within_window new_window do
+        expect(current_path).to eq decidim_proposals.proposal_path(id: proposal.id, participatory_process_id: participatory_process.id, feature_id: current_feature.id)
+        expect(page).to have_content(translated(proposal.title))
+      end
+    end
+  end
+
+  it "creates a new proposal" do
+    find(".actions .new").click
+
+    within ".new_proposal" do
+      fill_in :proposal_title, with: "Make decidim great again"
+      fill_in :proposal_body, with: "Decidim is great but it can be better"
+      select category.name["en"], from: :proposal_category_id
+      select scope.name["en"], from: :proposal_scope_id
+
+      find("*[type=submit]").click
+    end
+
+    within ".flash" do
+      expect(page).to have_content("successfully")
+    end
+
+    within "table" do
+      proposal = Decidim::Proposals::Proposal.last
+
+      expect(page).to have_content("Make decidim great again")
+      expect(proposal.body).to eq("Decidim is great but it can be better")
+      expect(proposal.category).to eq(category)
+      expect(proposal.scope).to eq(scope)
+    end
+  end
+end

data/decidim-proposals/spec/spec_helper.rb

@@ -0,0 +1,2 @@
+ENV["ENGINE_NAME"] = File.dirname(File.dirname(__FILE__)).split("/").last
+require "decidim/test/base_spec_helper"

data/decidim-system/Rakefile

@@ -1,27 +1,2 @@
 # frozen_string_literal: true
-
 require "decidim/common_rake"
-require "rdoc/task"
-
-RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = "rdoc"
-  rdoc.title    = "Decidim::System"
-  rdoc.options << "--line-numbers"
-  rdoc.rdoc_files.include("README.md")
-  rdoc.rdoc_files.include("lib/**/*.rb")
-end
-
-load "rails/tasks/statistics.rake"
-
-require "bundler/gem_tasks"
-
-begin
-  require "rspec/core/rake_task"
-  RSpec::Core::RakeTask.new(:spec)
-  ENV["ENGINE_PATH"] = File.dirname(__FILE__)
-
-  task default: :spec
-
-  Rake::Task["spec"].enhance ["common:test_app"]
-rescue LoadError
-end