decidim 0.0.1.alpha7 → 0.0.1.alpha8

data/decidim-admin/spec/commands/deactivate_participatory_process_step_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+
+describe Decidim::Admin::DeactivateParticipatoryProcessStep do
+  let(:process_step) { create :participatory_process_step, :active }
+
+  subject { described_class.new(process_step) }
+
+  context "when the step is nil" do
+    let(:process_step) { nil }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the step is inactive" do
+    let(:process_step) { create :participatory_process_step }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the step is active" do
+    it "is valid" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "deactivates it" do
+      subject.call
+      process_step.reload
+      expect(process_step).not_to be_active
+    end
+  end
+end

data/decidim-admin/spec/commands/publish_participatory_process_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+
+describe Decidim::Admin::PublishParticipatoryProcess do
+  let(:my_process) { create :participatory_process, :unpublished }
+
+  subject { described_class.new(my_process) }
+
+  context "when the process is nil" do
+    let(:my_process) { nil }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is published" do
+    let(:my_process) { create :participatory_process }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is not published" do
+    it "is valid" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "publishes it" do
+      subject.call
+      my_process.reload
+      expect(my_process).to be_published
+    end
+  end
+end

data/decidim-admin/spec/commands/reorder_participatory_process_steps_spec.rb

@@ -0,0 +1,53 @@
+require "spec_helper"
+
+describe Decidim::Admin::ReorderParticipatoryProcessSteps do
+  let(:process) { create :participatory_process }
+  let!(:process_step1) do
+    create(
+      :participatory_process_step,
+      participatory_process: process,
+      position: 1
+    )
+  end
+  let!(:process_step2) do
+    create(
+      :participatory_process_step,
+      participatory_process: process,
+      position: 2
+    )
+  end
+  let(:collection) { process.steps }
+  let(:order) { [process_step2.id, process_step1.id] }
+
+  subject { described_class.new(collection, order) }
+
+  context "when the order is nil" do
+    let(:order) { nil }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the order is empty" do
+    let(:order) { [] }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the order is valid" do
+    it "is valid" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "reorders the steps" do
+      subject.call
+      process_step1.reload
+      process_step2.reload
+      expect(process_step1.position).to eq 1
+      expect(process_step2.position).to eq 0
+    end
+  end
+end

data/decidim-admin/spec/commands/unpublish_participatory_process_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+
+describe Decidim::Admin::UnpublishParticipatoryProcess do
+  let(:my_process) { create :participatory_process }
+
+  subject { described_class.new(my_process) }
+
+  context "when the process is nil" do
+    let(:my_process) { nil }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is not published" do
+    let(:my_process) { create :participatory_process, :unpublished }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is published" do
+    it "is valid" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "unpublishes it" do
+      subject.call
+      my_process.reload
+      expect(my_process).not_to be_published
+    end
+  end
+end

data/decidim-admin/spec/controllers/participatory_processes_controller_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe ParticipatoryProcessesController, type: :controller do
+      let(:organization) { create(:organization) }
+      let!(:external_process) { create :participatory_process }
+
+      before do
+        @request.env["decidim.current_organization"] = organization
+        @request.env["devise.mapping"] = Devise.mappings[:user]
+      end
+
+      describe "GET show" do
+        context "process in another organization" do
+          let(:user) { create(:user, :admin, :confirmed, organization: organization) }
+
+          before do
+            sign_in user, scope: :user
+          end
+
+          it "is not visible to the user" do
+            expect do
+              get :show, params: { id: external_process.id }
+            end.to raise_error(ActiveRecord::RecordNotFound)
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-admin/spec/features/manage_participatory_process_steps_spec.rb

@@ -0,0 +1,151 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Manage participatory process steps", type: :feature do
+  let(:organization) { create(:organization) }
+  let(:admin) { create(:user, :admin, :confirmed, organization: organization) }
+  let(:participatory_process) do
+    create(
+      :participatory_process,
+      organization: organization,
+      description: { en: "Description", ca: "Descripció", es: "Descripción" },
+      short_description: { en: "Short description", ca: "Descripció curta", es: "Descripción corta" }
+    )
+  end
+  let(:active) { false }
+  let!(:process_step) do
+    create(
+      :participatory_process_step,
+      participatory_process: participatory_process,
+      active: active,
+      description: { en: "Description", ca: "Descripció", es: "Descripción" },
+      short_description: { en: "Short description", ca: "Descripció curta", es: "Descripción corta" }
+    )
+  end
+
+  before do
+    switch_to_host(organization.host)
+    login_as admin, scope: :user
+    visit decidim_admin.participatory_process_path(participatory_process)
+  end
+
+  it "displays all fields from a single participatory process" do
+    within "table" do
+      click_link translated(process_step.title)
+    end
+
+    within "dl" do
+      expect(page).to have_content(translated(process_step.title, locale: :en))
+      expect(page).to have_content(translated(process_step.title, locale: :es))
+      expect(page).to have_content(translated(process_step.title, locale: :ca))
+      expect(page).to have_content(translated(process_step.short_description, locale: :en))
+      expect(page).to have_content(translated(process_step.short_description, locale: :es))
+      expect(page).to have_content(translated(process_step.short_description, locale: :ca))
+      expect(page).to have_content(translated(process_step.description, locale: :en))
+      expect(page).to have_content(translated(process_step.description, locale: :es))
+      expect(page).to have_content(translated(process_step.description, locale: :ca))
+    end
+  end
+
+  it "creates a new participatory_process" do
+    find("#steps .actions .new").click
+
+    within ".new_participatory_process_step" do
+      fill_in :participatory_process_step_title_en, with: "My participatory process step"
+      fill_in :participatory_process_step_title_es, with: "Mi fase de proceso participativo"
+      fill_in :participatory_process_step_title_ca, with: "La meva fase de procés participatiu"
+      fill_in :participatory_process_step_short_description_en, with: "Short description"
+      fill_in :participatory_process_step_short_description_es, with: "Descripción corta"
+      fill_in :participatory_process_step_short_description_ca, with: "Descripció curta"
+      fill_in :participatory_process_step_description_en, with: "A longer description"
+      fill_in :participatory_process_step_description_es, with: "Descripción más larga"
+      fill_in :participatory_process_step_description_ca, with: "Descripció més llarga"
+      fill_in :participatory_process_step_start_date, with: 1.months.ago
+      fill_in :participatory_process_step_end_date, with: 2.months.from_now
+
+      find("*[type=submit]").click
+    end
+
+    within ".flash" do
+      expect(page).to have_content("successfully")
+    end
+
+    within "table" do
+      expect(page).to have_content("My participatory process step")
+    end
+  end
+
+  it "updates a participatory_process_step" do
+    within "#steps" do
+      within find("tr", text: translated(process_step.title)) do
+        click_link "Edit"
+      end
+    end
+
+    within ".edit_participatory_process_step" do
+      fill_in :participatory_process_step_title_en, with: "My new title"
+      fill_in :participatory_process_step_title_es, with: "Mi nuevo título"
+      fill_in :participatory_process_step_title_ca, with: "El meu nou títol"
+
+      find("*[type=submit]").click
+    end
+
+    within ".flash" do
+      expect(page).to have_content("successfully")
+    end
+
+    within "#steps table" do
+      expect(page).to have_content("My new title")
+      click_link("My new title")
+    end
+  end
+
+  context "deleting a participatory process step" do
+    let!(:process_step2) { create(:participatory_process_step, participatory_process: participatory_process) }
+
+    before do
+      visit decidim_admin.participatory_process_path(participatory_process)
+    end
+
+    it "deletes a participatory_process_step" do
+      within find("tr", text: translated(process_step2.title)) do
+        click_link "Destroy"
+      end
+
+      within ".flash" do
+        expect(page).to have_content("successfully")
+      end
+
+      within "table" do
+        expect(page).to_not have_content(translated(process_step2.title))
+      end
+    end
+  end
+
+  context "activating a step" do
+    it "activates a step" do
+      within find("tr", text: translated(process_step.title)) do
+        click_link "Activate"
+      end
+
+      within find("tr", text: translated(process_step.title)) do
+        expect(page).to have_content("Deactivate")
+      end
+    end
+  end
+
+  context "deactivating a step" do
+    let(:active) { true }
+
+    it "deactivates a step" do
+      within find("tr", text: translated(process_step.title)) do
+        click_link "Deactivate"
+      end
+
+      within find("tr", text: translated(process_step.title)) do
+        expect(page).to have_content("Activate")
+      end
+    end
+  end
+end

data/decidim-admin/spec/features/manage_participatory_processes_spec.rb

@@ -17,7 +17,14 @@ describe "Manage participatory processes", type: :feature do
   end
   let(:organization) { create(:organization) }
   let(:admin) { create(:user, :admin, :confirmed, organization: organization) }
-  let!(:participatory_process) { create(:process, organization: organization) }
+  let!(:participatory_process) do
+    create(
+      :participatory_process,
+      organization: organization,
+      description: { en: "Description", ca: "Descripció", es: "Descripción" },
+      short_description: { en: "Short description", ca: "Descripció curta", es: "Descripción corta" }
+    )
+  end
 
   before do
     switch_to_host(organization.host)
@@ -31,18 +38,18 @@ describe "Manage participatory processes", type: :feature do
     end
 
     within "dl" do
-      expect(page).to have_content(participatory_process.title["en"])
-      expect(page).to have_content(participatory_process.title["es"])
-      expect(page).to have_content(participatory_process.title["ca"])
-      expect(page).to have_content(participatory_process.subtitle["en"])
-      expect(page).to have_content(participatory_process.subtitle["es"])
-      expect(page).to have_content(participatory_process.subtitle["ca"])
-      expect(page).to have_content(participatory_process.short_description["en"])
-      expect(page).to have_content(participatory_process.short_description["es"])
-      expect(page).to have_content(participatory_process.short_description["ca"])
-      expect(page).to have_content(participatory_process.description["en"])
-      expect(page).to have_content(participatory_process.description["es"])
-      expect(page).to have_content(participatory_process.description["ca"])
+      expect(page).to have_content(translated(participatory_process.title, locale: :en))
+      expect(page).to have_content(translated(participatory_process.title, locale: :es))
+      expect(page).to have_content(translated(participatory_process.title, locale: :ca))
+      expect(page).to have_content(translated(participatory_process.subtitle, locale: :en))
+      expect(page).to have_content(translated(participatory_process.subtitle, locale: :es))
+      expect(page).to have_content(translated(participatory_process.subtitle, locale: :ca))
+      expect(page).to have_content(translated(participatory_process.short_description, locale: :en))
+      expect(page).to have_content(translated(participatory_process.short_description, locale: :es))
+      expect(page).to have_content(translated(participatory_process.short_description, locale: :ca))
+      expect(page).to have_content(translated(participatory_process.description, locale: :en))
+      expect(page).to have_content(translated(participatory_process.description, locale: :es))
+      expect(page).to have_content(translated(participatory_process.description, locale: :ca))
       expect(page).to have_content(participatory_process.hashtag)
       expect(page).to have_content(participatory_process.slug)
       expect(page).to have_xpath("//img[@src=\"#{participatory_process.hero_image.url}\"]")
@@ -90,7 +97,7 @@ describe "Manage participatory processes", type: :feature do
   end
 
   it "updates an participatory_process" do
-    within find("tr", text: participatory_process.title["en"]) do
+    within find("tr", text: translated(participatory_process.title)) do
       click_link "Edit"
     end
 
@@ -119,14 +126,14 @@ describe "Manage participatory processes", type: :feature do
   end
 
   context "deleting a participatory process" do
-    let!(:participatory_process2) { create(:process, organization: organization) }
+    let!(:participatory_process2) { create(:participatory_process, organization: organization) }
 
     before do
       visit decidim_admin.participatory_processes_path
     end
 
     it "deletes a participatory_process" do
-      within find("tr", text: participatory_process2.title["en"]) do
+      within find("tr", text: translated(participatory_process2.title)) do
         click_link "Destroy"
       end
 
@@ -135,44 +142,85 @@ describe "Manage participatory processes", type: :feature do
       end
 
       within "table" do
-        expect(page).to_not have_content(participatory_process2.title)
+        expect(page).to_not have_content(translated(participatory_process2.title))
       end
     end
   end
 
-  context "when there are multiple organizations in the system" do
-    let!(:external_participatory_process) { create(:process) }
+  context "publishing a process" do
+    let!(:participatory_process) { create(:participatory_process, :unpublished, organization: organization) }
 
-    before do
-      visit decidim_admin.participatory_processes_path
+    context "from the index page" do
+      it "publishes the process" do
+        click_link "Publish"
+        expect(page).to have_content("published successfully")
+        expect(page).to have_content("Unpublish")
+        expect(current_path).to eq decidim_admin.participatory_processes_path
+
+        participatory_process.reload
+        expect(participatory_process).to be_published
+      end
     end
 
-    it "doesn't let the admin manage processes form other organizations" do
-      within "table" do
-        expect(page).to_not have_content(external_participatory_process.title)
+    context "from the process page" do
+      before do
+        click_link translated(participatory_process.title)
+      end
+
+      it "publishes the process" do
+        click_link "Publish"
+        expect(page).to have_content("published successfully")
+        expect(page).to have_content("Unpublish")
+        expect(current_path).to eq decidim_admin.participatory_process_path(participatory_process)
+
+        participatory_process.reload
+        expect(participatory_process).to be_published
       end
     end
   end
 
-  context "when the user is not authorized to perform some actions" do
-    let(:policy_double) { double edit?: policy_edit }
-    let(:policy_edit) { true }
+  context "unpublishing a process" do
+    let!(:participatory_process) { create(:participatory_process, organization: organization) }
 
-    before do
-      allow(Decidim::Admin::ParticipatoryProcessPolicy)
-        .to receive(:new)
-        .and_return(policy_double)
+    context "from the index page" do
+      it "unpublishes the process" do
+        click_link "Unpublish"
+        expect(page).to have_content("unpublished successfully")
+        expect(page).to have_content("Publish")
+        expect(current_path).to eq decidim_admin.participatory_processes_path
+
+        participatory_process.reload
+        expect(participatory_process).not_to be_published
+      end
     end
 
-    context "it can't edit a record" do
-      let(:policy_edit) { false }
+    context "from the process page" do
+      before do
+        click_link translated(participatory_process.title)
+      end
+
+      it "unpublishes the process" do
+        click_link "Unpublish"
+        expect(page).to have_content("unpublished successfully")
+        expect(page).to have_content("Publish")
+        expect(current_path).to eq decidim_admin.participatory_process_path(participatory_process)
+
+        participatory_process.reload
+        expect(participatory_process).not_to be_published
+      end
+    end
+  end
+
+  context "when there are multiple organizations in the system" do
+    let!(:external_participatory_process) { create(:participatory_process) }
 
-      context 'when the user tries to manually access to the edition page' do
-        it "is redirected to the root path" do
-          visit decidim_admin.edit_participatory_process_path(participatory_process)
-          expect(page).to have_content("You are not authorized to perform this action")
-          expect(current_path).to eq decidim_admin.root_path
-        end
+    before do
+      visit decidim_admin.participatory_processes_path
+    end
+
+    it "doesn't let the admin manage processes form other organizations" do
+      within "table" do
+        expect(page).to_not have_content(external_participatory_process.title)
       end
     end
   end