decidim-toggle 0.1.3

data/spec/decidim/toggle/settings_tab_registry_spec.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe SettingsTabRegistry do
+      after do
+        described_class.destroy(:test_registry)
+      end
+
+      describe ".register" do
+        it "creates registry and stores configuration blocks" do
+          described_class.register(:test_registry) { |_tabs| nil }
+          described_class.register(:test_registry) { |_tabs| nil }
+          reg = described_class.find(:test_registry)
+          expect(reg.configurations.length).to eq(2)
+        end
+      end
+
+      describe ".find / .create" do
+        it "returns nil when missing" do
+          expect(described_class.find(:missing)).to be_nil
+        end
+
+        it "create stores a new registry" do
+          r = described_class.create(:test_registry)
+          expect(described_class.find(:test_registry)).to eq(r)
+        end
+      end
+
+      describe "#register_form_tab and #form_tab" do
+        it "stores form/command mapping" do
+          reg = described_class.create(:test_registry)
+          reg.register_form_tab(:foo, String, Integer)
+          expect(reg.form_tab(:foo)).to eq(form: String, command: Integer)
+        end
+
+        it "stores module_name for #form_tab_for_module" do
+          reg = described_class.create(:test_registry)
+          reg.register_form_tab(:foo, String, Integer, module_name: :decidim_geo)
+          expect(reg.form_tab_for_module(:decidim_geo)).to eq(
+            form: String,
+            command: Integer,
+            tab_identifier: :foo
+          )
+        end
+
+        it "drops module mapping when the same tab is re-registered without module_name" do
+          reg = described_class.create(:test_registry)
+          reg.register_form_tab(:foo, String, Integer, module_name: :decidim_geo)
+          reg.register_form_tab(:foo, String, Integer)
+          expect(reg.form_tab_for_module(:decidim_geo)).to be_nil
+        end
+
+        it "raises when the same tab id is re-registered with a different form in test" do
+          reg = described_class.create(:test_registry)
+          reg.register_form_tab(:foo, String, Integer)
+          expect do
+            reg.register_form_tab(:foo, Array, Integer)
+          end.to raise_error(Decidim::Toggle::DuplicateTabRegistrationError, /:foo/)
+        end
+      end
+    end
+  end
+end

data/spec/decidim/toggle/settings_tabs_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe SettingsTabs do
+      after do
+        SettingsTabRegistry.destroy(:tabs_spec)
+      end
+
+      it "raises when registry is missing" do
+        expect do
+          described_class.new(:tabs_spec).build_for(Object.new)
+        end.to raise_error(RuntimeError, /not registered/)
+      end
+
+      it "builds items from registered blocks" do
+        SettingsTabRegistry.register(:tabs_spec) do |tabs|
+          tabs.add_tab :one, "One", form: String, command: Integer, position: 1, module_name: :demo_mod
+        end
+
+        ctx = Object.new
+        list = described_class.new(:tabs_spec)
+        list.build_for(ctx)
+        expect(list.items.size).to eq(1)
+        expect(list.items.first.identifier).to eq(:one)
+        expect(list.items.first.module_name).to eq(:demo_mod)
+      end
+
+      it "add_tab supports form_layout_partial" do
+        SettingsTabRegistry.register(:tabs_spec) do |tabs|
+          tabs.add_tab :x,
+                       "X",
+                       form: String,
+                       command: Integer,
+                       form_layout_partial: "decidim/foo/tab",
+                       position: 2
+        end
+
+        list = described_class.new(:tabs_spec)
+        list.build_for(Object.new)
+        expect(list.items.first.form_layout_partial).to eq("decidim/foo/tab")
+        expect(list.items.first.form_tab?).to be(true)
+      end
+
+      it "remove_tab filters items" do
+        SettingsTabRegistry.register(:tabs_spec) do |tabs|
+          tabs.add_tab :a, "A", form: String, command: Integer
+          tabs.add_tab :b, "B", form: String, command: Integer
+          tabs.remove_tab(:a)
+        end
+
+        list = described_class.new(:tabs_spec)
+        list.build_for(Object.new)
+        expect(list.items.map(&:identifier)).to eq([:b])
+      end
+    end
+  end
+end

data/spec/forms/concerns/decidim/toggle/informative_callouts_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe InformativeCallouts do
+      let(:form_class) do
+        Class.new(Decidim::Form) do
+          include InformativeCallouts
+
+          mimic :organization
+
+          info :always_visible_message
+          warning :conditional_message, if_predicate: ->(form) { form.show_warning? }
+
+          def always_visible_message
+            "Always visible"
+          end
+
+          def conditional_message
+            "Conditional"
+          end
+
+          def show_warning?
+            @show_warning
+          end
+
+          attr_writer :show_warning
+        end
+      end
+
+      it "registers informative entries on the form class" do
+        expect(form_class.informative_callouts.map(&:type)).to eq([:info, :warning])
+      end
+
+      it "filters entries with visible_informative_callouts" do
+        form = form_class.from_params({})
+        form.show_warning = false
+
+        expect(form.visible_informative_callouts.map { |entry| entry.message_for(form) }).to eq(["Always visible"])
+
+        form.show_warning = true
+        expect(form.visible_informative_callouts.map { |entry| entry.message_for(form) }).to eq(["Always visible", "Conditional"])
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_authorizations_form_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateAuthorizationsForm do
+      let(:organization) { create(:organization, available_authorizations: []) }
+
+      describe ".from_model" do
+        it "loads workflow names as strings" do
+          org = create(:organization, available_authorizations: %w(dummy_authorization_handler))
+
+          form = described_class.from_model(org)
+
+          expect(form.available_authorizations).to eq(%w(dummy_authorization_handler))
+        end
+      end
+
+      describe ".from_params" do
+        it "defaults missing available_authorizations to an empty array" do
+          form = described_class.from_params(organization: {}).with_context(current_organization: organization)
+
+          expect(form.available_authorizations).to eq([])
+        end
+      end
+
+      describe "validations" do
+        it "rejects authorization names that are not registered workflows" do
+          form = described_class.from_params(
+            organization: { available_authorizations: %w(unknown_handler) }
+          ).with_context(current_organization: organization)
+
+          expect(form).not_to be_valid
+          expect(form.errors[:available_authorizations]).to be_present
+        end
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_emails_form_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateEmailsForm do
+      let(:organization) { create(:organization) }
+
+      it "exposes host and users_registration_mode from the organization" do
+        form = described_class.from_model(organization)
+
+        expect(form.host).to eq(organization.host)
+        expect(form.users_registration_mode).to eq(organization.users_registration_mode)
+      end
+
+      it "extracts host/users_registration_mode from params[:organization]" do
+        organization.update!(host: "current-host.example.org")
+
+        params_host = "params-host.example.org"
+        params = {
+          organization: {
+            host: params_host,
+            users_registration_mode: organization.users_registration_mode
+          }
+        }
+
+        form = described_class.from_params(params).with_context(current_organization: organization)
+
+        expect(form.host).to eq(params_host)
+        expect(form.users_registration_mode).to eq(organization.users_registration_mode)
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_file_upload_settings_form_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateFileUploadSettingsForm do
+      let(:organization) { create(:organization) }
+
+      describe ".from_model" do
+        it "wraps the organization file_upload_settings for editing" do
+          form = described_class.from_model(organization)
+
+          expect(form.file_upload_settings).to be_a(Decidim::System::FileUploadSettingsForm)
+          expect(form.file_upload_settings.maximum_file_size).to be_present
+        end
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_locale_form_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateLocaleForm do
+      let(:organization) { create(:organization) }
+
+      describe ".from_model" do
+        it "normalizes available_locales and default_locale to strings" do
+          org = Struct.new(:available_locales, :default_locale, :enable_machine_translations, :machine_translation_display_priority).new(
+            [:en, :ca, :es], :en, false, "original"
+          )
+
+          form = described_class.from_model(org)
+
+          expect(form.available_locales).to eq(%w(en ca es))
+          expect(form.default_locale).to eq("en")
+        end
+
+        it "loads locales from the Organization record when the source only has id (e.g. system UpdateOrganizationForm)" do
+          org = create(:organization, available_locales: %w(en ca), default_locale: "ca")
+          form_like = Struct.new(:id, :enable_machine_translations, :machine_translation_display_priority).new(
+            org.id, false, "original"
+          )
+
+          form = described_class.from_model(form_like)
+
+          expect(form.available_locales).to eq(%w(en ca))
+          expect(form.default_locale).to eq("ca")
+        end
+      end
+
+      describe ".from_params with hash available_locales" do
+        it "maps checked keys to array" do
+          form = described_class.from_params(
+            organization: { available_locales: { "en" => "1", "ca" => "1" }, default_locale: "en" }
+          ).with_context(current_organization: organization)
+
+          expect(form.available_locales).to include("en", "ca")
+        end
+      end
+
+      describe "validations" do
+        it "rejects default_locale not in available_locales" do
+          form = described_class.from_params(
+            organization: { available_locales: %w(en), default_locale: "ca" }
+          ).with_context(current_organization: organization)
+
+          expect(form).not_to be_valid
+        end
+
+        it "rejects available_locales outside I18n" do
+          form = described_class.from_params(
+            organization: { available_locales: %w(zz), default_locale: "zz" }
+          ).with_context(current_organization: organization)
+
+          expect(form).not_to be_valid
+        end
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_name_form_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateNameForm do
+      let(:organization) { create(:organization) }
+
+      describe ".from_params with name_* keys" do
+        it "maps name_en into nested name hash" do
+          form = described_class.from_params(
+            organization: { "name_en" => "Hello", :host => "x.lvh.me" }
+          ).with_context(current_organization: organization)
+
+          expect(form.name["en"]).to eq("Hello")
+        end
+      end
+
+      describe ".from_model" do
+        it "joins array secondary hosts with newlines" do
+          organization.update!(secondary_hosts: %w(a.example.org b.example.org))
+
+          form = described_class.from_model(organization)
+
+          expect(form.secondary_hosts).to eq("a.example.org\nb.example.org")
+        end
+
+        it "preserves string secondary hosts" do
+          allow(organization).to receive(:secondary_hosts).and_return("legacy.example.org")
+
+          form = described_class.from_model(organization)
+
+          expect(form.secondary_hosts).to eq("legacy.example.org")
+        end
+
+        it "defaults secondary hosts to an empty string for unexpected values" do
+          allow(organization).to receive(:secondary_hosts).and_return(nil)
+
+          form = described_class.from_model(organization)
+
+          expect(form.secondary_hosts).to eq("")
+        end
+      end
+
+      describe "#clean_secondary_hosts" do
+        it "splits lines and drops blanks" do
+          form = described_class.from_params(
+            organization: { host: organization.host, secondary_hosts: "a.com\n\nb.com" }
+          ).with_context(current_organization: organization)
+
+          expect(form.clean_secondary_hosts).to eq(%w(a.com b.com))
+        end
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_omniauth_form_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateOmniauthForm do
+      let(:organization) { create(:organization) }
+
+      it "exposes host and users_registration_mode from the organization" do
+        form = described_class.from_model(organization)
+
+        expect(form.host).to eq(organization.host)
+        expect(form.users_registration_mode).to eq(organization.users_registration_mode)
+      end
+
+      it "builds omniauth encrypted settings from params[:organization]" do
+        provider = Decidim::OmniauthProvider.available.keys.first
+        omniauth_secrets = Rails.application.secrets.dig(:omniauth, provider) || {}
+
+        # Pick the first setting other than :enabled. For `developer` this is typically :icon.
+        setting_key = (omniauth_secrets.keys.map(&:to_sym) - [:enabled]).first
+        skip "No omniauth provider settings found in secrets" if provider.blank? || setting_key.blank?
+
+        params = {
+          organization: {
+            :host => organization.host,
+            :users_registration_mode => organization.users_registration_mode,
+            "omniauth_settings_#{provider}_enabled" => true,
+            "omniauth_settings_#{provider}_#{setting_key}" => "foo-#{setting_key}"
+          }
+        }
+
+        form = described_class.from_params(params).with_context(current_organization: organization)
+
+        expect(form.omniauth_settings).to include(
+          "omniauth_settings_#{provider}_enabled" => true,
+          "omniauth_settings_#{provider}_#{setting_key}" => "foo-#{setting_key}"
+        )
+        expect(form.encrypted_omniauth_settings).to include("omniauth_settings_#{provider}_#{setting_key}")
+      end
+
+      it "registers space page info callout only when decidim-space_page is in the bundle" do
+        form = described_class.from_params({})
+        entries = form.visible_informative_callouts
+
+        if Decidim::Toggle.gem_present?("decidim-space_page")
+          expect(entries.map(&:type)).to eq([:info])
+          expect(entries.first.message_for(form)).to include("decidim space page")
+        else
+          expect(entries).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/forms/decidim/toggle/update_security_form_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe UpdateSecurityForm do
+      let(:organization) { create(:organization) }
+
+      describe "#content_security_policy" do
+        it "compacts blank directive values" do
+          form = described_class.from_model(organization)
+          form.send(:"default-src=", "'self'")
+          form.send(:"img-src=", nil)
+
+          csp = form.content_security_policy
+          expect(csp["default-src"]).to eq("'self'")
+          expect(csp).not_to have_key("img-src")
+        end
+      end
+
+      describe "validations" do
+        it "rejects invalid users_registration_mode" do
+          form = described_class.from_model(organization)
+          form.users_registration_mode = "invalid_mode"
+
+          expect(form).not_to be_valid
+        end
+      end
+    end
+  end
+end

data/spec/helpers/decidim/toggle/system_settings_tab_helper_spec.rb

@@ -0,0 +1,99 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe SystemSettingsTabHelper do
+      describe "#decidim_toggle_update_settings_tab_organization_path" do
+        let(:helper_host) do
+          Class.new do
+            include Decidim::Toggle::SystemSettingsTabHelper
+          end.new
+        end
+
+        it "prefixes engine path with /decidim_toggle once" do
+          org = create(:organization)
+          path = helper_host.decidim_toggle_update_settings_tab_organization_path(org, tab_id: "name")
+          expect(path).to start_with("/decidim_toggle")
+          expect(path).to include("settings_tab")
+          expect(path).not_to include("/decidim_toggle/decidim_toggle")
+        end
+      end
+
+      describe "#decidim_toggle_settings_tab_form" do
+        let(:helper_host) do
+          Class.new do
+            include Decidim::Toggle::SystemSettingsTabHelper
+            include ActionView::Helpers::FormHelper
+            include ActionView::Helpers::FormTagHelper
+            include ActionView::Helpers::OutputSafetyHelper
+            include ActionView::Context
+
+            def flash
+              @flash ||= {}
+            end
+          end.new
+        end
+
+        let(:tab) do
+          SettingsTabItem.new(
+            :security,
+            "Security",
+            form_class: UpdateSecurityForm,
+            command_class: UpdateSecurityCommand
+          )
+        end
+        let(:form) { UpdateSecurityForm.from_params(organization: { host: "example.org", users_registration_mode: "enabled" }) }
+        let(:organization) { instance_double(Decidim::Organization, id: 1) }
+
+        before do
+          allow(UpdateSecurityForm).to receive(:from_model).with(organization).and_return(form)
+          allow(helper_host).to receive(:render).and_return("".html_safe)
+          allow(helper_host).to receive(:decidim_toggle_update_settings_tab_organization_path)
+            .with(organization, tab_id: :security)
+            .and_return("/decidim_toggle/system/organizations/1/settings_tab/security")
+        end
+
+        it "renders form shell markup" do
+          html = helper_host.decidim_toggle_settings_tab_form(organization, tab) { |_tf| "body" }
+          expect(html).to include("settings_tab_form_security")
+          expect(html).to include('action="/decidim_toggle/system/organizations/1/settings_tab/security"')
+        end
+      end
+
+      describe "#encryption_configured?" do
+        let(:helper_host) do
+          Class.new do
+            include Decidim::Toggle::SystemSettingsTabHelper
+          end.new
+        end
+
+        around do |example|
+          Decidim::AttributeEncryptor.remove_instance_variable(:@cryptor) if Decidim::AttributeEncryptor.instance_variable_defined?(:@cryptor)
+          example.run
+          Decidim::AttributeEncryptor.remove_instance_variable(:@cryptor) if Decidim::AttributeEncryptor.instance_variable_defined?(:@cryptor)
+        end
+
+        it "returns true when encryption round-trips" do
+          allow(Rails.application).to receive(:secret_key_base).and_return(SecureRandom.hex(64))
+
+          expect(helper_host.encryption_configured?).to be(true)
+        end
+
+        it "returns false when secret_key_base is missing" do
+          allow(Rails.application).to receive(:secret_key_base).and_return(nil)
+
+          expect(helper_host.encryption_configured?).to be(false)
+        end
+
+        it "returns false when encryption fails" do
+          allow(Rails.application).to receive(:secret_key_base).and_return("too-short")
+          allow(Decidim::AttributeEncryptor).to receive(:encrypt).and_raise(ArgumentError)
+
+          expect(helper_host.encryption_configured?).to be(false)
+        end
+      end
+    end
+  end
+end

data/spec/lib/decidim/toggle/expose_attributes_to_js_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe ExposeAttributesToJs do
+      let(:form_class) do
+        Class.new(Decidim::Form) do
+          include ExposeAttributesToJs
+
+          mimic :organization
+          attribute :enabled, :boolean
+          attribute :search_bar, :boolean
+          attribute :secret, :string
+
+          expose_to_javascript :enabled, :search_bar
+        end
+      end
+
+      it "registers attributes via expose_to_javascript" do
+        expect(form_class.javascript_exposed_attribute_names).to contain_exactly("enabled", "search_bar")
+      end
+
+      it "deduplicates exposed attribute names" do
+        form_class.expose_to_javascript(:enabled)
+        expect(form_class.javascript_exposed_attribute_names).to contain_exactly("enabled", "search_bar")
+      end
+    end
+  end
+end

data/spec/lib/decidim/toggle/expose_attributes_to_js_validator_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe ExposeAttributesToJsValidator do
+      it "warns when an exposed attribute is not declared on the form" do
+        form_class = Class.new(Decidim::Form) do
+          include ExposeAttributesToJs
+
+          mimic :organization
+          attribute :enabled, :boolean
+
+          expose_to_javascript :missing_flag
+        end
+
+        expect(Rails.logger).to receive(:warn).with(
+          /decidim-toggle.*missing_flag/
+        )
+
+        described_class.validate_form!(form_class)
+      end
+
+      it "validates every registered organization settings form without error" do
+        expect { described_class.validate! }.not_to raise_error
+      end
+    end
+  end
+end

data/spec/lib/decidim/toggle/gem_registry_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Toggle
+    describe GemRegistry do
+      describe ".present?" do
+        it "returns true when the gem is in the bundle" do
+          expect(described_class.present?("decidim-core")).to be(true)
+        end
+
+        it "returns false when the gem is not in the bundle" do
+          expect(described_class.present?("decidim-space_page")).to be(false)
+        end
+
+        it "returns false for blank names" do
+          expect(described_class.present?("")).to be(false)
+          expect(described_class.present?(nil)).to be(false)
+        end
+      end
+    end
+
+    describe "Decidim::Toggle.gem_present?" do
+      it "returns true for gems in the bundle" do
+        expect(Decidim::Toggle.gem_present?("decidim-core")).to be(true)
+      end
+    end
+  end
+end