decidim-proposals 0.24.0 → 0.25.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc19261b23f64f8508319ad79afa60c5268b6071d397a024750ffffa9d708676
-  data.tar.gz: e9014329c51b1a0d4611f161dc84e2849c14e02646d92d50aa2e340e08c87c1d
+  metadata.gz: 47fa5c2b39c2888c4cd18246303276f31bc9814aea6f2a95fbeed90801018cd9
+  data.tar.gz: 66b35526e1ba74dd1e4c58e6b81bf5d5785638ade13ac182f040746dabe2e97f
 SHA512:
-  metadata.gz: 866c986caaf10b21ba47b4a7e6a5f63cdaae8aa48277b99d4cbceb3e34a7fdb5b2824ad7a7c66122f32c86fa2d4b439fdf82083beba025b119ec572c94207cb8
-  data.tar.gz: be429c52ecfd6db0ac027291d53d5e8446fd325acaabee3515a4724020bc80a9b5a379e8e918c2b1ad4cd73475812e2388b52a45a80739d82eef3cfa6a4b23a1
+  metadata.gz: 4791d3eac05ea12713c702f479edbe8044aa1aa42eefe84f9def5f66c70e621253341cc3988423b7152ac321bd8bb0c65514eb5a5877a9ff1c944a0f01f34b1e
+  data.tar.gz: 561231c064de2ccd37f32cce1839f64fcba927de4b9f1490145a747d57214788f36010c1a7464e23d20b35af398ccfc897fcaf514ccfb3eff19856d150f2fa8d

data/app/cells/decidim/proposals/cost_report_cell.rb

@@ -14,7 +14,7 @@ module Decidim
       private
 
       def cost
-        number_to_currency(model.cost)
+        number_to_currency(model.cost, unit: Decidim.currency_unit)
       end
 
       def cost_report

data/app/cells/decidim/proposals/proposal_m_cell.rb

@@ -132,14 +132,18 @@ module Decidim
         hash << model.cache_key_with_version
         hash << model.proposal_votes_count
         hash << model.endorsements_count
+        hash << model.comments_count
         hash << Digest::MD5.hexdigest(model.component.cache_key_with_version)
         hash << Digest::MD5.hexdigest(resource_image_path) if resource_image_path
+        hash << render_space? ? 1 : 0
         if current_user
           hash << current_user.cache_key_with_version
           hash << current_user.follows?(model) ? 1 : 0
         end
         hash << model.follows_count
         hash << Digest::MD5.hexdigest(model.authors.map(&:cache_key_with_version).to_s)
+        hash << (model.must_render_translation?(model.organization) ? 1 : 0) if model.respond_to?(:must_render_translation?)
+        hash << model.component.participatory_space.active_step.id if model.component.participatory_space.has_steps?
 
         hash.join("/")
       end

data/app/cells/decidim/proposals/proposals_picker/show.erb

@@ -11,4 +11,4 @@
   </div>
 </div>
 
-<%= javascript_include_tag "decidim/proposals/admin/proposals_picker" %>
+<%= javascript_pack_tag "decidim_proposals_admin" %>

data/app/cells/decidim/proposals/proposals_picker_cell.rb

@@ -50,7 +50,7 @@ module Decidim
 
       def filtered_proposals
         @filtered_proposals ||= if filtered?
-                                  proposals.where("title ILIKE ?", "%#{search_text}%")
+                                  proposals.where("title::text ILIKE ?", "%#{search_text}%")
                                            .or(proposals.where("reference ILIKE ?", "%#{search_text}%"))
                                            .or(proposals.where("id::text ILIKE ?", "%#{search_text}%"))
                                 else

data/app/commands/decidim/proposals/admin/import_proposals.rb

@@ -39,15 +39,17 @@ module Decidim
               action_user: form.current_user,
               extra_attributes: {
                 "component" => target_component
-              }
+              }.merge(proposal_answer_attributes(original_proposal))
             )
           end.compact
         end
 
         def proposals
-          Decidim::Proposals::Proposal
-            .where(component: origin_component)
-            .where(state: proposal_states)
+          @proposals = Decidim::Proposals::Proposal
+                       .where(component: origin_component)
+                       .where(state: proposal_states)
+          @proposals = @proposals.where(scope: proposal_scopes) unless proposal_scopes.empty?
+          @proposals
         end
 
         def proposal_states
@@ -61,6 +63,10 @@ module Decidim
           @proposal_states
         end
 
+        def proposal_scopes
+          @form.scopes
+        end
+
         def origin_component
           @form.origin_component
         end
@@ -78,6 +84,17 @@ module Decidim
         def proposal_author
           form.keep_authors ? nil : @form.current_organization
         end
+
+        def proposal_answer_attributes(original_proposal)
+          return {} unless form.keep_answers
+
+          {
+            answer: original_proposal.answer,
+            answered_at: original_proposal.answered_at,
+            state: original_proposal.state,
+            state_published_at: original_proposal.state_published_at
+          }
+        end
       end
     end
   end

data/app/controllers/decidim/proposals/admin/proposals_controller.rb

@@ -147,7 +147,7 @@ module Decidim
         private
 
         def collection
-          @collection ||= Proposal.where(component: current_component).published
+          @collection ||= Proposal.where(component: current_component).not_hidden.published
         end
 
         def proposals

data/app/controllers/decidim/proposals/collaborative_drafts_controller.rb

@@ -7,6 +7,7 @@ module Decidim
       helper Decidim::WidgetUrlsHelper
       helper ProposalWizardHelper
       helper TooltipHelper
+      helper UserGroupHelper
 
       include Decidim::ApplicationHelper
       include FormFactory
@@ -133,7 +134,7 @@ module Decidim
       end
 
       def geocoded_collaborative_draft
-        @geocoded_collaborative_draft ||= search.results.not_hidden.select(&:geocoded?)
+        @geocoded_collaborative_draft ||= search.results.not_hidden.select(&:geocoded_and_valid?)
       end
 
       def search_klass

data/app/controllers/decidim/proposals/proposals_controller.rb

@@ -7,6 +7,7 @@ module Decidim
       helper Decidim::WidgetUrlsHelper
       helper ProposalWizardHelper
       helper ParticipatoryTextsHelper
+      helper UserGroupHelper
       include Decidim::ApplicationHelper
       include Flaggable
       include Withdrawable

data/app/forms/decidim/proposals/admin/import_participatory_text_form.rb

@@ -7,6 +7,7 @@ module Decidim
       # from a participatory text.
       class ImportParticipatoryTextForm < Decidim::Form
         include TranslatableAttributes
+        include Decidim::HasUploadValidations
 
         # WARNING: consider adding/removing the relative translation key at
         # decidim.assemblies.admin.new_import.accepted_types when modifying this hash

data/app/forms/decidim/proposals/admin/proposals_import_form.rb

@@ -10,8 +10,10 @@ module Decidim
 
         attribute :origin_component_id, Integer
         attribute :import_proposals, Boolean
+        attribute :keep_answers, Boolean
         attribute :keep_authors, Boolean
         attribute :states, Array
+        attribute :scope_ids, Array
 
         validates :origin_component_id, :origin_component, :states, :current_component, presence: true
         validates :import_proposals, allow_nil: false, acceptance: true
@@ -32,6 +34,10 @@ module Decidim
           super.reject(&:blank?)
         end
 
+        def scopes
+          Decidim::Scope.where(organization: current_organization, id: scope_ids)
+        end
+
         def origin_component
           @origin_component ||= origin_components.find_by(id: origin_component_id)
         end

data/app/forms/decidim/proposals/proposal_form.rb

@@ -107,12 +107,15 @@ module Decidim
 
       private
 
-      # This method will add an error to the `attachment` field only if there's
-      # any error in any other field. This is needed because when the form has
-      # an error, the attachment is lost, so we need a way to inform the user of
+      # This method will add an error to the `add_photos` and/or "add_documents" fields
+      # only if there's any error in any other field. This is needed because when the
+      # form has an error, the attachment is lost, so we need a way to inform the user of
       # this problem.
       def notify_missing_attachment_if_errored
-        errors.add(:attachment, :needs_to_be_reattached) if errors.any? && attachment.present?
+        if errors.any?
+          errors.add(:add_photos, :needs_to_be_reattached) if add_photos.present?
+          errors.add(:add_documents, :needs_to_be_reattached) if add_documents.present?
+        end
       end
 
       def ordered_hashtag_list(string)

data/app/helpers/decidim/proposals/map_helper.rb

@@ -26,16 +26,16 @@ module Decidim
       end
 
       def proposal_preview_data_for_map(proposal)
-        [
-          proposal.slice(
+        {
+          type: "drag-marker",
+          marker: proposal.slice(
             :latitude,
             :longitude,
             :address
           ).merge(
-            icon: icon("proposals", width: 40, height: 70, remove_icon_class: true),
-            draggable: true
+            icon: icon("proposals", width: 40, height: 70, remove_icon_class: true)
           )
-        ]
+        }
       end
 
       def has_position?(proposal)

data/app/helpers/decidim/proposals/participatory_texts_helper.rb

@@ -30,7 +30,7 @@ module Decidim
         accepted_mime_types = Decidim::Proposals::DocToMarkdown::ACCEPTED_MIME_TYPES.keys
         accepted_mime_types.each_with_index do |mime_type, index|
           links += link_to t(".accepted_mime_types.#{mime_type}"),
-                           asset_path("decidim/proposals/participatory_texts/participatory_text.#{mime_type}"),
+                           asset_pack_path("media/documents/participatory_text.#{mime_type}"),
                            download: "participatory_text.#{mime_type}"
           links += ", " unless accepted_mime_types.length == index + 1
         end

data/app/helpers/decidim/proposals/proposal_wizard_helper.rb

@@ -107,22 +107,6 @@ module Decidim
         translated_attribute(component_settings.try("proposal_wizard_#{step}_help_text")).present?
       end
 
-      # Renders a user_group select field in a form.
-      # form - FormBuilder object
-      # name - attribute user_group_id
-      #
-      # Returns nothing.
-      def user_group_select_field(form, name)
-        selected = @form.user_group_id.presence
-        user_groups = Decidim::UserGroups::ManageableUserGroups.for(current_user).verified
-        form.select(
-          name,
-          user_groups.map { |g| [g.name, g.id] },
-          selected: selected,
-          include_blank: current_user.name
-        )
-      end
-
       private
 
       def total_steps

data/app/models/decidim/proposals/proposal.rb

@@ -337,8 +337,18 @@ module Decidim
         ")
       end
 
+      def self.sort_by_translated_title_asc
+        field = Arel::Nodes::InfixOperation.new("->>", arel_table[:title], Arel::Nodes.build_quoted(I18n.locale))
+        order(Arel::Nodes::InfixOperation.new("", field, Arel.sql("ASC")))
+      end
+
+      def self.sort_by_translated_title_desc
+        field = Arel::Nodes::InfixOperation.new("->>", arel_table[:title], Arel::Nodes.build_quoted(I18n.locale))
+        order(Arel::Nodes::InfixOperation.new("", field, Arel.sql("DESC")))
+      end
+
       ransacker :title do
-        Arel.sql(%{("decidim_proposals_proposals"."title")::text})
+        Arel.sql(%{cast("decidim_proposals_proposals"."title" as text)})
       end
 
       ransacker :id_string do

data/app/packs/entrypoints/decidim_proposals.js

@@ -0,0 +1,8 @@
+import "src/decidim/proposals/utils"
+import "src/decidim/proposals/add_proposal"
+
+// Images
+require.context("../images", true)
+
+// Documents
+require.context("../documents", true)

data/app/packs/entrypoints/decidim_proposals_admin.js

@@ -0,0 +1,3 @@
+import "src/decidim/proposals/admin/proposals"
+import "src/decidim/proposals/admin/proposals_form"
+import "src/decidim/proposals/admin/proposals_picker"

data/app/packs/src/decidim/proposals/add_proposal.js

@@ -0,0 +1,49 @@
+import attachGeocoding from "src/decidim/geocoding/attach_input"
+import getCoordinateInputName from "src/decidim/geocoding/coordinate_input";
+
+$(() => {
+  const $checkbox = $("input:checkbox[name$='[has_address]']");
+  const $addressInput = $("#address_input");
+  const $addressInputField = $("input", $addressInput);
+  const $map = $("#address_map");
+  const latFieldName = getCoordinateInputName("latitude", $addressInputField, {})
+  const longFieldName = getCoordinateInputName("longitude", $addressInputField, {})
+  $map.hide();
+
+  if ($checkbox.length > 0) {
+    const toggleInput = () => {
+      if ($checkbox[0].checked) {
+        $addressInput.show();
+        $addressInputField.prop("disabled", false);
+      } else {
+        $addressInput.hide();
+        $addressInputField.prop("disabled", true);
+      }
+    }
+    toggleInput();
+    $checkbox.on("change", toggleInput);
+  }
+
+  if ($addressInput.length > 0) {
+    if ($checkbox[0].checked) {
+      $map.show();
+    }
+
+    const ctrl = $("[data-decidim-map]").data("map-controller");
+    ctrl.setEventHandler("coordinates", (ev) => {
+      $(`input[name='${latFieldName}']`).val(ev.lat);
+      $(`input[name='${longFieldName}']`).val(ev.lng);
+    });
+
+    attachGeocoding($addressInputField, null, (coordinates) => {
+      $map.show();
+      // Remove previous marker when user updates address in address field
+      ctrl.removeMarker();
+      ctrl.addMarker({
+        latitude: coordinates[0],
+        longitude: coordinates[1],
+        address: $addressInput.val()
+      });
+    });
+  }
+});

data/app/packs/src/decidim/proposals/admin/proposals.js

@@ -0,0 +1,143 @@
+/* eslint-disable no-invalid-this */
+/* eslint no-unused-vars: 0 */
+/* eslint id-length: ["error", { "exceptions": ["e"] }] */
+
+$(() => {
+  const selectedProposalsCount = function() {
+    return $(".table-list .js-check-all-proposal:checked").length
+  }
+
+  const selectedProposalsNotPublishedAnswerCount = function() {
+    return $(".table-list [data-published-state=false] .js-check-all-proposal:checked").length
+  }
+
+  const selectedProposalsCountUpdate = function() {
+    const selectedProposals = selectedProposalsCount();
+    const selectedProposalsNotPublishedAnswer = selectedProposalsNotPublishedAnswerCount();
+    if (selectedProposals === 0) {
+      $("#js-selected-proposals-count").text("")
+    } else {
+      $("#js-selected-proposals-count").text(selectedProposals);
+    }
+
+    if (selectedProposals >= 2) {
+      $('button[data-action="merge-proposals"]').parent().show();
+    } else {
+      $('button[data-action="merge-proposals"]').parent().hide();
+    }
+
+    if (selectedProposalsNotPublishedAnswer > 0) {
+      $('button[data-action="publish-answers"]').parent().show();
+      $("#js-form-publish-answers-number").text(selectedProposalsNotPublishedAnswer);
+    } else {
+      $('button[data-action="publish-answers"]').parent().hide();
+    }
+  }
+
+  const showBulkActionsButton = function() {
+    if (selectedProposalsCount() > 0) {
+      $("#js-bulk-actions-button").removeClass("hide");
+    }
+  }
+
+  const hideBulkActionsButton = function(force = false) {
+    if (selectedProposalsCount() === 0 || force === true) {
+      $("#js-bulk-actions-button").addClass("hide");
+      $("#js-bulk-actions-dropdown").removeClass("is-open");
+    }
+  }
+
+  const showOtherActionsButtons = function() {
+    $("#js-other-actions-wrapper").removeClass("hide");
+  }
+
+  const hideOtherActionsButtons = function() {
+    $("#js-other-actions-wrapper").addClass("hide");
+  }
+
+  const hideBulkActionForms = function() {
+    $(".js-bulk-action-form").addClass("hide");
+  }
+
+  // Expose functions to make them avaialble in .js.erb templates
+  window.selectedProposalsCount = selectedProposalsCount;
+  window.selectedProposalsNotPublishedAnswerCount = selectedProposalsNotPublishedAnswerCount;
+  window.selectedProposalsCountUpdate = selectedProposalsCountUpdate;
+  window.showBulkActionsButton = showBulkActionsButton;
+  window.hideBulkActionsButton = hideBulkActionsButton;
+  window.showOtherActionsButtons = showOtherActionsButtons;
+  window.hideOtherActionsButtons = hideOtherActionsButtons;
+  window.hideBulkActionForms = hideBulkActionForms;
+
+  if ($(".js-bulk-action-form").length) {
+    hideBulkActionForms();
+    $("#js-bulk-actions-button").addClass("hide");
+
+    $("#js-bulk-actions-dropdown ul li button").click(function(e) {
+      e.preventDefault();
+      let action = $(e.target).data("action");
+
+      if (action) {
+        $(`#js-form-${action}`).submit(function() {
+          $(".layout-content > .callout-wrapper").html("");
+        })
+
+        $(`#js-${action}-actions`).removeClass("hide");
+        hideBulkActionsButton(true);
+        hideOtherActionsButtons();
+      }
+    })
+
+    // select all checkboxes
+    $(".js-check-all").change(function() {
+      $(".js-check-all-proposal").prop("checked", $(this).prop("checked"));
+
+      if ($(this).prop("checked")) {
+        $(".js-check-all-proposal").closest("tr").addClass("selected");
+        showBulkActionsButton();
+      } else {
+        $(".js-check-all-proposal").closest("tr").removeClass("selected");
+        hideBulkActionsButton();
+      }
+
+      selectedProposalsCountUpdate();
+    });
+
+    // proposal checkbox change
+    $(".table-list").on("change", ".js-check-all-proposal", function (e) {
+      let proposalId = $(this).val()
+      let checked = $(this).prop("checked")
+
+      // uncheck "select all", if one of the listed checkbox item is unchecked
+      if ($(this).prop("checked") === false) {
+        $(".js-check-all").prop("checked", false);
+      }
+      // check "select all" if all checkbox proposals are checked
+      if ($(".js-check-all-proposal:checked").length === $(".js-check-all-proposal").length) {
+        $(".js-check-all").prop("checked", true);
+        showBulkActionsButton();
+      }
+
+      if ($(this).prop("checked")) {
+        showBulkActionsButton();
+        $(this).closest("tr").addClass("selected");
+      } else {
+        hideBulkActionsButton();
+        $(this).closest("tr").removeClass("selected");
+      }
+
+      if ($(".js-check-all-proposal:checked").length === 0) {
+        hideBulkActionsButton();
+      }
+
+      $(".js-bulk-action-form").find(`.js-proposal-id-${proposalId}`).prop("checked", checked);
+      selectedProposalsCountUpdate();
+    });
+
+    $(".js-cancel-bulk-action").on("click", function (e) {
+      hideBulkActionForms()
+      showBulkActionsButton();
+      showOtherActionsButtons();
+    });
+  }
+});