decidim-initiatives 0.11.2 → 0.12.0.pre

data/app/permissions/decidim/initiatives/permissions.rb

@@ -0,0 +1,139 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    class Permissions < Decidim::DefaultPermissions
+      def permissions
+        if read_admin_dashboard_action?
+          user_can_read_admin_dashboard?
+          return permission_action
+        end
+
+        # Delegate the admin permission checks to the admin permissions class
+        return Decidim::Initiatives::Admin::Permissions.new(user, permission_action, context).permissions if permission_action.scope == :admin
+        return permission_action if permission_action.scope != :public
+
+        # Non-logged users permissions
+        list_public_initiatives?
+        read_public_initiative?
+        search_initiative_types_and_scopes?
+
+        return permission_action unless user
+
+        create_initiative?
+        request_membership?
+
+        vote_initiative?
+        unvote_initiative?
+
+        permission_action
+      end
+
+      private
+
+      def initiative
+        @initiative ||= context.fetch(:initiative, nil) || context.fetch(:current_participatory_space, nil)
+      end
+
+      def list_public_initiatives?
+        allow! if permission_action.subject == :initiative &&
+                  permission_action.action == :list
+      end
+
+      def read_public_initiative?
+        return unless [:initiative, :participatory_space].include?(permission_action.subject) &&
+                      permission_action.action == :read
+
+        return allow! if initiative.published? || initiative.rejected? || initiative.accepted?
+        return allow! if user && (initiative.has_authorship?(user) || user.admin?)
+        disallow!
+      end
+
+      def search_initiative_types_and_scopes?
+        return unless permission_action.action == :search
+        return unless [:initiative_type, :initiative_type_scope].include?(permission_action.subject)
+
+        allow!
+      end
+
+      def create_initiative?
+        return unless permission_action.subject == :initiative &&
+                      permission_action.action == :create
+
+        toggle_allow(creation_enabled?)
+      end
+
+      def creation_enabled?
+        Decidim::Initiatives.creation_enabled && (
+          Decidim::Initiatives.do_not_require_authorization ||
+            UserAuthorizations.for(user).any? ||
+            user.user_groups.verified.any?
+        )
+      end
+
+      def request_membership?
+        return unless permission_action.subject == :initiative &&
+                      permission_action.action == :request_membership
+
+        can_request = !initiative.published? &&
+                      !initiative.has_authorship?(user) &&
+                      (
+                        Decidim::Initiatives.do_not_require_authorization ||
+                        UserAuthorizations.for(user).any? ||
+                        user.user_groups.verified.any?
+                      )
+
+        toggle_allow(can_request)
+      end
+
+      def has_initiatives?
+        (InitiativesCreated.by(user) | InitiativesPromoted.by(user)).any?
+      end
+
+      def read_admin_dashboard_action?
+        permission_action.action == :read &&
+          permission_action.subject == :admin_dashboard
+      end
+
+      def user_can_read_admin_dashboard?
+        return unless user
+        allow! if has_initiatives?
+      end
+
+      def vote_initiative?
+        return unless permission_action.action == :vote &&
+                      permission_action.subject == :initiative
+
+        can_vote = initiative.votes_enabled? &&
+                   initiative.organization&.id == user.organization&.id &&
+                   initiative.votes.where(decidim_author_id: user.id, decidim_user_group_id: decidim_user_group_id).empty? &&
+                   (can_user_support?(initiative) || user.user_groups.verified.any?)
+
+        toggle_allow(can_vote)
+      end
+
+      def unvote_initiative?
+        return unless permission_action.action == :unvote &&
+                      permission_action.subject == :initiative
+
+        can_unvote = initiative.votes_enabled? &&
+                     initiative.organization&.id == user.organization&.id &&
+                     initiative.votes.where(decidim_author_id: user.id, decidim_user_group_id: decidim_user_group_id).any? &&
+                     (can_user_support?(initiative) || user.user_groups.verified.any?)
+
+        toggle_allow(can_unvote)
+      end
+
+      def decidim_user_group_id
+        context.fetch(:group_id, nil)
+      end
+
+      def can_user_support?(initiative)
+        !initiative.offline? && (
+          Decidim::Initiatives.do_not_require_authorization ||
+          UserAuthorizations.for(user).any?
+        )
+      end
+    end
+  end
+end

data/app/presenters/decidim/initiative_presenter.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Decidim
+  #
+  # Decorator for initiatives
+  #
+  class InitiativePresenter < SimpleDelegator
+    def author
+      @author ||= if user_group
+                    Decidim::UserGroupPresenter.new(user_group)
+                  else
+                    Decidim::UserPresenter.new(super)
+                  end
+    end
+  end
+end

data/app/views/decidim/initiatives/_initiative.html.erb

@@ -1,35 +1 @@
-<div class="column">
-  <article class="card card--initiative">
-    <div class="card__content">
-      <div class="card__header">
-        <%= link_to initiative do %>
-          <h5 class="card__title"><%= translated_attribute initiative.title %></h5>
-        <% end %>
-        <%= render partial: "decidim/initiatives/initiatives/author", locals: { initiative: initiative } %>
-      </div>
-      <%= render partial: "decidim/initiatives/initiatives/initiative_badge", locals: { initiative: initiative } %>
-      <%= simple_format Truncato.truncate(translated_attribute(initiative.description), max_length: 100, separator: "...") %>
-      <%= render partial: "decidim/initiatives/initiatives/tags", locals: { resource: initiative } %>
-    </div>
-
-    <div class="card__footer">
-      <div class="card__support">
-        <% if initiative.published? %>
-          <%= render partial: "decidim/initiatives/initiatives/supports_count", locals: { initiative: initiative } %>
-        <% else %>
-          <div class="card__support__data"></div>
-        <% end %>
-
-        <% if initiative.closed? || initiative.offline? %>
-          <%= link_to t("initiatives.initiative.check", scope: "layouts.decidim"),
-                      initiative,
-                      class: "card__button button small secondary" %>
-        <% else %>
-          <%= link_to t("initiatives.initiative.check_and_support", scope: "layouts.decidim"),
-                      initiative,
-                      class: "card__button button small secondary" %>
-        <% end %>
-      </div>
-    </div>
-  </article>
-</div>
+<%= card_for initiative %>

data/app/views/decidim/initiatives/admin/committee_requests/index.html.erb

@@ -39,14 +39,14 @@
                 <%= link_to request.user.name, "mailto:#{request.user.email}" %>
               </td>
               <td class="table-list__actions">
-                <% if can? :approve, request %>
+                <% if allowed_to? :approve, :initiative_committee_member, request: request %>
                   <%= icon_link_to "check",
                                    approve_initiative_committee_request_path(current_initiative, request),
                                    t(".approve"),
                                    class: "action-icon--check" %>
                 <% end %>
 
-                <% if can? :revoke, request %>
+                <% if allowed_to? :revoke, :initiative_committee_member, request: request %>
                   <%= icon_link_to "circle-x",
                                    revoke_initiative_committee_request_path(current_initiative, request),
                                    t(".revoke"),
@@ -64,4 +64,3 @@
 </div>
 
 <%= javascript_include_tag "decidim/initiatives/admin/invite_users.js" %>
-<%= stylesheet_link_tag "decidim/initiatives/application.css" %>

data/app/views/decidim/initiatives/admin/initiatives/_form.html.erb

@@ -5,11 +5,11 @@
 
   <div class="card-section">
     <div class="row column">
-      <%= form.translated :text_field, :title, autofocus: true, disabled: cannot?(:update, current_initiative) %>
+      <%= form.translated :text_field, :title, autofocus: true, disabled: !allowed_to?(:update, :initiative, initiative: current_initiative) %>
     </div>
 
     <div class="row column">
-      <%= form.translated :editor, :description, toolbar: :full, lines: 8, disabled: cannot?(:update, current_initiative) %>
+      <%= form.translated :editor, :description, toolbar: :full, lines: 8, disabled: !allowed_to?(:update, :initiative, initiative: current_initiative) %>
     </div>
 
     <div class="row">
@@ -44,7 +44,7 @@
 
     <div class="row">
       <div class="columns xlarge-6">
-        <%= form.text_field :hashtag, disabled: cannot?(:update, current_initiative) %>
+        <%= form.text_field :hashtag, disabled: !allowed_to?(:update, :initiative, initiative: current_initiative) %>
       </div>
 
       <div class="columns xlarge-6">

data/app/views/decidim/initiatives/admin/initiatives/edit.html.erb

@@ -1,9 +1,9 @@
 <%= decidim_form_for @form, html: { class: "form edit_initiative" } do |f| %>
   <%= render partial: "form", object: f %>
   <div class="button--double form-general-submit">
-    <%= f.submit t(".update"), class: "button" if can? :update, current_initiative %>
+    <%= f.submit t(".update"), class: "button" if allowed_to? :update, :initiative, initiative: current_initiative %>
 
-    <% if can? :send_to_technical_validation, current_initiative %>
+    <% if allowed_to? :send_to_technical_validation, :initiative, initiative: current_initiative %>
       <%= link_to t(".send_to_technical_validation"),
                   send_to_technical_validation_initiative_path(current_initiative),
                   class: "button muted",
@@ -12,7 +12,7 @@
       <%= link_to t(".send_to_technical_validation"), "#", class: "button muted disabled" if current_initiative.created? %>
     <% end %>
 
-    <% if can? :publish, current_initiative %>
+    <% if allowed_to? :publish, :initiative, initiative: current_initiative %>
       <%= link_to t("actions.publish", scope: "decidim.admin"),
                   publish_initiative_path(current_initiative),
                   method: :post,
@@ -20,7 +20,7 @@
                   data: { confirm: t(".confirm") } %>
     <% end %>
 
-    <% if can? :unpublish, current_initiative %>
+    <% if allowed_to? :unpublish, :initiative, initiative: current_initiative %>
       <%= link_to t("actions.unpublish", scope: "decidim.admin"),
                   unpublish_initiative_path(current_initiative),
                   method: :delete,
@@ -28,7 +28,7 @@
                   data: { confirm: t(".confirm") } %>
     <% end %>
 
-    <% if can? :accept, current_initiative %>
+    <% if allowed_to? :accept, :initiative, initiative: current_initiative %>
         <%= link_to t(".accept"),
                     accept_initiative_path(current_initiative),
                     method: :post,
@@ -36,7 +36,7 @@
                     data: { confirm: t(".confirm") } %>
     <% end %>
 
-    <% if can? :reject, current_initiative %>
+    <% if allowed_to? :reject, :initiative, initiative: current_initiative %>
         <%= link_to t(".reject"),
                     reject_initiative_path(current_initiative),
                     method: :delete,
@@ -44,7 +44,7 @@
                     data: { confirm: t(".confirm") } %>
     <% end %>
 
-    <% if can? :discard, current_initiative %>
+    <% if allowed_to? :discard, :initiative, initiative: current_initiative %>
       <%= link_to t(".discard"),
                   discard_initiative_path(current_initiative),
                   method: :delete,
@@ -52,7 +52,7 @@
                   data: { confirm: t(".confirm") } %>
     <% end %>
 
-    <% if can? :export_votes, current_initiative %>
+    <% if allowed_to? :export_votes, :initiative, initiative: current_initiative %>
       <%= link_to t(".export_votes"),
                   export_votes_initiative_path(current_initiative, format: :csv),
                   class: "button alert",

data/app/views/decidim/initiatives/admin/initiatives/index.html.erb

@@ -61,7 +61,7 @@
           <% @initiatives.each do |initiative| %>
           <tr>
             <td>
-              <% if can? :edit, initiative %>
+              <% if allowed_to? :edit, :initiative, initiative: initiative %>
                 <%= link_to translated_attribute(initiative.title),
                             decidim_admin_initiatives.edit_initiative_path(initiative.to_param) %>
               <% else %>
@@ -72,7 +72,7 @@
             <td><%= initiative.supports_count %>/<%= initiative.scoped_type.supports_required %></td>
             <td><%= l initiative.created_at, format: :short %></td>
             <td class="table-list__actions">
-              <% if can? :preview, initiative %>
+              <% if allowed_to? :preview, :initiative, initiative: initiative %>
                 <%= icon_link_to "eye",
                                  decidim_initiatives.initiative_path(initiative.to_param),
                                  t(".preview"),
@@ -80,14 +80,14 @@
                                  target: "_blank" %>
               <% end %>
 
-              <% if can? :edit, initiative %>
+              <% if allowed_to? :edit, :initiative, initiative: initiative %>
                 <%= icon_link_to "pencil",
                                  decidim_admin_initiatives.edit_initiative_path(initiative.to_param),
                                  t("actions.configure", scope: "decidim.admin"),
                                  class: "action-icon--edit" %>
               <% end %>
 
-              <% if can? :read, initiative %>
+              <% if allowed_to? :read, :initiative, initiative: initiative %>
                 <%= icon_link_to "print",
                                  decidim_admin_initiatives.initiative_path(initiative.to_param),
                                  t(".print",),

data/app/views/decidim/initiatives/admin/initiatives_type_scopes/edit.html.erb

@@ -9,7 +9,7 @@
   <div class="button--double form-general-submit">
     <%= f.submit t(".update"), class: "button" %>
 
-    <% if can? :destroy, current_initiative_type_scope %>
+    <% if allowed_to? :destroy, :initiative_type_scope, initiative_type_scope: current_initiative_type_scope %>
         <%= link_to t(".destroy"), initiatives_type_initiatives_type_scope_path(params[:initiatives_type_id], current_initiative_type_scope),
                     method: :delete,
                     class: "alert button",

data/app/views/decidim/initiatives/admin/initiatives_types/_form.html.erb

@@ -20,5 +20,3 @@
 
   </div>
 </div>
-
-<%= stylesheet_link_tag "decidim/initiatives/application" %>

data/app/views/decidim/initiatives/admin/initiatives_types/_initiative_type_scopes.html.erb

@@ -4,7 +4,7 @@
       <%= t ".title" %>
       <%= link_to t("actions.new", scope: "decidim.admin", name: t("models.initiatives_type_scope.name", scope: "decidim.admin")),
                   new_initiatives_type_initiatives_type_scope_path(initiative_type),
-                  class: "button tiny button--title" if can? :create, Decidim::InitiativesTypeScope %>
+                  class: "button tiny button--title" if allowed_to? :create, :initiative_type_scope %>
     </h2>
   </div>
   <div class="row column">
@@ -28,7 +28,7 @@
               <%= icon_link_to "pencil",
                                decidim_admin_initiatives.edit_initiatives_type_initiatives_type_scope_path(initiative_type, s),
                                t("actions.configure", scope: "decidim.admin"),
-                               class: "action-icon--new" if can? :edit, s %>
+                               class: "action-icon--new" if allowed_to? :edit, :initiative_type_scope, initiative_type_scope: s %>
             </td>
           </tr>
         <% end %>

data/app/views/decidim/initiatives/admin/initiatives_types/edit.html.erb

@@ -3,7 +3,7 @@
   <div class="button--double form-general-submit">
     <%= f.submit t(".update"), class: "button" %>
 
-    <% if can? :destroy, current_initiative_type %>
+    <% if allowed_to? :destroy, :initiative_type, initiative_type: current_initiative_type %>
       <%= link_to t(".destroy"), current_initiative_type,
                   method: :delete,
                   class: "alert button",

data/app/views/decidim/initiatives/admin/initiatives_types/index.html.erb

@@ -4,7 +4,7 @@
       <%= t "decidim.admin.titles.initiatives_types" %>
       <%= link_to t("actions.new", scope: "decidim.admin", name: t("models.initiatives_types.name", scope: "decidim.admin")),
                   ["new", "initiatives_type"],
-                  class: "button tiny button--title" if can? :create, Decidim::InitiativesType %>
+                  class: "button tiny button--title" if allowed_to? :create, :initiative_type %>
     </h2>
   </div>
   <div class="card-section">
@@ -20,7 +20,7 @@
           <% @initiatives_types.each do |initiative_type| %>
           <tr>
             <td>
-              <% if can? :update, initiative_type %>
+              <% if allowed_to? :update, :initiative_type, initiative_type: initiative_type %>
                 <%= link_to translated_attribute(initiative_type.title), edit_initiatives_type_path(initiative_type) %>
               <% else %>
                 <%= translated_attribute initiative_type.title %></td>

data/app/views/decidim/initiatives/committee_requests/new.html.erb

@@ -27,11 +27,9 @@
                   spawn_initiative_committee_requests_path(current_initiative),
                   class: "title-action__action button small hollow" if current_user %>
 
-      <%= action_authorized_link_to :spawn,
-                                    t(".continue"),
-                                    spawn_initiative_committee_requests_path(current_initiative),
-                                    class: "title-action__action button small hollow" unless current_user %>
+      <%= link_to t(".continue"),
+                  spawn_initiative_committee_requests_path(current_initiative),
+                  class: "title-action__action button small hollow" unless current_user %>
     </div>
   </div>
 </div>
-<%= stylesheet_link_tag "decidim/initiatives/application" %>

data/app/views/decidim/initiatives/initiatives/_index_header.html.erb

@@ -2,8 +2,8 @@
   <h2 id="initiatives-count" class="title-action__title section-heading">
     <%= render partial: "count" %>
   </h2>
-  <% if can? :create, Decidim::Initiative %>
-    <%= action_authorized_link_to :create, create_initiative_path(:select_initiative_type), class: "title-action__action button small hollow" do %>
+  <% if allowed_to? :create, :initiative %>
+    <%= link_to create_initiative_path(:select_initiative_type), class: "title-action__action button small hollow" do %>
         <%= t(".new_initiative") %>
         <%= icon "plus" %>
     <% end %>

data/app/views/decidim/initiatives/initiatives/_vote_button.html.erb

@@ -1,18 +1,20 @@
-<% if can? :vote, initiative %>
-    <%= action_authorized_button_to :vote,
-                                    vote_label,
-                                    initiative_initiative_vote_path(initiative_slug: initiative.slug),
-                                    remote: true,
-                                    data: { disable: true },
-                                    class: "card__button button expanded button--sc" %>
+<% if allowed_to? :vote, :initiative, initiative: initiative %>
+  <%= button_to(
+    vote_label,
+    initiative_initiative_vote_path(initiative_slug: current_initiative.slug),
+    remote: true,
+    data: { disable: true },
+    class: "card__button button expanded button--sc"
+  ) %>
 <% end %>
 
-<% if can? :unvote, initiative %>
-    <%= action_authorized_button_to :vote,
-                                    unvote_label,
-                                    initiative_initiative_vote_path(initiative_slug: initiative.slug),
-                                    method: :delete,
-                                    remote: true,
-                                    data: { disable: true },
-                                    class: "card__button button expanded button--sc success" %>
+<% if allowed_to? :unvote, :initiative, initiative: initiative %>
+  <%= button_to(
+    vote_label,
+    initiative_initiative_vote_path(initiative_slug: current_initiative.slug),
+    method: :delete,
+    remote: true,
+    data: { disable: true },
+    class: "card__button button expanded button--sc success"
+  ) %>
 <% end %>