decidim-forms 0.31.5 → 0.32.0.rc1

data/lib/decidim/forms/test/shared_examples/has_questionnaire.rb

@@ -53,7 +53,7 @@ shared_examples_for "has questionnaire" do
         click_on "Submit"
       end
 
-      expect(page).to have_admin_callout(callout_success)
+      expect(page).to have_callout(callout_success)
 
       visit questionnaire_public_path
       see_questionnaire_questions
@@ -125,7 +125,7 @@ shared_examples_for "has questionnaire" do
         check "questionnaire_tos_agreement"
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
 
         visit questionnaire_public_path
         see_questionnaire_questions
@@ -269,7 +269,7 @@ shared_examples_for "has questionnaire" do
       end
 
       it "submits the form and shows errors" do
-        expect(page).to have_admin_callout(callout_failure)
+        expect(page).to have_callout(callout_failure)
         expect(page).to have_content("cannot be blank")
       end
     end
@@ -283,7 +283,7 @@ shared_examples_for "has questionnaire" do
 
       it "submits the form and shows errors" do
         expect(page).to have_css ".alert.flash"
-        expect(page).to have_admin_callout(callout_failure)
+        expect(page).to have_callout(callout_failure)
         different_error = I18n.t("decidim.forms.questionnaires.response.max_choices_alert")
         expect(different_error).to eq("There are too many choices selected")
         expect(page).to have_no_content(different_error)
@@ -317,7 +317,7 @@ shared_examples_for "has questionnaire" do
       end
 
       it "submits the form and shows errors" do
-        expect(page).to have_admin_callout(callout_failure)
+        expect(page).to have_callout(callout_failure)
         expect(page).to have_content("cannot be blank")
       end
     end
@@ -391,7 +391,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout(callout_success)
+          expect(page).to have_callout(callout_success)
           expect(Decidim::Forms::Response.first.choices.first.custom_body).to eq("Cacatua")
         end
 
@@ -406,7 +406,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout("There was a problem responding")
+          expect(page).to have_callout("There was a problem responding")
           expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", with: "Cacatua")
         end
 
@@ -433,7 +433,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout(callout_success)
+          expect(page).to have_callout(callout_success)
           expect(Decidim::Forms::Response.first.choices.first.custom_body).to eq("Cacatua")
         end
 
@@ -448,7 +448,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout("There was a problem responding")
+          expect(page).to have_callout("There was a problem responding")
           expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", with: "Cacatua")
         end
 
@@ -500,7 +500,7 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
 
         visit questionnaire_public_path
         see_questionnaire_questions
@@ -529,7 +529,7 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
 
         visit questionnaire_public_path
         see_questionnaire_questions
@@ -556,14 +556,14 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout("There was a problem responding")
+        expect(page).to have_callout("There was a problem responding")
         expect(page).to have_content("are too many")
 
         uncheck response_options[2]["body"][:en]
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
       end
     end
 
@@ -606,7 +606,7 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
         expect(Decidim::Forms::Response.first.choices.pluck(:position, :body)).to eq(
           [[0, "We"], [1, "all"], [2, "like"], [3, "dark"], [4, "chocolate"]]
         )
@@ -647,7 +647,7 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
 
         visit questionnaire_public_path
         see_questionnaire_questions
@@ -670,7 +670,7 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout("There was a problem responding")
+        expect(page).to have_callout("There was a problem responding")
 
         radio_buttons = page.all(".js-radio-button-collection input[type=radio]")
         expect(radio_buttons.pluck(:checked)).to eq([nil, "true", nil, nil])
@@ -689,7 +689,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout("There was a problem responding")
+          expect(page).to have_callout("There was a problem responding")
           expect(page).to have_content("Choices are not complete")
         end
       end
@@ -732,7 +732,7 @@ shared_examples_for "has questionnaire" do
 
         accept_confirm { click_on "Submit" }
 
-        expect(page).to have_admin_callout(callout_success)
+        expect(page).to have_callout(callout_success)
 
         visit questionnaire_public_path
         see_questionnaire_questions
@@ -779,7 +779,7 @@ shared_examples_for "has questionnaire" do
 
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout("There was a problem responding")
+          expect(page).to have_callout("There was a problem responding")
           expect(page).to have_content("are too many")
 
           checkboxes = page.all(".js-check-box-collection input[type=checkbox]")
@@ -788,7 +788,7 @@ shared_examples_for "has questionnaire" do
 
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout(callout_success)
+          expect(page).to have_callout(callout_success)
         end
       end
 
@@ -805,7 +805,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout("There was a problem responding")
+          expect(page).to have_callout("There was a problem responding")
           expect(page).to have_content("Choices are not complete")
         end
       end
@@ -826,7 +826,7 @@ shared_examples_for "has questionnaire" do
           check "questionnaire_tos_agreement"
           accept_confirm { click_on "Submit" }
 
-          expect(page).to have_admin_callout("There was a problem responding")
+          expect(page).to have_callout("There was a problem responding")
 
           checkboxes = page.all(".js-check-box-collection input[type=checkbox]")
           expect(checkboxes.pluck(:checked)).to eq(["true", "true", "true", nil, nil, "true"])
@@ -1373,7 +1373,7 @@ shared_examples_for "has questionnaire" do
 
             accept_confirm { click_on "Submit" }
 
-            expect(page).to have_admin_callout(callout_success)
+            expect(page).to have_callout(callout_success)
           end
         end
       end

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_display_conditions.rb

@@ -173,7 +173,7 @@ shared_examples_for "add display conditions" do
 
           click_on "Save"
 
-          expect(page).to have_admin_callout("successfully")
+          expect(page).to have_callout(callout_success)
         end
       end
     end

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_questions.rb

@@ -54,7 +54,7 @@ shared_examples_for "add questions" do
 
     click_on "Save"
 
-    expect(page).to have_admin_callout("successfully")
+    expect(page).to have_callout(callout_success)
 
     visit_manage_questions_and_expand_all
 
@@ -76,7 +76,7 @@ shared_examples_for "add questions" do
 
     click_on "Save"
 
-    expect(page).to have_admin_callout("successfully")
+    expect(page).to have_callout(callout_success)
 
     update_component_settings_or_attributes
 
@@ -98,7 +98,7 @@ shared_examples_for "add questions" do
 
     click_on "Save"
 
-    expect(page).to have_admin_callout("successfully")
+    expect(page).to have_callout(callout_success)
 
     update_component_settings_or_attributes
 
@@ -152,7 +152,7 @@ shared_examples_for "add questions" do
 
     click_on "Save"
 
-    expect(page).to have_admin_callout("successfully")
+    expect(page).to have_callout(callout_success)
 
     visit_manage_questions_and_expand_all
 

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/update_display_conditions.rb

@@ -80,7 +80,7 @@ shared_examples_for "update display conditions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       visit_manage_questions_and_expand_all
 

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/update_questions.rb

@@ -21,7 +21,7 @@ shared_examples_for "update questions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       visit_manage_questions_and_expand_all
 
@@ -47,7 +47,7 @@ shared_examples_for "update questions" do
       click_on "Save"
       click_on "Expand all questions"
 
-      expect(page).to have_admin_callout("There was a problem saving")
+      expect(page).to have_callout(callout_failure)
       expect(page).to have_content("cannot be blank", count: 5)
       expect(page).to have_content("must be greater than or equal to 0", count: 1)
 
@@ -83,7 +83,7 @@ shared_examples_for "update questions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       click_on "Questions"
 
@@ -118,7 +118,7 @@ shared_examples_for "update questions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       visit_manage_questions_and_expand_all
 
@@ -137,7 +137,7 @@ shared_examples_for "update questions" do
 
       expand_all_questions
 
-      expect(page).to have_admin_callout("There was a problem saving")
+      expect(page).to have_callout(callout_failure)
       expect(page).to have_content("cannot be blank", count: 1)
       expect(page).to have_css("input[value='']")
       expect(page).to have_no_css("input[value='This is the first title and description']")
@@ -167,7 +167,7 @@ shared_examples_for "update questions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       click_on "Questions"
 
@@ -237,7 +237,7 @@ shared_examples_for "update questions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       visit_manage_questions_and_expand_all
 
@@ -300,7 +300,7 @@ shared_examples_for "update questions" do
 
       click_on "Save"
 
-      expect(page).to have_admin_callout("successfully")
+      expect(page).to have_callout(callout_success)
 
       visit_manage_questions_and_expand_all
 
@@ -592,7 +592,7 @@ shared_examples_for "update questions" do
         sleep 0.5
 
         click_on "Save"
-        expect(page).to have_admin_callout("successfully")
+        expect(page).to have_callout(callout_success)
 
         visit_manage_questions_and_expand_all
 

data/lib/decidim/forms/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-forms version.
   module Forms
     def self.version
-      "0.31.5"
+      "0.32.0.rc1"
     end
   end
 end

metadata

@@ -1,17 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: decidim-forms
 version: !ruby/object:Gem::Version
-  version: 0.31.5
+  version: 0.32.0.rc1
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
 - Marc Riera Casals
 - Oriol Gual Oliva
 - Rubén González Valero
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-12 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: decidim-core
@@ -19,42 +18,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.5
+        version: 0.32.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.5
+        version: 0.32.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-admin
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.5
+        version: 0.32.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.5
+        version: 0.32.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-dev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.5
+        version: 0.32.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.5
+        version: 0.32.0.rc1
 description: A forms gem for decidim.
 email:
 - josepjaume@gmail.com
@@ -287,8 +286,6 @@ files:
 - lib/decidim/forms/test/shared_examples/manage_questionnaires/draggable_behavior.rb
 - lib/decidim/forms/test/shared_examples/manage_questionnaires/update_display_conditions.rb
 - lib/decidim/forms/test/shared_examples/manage_questionnaires/update_questions.rb
-- lib/decidim/forms/test/shared_examples/questionnaire_admin_access.rb
-- lib/decidim/forms/test/shared_examples/questionnaire_admin_controller_permissions.rb
 - lib/decidim/forms/user_responses_serializer.rb
 - lib/decidim/forms/version.rb
 homepage: https://decidim.org
@@ -300,7 +297,6 @@ metadata:
   funding_uri: https://opencollective.com/decidim
   homepage_uri: https://decidim.org
   source_code_uri: https://github.com/decidim/decidim
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -308,15 +304,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: 3.3.0
+      version: 3.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Decidim forms
 test_files: []

data/lib/decidim/forms/test/shared_examples/questionnaire_admin_access.rb

@@ -1,95 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-shared_examples_for "questionnaire admin access" do |denied_error:, allow_process_admin: true|
-  context "when the user is not an admin", driver: :rack_test do
-    let(:regular_user) { create(:user, :confirmed, organization:) }
-    let(:target_path) { manage_questions_path }
-
-    before do
-      login_as regular_user, scope: :user
-    end
-
-    before do
-      allow(Rails.application).to \
-        receive(:env_config).with(no_args).and_wrap_original do |m, *|
-          m.call.merge(
-            "action_dispatch.show_exceptions" => true,
-            "action_dispatch.show_detailed_exceptions" => false
-          )
-        end
-
-      visit target_path
-    end
-
-    it "leads to an error" do
-      denied_response = case denied_error
-                        when 403
-                          page.status_code == 403 || page.has_content?("You are not authorized to perform this action")
-                        when 404
-                          page.status_code == 404 || page.has_content?("The page you are looking for cannot be found")
-                        else
-                          raise ArgumentError, "unsupported denied_error: #{denied_error.inspect}. Use 403 or 404"
-                        end
-
-      expect(denied_response).to be(true)
-    end
-  end
-
-  if allow_process_admin
-    context "when the user is a process admin" do
-      let(:process_admin) { create(:process_admin, :confirmed, participatory_process:) }
-
-      it "allows access to the questionnaire" do
-        login_as process_admin, scope: :user
-        visit manage_questions_path
-
-        expect(page).to have_current_path(manage_questions_path)
-      end
-    end
-  else
-    context "when the user is a process admin", driver: :rack_test do
-      let(:participatory_process) { create(:participatory_process, organization:) }
-      let(:process_admin) { create(:process_admin, :confirmed, participatory_process:) }
-
-      before do
-        login_as process_admin, scope: :user
-
-        allow(Rails.application).to \
-          receive(:env_config).with(no_args).and_wrap_original do |m, *|
-            m.call.merge(
-              "action_dispatch.show_exceptions" => true,
-              "action_dispatch.show_detailed_exceptions" => false
-            )
-          end
-
-        visit manage_questions_path
-      end
-
-      it "denies access to the questionnaire" do
-        denied_response = case denied_error
-                          when 403
-                            page.status_code == 403 || page.has_content?("You are not authorized to perform this action")
-                          when 404
-                            page.status_code == 404 || page.has_content?("The page you are looking for cannot be found")
-                          else
-                            raise ArgumentError, "unsupported denied_error: #{denied_error.inspect}. Use 403 or 404"
-                          end
-
-        expect(denied_response).to be(true)
-      end
-    end
-  end
-
-  context "when the user is an admin" do
-    let(:admin) { create(:user, :admin, :confirmed, organization:) }
-
-    it "allows access to the questionnaire" do
-      login_as admin, scope: :user
-      visit manage_questions_path
-
-      expect(page).to have_current_path(manage_questions_path)
-    end
-  end
-end

data/lib/decidim/forms/test/shared_examples/questionnaire_admin_controller_permissions.rb

@@ -1,41 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-shared_examples_for "questionnaire admin controller permissions" do
-  describe "GET #edit" do
-    let(:action) { :edit }
-
-    it "enforces permission to update the questionnaire" do
-      expect(controller).to receive(:enforce_permission_to).with(:update, permission_subject, questionnaire:)
-      get action
-    end
-  end
-
-  describe "PATCH #update" do
-    let(:action) { :update }
-
-    it "enforces permission to update the questionnaire" do
-      expect(controller).to receive(:enforce_permission_to).with(:update, permission_subject, questionnaire:)
-      patch action, params: { questionnaire: {} }
-    end
-  end
-
-  describe "GET #edit_questions" do
-    let(:action) { :edit_questions }
-
-    it "enforces permission to update the questionnaire" do
-      expect(controller).to receive(:enforce_permission_to).with(:update, permission_subject, questionnaire:)
-      get action
-    end
-  end
-
-  describe "PATCH #update_questions" do
-    let(:action) { :update_questions }
-
-    it "enforces permission to update the questionnaire" do
-      expect(controller).to receive(:enforce_permission_to).with(:update, permission_subject, questionnaire:)
-      patch action, params: { questions: {} }
-    end
-  end
-end