decidim-forms 0.29.5 → 0.30.0.rc1

data/lib/decidim/forms/test/shared_examples/has_questionnaire.rb

@@ -6,6 +6,7 @@ shared_examples_for "has questionnaire" do
   context "when the user is not logged in" do
     it "does not allow answering the questionnaire" do
       visit questionnaire_public_path
+      see_questionnaire_questions
 
       expect(page).to have_i18n_content(questionnaire.title)
       expect(page).to have_i18n_content(questionnaire.description, strip_tags: true)
@@ -30,6 +31,7 @@ shared_examples_for "has questionnaire" do
 
       it "shows an empty page with a message" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("No questions configured for this form yet.")
       end
@@ -41,6 +43,8 @@ shared_examples_for "has questionnaire" do
       expect(page).to have_i18n_content(questionnaire.title)
       expect(page).to have_i18n_content(questionnaire.description, strip_tags: true)
 
+      see_questionnaire_questions
+
       fill_in question.body["en"], with: "My first answer"
 
       check "questionnaire_tos_agreement"
@@ -52,6 +56,7 @@ shared_examples_for "has questionnaire" do
       expect(page).to have_admin_callout(callout_success)
 
       visit questionnaire_public_path
+      see_questionnaire_questions
 
       expect(page).to have_content("You have already answered this form.")
       expect(page).to have_no_i18n_content(question.body)
@@ -73,6 +78,7 @@ shared_examples_for "has questionnaire" do
       end
 
       it "it renders the asterisk as a separated element" do
+        see_questionnaire_questions
         within "label.answer-questionnaire__question-label" do
           expect(page).to have_content(translated_attribute(question.body).to_s)
           within "span.label-required.has-tip" do
@@ -89,6 +95,7 @@ shared_examples_for "has questionnaire" do
 
       before do
         visit questionnaire_public_path
+        see_questionnaire_questions
       end
 
       it "allows answering the first questionnaire" do
@@ -121,6 +128,7 @@ shared_examples_for "has questionnaire" do
         expect(page).to have_admin_callout(callout_success)
 
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("You have already answered this form.")
       end
@@ -138,14 +146,13 @@ shared_examples_for "has questionnaire" do
 
     it "requires confirmation when exiting mid-answering" do
       visit questionnaire_public_path
+      see_questionnaire_questions
 
       fill_in question.body["en"], with: "My first answer"
 
-      dismiss_page_unload do
-        page.find(".main-bar__logo a").click
-      end
+      click_on translated_attribute(component.name)
 
-      expect(page).to have_current_path questionnaire_public_path
+      expect(page).to have_current_path(questionnaire_public_path)
     end
 
     context "when the questionnaire has already been answered by someone else" do
@@ -173,6 +180,7 @@ shared_examples_for "has questionnaire" do
 
       it "does not leak defaults from other answers" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_no_field(type: "radio", checked: true)
       end
@@ -195,6 +203,7 @@ shared_examples_for "has questionnaire" do
 
       before do
         visit questionnaire_public_path
+        see_questionnaire_questions
       end
 
       it_behaves_like "a correctly ordered questionnaire"
@@ -205,6 +214,7 @@ shared_examples_for "has questionnaire" do
 
       before do
         visit questionnaire_public_path
+        see_questionnaire_questions
         accept_confirm { click_on "Submit" }
       end
 
@@ -224,6 +234,7 @@ shared_examples_for "has questionnaire" do
 
       before do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         check "questionnaire_tos_agreement"
       end
@@ -235,6 +246,7 @@ shared_examples_for "has questionnaire" do
 
         it "shows a message indicating number of characters left" do
           visit questionnaire_public_path
+          see_questionnaire_questions
 
           expect(page).to have_content("30 characters left")
         end
@@ -271,9 +283,8 @@ shared_examples_for "has questionnaire" do
         accept_confirm { click_on "Submit" }
       end
 
-      it "submits the form and shows errors" do
-        expect(page).to have_css ".alert.flash"
-        expect(page).to have_admin_callout(callout_failure)
+      it "shows errors without submitting the form" do
+        expect(page).to have_no_css ".alert.flash"
         different_error = I18n.t("decidim.forms.questionnaires.answer.max_choices_alert")
         expect(different_error).to eq("There are too many choices selected")
         expect(page).to have_no_content(different_error)
@@ -299,6 +310,7 @@ shared_examples_for "has questionnaire" do
 
       before do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         check "questionnaire_tos_agreement"
 
@@ -316,6 +328,7 @@ shared_examples_for "has questionnaire" do
 
       it "properly interprets HTML descriptions" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css("b", text: "This question is important")
       end
@@ -356,6 +369,7 @@ shared_examples_for "has questionnaire" do
 
       before do
         visit questionnaire_public_path
+        see_questionnaire_questions
       end
 
       context "when question is single_option type" do
@@ -449,6 +463,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders the answer as a textarea" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css("textarea#questionnaire_responses_0")
       end
@@ -462,6 +477,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders the answer as a text field" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_field(id: "questionnaire_responses_0")
       end
@@ -475,6 +491,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders answers as a collection of radio buttons" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css(".js-radio-button-collection input[type=radio]", count: 2)
 
@@ -487,6 +504,7 @@ shared_examples_for "has questionnaire" do
         expect(page).to have_admin_callout(callout_success)
 
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("You have already answered this form.")
         expect(page).to have_no_i18n_content(question.body)
@@ -499,6 +517,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders answers as a collection of radio buttons" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css(".js-check-box-collection input[type=checkbox]", count: 3)
 
@@ -514,6 +533,7 @@ shared_examples_for "has questionnaire" do
         expect(page).to have_admin_callout(callout_success)
 
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("You have already answered this form.")
         expect(page).to have_no_i18n_content(question.body)
@@ -523,6 +543,7 @@ shared_examples_for "has questionnaire" do
         question.update!(max_choices: 2)
 
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("Max choices: 2")
 
@@ -565,6 +586,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders the question answers as a collection of divs sortable on drag and drop" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css("div.answer-questionnaire__sorting.js-collection-input", count: 5)
 
@@ -575,6 +597,7 @@ shared_examples_for "has questionnaire" do
 
       it "properly saves valid sortings" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         %w(We all like dark chocolate).reverse.each do |text|
           find("div.answer-questionnaire__sorting", text:).drag_to(find("div.answer-questionnaire__sorting", match: :first))
@@ -609,6 +632,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders the question answers as a collection of radio buttons" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css(".js-radio-button-collection input[type=radio]", count: 4)
 
@@ -627,6 +651,7 @@ shared_examples_for "has questionnaire" do
         expect(page).to have_admin_callout(callout_success)
 
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("You have already answered this form.")
         expect(page).to have_no_i18n_content(question.body)
@@ -639,6 +664,7 @@ shared_examples_for "has questionnaire" do
 
       it "preserves the chosen answers if submission not correct" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         radio_buttons = page.all(".js-radio-button-collection input[type=radio]")
         choose radio_buttons[1][:id]
@@ -656,6 +682,7 @@ shared_examples_for "has questionnaire" do
 
         it "shows an error if the question is mandatory and the answer is not complete" do
           visit questionnaire_public_path
+          see_questionnaire_questions
 
           radio_buttons = page.all(".js-radio-button-collection input[type=radio]")
           choose radio_buttons[0][:id]
@@ -689,6 +716,7 @@ shared_examples_for "has questionnaire" do
 
       it "renders the question answers as a collection of check boxes" do
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_css(".js-check-box-collection input[type=checkbox]", count: 6)
 
@@ -708,6 +736,7 @@ shared_examples_for "has questionnaire" do
         expect(page).to have_admin_callout(callout_success)
 
         visit questionnaire_public_path
+        see_questionnaire_questions
 
         expect(page).to have_content("You have already answered this form.")
         expect(page).to have_no_i18n_content(question.body)
@@ -724,6 +753,7 @@ shared_examples_for "has questionnaire" do
 
         it "respects the max number of choices" do
           visit questionnaire_public_path
+          see_questionnaire_questions
 
           expect(page).to have_content("Max choices: 2")
 
@@ -768,6 +798,7 @@ shared_examples_for "has questionnaire" do
 
         it "shows an error" do
           visit questionnaire_public_path
+          see_questionnaire_questions
 
           checkboxes = page.all(".js-check-box-collection input[type=checkbox]")
           check checkboxes[0][:id]
@@ -785,6 +816,7 @@ shared_examples_for "has questionnaire" do
 
         it "preserves the chosen answers" do
           visit questionnaire_public_path
+          see_questionnaire_questions
 
           checkboxes = page.all(".js-check-box-collection input[type=checkbox]")
           check checkboxes[0][:id]
@@ -834,6 +866,7 @@ shared_examples_for "has questionnaire" do
 
           before do
             visit questionnaire_public_path
+            see_questionnaire_questions
           end
 
           context "when the condition_question type is short answer" do
@@ -926,6 +959,7 @@ shared_examples_for "has questionnaire" do
 
           before do
             visit questionnaire_public_path
+            see_questionnaire_questions
           end
 
           context "when the condition_question type is short answer" do
@@ -1007,6 +1041,7 @@ shared_examples_for "has questionnaire" do
 
           before do
             visit questionnaire_public_path
+            see_questionnaire_questions
           end
 
           context "when the condition_question type is single option" do
@@ -1063,6 +1098,7 @@ shared_examples_for "has questionnaire" do
 
           before do
             visit questionnaire_public_path
+            see_questionnaire_questions
           end
 
           context "when the condition_question type is single option" do
@@ -1120,6 +1156,7 @@ shared_examples_for "has questionnaire" do
 
           before do
             visit questionnaire_public_path
+            see_questionnaire_questions
           end
 
           context "when the condition_question type is short answer" do
@@ -1240,6 +1277,7 @@ shared_examples_for "has questionnaire" do
       context "when a question has multiple display conditions" do
         before do
           visit questionnaire_public_path
+          see_questionnaire_questions
         end
 
         context "when all conditions are mandatory" do
@@ -1328,6 +1366,7 @@ shared_examples_for "has questionnaire" do
 
           it "does not throw error" do
             visit questionnaire_public_path
+            see_questionnaire_questions
 
             fill_in condition_question.body["en"], with: "My first answer"
 

data/lib/decidim/forms/test/shared_examples/manage_questionnaire_answers.rb

@@ -5,13 +5,13 @@ require "spec_helper"
 shared_examples_for "manage questionnaire answers" do
   let(:first_type) { "short_answer" }
   let!(:first) do
-    create :questionnaire_question, questionnaire:, position: 1, question_type: first_type
+    create(:questionnaire_question, questionnaire:, position: 1, question_type: first_type)
   end
   let!(:second) do
-    create :questionnaire_question, questionnaire:, position: 2, question_type: "single_option"
+    create(:questionnaire_question, questionnaire:, position: 2, question_type: "single_option")
   end
   let!(:third) do
-    create :questionnaire_question, questionnaire:, position: 3, question_type: "files"
+    create(:questionnaire_question, questionnaire:, position: 3, question_type: "files")
   end
   let(:questions) do
     [first, second, third]
@@ -19,25 +19,25 @@ shared_examples_for "manage questionnaire answers" do
 
   context "when there are no answers" do
     it "do not answer admin link" do
-      visit questionnaire_edit_path
+      click_on "Manage questions"
       expect(page).to have_content("No answers yet")
     end
   end
 
   context "when there are answers" do
-    let!(:answer1) { create :answer, questionnaire:, question: first }
-    let!(:answer2) { create :answer, body: "second answer", questionnaire:, question: first }
-    let!(:answer3) { create :answer, questionnaire:, question: second }
-    let!(:file_answer) { create :answer, :with_attachments, questionnaire:, question: third, body: nil, user: answer3.user, session_token: answer3.session_token }
+    let!(:answer1) { create(:answer, questionnaire:, question: first) }
+    let!(:answer2) { create(:answer, body: "second answer", questionnaire:, question: first) }
+    let!(:answer3) { create(:answer, questionnaire:, question: second) }
+    let!(:file_answer) { create(:answer, :with_attachments, questionnaire:, question: third, body: nil, user: answer3.user, session_token: answer3.session_token) }
 
     it "shows the answer admin link" do
-      visit questionnaire_edit_path
+      click_on "Manage questions"
       expect(page).to have_content("Show responses")
     end
 
     context "and managing answers page" do
       before do
-        visit questionnaire_edit_path
+        click_on "Manage questions"
         click_on "Show responses"
       end
 
@@ -76,9 +76,9 @@ shared_examples_for "manage questionnaire answers" do
 
       context "when multiple answer choice" do
         let(:first_type) { "multiple_option" }
-        let!(:answer1) { create :answer, questionnaire:, question: first, body: nil }
-        let!(:answer_option) { create :answer_option, question: first }
-        let!(:answer_choice) { create :answer_choice, answer: answer1, answer_option:, body: translated(answer_option.body, locale: I18n.locale) }
+        let!(:answer1) { create(:answer, questionnaire:, question: first, body: nil) }
+        let!(:answer_option) { create(:answer_option, question: first) }
+        let!(:answer_choice) { create(:answer_choice, answer: answer1, answer_option:, body: translated(answer_option.body, locale: I18n.locale)) }
 
         it "shows the answers page with custom body" do
           new_window = window_opened_by { find_all("a.action-icon.action-icon--eye").first.click }
@@ -94,10 +94,10 @@ shared_examples_for "manage questionnaire answers" do
     end
 
     context "and managing individual answer page" do
-      let!(:answer11) { create :answer, questionnaire:, body: "", user: answer1.user, question: second }
+      let!(:answer11) { create(:answer, questionnaire:, body: "", user: answer1.user, question: second) }
 
       before do
-        visit questionnaire_edit_path
+        click_on "Manage questions"
         click_on "Show responses"
       end
 
@@ -133,10 +133,10 @@ shared_examples_for "manage questionnaire answers" do
       end
 
       context "when the file answer does not have a title for the attachment" do
-        let!(:file_answer) { create :answer, questionnaire:, question: third, body: nil, user: answer3.user, session_token: answer3.session_token }
+        let!(:file_answer) { create(:answer, questionnaire:, question: third, body: nil, user: answer3.user, session_token: answer3.session_token) }
 
         before do
-          create :attachment, :with_image, attached_to: file_answer, title: {}, description: {}
+          create(:attachment, :with_image, attached_to: file_answer, title: {}, description: {})
         end
 
         it "third answer has download link for the attachments" do

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_display_conditions.rb

@@ -17,7 +17,8 @@ shared_examples_for "add display conditions" do
       let!(:question) { create(:questionnaire_question, questionnaire:, body:, question_type: "short_answer") }
 
       before do
-        visit_questionnaire_edit_path_and_expand_all
+        click_on "Save"
+        visit_manage_questions_and_expand_all
       end
 
       it "does not display an add display condition button" do
@@ -26,12 +27,10 @@ shared_examples_for "add display conditions" do
 
       context "when creating a new question" do
         it "disables the add display condition button if the question has not been saved" do
-          within "form.edit_questionnaire" do
-            click_on "Add question"
-            expand_all_questions
+          click_on "Add question"
+          expand_all_questions
 
-            expect(page).to have_button("Add display condition", disabled: true)
-          end
+          expect(page).to have_button("Add display condition", disabled: true)
         end
       end
     end
@@ -71,29 +70,28 @@ shared_examples_for "add display conditions" do
       let(:questions) { [question_short_answer, question_long_answer, question_single_option, question_multiple_option] }
 
       before do
-        visit_questionnaire_edit_path_and_expand_all
+        click_on "Save"
+        visit_manage_questions_and_expand_all
       end
 
       context "when clicking add display condition button" do
         it "adds a new display condition form with all correct elements" do
-          within "form.edit_questionnaire" do
-            within_add_display_condition do
-              expect(page).to have_select("Question")
-              expect(page).to have_select("Condition")
-              expect(page).to have_css("[id$=mandatory]")
+          within_add_display_condition do
+            expect(page).to have_select("Question")
+            expect(page).to have_select("Condition")
+            expect(page).to have_css("[id$=mandatory]")
 
-              select question_single_option.body["en"], from: "Question"
-              select "Answered", from: "Condition"
+            select question_single_option.body["en"], from: "Question"
+            select "Answered", from: "Condition"
 
-              expect(page).to have_no_select("Answer option")
-              expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
+            expect(page).to have_no_select("Answer option")
+            expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
 
-              select question_single_option.body["en"], from: "Question"
-              select "Equal", from: "Condition"
+            select question_single_option.body["en"], from: "Question"
+            select "Equal", from: "Condition"
 
-              expect(page).to have_select("Answer option")
-              expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
-            end
+            expect(page).to have_select("Answer option")
+            expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
           end
         end